[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155988#comment-15155988 ] Jacques Le Roux commented on OFBIZ-6290: Actually I should have thank Adam also! > ButtonEventConfig uses getXmlRootElement which has been deprecated > -- > > Key: OFBIZ-6290 > URL: https://issues.apache.org/jira/browse/OFBIZ-6290 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/pos >Reporter: Adam Heath >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > > ResourceLoader.getXmlRootElement() caches its return value; however, DOM > elements are memory intensive, and the returned value tends to only be used > once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155985#comment-15155985 ] Jacques Le Roux commented on OFBIZ-6290: Thanks for your work on this Deepak! > ButtonEventConfig uses getXmlRootElement which has been deprecated > -- > > Key: OFBIZ-6290 > URL: https://issues.apache.org/jira/browse/OFBIZ-6290 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/pos >Reporter: Adam Heath >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > > ResourceLoader.getXmlRootElement() caches its return value; however, DOM > elements are memory intensive, and the returned value tends to only be used > once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155617#comment-15155617 ] Deepak Dixit commented on OFBIZ-6290: - This has been merged at r#1731399 > ButtonEventConfig uses getXmlRootElement which has been deprecated > -- > > Key: OFBIZ-6290 > URL: https://issues.apache.org/jira/browse/OFBIZ-6290 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/pos >Reporter: Adam Heath >Assignee: Adam Heath >Priority: Minor > Fix For: Upcoming Branch > > > ResourceLoader.getXmlRootElement() caches its return value; however, DOM > elements are memory intensive, and the returned value tends to only be used > once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1511#comment-1511 ] Deepak Dixit commented on OFBIZ-6290: - Can we merge all the fixes from https://svn.apache.org/repos/asf/ofbiz/branches/OFBIZ-6275 into trunk? > ButtonEventConfig uses getXmlRootElement which has been deprecated > -- > > Key: OFBIZ-6290 > URL: https://issues.apache.org/jira/browse/OFBIZ-6290 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/pos >Reporter: Adam Heath >Assignee: Adam Heath >Priority: Minor > > ResourceLoader.getXmlRootElement() caches its return value; however, DOM > elements are memory intensive, and the returned value tends to only be used > once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507350#comment-14507350 ] Adam Heath commented on OFBIZ-6290: --- [javac17] /srv/ofbiz/apache-git/specialpurpose/pos/src/org/ofbiz/pos/config/ButtonEventConfig.java:55: warning: [deprecation] getXmlRootElement(String) in ResourceLoader has been deprecated [javac17] Element root = ResourceLoader.getXmlRootElement(ButtonEventConfig.BUTTON_EVENT_CONFIG); [javac17] ^ ButtonEventConfig uses getXmlRootElement which has been deprecated -- Key: OFBIZ-6290 URL: https://issues.apache.org/jira/browse/OFBIZ-6290 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/pos Reporter: Adam Heath Assignee: Adam Heath Priority: Minor ResourceLoader.getXmlRootElement() caches its return value; however, DOM elements are memory intensive, and the returned value tends to only be used once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6290) ButtonEventConfig uses getXmlRootElement which has been deprecated
[ https://issues.apache.org/jira/browse/OFBIZ-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507352#comment-14507352 ] Adam Heath commented on OFBIZ-6290: --- Same problem, don't use a cached version of this method. ButtonEventConfig uses getXmlRootElement which has been deprecated -- Key: OFBIZ-6290 URL: https://issues.apache.org/jira/browse/OFBIZ-6290 Project: OFBiz Issue Type: Sub-task Components: specialpurpose/pos Reporter: Adam Heath Assignee: Adam Heath Priority: Minor ResourceLoader.getXmlRootElement() caches its return value; however, DOM elements are memory intensive, and the returned value tends to only be used once. So, this is a poor pattern. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
