[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546696#comment-14546696 ] Deepak Dixit commented on OFBIZ-6329: - Martin Becker, You can crate patch using git diff --no-prefix option. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Assignee: Deepak Dixit Attachments: OFBIZ-6329_FTL-Caching-DiffOnly.patch, OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching-DiffOnly.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546695#comment-14546695 ] Deepak Dixit commented on OFBIZ-6329: - Thanks Martin Becker, Your patch has been committed at Trunk at r#1679728 14.12 at r#1679729 Not able to apply this patch, getting conflicts while merging. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Assignee: Deepak Dixit Attachments: OFBIZ-6329_FTL-Caching-DiffOnly.patch, OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching-DiffOnly.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528284#comment-14528284 ] Martin Becker commented on OFBIZ-6329: -- Sorry for that, Adrian. I'm using git locally and created the patch files with git format-patch as Michael stated. Therefore there are some header informations additional to the standard diff in the patch file. There should be no need for a committer to modify a patch file to get it working, so we will create the patch files with git diff, that should be fine. I will provide corrected patch files here soon and Adrian may check if they are usable for him (and thus for all others). Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528085#comment-14528085 ] Jacques Le Roux commented on OFBIZ-6329: We may ask Christian how he did it. Personally, normally I just change 1 or 2 things and it's OK, of course it's easier if it's in the right format from start. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526847#comment-14526847 ] Adrian Crum commented on OFBIZ-6329: Thank you for working on this, but the patch file format is wrong. Please use a unified diff format. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527083#comment-14527083 ] Michael Brohl commented on OFBIZ-6329: -- The patch format is following the Apache proposed workflow for working with git repositories, see http://www.apache.org/dev/git.html. What's wrong with it? Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527207#comment-14527207 ] Michael Brohl commented on OFBIZ-6329: -- Yes, I know. I thought that the patch formats are compatible. The git patch contains a unified diff format. Haven't tried it myself but since the german translations patch went through without problems, I thought it's ok. We will provide new patches then. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6329) Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText
[ https://issues.apache.org/jira/browse/OFBIZ-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527172#comment-14527172 ] Adrian Crum commented on OFBIZ-6329: OFBiz uses Subversion, not Git. Malfunction of configurable FTL-Template caching in DataResourceWorker.renderDataResourceAsText --- Key: OFBIZ-6329 URL: https://issues.apache.org/jira/browse/OFBIZ-6329 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Martin Becker Attachments: OFBIZ-6329_FTL-Caching.patch, OFBIZ-6329_Non-Template-Caching.patch There are several problems with the current caching logic in DataResourceWorker.renderDataResourceAsText(...). Enabling the caching of rendered FTL-Templates from DataResources with the property disable.ftl.template.cache in content.properties enables a non-functioning block of code that handles the rendering of the cached template. And if it is deactivated (default), the FTL-Templates are still cached by the FreeMarkerWorker. However the correct logic for caching and using the rendered FTL-Template is already implemented in the FreeMarkerWorker and controlled by an optional useCache parameter. In addition there is an API call to DataResourceWorker.writeDataResourceText for non template content with a static true for useCache instead of using the given cache parameter value of the renderDataResourceAsText method itself, so even if the caller do not want to use caching at all, the non template text data is cached an FTL-Templates are cached also. I will provide a patch for those two issues in the mentioned method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
