[jira] [Commented] (OFBIZ-6784) JobSandbox : reload crashed job maybe duplicate pending service
[ https://issues.apache.org/jira/browse/OFBIZ-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080857#comment-15080857 ] Nicolas Malin commented on OFBIZ-6784: -- Thanks a lot Scott, you give the right correction, I will correct it. > JobSandbox : reload crashed job maybe duplicate pending service > --- > > Key: OFBIZ-6784 > URL: https://issues.apache.org/jira/browse/OFBIZ-6784 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Labels: jobsandbox > Attachments: OFBIZ-6784.patch > > > When the JobPoller run reloadCrashedJobs() after an OFBiz restart, if you > have a large service that crash that already replenish the pool receive a new > run instant for it. > Example: If you have a service like loadExternalOrder that run each hours. > You stop your OFBiz during their activity and at restart you have : > * job1 loadExternalOrder RUNINNG > * job2 loadExternalOrder PENDING at t+1h (normal schedule) > * job1.1 loadExternalOrder PENDING at t+1h (crashed schedule) > I propose to exclude from the process reloadCrashedJobs() all jobs that have > already a new scheduled instance -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6784) JobSandbox : reload crashed job maybe duplicate pending service
[ https://issues.apache.org/jira/browse/OFBIZ-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080525#comment-15080525 ] Scott Gray commented on OFBIZ-6784: --- bq. Right the job run immediately, but the job is also planned one hour later. Weird, I thought this had been fixed already. reloadCrashedJobs shouldn't store recurrence/temporal info on the new job if the crashed job's status is SERVICE_RUNNING, because the init() of the crashed job will have already scheduled it before the server went down. It's just a matter of setting tempExprId and recurrenceInfoId to null before storing the new job. > JobSandbox : reload crashed job maybe duplicate pending service > --- > > Key: OFBIZ-6784 > URL: https://issues.apache.org/jira/browse/OFBIZ-6784 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Labels: jobsandbox > Attachments: OFBIZ-6784.patch > > > When the JobPoller run reloadCrashedJobs() after an OFBiz restart, if you > have a large service that crash that already replenish the pool receive a new > run instant for it. > Example: If you have a service like loadExternalOrder that run each hours. > You stop your OFBiz during their activity and at restart you have : > * job1 loadExternalOrder RUNINNG > * job2 loadExternalOrder PENDING at t+1h (normal schedule) > * job1.1 loadExternalOrder PENDING at t+1h (crashed schedule) > I propose to exclude from the process reloadCrashedJobs() all jobs that have > already a new scheduled instance -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6784) JobSandbox : reload crashed job maybe duplicate pending service
[
https://issues.apache.org/jira/browse/OFBIZ-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080473#comment-15080473
]
Nicolas Malin commented on OFBIZ-6784:
--
Thanks scott to sharing.
{quote}The new job created by the crashed job is set to run immediately, not
after one hour.{quote} Right the job run immediately, but the job is also
planned one hour later. And it's the problem because after each job continue
their life and the next crash it's not one job that will be replay but two that
will create four jobs ...
{quote}What if the job runs weekly/monthly/yearly instead of hourly?{quote}
good spot, I focused only on job to highest incidence.
So I will check a better solution on the replay process. It's important to
ensure that one job replay only one job.
> JobSandbox : reload crashed job maybe duplicate pending service
> ---
>
> Key: OFBIZ-6784
> URL: https://issues.apache.org/jira/browse/OFBIZ-6784
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Labels: jobsandbox
> Attachments: OFBIZ-6784.patch
>
>
> When the JobPoller run reloadCrashedJobs() after an OFBiz restart, if you
> have a large service that crash that already replenish the pool receive a new
> run instant for it.
> Example: If you have a service like loadExternalOrder that run each hours.
> You stop your OFBiz during their activity and at restart you have :
> * job1 loadExternalOrder RUNINNG
> * job2 loadExternalOrder PENDING at t+1h (normal schedule)
> * job1.1 loadExternalOrder PENDING at t+1h (crashed schedule)
> I propose to exclude from the process reloadCrashedJobs() all jobs that have
> already a new scheduled instance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6784) JobSandbox : reload crashed job maybe duplicate pending service
[ https://issues.apache.org/jira/browse/OFBIZ-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076404#comment-15076404 ] Scott Gray commented on OFBIZ-6784: --- The new job created by the crashed job is set to run immediately, not after one hour. I disagree with this change. What if the job runs weekly/monthly/yearly instead of hourly? I think it is better to run a recurring job too often than not often enough. > JobSandbox : reload crashed job maybe duplicate pending service > --- > > Key: OFBIZ-6784 > URL: https://issues.apache.org/jira/browse/OFBIZ-6784 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Labels: jobsandbox > Attachments: OFBIZ-6784.patch > > > When the JobPoller run reloadCrashedJobs() after an OFBiz restart, if you > have a large service that crash that already replenish the pool receive a new > run instant for it. > Example: If you have a service like loadExternalOrder that run each hours. > You stop your OFBiz during their activity and at restart you have : > * job1 loadExternalOrder RUNINNG > * job2 loadExternalOrder PENDING at t+1h (normal schedule) > * job1.1 loadExternalOrder PENDING at t+1h (crashed schedule) > I propose to exclude from the process reloadCrashedJobs() all jobs that have > already a new scheduled instance -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6784) JobSandbox : reload crashed job maybe duplicate pending service
[ https://issues.apache.org/jira/browse/OFBIZ-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075240#comment-15075240 ] Nicolas Malin commented on OFBIZ-6784: -- I have the problem on production site under 13.07 so I will interested to backport this on all stables branches. I open to a review :) > JobSandbox : reload crashed job maybe duplicate pending service > --- > > Key: OFBIZ-6784 > URL: https://issues.apache.org/jira/browse/OFBIZ-6784 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Labels: jobsandbox > Attachments: OFBIZ-6784.patch > > > When the JobPoller run reloadCrashedJobs() after an OFBiz restart, if you > have a large service that crash that already replenish the pool receive a new > run instant for it. > Example: If you have a service like loadExternalOrder that run each hours. > You stop your OFBiz during their activity and at restart you have : > * job1 loadExternalOrder RUNINNG > * job2 loadExternalOrder PENDING at t+1h (normal schedule) > * job1.1 loadExternalOrder PENDING at t+1h (crashed schedule) > I propose to exclude from the process reloadCrashedJobs() all jobs that have > already a new scheduled instance -- This message was sent by Atlassian JIRA (v6.3.4#6332)
