[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317057#comment-15317057 ] Jacques Le Roux commented on OFBIZ-7139: PLease Rishi use short refs for Jira issues, easier to follow status ;) > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > Fix For: Upcoming Branch > > Attachments: OFBIZ-7139-Updated.patch, OFBIZ-7139.patch > > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315336#comment-15315336 ] Rishi Solanki commented on OFBIZ-7139: -- We will address remaining classes under - https://issues.apache.org/jira/browse/OFBIZ-7169 > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki > Attachments: OFBIZ-7139.patch > > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314227#comment-15314227 ] Rishi Solanki commented on OFBIZ-7139: -- [~jacques.le.roux]: Thanks for the pointers, I checked into all the classes having the same problem. Once will have this product name or better to say product fields fix in the system, we will provide fix for all other classes in separate ticket. We have tested the fix and seems it is working fine, please take a look and let us know if it looks fine to you. If fix looks good then we will try to provide the same in other files in a day or two. > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki > Attachments: OFBIZ-7139.patch > > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314177#comment-15314177 ] Jacques Le Roux commented on OFBIZ-7139: I agree on the principle. Note that the same exists for # Categories CategoryContentWrapper.java # Parties PartyContentWrapper.java # ProductConfigItems ProductConfigItemContentWrapper.java # ProductContents ProductContentWrapper.java # ProductPromoContent ProductPromoContentWrapper.java # WorkEffortContent WorkEffortContentWrapper.java I though did not check, but for categories, if my comment makes sense in screens... Thanks! > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki > Attachments: OFBIZ-7139.patch > > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314116#comment-15314116 ] Rishi Solanki commented on OFBIZ-7139: -- [~julien.nicolas] thanks for the your input and I'm agree with you on the flow we should opt for. We have provided fix for it, and if community agree then it should be in trunk soon. Thanks! > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7139.patch > > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314036#comment-15314036 ] Julien NICOLAS commented on OFBIZ-7139: --- Ideally it should look for content first if found then return and if not found then go for Product.productName. I agree, it seems good like that. It's a easier way if you don't need translation on your product. Julien. > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki >Priority: Minor > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[
https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314003#comment-15314003
]
Rishi Solanki commented on OFBIZ-7139:
--
[~jacques.le.roux] [~pfm.smits]:
We have further look into the issue and found that
ProductContentWrapper.getProductContentAsText() line 173-205 is responsible for
showing productName instead of Product Content of type Product Name. You can
see that after getting value from Product.productName it return from the
method. Ideally it should look for content first if found then return and if
not found then go for Product.productName.
I would say, add productName on edit product and fix this method will solve all
purpose. If no objection then we would provide patch for the same.
Here is code for quick reference;
{code}
if (productModel.isField(candidateFieldName)) {
String candidateValue = product.getString(candidateFieldName);
if (UtilValidate.isNotEmpty(candidateValue)) {
outWriter.write(candidateValue);
return;
} else if ("Y".equals(product.getString("isVariant"))) {
// look up the virtual product
GenericValue parent =
ProductWorker.getParentProduct(productId, delegator);
if (parent != null) {
candidateValue = parent.getString(candidateFieldName);
if (UtilValidate.isNotEmpty(candidateValue)) {
outWriter.write(candidateValue);
return;
}
}
}
}
List productContentList =
EntityQuery.use(delegator).from("ProductContent").where("productId", productId,
"productContentTypeId",
productContentTypeId).orderBy("-fromDate").cache(cache).filterByDate().queryList();
if (UtilValidate.isEmpty(productContentList) &&
("Y".equals(product.getString("isVariant" {
GenericValue parent = ProductWorker.getParentProduct(productId,
delegator);
if (UtilValidate.isNotEmpty(parent)) {
productContentList =
EntityQuery.use(delegator).from("ProductContent").where("productId",
parent.get("productId"), "productContentTypeId",
productContentTypeId).orderBy("-fromDate").cache(cache).filterByDate().queryList();
}
}
GenericValue productContent = EntityUtil.getFirst(productContentList);
if (productContent != null) {
// when rendering the product content, always include the Product
and ProductContent records that this comes from
Map inContext = new HashMap();
inContext.put("product", product);
inContext.put("productContent", productContent);
ContentWorker.renderContentAsText(dispatcher, delegator,
productContent.getString("contentId"), outWriter, inContext, locale,
mimeTypeId, partyId, roleTypeId, cache);
}
{code}
> Product Name
>
>
> Key: OFBIZ-7139
> URL: https://issues.apache.org/jira/browse/OFBIZ-7139
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rishi Solanki
>Priority: Minor
>
> As per the discussion over user list (subject: "Product Name"), user should
> be able to add product name in product creation process.
> On Catalog >> Products >> New Product section, user won't see any input field
> to add product name. Same applies to Edit product screen.
> - Add field on the create and edit form.
> - Check for the support in the services used, if not then add support for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306297#comment-15306297 ] Rishi Solanki commented on OFBIZ-7139: -- Thank you Jacques, Pierre for adding more details and inputs on this. It seems to me will need to further look on how system display the product name on UI and how manages the contents. I will try to check further and share details here to discuss further. > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305219#comment-15305219 ] Jacques Le Roux commented on OFBIZ-7139: bq. But it could be shown in the ProductContent screen that the product name is overriden by the content variant. That's already done bq. Good functionality wouldn't require users to remove the product name, when they go the content route. I was bitten by that long ago, did not get an opportunity to look at it again... At least it's important to be known in the current context! > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305206#comment-15305206 ] Pierre Smits commented on OFBIZ-7139: - No... Good functionality wouldn't require users to remove the product name, when they go the content route. But it could be shown in the ProductContent screen that the product name is overriden by the content variant. > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7139) Product Name
[ https://issues.apache.org/jira/browse/OFBIZ-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304793#comment-15304793 ] Jacques Le Roux commented on OFBIZ-7139: Wait, users should be warned that if they set the productName and later want to use content to override the productName it will not work. They will 1st need to remove the productName. See my comment at top of DemoProductI18nData.xml > Product Name > > > Key: OFBIZ-7139 > URL: https://issues.apache.org/jira/browse/OFBIZ-7139 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > As per the discussion over user list (subject: "Product Name"), user should > be able to add product name in product creation process. > On Catalog >> Products >> New Product section, user won't see any input field > to add product name. Same applies to Edit product screen. > - Add field on the create and edit form. > - Check for the support in the services used, if not then add support for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
