[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-20 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1534#comment-1534
 ] 

Swapnil Shah commented on OFBIZ-7255:
-

Sure Jacques, would take care of it

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Mohammad Kathawala
>Assignee: Swapnil Shah
> Fix For: 14.12.01, 15.12.01
>
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-20 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339474#comment-15339474
 ] 

Swapnil Shah commented on OFBIZ-7255:
-

I have tested it now and looks to be working fine as per outlined expected 
behavior. Hence closing it now.

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Mohammad Kathawala
>Assignee: Swapnil Shah
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-20 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339453#comment-15339453
 ] 

Rishi Solanki commented on OFBIZ-7255:
--

[~diveshdut]: Now all makes sense, thanks for adding details. In case of any 
confusion will get back. Thanks again!

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Mohammad Kathawala
>Assignee: Swapnil Shah
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-18 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338307#comment-15338307
 ] 

Divesh Dutta commented on OFBIZ-7255:
-

Fix of OFBIZ-7190 should also fix this issue. 

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-10 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324713#comment-15324713
 ] 

Jacques Le Roux commented on OFBIZ-7255:


This makes sense to me Divesh, more information is not a bad thing, moreover 
having almost all at hand, +1

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-10 Thread Mohammad Kathawala (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324395#comment-15324395
 ] 

Mohammad Kathawala commented on OFBIZ-7255:
---

I agree with [~diveshdut]. We should do this improvement for logging the cancel 
quantity for the order item.

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-10 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324275#comment-15324275
 ] 

Divesh Dutta commented on OFBIZ-7255:
-

When this issue was created, I was also thinking that this issue is not valid, 
because you as [~deepak.dixit] mentioned , user can edit order to reduce the 
quantity of an order . But after thinking more no it, I think we can still work 
on this ticket. This might not be but and we can change this to an improvement. 
 I will tell why I think we can still work on this ticket. 

OrderItem table have field cancelQuantity . In current OFBiz work flow, when 
user clicks on cancel quantity, all items are cancelled in one shot. But I 
think this is a valid business case that you have taken an order, and then 
customer calls back after some time and says that he would like to cancel some 
items. So say 5 items have been ordered and customer wants to cancel 2 items. 

So one option is to edit the order item from 5 to 3. But this does not records 
in system that  2 items are cancelled. In order view page, cancelled items are 
shown as 0. But if we leverage cancelQuantity field of OrderItem table and 
allow user to cancel 2 items out of 5, then we can save 2 quantity in 
cancelQuantity field of OrderItem table and in Order view we can show 2 items 
are cancelled. 

So we have data model and UI for it, but we don't have support in code. So I 
think we can make this improvement. As per my above given example, in 
OrderItemChange table , cancelled item will be recorded as "Cancelled" instead 
of "Order Item Change". So I think for logging purpose this is better flow to 
allow user to cancel items. 

So user will have both the options, cancel item or edit order item. 

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-09 Thread Mridul Pathak (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322023#comment-15322023
 ] 

Mridul Pathak commented on OFBIZ-7255:
--

I agree with [~deepakddixit]. It's not a valid bug.

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322017#comment-15322017
 ] 

Rishi Solanki commented on OFBIZ-7255:
--

+1

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7255) Not able to cancel quantity of order item less than ordered quantity

2016-06-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321973#comment-15321973
 ] 

Deepak Dixit commented on OFBIZ-7255:
-

Hi [~Mohammad K],

Why we want to cancel the order item quantity in approved order? We can edit 
quantity and update the order item record.

> Not able to cancel quantity of order item less than ordered quantity
> 
>
> Key: OFBIZ-7255
> URL: https://issues.apache.org/jira/browse/OFBIZ-7255
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Mohammad Kathawala
> Attachments: Screenshot1.png, Screenshot2.png, Screenshot3.png
>
>
> Steps to generate:
> 1) Create a sales order with item quantity more than 1. Lets suppose 3.
> 2) Go to order overview page and click on 'Edit Items'.
> 3) Try to cancel the item with quantity less than 3. Lets suppose 2.
> Expected result:
> Item's 2 quantity should be cancelled.
> Actual result:
> All 3 quantity gets cancelled.
> See attached screenshots for more info.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)