[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344239#comment-15344239 ] Pranay Pandey commented on OFBIZ-7519: -- Thanks for the confirmation Nicolas. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344167#comment-15344167 ] Nicolas Malin commented on OFBIZ-7519: -- I confirm, this patch is good. When I converted simple to entity-auto I just control that we haven't regression to centralise the modification only on the engine, and with this issue you finish to correct the service definition. Thanks for that > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344100#comment-15344100 ] Pranay Pandey commented on OFBIZ-7519: -- Thanks for the confirmation Jacques :). > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344079#comment-15344079 ] Jacques Le Roux commented on OFBIZ-7519: Oops, you are right I mixed the 2 things :( > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344080#comment-15344080 ] Jacques Le Roux commented on OFBIZ-7519: This was most needed, thanks! > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344002#comment-15344002 ] Pranay Pandey commented on OFBIZ-7519: -- Hi Jacques, Thanks for your comment. I don't think both of these are the same thing. The changes committed under this patch are to correct server side validations of input parameters to a service. [OFBIZ-7511] is talking about enhancement in Form-Widget to enforce right client side validation. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343983#comment-15343983 ] Jacques Le Roux commented on OFBIZ-7519: Please see my comment at https://issues.apache.org/jira/browse/OFBIZ-7511?focusedCommentId=15343963 With Deepak's solution we would no longer need to put the changes you and I did :) > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343767#comment-15343767 ] Jacques Le Roux commented on OFBIZ-7519: Thanks for your comprehension Pranay :) > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343754#comment-15343754 ] Pranay Pandey commented on OFBIZ-7519: -- Sure thing Jacques, please take your time. > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342667#comment-15342667 ] Jacques Le Roux commented on OFBIZ-7519: Thanks guys for the "generalisation", though before being totally sure about that I have to read OFBIZ-7511. I'll do tomorrow... > Some entity-auto services fields doesn't have optional false in case of > multiple PK's > - > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Fix For: Upcoming Branch > > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's.
[ https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341253#comment-15341253 ] Amardeep Singh Jhajj commented on OFBIZ-7519: - Please find attached patch for trunk. Thanks > Some entity-auto services fields doesn't have optional false in case of > multiple PK's. > -- > > Key: OFBIZ-7519 > URL: https://issues.apache.org/jira/browse/OFBIZ-7519 > Project: OFBiz > Issue Type: Improvement > Components: accounting, content, marketing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Pranay Pandey > Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch > > > Some services with entity-auto doesn't have optional false in case of > multiple PK's. In this cases if any of the PK is missing then sql error > returns. > Please find attached screenshot of error. > According to my analysis of entity auto engine, Here are some cases: > 1. One primary key: Takes new sequence if PK not passed. > 2. Two primary key: Both PK should be mandatory except the case of secondary > primary key (like agreementItemSeqId) where next subsequence is generated. > 3. More than two PK's, all PK's should be mandatory except the fromDate. > Here is the list of services which need to be fixed according to above points. > 1. createAgreementItem > 2. updateAgreementItem > 3. deleteAgreementItem > 4. updateAgreementTerm > 5. deleteAgreementTerm > 6. createContentMetaData > 7. createContentPurpose > 8. createContentPurposeOperation > 9. createContentAttribute > 10. createContentRevisionItem > 11. createContentTypeAttr > 12. createDataResourceMetaData > 13. createDataResourcePurpose > 14. createSurveyTrigger > 15. createDataResourceAttribute > 16. createSalesOpportunityRole > I am working on it and will add patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
