[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[
https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402118#comment-15402118
]
Jacques Le Roux commented on OFBIZ-7923:
I quickly tried to move the DemoMarketing.xml file in marketing/data/ but using
component syntax does not work in ofbiz-component.xml files:
{code}
{code}
does not work, you get
{code}
2016-08-01 16:07:31,434 |main |EntityDataLoader
|W| Could not get URL for Component ResourceHandler:
org.apache.ofbiz.base.component.ComponentException: File Resource not found:
C:/projectASF-Mars/ofbiz/specialpurpose/ecommerce/component://marketing/data/DemoMarketing.xml
{code}
The loaded in ofbiz-component.xml refers to the local component, hence
*C:/projectASF-Mars/ofbiz/specialpurpose/ecommerce/component://marketing/data/DemoMarketing.xml*
We need another solution, or to code that there...later...
> Improve the Marketing Demo data
> ---
>
> Key: OFBIZ-7923
> URL: https://issues.apache.org/jira/browse/OFBIZ-7923
> Project: OFBiz
> Issue Type: Improvement
> Components: marketing
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: campaign, data, demo, marketing
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch
>
>
> In the following issue : OFBIZ-7922, there was a problem with the pagination
> of the Marketing Campaing list. Because there is not enough data in the demo,
> it was more difficult to find this bug.
> To help the testing of this component, we can add some Marketing Campaign in
> the demo data (at least enough to unlock a second page of search).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402105#comment-15402105 ] Jacques Le Roux commented on OFBIZ-7923: Huho 2016-08-01 16:07:31,434 |main |EntityDataLoader |W| Could not get URL for Component ResourceHandler: org.apache.ofbiz.base.component.ComponentException: File Resource not found: C :/projectASF-Mars/ofbiz/specialpurpose/ecommerce/component://marketing/data/DemoMarketing.xml OK let's see... > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux >Priority: Minor > Labels: campaign, data, demo, marketing > Fix For: Upcoming Branch > > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402073#comment-15402073 ] Pierre Smits commented on OFBIZ-7923: - Thanks! > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux >Priority: Minor > Labels: campaign, data, demo, marketing > Fix For: Upcoming Branch > > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402071#comment-15402071 ] Jacques Le Roux commented on OFBIZ-7923: Oh right, this was wrong in 1st place (pre Apache era). I'll do it! > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux >Priority: Minor > Labels: campaign, data, demo, marketing > Fix For: Upcoming Branch > > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401723#comment-15401723 ] Pierre Smits commented on OFBIZ-7923: - In light of removing the dependencies on the ecommerce commerce (OFBIZ-7016) , this patch should not have gone into the datasets of the ecommerce component. Instead, it should have gone into the demo data set of the marketing component. Will you correct this situation, [~jacques.le.roux]? > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Assignee: Jacques Le Roux >Priority: Minor > Labels: campaign, data, demo, marketing > Fix For: Upcoming Branch > > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[
https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401686#comment-15401686
]
Montalbano Florian commented on OFBIZ-7923:
---
I found where this replacement was done but before opening a Jira, I would like
to fully understand the comment put above the replace : (found in the file
GenericEntity.java at line 1166 in the function writeXmlText)
{code}
/*
* Some common character for these invalid values, have seen these are mostly
from MS Word, but may be part of some standard:
* 5 = ... 18 = apostrophe 19 = left quotation mark 20 = right quotation mark 22
= – 23 = - 25 = tm
*/
{code}
After this, there is a switch checking some specials characters such as ' , " ,
& , < and > .
If useful, we could remove the replace for all those characters. But I don't
know the range of this modification. Do you have more intel about this matter ?
> Improve the Marketing Demo data
> ---
>
> Key: OFBIZ-7923
> URL: https://issues.apache.org/jira/browse/OFBIZ-7923
> Project: OFBiz
> Issue Type: Improvement
> Components: marketing
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: campaign, data, demo, marketing
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch
>
>
> In the following issue : OFBIZ-7922, there was a problem with the pagination
> of the Marketing Campaing list. Because there is not enough data in the demo,
> it was more difficult to find this bug.
> To help the testing of this component, we can add some Marketing Campaign in
> the demo data (at least enough to unlock a second page of search).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[
https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396896#comment-15396896
]
Jacques Le Roux commented on OFBIZ-7923:
Actually you don't even have to add more data. The size of the list is defined
by this property in widget.properties
{code}
# Default number of items to be displayed per page in a list form
widget.form.defaultViewSize=20
{code}
Locally you can change that by hand, clear caches, et voilà.
Now if we would like to have the same on demos we would need to have this
property in the DB and use EntityUtilProperties.getPropertyNumber() to retrieve
where it's done at the moment. Unfortunately
EntityUtilProperties.getPropertyNumber() simply uses for the moment
UtilProperties.getPropertyNumber() so it means more work than adding those
data. But once done, it's for all (though you would still have to replace the
calls where UtilProperties is used instead of EntityUtilProperties. I don't
remember if we have an umbrella task ans subtasks for that. It seems though a
long term work, because we have much properties likely to benefit from this
possibility.
Another KISS option: maybe simply testing locally is sufficient ;)
> Improve the Marketing Demo data
> ---
>
> Key: OFBIZ-7923
> URL: https://issues.apache.org/jira/browse/OFBIZ-7923
> Project: OFBiz
> Issue Type: Improvement
> Components: marketing
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Priority: Minor
> Labels: campaign, data, demo, marketing
> Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch
>
>
> In the following issue : OFBIZ-7922, there was a problem with the pagination
> of the Marketing Campaing list. Because there is not enough data in the demo,
> it was more difficult to find this bug.
> To help the testing of this component, we can add some Marketing Campaign in
> the demo data (at least enough to unlock a second page of search).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393421#comment-15393421 ] Montalbano Florian commented on OFBIZ-7923: --- Thanks for the review :) By the hardest way, do you mean updating the function Exporting All Data ? I think it may be better to open a new issue for that. But I didn't check the code yet so it may be a specific issue to exporting this entity (or maybe the appears when creating a marketing campaign ?). If those datas are ok, I'll add the remaining one. I'll stop when we can have at least a navigation to the second page (for the testing purpose). > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392686#comment-15392686 ] Jacques Le Roux commented on OFBIZ-7923: BTW your data look good to me, thanks! > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392672#comment-15392672 ] Jacques Le Roux commented on OFBIZ-7923: So you did not go the hardest way ;) May I ask why? > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch, OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391553#comment-15391553 ] Jacques Le Roux commented on OFBIZ-7923: Yes, I guess so, thanks! > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391460#comment-15391460 ] Montalbano Florian commented on OFBIZ-7923: --- Thanks for the improvment [~jacques.le.roux] ! I'll do the change. Those " came from the functionnality "Export all XML data" in the webtools. If they can be replaced, maybe it can be done in this function too ? > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390297#comment-15390297 ] Jacques Le Roux commented on OFBIZ-7923: 1st I can say that can be replaced by ' inside ", too late tonight for the rest ;) > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7923) Improve the Marketing Demo data
[ https://issues.apache.org/jira/browse/OFBIZ-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390292#comment-15390292 ] Jacques Le Roux commented on OFBIZ-7923: Thanks Florian, I have used your data to test OFBIZ-7922. I have though to check them because you put a *lot* of details :) > Improve the Marketing Demo data > --- > > Key: OFBIZ-7923 > URL: https://issues.apache.org/jira/browse/OFBIZ-7923 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Minor > Labels: campaign, data, demo, marketing > Attachments: OFBIZ-7923.patch > > > In the following issue : OFBIZ-7922, there was a problem with the pagination > of the Marketing Campaing list. Because there is not enough data in the demo, > it was more difficult to find this bug. > To help the testing of this component, we can add some Marketing Campaign in > the demo data (at least enough to unlock a second page of search). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
