[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-7311:
--
Attachment: OFBIZ-7311-removed_references_of_maincss.patch
Hello team,
I have removed the unused references of the maincss.css from source code, done
the following things
1.) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
*Reason:* Since, there is no file like 'maincss.css' exist under any includes
directory.
2.) Removed the unused references of maincss.css from FTLs, code
{code}
{code}
has been removed.
*Reason:* This is an interesting thing, these FTLs were using the maincss.css
located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3.) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic
HTML code to style, instead of using style defined in 'maincss.css' which were
exist in release-4.0
4.) Updated some references from 'maincss.css' to style.css in comments.
5.) Also removed the entry of including '/images/maincss.css' and
'/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.
Dear [~pandeypranay], [~wt] and team,
Please have a look this patch :)
Thanks!
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil M Mane
>Assignee: Pranay Pandey
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch,
> OFBIZ-7311-removed_references_of_maincss.patch,
> OFBIZ-7311-renamed-maincss-to-style.patch, OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranay Pandey updated OFBIZ-7311:
-
Sprint: Community Day 2 - 2016
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil M Mane
>Assignee: Pranay Pandey
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch,
> OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranay Pandey updated OFBIZ-7311:
-
Component/s: themes
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil M Mane
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch,
> OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranay Pandey updated OFBIZ-7311:
-
Affects Version/s: Trunk
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil M Mane
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch,
> OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-7311:
--
Attachment: OFBIZ-7311-renamed-maincss-to-style.patch
To maintain the consistency, renamed the *maincss.css* to *style.css* (also
*mainrtl.css* to *stylertl.css*)
This patch is to update the references of files after renaming.
After applying this patch, kindly run the following commands from OFBiz home
svn mv themes/flatgrey/webapp/flatgrey/maincss.css
themes/flatgrey/webapp/flatgrey/style.css
svn mv themes/flatgrey/webapp/flatgrey/mainrtl.css
themes/flatgrey/webapp/flatgrey/stylertl.css
svn mv themes/rainbowstone/webapp/rainbowstone/maincss.css
themes/rainbowstone/webapp/rainbowstone/style.css
svn mv themes/rainbowstone/webapp/rainbowstone/mainrtl.css
themes/rainbowstone/webapp/rainbowstone/stylertl.css
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch,
> OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-7311:
--
Attachment: OFBIZ-7311-tomahawk.patch
OFBIZ-7311-rainbowstone.patch
OFBIZ-7311-multiflex.patch
OFBIZ-7311-flatgrey.patch
OFBIZ-7311-droppingcrumbs.patch
OFBIZ-7311-bluelight.patch
OFBIZ-7311-bizznesstime.patch
Attaching the patches with respect to each theme for the formatted code.
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-7311-bizznesstime.patch,
> OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch,
> OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch,
> OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-7311:
--
Description:
In CSS files, we are having various inconsistency in the formatting of the code
for e.g. we have following types of code formatting
// No space
{code}
ul#preferences-menu a:hover {
text-decoration: none;
}
{code}
// Space of 2
{code}
div.autocomplete ul {
list-style-type:none;
margin:0;
padding:0;
}
{code}
// Space of 4
{code}
.control-area a {
font-size: 1.1em;
color: #5CA3D7;
}
{code}
For better readability we should format the existing files with space of 4.
Also for some theme, we named CSS files as *maincss.css* and for some, we named
it as *style.css*. We can rename these file as per best practices for
consistency.
was:
This is a placeholder task to capture all tasks regarding the formatting of CSS
code and renaming of files for the various themes.
In CSS files, we are having various inconsistency in the formatting of the code
for e.g. we have following types of code formatting
// No space
{code}
ul#preferences-menu a:hover {
text-decoration: none;
}
{code}
// Space of 2
{code}
div.autocomplete ul {
list-style-type:none;
margin:0;
padding:0;
}
{code}
// Space of 4
{code}
.control-area a {
font-size: 1.1em;
color: #5CA3D7;
}
{code}
For better readability we should format the existing files with space of 4.
Also for some theme, we named CSS files as *maincss.css* and for some, we named
it as *style.css*. We can rename these file as per best practices for
consistency.
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Minor
>
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-7311:
--
Summary: Formatting and renaming of the CSS files as per best practices
(was: Formatting in the CSS files)
> Formatting and renaming of the CSS files as per best practices
> --
>
> Key: OFBIZ-7311
> URL: https://issues.apache.org/jira/browse/OFBIZ-7311
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Minor
>
> This is a placeholder task to capture all tasks regarding the formatting of
> CSS code and renaming of files for the various themes.
> In CSS files, we are having various inconsistency in the formatting of the
> code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we
> named it as *style.css*. We can rename these file as per best practices for
> consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
