[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class

2016-07-16 Thread Chinmay Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802.patch

Provided patch for the issue. Thanks [~rishisolankii] for providing detailed 
explanation.

> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802.patch
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the 
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class

2016-07-16 Thread Chinmay Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-7802:
---
Attachment: (was: OFBIZ-7802)

> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the 
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7802) Enforce noninstantiability to ProductWorker class

2016-07-16 Thread Chinmay Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-7802:
---
Attachment: OFBIZ-7802

Providing the patch for the issue. Thanks [~rishisolankii] for the detailed 
explanation.

> Enforce noninstantiability to ProductWorker class
> -
>
> Key: OFBIZ-7802
> URL: https://issues.apache.org/jira/browse/OFBIZ-7802
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Chinmay Patidar
>Priority: Minor
> Attachments: OFBIZ-7802
>
>
> - Make class as final.
> - Private constructor already exists, by making it final we just matching the 
> patterns from other utility classes.
> - Make following public static final variables as private;
> {code}
> public static final String resource = "ProductUiLabels";
> public static final MathContext generalRounding = new MathContext(10);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)