[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[
https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7929:
--
Attachment: OFBIZ-7929_15.12.patch
Patch for the release 15.12 .
Is it ok or should I do the release 14.12 too ?
> Scrum find Total Backlog Item is not working in non-English language
>
>
> Key: OFBIZ-7929
> URL: https://issues.apache.org/jira/browse/OFBIZ-7929
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
> Labels: backlog, find, item, scrum
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch,
> OFBIZ-7929.patch, OFBIZ-7929_15.12.patch
>
>
> The Find form for Product Backlog Item does not work in language other than
> English when no "statusId" or "custRequestTypeId" are selected.
> Step to reproduce :
> - Go to the Scrum component and select a product
> - Go to the "Total Backlog" tab
> or use this linl :
> https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
> - Hit the search button, the find action is performed and return a non-empty
> list.
> - Set your language preference to a non english language (french for
> example).
> - Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
> - No results are found.
> Where does the problem come from ?
> The results displayed are from a list named "backlogList" which is built in
> the following script : FindProductBacklogItem.groovy .
> In this script, there were a check on the parameter "custRequestTypeId" and
> on the parameter "statusId".
> But the value was hardcoded :
> {code}
> if("Any".equals(parameters.custRequestTypeId))
> {code}
> and
> {code}
> if(!"Any".equals(parameters.statusId))
> {code}
> Obviously, when the form is in another language than english, those
> conditions aren't valid anymore (for exemple, "Any" is "Dont" in French")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[
https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7929:
--
Attachment: OFBIZ-7929.patch
Patch created from an up-to-date OFBiz trunk version
> Scrum find Total Backlog Item is not working in non-English language
>
>
> Key: OFBIZ-7929
> URL: https://issues.apache.org/jira/browse/OFBIZ-7929
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
> Labels: backlog, find, item, scrum
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch,
> OFBIZ-7929.patch
>
>
> The Find form for Product Backlog Item does not work in language other than
> English when no "statusId" or "custRequestTypeId" are selected.
> Step to reproduce :
> - Go to the Scrum component and select a product
> - Go to the "Total Backlog" tab
> or use this linl :
> https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
> - Hit the search button, the find action is performed and return a non-empty
> list.
> - Set your language preference to a non english language (french for
> example).
> - Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
> - No results are found.
> Where does the problem come from ?
> The results displayed are from a list named "backlogList" which is built in
> the following script : FindProductBacklogItem.groovy .
> In this script, there were a check on the parameter "custRequestTypeId" and
> on the parameter "statusId".
> But the value was hardcoded :
> {code}
> if("Any".equals(parameters.custRequestTypeId))
> {code}
> and
> {code}
> if(!"Any".equals(parameters.statusId))
> {code}
> Obviously, when the form is in another language than english, those
> conditions aren't valid anymore (for exemple, "Any" is "Dont" in French")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[
https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7929:
--
Attachment: OFBIZ-7929.patch
Thank you for your review and advice !
I put it all in this new version of the patch :
- Changed UtilValidate test to Groovy Truth test on string
- Changed the big first test by a test on "noConditionFind"
- Added some commentaries
- Harmonization of hte if test
- Removed the uiLabelMap.CommonAny in the file (the two others belonged to
another form --> "FindTotalBacklog")
- Added a "noConditionFind" field to this form --> "FindTotalBacklog"
Both forms seem to work fine. I hope I didn't forget anything this time ; )
The second form can be accessed by :
- Scrum component
- Administration Tab
- All Backlog subTab
If those change are fine, I'll create a patch for the other versions.
> Scrum find Total Backlog Item is not working in non-English language
>
>
> Key: OFBIZ-7929
> URL: https://issues.apache.org/jira/browse/OFBIZ-7929
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
> Labels: backlog, find, item, scrum
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch, OFBIZ-7929.patch
>
>
> The Find form for Product Backlog Item does not work in language other than
> English when no "statusId" or "custRequestTypeId" are selected.
> Step to reproduce :
> - Go to the Scrum component and select a product
> - Go to the "Total Backlog" tab
> or use this linl :
> https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
> - Hit the search button, the find action is performed and return a non-empty
> list.
> - Set your language preference to a non english language (french for
> example).
> - Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
> - No results are found.
> Where does the problem come from ?
> The results displayed are from a list named "backlogList" which is built in
> the following script : FindProductBacklogItem.groovy .
> In this script, there were a check on the parameter "custRequestTypeId" and
> on the parameter "statusId".
> But the value was hardcoded :
> {code}
> if("Any".equals(parameters.custRequestTypeId))
> {code}
> and
> {code}
> if(!"Any".equals(parameters.statusId))
> {code}
> Obviously, when the form is in another language than english, those
> conditions aren't valid anymore (for exemple, "Any" is "Dont" in French")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[
https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7929:
--
Attachment: OFBIZ-7929.patch
Found two ugly things in the patch so I'm updating it (sorry for the first one,
I was too careless).
- Used UtilValidate.isEmpty instead of "".equals
- Removed the useless line at the start of the file (when removing the ?: part
of the condition, I forgot to remove the remaining part of the line)
> Scrum find Total Backlog Item is not working in non-English language
>
>
> Key: OFBIZ-7929
> URL: https://issues.apache.org/jira/browse/OFBIZ-7929
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
> Labels: backlog, find, item, scrum
> Attachments: OFBIZ-7929.patch, OFBIZ-7929.patch
>
>
> The Find form for Product Backlog Item does not work in language other than
> English when no "statusId" or "custRequestTypeId" are selected.
> Step to reproduce :
> - Go to the Scrum component and select a product
> - Go to the "Total Backlog" tab
> or use this linl :
> https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
> - Hit the search button, the find action is performed and return a non-empty
> list.
> - Set your language preference to a non english language (french for
> example).
> - Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
> - No results are found.
> Where does the problem come from ?
> The results displayed are from a list named "backlogList" which is built in
> the following script : FindProductBacklogItem.groovy .
> In this script, there were a check on the parameter "custRequestTypeId" and
> on the parameter "statusId".
> But the value was hardcoded :
> {code}
> if("Any".equals(parameters.custRequestTypeId))
> {code}
> and
> {code}
> if(!"Any".equals(parameters.statusId))
> {code}
> Obviously, when the form is in another language than english, those
> conditions aren't valid anymore (for exemple, "Any" is "Dont" in French")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language
[
https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7929:
--
Attachment: OFBIZ-7929.patch
I removed the option based on "uiLabelMap.CommonAny" in the form for both the
"custRequestTypeId" and the "statusId". And I set the "allow-empty" attribute
of the drop-down to "true".
Please tell me what you think about that solution (I'm not sure about the
"allow-empty" thing).
> Scrum find Total Backlog Item is not working in non-English language
>
>
> Key: OFBIZ-7929
> URL: https://issues.apache.org/jira/browse/OFBIZ-7929
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/scrum
>Affects Versions: Trunk
>Reporter: Montalbano Florian
> Labels: backlog, find, item, scrum
> Attachments: OFBIZ-7929.patch
>
>
> The Find form for Product Backlog Item does not work in language other than
> English when no "statusId" or "custRequestTypeId" are selected.
> Step to reproduce :
> - Go to the Scrum component and select a product
> - Go to the "Total Backlog" tab
> or use this linl :
> https://localhost:8443/scrum/control/ViewTotalBacklog?productId=DEMO-PRODUCT-1
> - Hit the search button, the find action is performed and return a non-empty
> list.
> - Set your language preference to a non english language (french for
> example).
> - Click again on the "Total Backlog" tab, and hit the "Rechercher" button.
> - No results are found.
> Where does the problem come from ?
> The results displayed are from a list named "backlogList" which is built in
> the following script : FindProductBacklogItem.groovy .
> In this script, there were a check on the parameter "custRequestTypeId" and
> on the parameter "statusId".
> But the value was hardcoded :
> {code}
> if("Any".equals(parameters.custRequestTypeId))
> {code}
> and
> {code}
> if(!"Any".equals(parameters.statusId))
> {code}
> Obviously, when the form is in another language than english, those
> conditions aren't valid anymore (for exemple, "Any" is "Dont" in French")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
