Re: Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-30 Thread Pierre Smits 
Hi Mathieu, all,

I am at a loss here, are you suggesting to introduce new ticket types,
and/or sub types? As far as JIRA shows there are only:

   1. bug (which can get to final successful resolution 'fixed')
   2. improvement (which can get to final successful resolution
   'implemented')
   3. new feature (which also can get to final successful resolution
   'implemented')
   4. task (which can get to final successful resolution 'done')
   5. test (which can get to a final successful resolution 'executed')
   6. wish ()

Refactoring is not a recognised type, and IMO it should not be in. We
should keep things as simple as possible.

Doesn't the proposed change for bug tickets (being able to classify it as
'improved' confuse many? Or am I missing the point?

Best regards,

Pierre Smits

*Apache Trafodion , Vice President*
*Apache Directory , PMC Member*
Apache Incubator , committer
*Apache OFBiz , contributor (without privileges)
since 2008*
Apache Steve , committer


On Sun, Sep 29, 2019 at 1:38 PM Mathieu Lirzin 
wrote:

> Hello,
>
> Pierre Smits  writes:
>
> > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As
> per
> > established conventions.
>
> From what I understood from the examples and common practice [1], this
> is only partially true.  Improvement tickets can be associated with both
> ‘Implemented:’ and ‘Improved:’ commits depending on the type of
> improvement:
>
>- Refactoring => “Improved:”
>- New feature => “Implemented:”
>
> [1]
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
>
> > On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane 
> wrote:
> >
> >> Hi Deepak,
> >>
> >> Happy to see your commits in action. :)
> >> Just a minor suggestion, we put Jira ticket ID in separate line in
> commit
> >> log.
> >> Also, add colon ':' in Thanks statement.
> >> And since the ticket type is 'Improvement', it seems to me, we should
> use
> >> 'Improved' instead of 'Fixed'.
> >>
> >> Here is commit template for your quick reference
> >>
> >>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> >>
> >> Following commit log template will help us in producing the monthly blog
> >> development details.
>
> As a general rule, I would say that working on a “bug” ticket implies at
> least one “Fixed:” commit, but it is possible to associate a
> complementary refactoring “Improved:” commit to a “bug” ticket.  On the
> other hand an “improvement” ticket can not be associated with a “Fixed:”
> commit.
>
> What about adding a CONTRIBUTING.adoc file the repository stating those
> rules?  This would make things far more visible and explicit than on
> Confluence which is not very visible (I often to keep bookmarks to
> retrieve some information) and far from the code.
>
> What do people think?
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>

Re: Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-29 Thread Aditya Sharma 
+1. Thank you Mathieu!

Thanks and regards,
Aditya Sharma

On Mon, Sep 30, 2019 at 11:44 AM Pawan Verma 
wrote:

> +1
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Mon, Sep 30, 2019 at 10:57 AM Swapnil M Mane 
> wrote:
>
> > +1 Mathieu for documenting these rules/conventions, thank you!
> >
> > Best regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Sun, Sep 29, 2019 at 5:08 PM Mathieu Lirzin <
> mathieu.lir...@nereide.fr>
> > wrote:
> >
> > > Hello,
> > >
> > > Pierre Smits  writes:
> > >
> > > > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’.
> As
> > > per
> > > > established conventions.
> > >
> > > From what I understood from the examples and common practice [1], this
> > > is only partially true.  Improvement tickets can be associated with
> both
> > > ‘Implemented:’ and ‘Improved:’ commits depending on the type of
> > > improvement:
> > >
> > >- Refactoring => “Improved:”
> > >- New feature => “Implemented:”
> > >
> > > [1]
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> > >
> > > > On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane  >
> > > wrote:
> > > >
> > > >> Hi Deepak,
> > > >>
> > > >> Happy to see your commits in action. :)
> > > >> Just a minor suggestion, we put Jira ticket ID in separate line in
> > > commit
> > > >> log.
> > > >> Also, add colon ':' in Thanks statement.
> > > >> And since the ticket type is 'Improvement', it seems to me, we
> should
> > > use
> > > >> 'Improved' instead of 'Fixed'.
> > > >>
> > > >> Here is commit template for your quick reference
> > > >>
> > > >>
> > >
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> > > >>
> > > >> Following commit log template will help us in producing the monthly
> > blog
> > > >> development details.
> > >
> > > As a general rule, I would say that working on a “bug” ticket implies
> at
> > > least one “Fixed:” commit, but it is possible to associate a
> > > complementary refactoring “Improved:” commit to a “bug” ticket.  On the
> > > other hand an “improvement” ticket can not be associated with a
> “Fixed:”
> > > commit.
> > >
> > > What about adding a CONTRIBUTING.adoc file the repository stating those
> > > rules?  This would make things far more visible and explicit than on
> > > Confluence which is not very visible (I often to keep bookmarks to
> > > retrieve some information) and far from the code.
> > >
> > > What do people think?
> > >
> > > --
> > > Mathieu Lirzin
> > > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> > >
> >
>

Re: Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-29 Thread Pawan Verma 
+1
-- 
Thanks & Regards
Pawan Verma
Technical Consultant
*HotWax Systems*
*Enterprise open source experts*
http://www.hotwaxsystems.com


On Mon, Sep 30, 2019 at 10:57 AM Swapnil M Mane 
wrote:

> +1 Mathieu for documenting these rules/conventions, thank you!
>
> Best regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Sun, Sep 29, 2019 at 5:08 PM Mathieu Lirzin 
> wrote:
>
> > Hello,
> >
> > Pierre Smits  writes:
> >
> > > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As
> > per
> > > established conventions.
> >
> > From what I understood from the examples and common practice [1], this
> > is only partially true.  Improvement tickets can be associated with both
> > ‘Implemented:’ and ‘Improved:’ commits depending on the type of
> > improvement:
> >
> >- Refactoring => “Improved:”
> >- New feature => “Implemented:”
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> >
> > > On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane 
> > wrote:
> > >
> > >> Hi Deepak,
> > >>
> > >> Happy to see your commits in action. :)
> > >> Just a minor suggestion, we put Jira ticket ID in separate line in
> > commit
> > >> log.
> > >> Also, add colon ':' in Thanks statement.
> > >> And since the ticket type is 'Improvement', it seems to me, we should
> > use
> > >> 'Improved' instead of 'Fixed'.
> > >>
> > >> Here is commit template for your quick reference
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> > >>
> > >> Following commit log template will help us in producing the monthly
> blog
> > >> development details.
> >
> > As a general rule, I would say that working on a “bug” ticket implies at
> > least one “Fixed:” commit, but it is possible to associate a
> > complementary refactoring “Improved:” commit to a “bug” ticket.  On the
> > other hand an “improvement” ticket can not be associated with a “Fixed:”
> > commit.
> >
> > What about adding a CONTRIBUTING.adoc file the repository stating those
> > rules?  This would make things far more visible and explicit than on
> > Confluence which is not very visible (I often to keep bookmarks to
> > retrieve some information) and far from the code.
> >
> > What do people think?
> >
> > --
> > Mathieu Lirzin
> > GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
> >
>

Re: Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-29 Thread Swapnil M Mane 
+1 Mathieu for documenting these rules/conventions, thank you!

Best regards,
Swapnil M Mane,
ofbiz.apache.org



On Sun, Sep 29, 2019 at 5:08 PM Mathieu Lirzin 
wrote:

> Hello,
>
> Pierre Smits  writes:
>
> > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As
> per
> > established conventions.
>
> From what I understood from the examples and common practice [1], this
> is only partially true.  Improvement tickets can be associated with both
> ‘Implemented:’ and ‘Improved:’ commits depending on the type of
> improvement:
>
>- Refactoring => “Improved:”
>- New feature => “Implemented:”
>
> [1]
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
>
> > On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane 
> wrote:
> >
> >> Hi Deepak,
> >>
> >> Happy to see your commits in action. :)
> >> Just a minor suggestion, we put Jira ticket ID in separate line in
> commit
> >> log.
> >> Also, add colon ':' in Thanks statement.
> >> And since the ticket type is 'Improvement', it seems to me, we should
> use
> >> 'Improved' instead of 'Fixed'.
> >>
> >> Here is commit template for your quick reference
> >>
> >>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
> >>
> >> Following commit log template will help us in producing the monthly blog
> >> development details.
>
> As a general rule, I would say that working on a “bug” ticket implies at
> least one “Fixed:” commit, but it is possible to associate a
> complementary refactoring “Improved:” commit to a “bug” ticket.  On the
> other hand an “improvement” ticket can not be associated with a “Fixed:”
> commit.
>
> What about adding a CONTRIBUTING.adoc file the repository stating those
> rules?  This would make things far more visible and explicit than on
> Confluence which is not very visible (I often to keep bookmarks to
> retrieve some information) and far from the code.
>
> What do people think?
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>

Adding a CONTRIBUTING.adoc file to the “ofbiz-framework” repository (was: svn commit: r1867663 …)

2019-09-29 Thread Mathieu Lirzin 
Hello,

Pierre Smits  writes:

> Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As per
> established conventions.

>From what I understood from the examples and common practice [1], this
is only partially true.  Improvement tickets can be associated with both
‘Implemented:’ and ‘Improved:’ commits depending on the type of
improvement:

   - Refactoring => “Improved:”
   - New feature => “Implemented:”

[1] 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template

> On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane  wrote:
>
>> Hi Deepak,
>>
>> Happy to see your commits in action. :)
>> Just a minor suggestion, we put Jira ticket ID in separate line in commit
>> log.
>> Also, add colon ':' in Thanks statement.
>> And since the ticket type is 'Improvement', it seems to me, we should use
>> 'Improved' instead of 'Fixed'.
>>
>> Here is commit template for your quick reference
>>
>> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template
>>
>> Following commit log template will help us in producing the monthly blog
>> development details.

As a general rule, I would say that working on a “bug” ticket implies at
least one “Fixed:” commit, but it is possible to associate a
complementary refactoring “Improved:” commit to a “bug” ticket.  On the
other hand an “improvement” ticket can not be associated with a “Fixed:”
commit.

What about adding a CONTRIBUTING.adoc file the repository stating those
rules?  This would make things far more visible and explicit than on
Confluence which is not very visible (I often to keep bookmarks to
retrieve some information) and far from the code.

What do people think?

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37