Re: Rat flag for failure or success

2019-06-11 Thread Jacques Le Roux

Hi Jochen, All,

Kinda message in a bottle :)

I have created https://issues.apache.org/jira/browse/OFBIZ-11097 for that

But I'm unsure on how I should use numUnapprovedLicenses inside the Buildbot 
OFBiz RAT script.

Would something like

diff --git a/modules/buildbot_slave/files/ofbiz.xml 
b/modules/buildbot_slave/files/ofbiz.xml
index 38fddfa2..1c78af4f 100644
--- a/modules/buildbot_slave/files/ofbiz.xml
+++ b/modules/buildbot_slave/files/ofbiz.xml
@@ -40,6 +40,7 @@
   
 
   
+  
 
   

work (correct syntax? I know 0 unapproved licenses is the default)?
But then how to alert the OFBiz dev ML in case of issues?

Reading http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html, I 
can't clearly find a way to send an email when numUnapprovedLicenses is not 0.

If I refer to other OFBiz builds we receive an email when the state change. 
Could we do something like that?

Thanks

Jacques

Le 15/02/2018 à 11:23, Jochen Wiedmann a écrit :

See numUnapprovedLicenses on
http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html,


On Thu, Feb 15, 2018 at 11:19 AM, Jacques Le Roux
 wrote:

Hi,

I recently had this discussion in the infra HipChat room

[10:03 AM] Jacques Le Roux: Dear Infra team :) We use RAT and have this
report https://ci.apache.org/projects/ofbiz/rat-output.html
I was wondering if there is a way in RAT to get an alert when the status
change from "ALL OK" to an issue?
If not I guess I should ask the RAT project?
[10:05 AM] Daniel Takamori (pono): I'm not too familiar with RAT, so not
sure it's possible in buildbot besides adding a step to grep for errors or
something
[10:05 AM] Gavin McDonald: that would need some thought
[10:06 AM] Gavin McDonald: you could ask the RAT project if there output
might contain a flag or something we can use in builbot
[10:06 AM] Jacques Le Roux: Yes makes sense Daniel, I'll ask RAT and see if
we can get something for everybody...
And indeed need some thoughts
[10:07 AM] Jacques Le Roux: Thanks guys

So here is my request: is there a such flag? If not could there be one?

Thanks

Jacques



Re: Rat flag for failure or success

2018-02-15 Thread Jacques Le Roux

Thanks Jochen,

I'll have a look on how to use that in Buildbot

Jacques


Le 15/02/2018 à 11:23, Jochen Wiedmann a écrit :

See numUnapprovedLicenses on
http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html,


On Thu, Feb 15, 2018 at 11:19 AM, Jacques Le Roux
 wrote:

Hi,

I recently had this discussion in the infra HipChat room

[10:03 AM] Jacques Le Roux: Dear Infra team :) We use RAT and have this
report https://ci.apache.org/projects/ofbiz/rat-output.html
I was wondering if there is a way in RAT to get an alert when the status
change from "ALL OK" to an issue?
If not I guess I should ask the RAT project?
[10:05 AM] Daniel Takamori (pono): I'm not too familiar with RAT, so not
sure it's possible in buildbot besides adding a step to grep for errors or
something
[10:05 AM] Gavin McDonald: that would need some thought
[10:06 AM] Gavin McDonald: you could ask the RAT project if there output
might contain a flag or something we can use in builbot
[10:06 AM] Jacques Le Roux: Yes makes sense Daniel, I'll ask RAT and see if
we can get something for everybody...
And indeed need some thoughts
[10:07 AM] Jacques Le Roux: Thanks guys

So here is my request: is there a such flag? If not could there be one?

Thanks

Jacques





Re: Rat flag for failure or success

2018-02-15 Thread Jochen Wiedmann
See numUnapprovedLicenses on
http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html,


On Thu, Feb 15, 2018 at 11:19 AM, Jacques Le Roux
 wrote:
> Hi,
>
> I recently had this discussion in the infra HipChat room
>
> [10:03 AM] Jacques Le Roux: Dear Infra team :) We use RAT and have this
> report https://ci.apache.org/projects/ofbiz/rat-output.html
> I was wondering if there is a way in RAT to get an alert when the status
> change from "ALL OK" to an issue?
> If not I guess I should ask the RAT project?
> [10:05 AM] Daniel Takamori (pono): I'm not too familiar with RAT, so not
> sure it's possible in buildbot besides adding a step to grep for errors or
> something
> [10:05 AM] Gavin McDonald: that would need some thought
> [10:06 AM] Gavin McDonald: you could ask the RAT project if there output
> might contain a flag or something we can use in builbot
> [10:06 AM] Jacques Le Roux: Yes makes sense Daniel, I'll ask RAT and see if
> we can get something for everybody...
> And indeed need some thoughts
> [10:07 AM] Jacques Le Roux: Thanks guys
>
> So here is my request: is there a such flag? If not could there be one?
>
> Thanks
>
> Jacques
>