Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Le 30/09/2014 23:19, Nicolas Malin a écrit : Ho, sorry Jacques, I misunderstood this : Also, not everone knows how jira works. Or confluence. Or AutoConfigMaintenceWidgetApplication. What you may thing as a sensible cross-reference(OFBIZ-, debbugs ) may mean nothing to the person reading your changelog. (https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities) I read and understood do not set issue reference, but I totally wrong. It's more do not issue reference only !. I did not find what you are referring too, only 3) The commit log must identify the name of the contributor and, if relevant, the JIRA issue for it. Anyway it's fine since you got it ;) Jacques Thanks for this remark, I will correct my commit's comment the next time. Nicolas Le 30/09/2014 18:43, Jacques Le Roux a écrit : Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Thanks Adrian, I would like everyone to do that... Jacques Le 01/10/2014 02:01, Adrian Crum a écrit : Also, please put the revision number in the Jira issue. That helps others doing research on changes. Adrian Crum Sandglass Software www.sandglass-software.com On 9/30/2014 5:43 PM, Jacques Le Roux wrote: Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value value-field=prodCatalogCategory/ -/simple-method - -!-- Party and Catalog services -- -simple-method method-name=addProdCatalogToParty short-description=Add ProdCatalog To Party -make-value value-field=newEntity entity-name=ProdCatalogRole/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
If it's not in the https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities I will add it as a best practice Jacques Le 01/10/2014 11:45, Jacques Le Roux a écrit : Thanks Adrian, I would like everyone to do that... Jacques Le 01/10/2014 02:01, Adrian Crum a écrit : Also, please put the revision number in the Jira issue. That helps others doing research on changes. Adrian Crum Sandglass Software www.sandglass-software.com On 9/30/2014 5:43 PM, Jacques Le Roux wrote: Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value value-field=prodCatalogCategory/ -/simple-method - -!-- Party and Catalog services -- -simple-method method-name=addProdCatalogToParty
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
+1, it's not present and it's important that we use the same rule :) Le 01/10/2014 13:23, Jacques Le Roux a écrit : If it's not in the https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities I will add it as a best practice Jacques Le 01/10/2014 11:45, Jacques Le Roux a écrit : Thanks Adrian, I would like everyone to do that... Jacques Le 01/10/2014 02:01, Adrian Crum a écrit : Also, please put the revision number in the Jira issue. That helps others doing research on changes. Adrian Crum Sandglass Software www.sandglass-software.com On 9/30/2014 5:43 PM, Jacques Le Roux wrote: Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Thanks for confirmation Nicolas Jacques Le 01/10/2014 13:50, Nicolas Malin a écrit : +1, it's not present and it's important that we use the same rule :) Le 01/10/2014 13:23, Jacques Le Roux a écrit : If it's not in the https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities I will add it as a best practice Jacques Le 01/10/2014 11:45, Jacques Le Roux a écrit : Thanks Adrian, I would like everyone to do that... Jacques Le 01/10/2014 02:01, Adrian Crum a écrit : Also, please put the revision number in the Jira issue. That helps others doing research on changes. Adrian Crum Sandglass Software www.sandglass-software.com On 9/30/2014 5:43 PM, Jacques Le Roux wrote: Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value value-field=prodCatalogCategory/ -/simple-method - -!-- Party and Catalog services -- -simple-method method-name=addProdCatalogToParty short-description=Add ProdCatalog To Party -make-value value-field=newEntity entity-name=ProdCatalogRole/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalogToParty
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Ho, sorry Jacques, I misunderstood this : Also, not everone knows how jira works. Or confluence. Or AutoConfigMaintenceWidgetApplication. What you may thing as a sensible cross-reference(OFBIZ-, debbugs ) may mean nothing to the person reading your changelog. (https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities) I read and understood do not set issue reference, but I totally wrong. It's more do not issue reference only !. Thanks for this remark, I will correct my commit's comment the next time. Nicolas Le 30/09/2014 18:43, Jacques Le Roux a écrit : Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value
Re: svn commit: r1628405 - in /ofbiz/trunk/applications/product: script/org/ofbiz/product/catalog/CatalogServices.xml servicedef/services.xml
Also, please put the revision number in the Jira issue. That helps others doing research on changes. Adrian Crum Sandglass Software www.sandglass-software.com On 9/30/2014 5:43 PM, Jacques Le Roux wrote: Hi Nicolas, When possible please put a least the number of the Jira issue in commit, it's easier to follow things (links are even easier ;) Thanks Jacques Le 30/09/2014 13:59, nma...@apache.org a écrit : Author: nmalin Date: Tue Sep 30 11:59:29 2014 New Revision: 1628405 URL: http://svn.apache.org/r1628405 Log: Convert the ProdCatalog CRUD simple service to entity-auto Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml ofbiz/trunk/applications/product/servicedef/services.xml Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml?rev=1628405r1=1628404r2=1628405view=diff == --- ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml (original) +++ ofbiz/trunk/applications/product/script/org/ofbiz/product/catalog/CatalogServices.xml Tue Sep 30 11:59:29 2014 @@ -20,92 +20,6 @@ under the License. simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods-v2.xsd; -simple-method method-name=createProdCatalog short-description=Create an ProdCatalog -make-value value-field=newEntity entity-name=ProdCatalog/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=parameters.prodCatalogId -sequenced-id sequence-name=ProdCatalog field=newEntity.prodCatalogId/ -else -set field=newEntity.prodCatalogId from-field=parameters.prodCatalogId/ -check-id field=newEntity.prodCatalogId/ -check-errors/ -/else -/if-empty -field-to-result field=newEntity.prodCatalogId result-name=prodCatalogId/ - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProdCatalog short-description=Update an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -set-nonpk-fields map=parameters value-field=prodCatalog/ -store-value value-field=prodCatalog/ -/simple-method -simple-method method-name=deleteProdCatalog short-description=Delete an ProdCatalog -entity-one entity-name=ProdCatalog value-field=prodCatalog/ -remove-value value-field=prodCatalog/ -/simple-method - -simple-method method-name=addProductCategoryToProdCatalog short-description=Add Category To ProdCatalog -!-- Check that the ProductCategory exists -- -entity-one entity-name=ProductCategory value-field=productCategory/ -if-empty field=productCategory -add-errorfail-property resource=ProductUiLabels property=ProductCategoryNotFoundForCategoryID//add-error -/if-empty -check-errors/ - -make-value value-field=newEntity entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp field=nowTimestamp/ -set from-field=nowTimestamp field=newEntity.fromDate/ -/if-empty - -create-value value-field=newEntity/ -/simple-method -simple-method method-name=updateProductCategoryToProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -set-nonpk-fields map=parameters value-field=prodCatalogCategory/ -store-value value-field=prodCatalogCategory/ -/simple-method -simple-method method-name=removeProductCategoryFromProdCatalog short-description=Remove ContactMech From ProdCatalog - -make-value value-field=lookupPKMap entity-name=ProdCatalogCategory/ -set-pk-fields map=parameters value-field=lookupPKMap/ -find-by-primary-key entity-name=ProdCatalogCategory map=lookupPKMap value-field=prodCatalogCategory/ -remove-value value-field=prodCatalogCategory/ -/simple-method - -!-- Party and Catalog services -- -simple-method method-name=addProdCatalogToParty short-description=Add ProdCatalog To Party -make-value value-field=newEntity entity-name=ProdCatalogRole/ -set-pk-fields map=parameters value-field=newEntity/ -set-nonpk-fields map=parameters value-field=newEntity/ - -if-empty field=newEntity.fromDate -now-timestamp
