Re: svn commit: r1683642 - in /ofbiz/trunk/framework/widget: dtd/widget-common.xsd src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java templates/htmlFormMacroLibrary.ftl
Le 05/06/2015 08:23, Nicolas Malin a écrit :
Le 05/06/2015 08:18, Jacopo Cappellato a écrit :
Hi Nicolas,
if I am not wrong when we modify the attributes set by MacroFormRenderer we need to modify the macros in all the *FormMacroLibrary.ftl, even if
some of them don't need and can actually ignore the passed-in values.
Yes right Jacopo. I saw yesterday that some macro aren't synchronized. I
planned to check all on one pass.
In a recent effort at r1671756 and r1680921 at least (maybe also another
commit) I completed missing parameters, I could have missed some though
Jacques
Nicolas
Cheers,
Jacopo
On Jun 4, 2015, at 10:56 PM, nma...@apache.org wrote:
Author: nmalin
Date: Thu Jun 4 20:55:59 2015
New Revision: 1683642
URL: http://svn.apache.org/r1683642
Log:
Form widget hyperlink.id attribute isn't supported by MacroFormRenderer.java
(OFBIZ-6403) thanks christian carlow for this issue
Modified:
ofbiz/trunk/framework/widget/dtd/widget-common.xsd
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
Modified: ofbiz/trunk/framework/widget/dtd/widget-common.xsd
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-common.xsd?rev=1683642&r1=1683641&r2=1683642&view=diff
==
--- ofbiz/trunk/framework/widget/dtd/widget-common.xsd (original)
+++ ofbiz/trunk/framework/widget/dtd/widget-common.xsd Thu Jun 4 20:55:59 2015
@@ -583,7 +583,13 @@ under the License.
-
+
+
+
+ If you use id for link present in list form or multi
form, you can use ${itemIndex} to generate an unique id by line.
+
+
+
Modified:
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java?rev=1683642&r1=1683641&r2=1683642&view=diff
==
---
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
(original)
+++
ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
Thu Jun 4 20:55:59 2015
@@ -311,6 +311,7 @@ public final class MacroFormRenderer imp
this.request.setAttribute("alternate", encodedAlternate);
this.request.setAttribute("imageTitle", encodedImageTitle);
this.request.setAttribute("descriptionSize", hyperlinkField.getSize());
+this.request.setAttribute("id", hyperlinkField.getId(context));
makeHyperlinkByType(writer, hyperlinkField.getLinkType(), modelFormField.getWidgetStyle(), hyperlinkField.getUrlMode(),
hyperlinkField.getTarget(context), hyperlinkField.getParameterMap(context), hyperlinkField.getDescription(context),
hyperlinkField.getTargetWindow(context),
hyperlinkField.getConfirmation(context), modelFormField,
this.request, this.response, context);
this.appendTooltip(writer, context, modelFormField);
@@ -3073,6 +3074,7 @@ public final class MacroFormRenderer imp
String action = "";
String imgSrc = "";
String alt = "";
+String id = "";
String imgTitle = "";
String hiddenFormName =
WidgetWorker.makeLinkHiddenFormName(context, modelFormField);
if (UtilValidate.isNotEmpty(modelFormField.getEvent()) &&
UtilValidate.isNotEmpty(modelFormField.getAction(context))) {
@@ -3099,6 +3101,9 @@ public final class MacroFormRenderer imp
if (UtilValidate.isEmpty(imgTitle)) {
imgTitle = modelFormField.getTitle(context);
}
+if (UtilValidate.isNotEmpty(request.getAttribute("id"))) {
+id = request.getAttribute("id").toString();
+}
StringWriter sr = new StringWriter();
sr.append("<@makeHyperlinkString ");
sr.append("linkStyle=\"");
@@ -3123,6 +3128,8 @@ public final class MacroFormRenderer imp
sr.append(description);
sr.append("\" confirmation =\"");
sr.append(confirmation);
+sr.append("\" id=\"");
+sr.append(id);
sr.append("\" />");
executeMacro(writer, sr.toString());
}
Modified: ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=1683642&r1=1683641&r2=1683642&view=diff
==
--- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl (original)
+++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary
Re: References for DITA as a tool for on-line help
Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be nice and powerful. I'm beginning to do some of our own documentation on it. - Original Message - From: "Ron Wheeler" To: "dev" Sent: Thursday, 4 June, 2015 6:14:56 PM Subject: References for DITA as a tool for on-line help http://www.slideshare.net/abelsp/using-dita-for-online-help Slideshare has a lot of other presentations on DITA http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture Short with Hello World example http://en.wikipedia.org/wiki/Online_help Alternatives for producing on-line help - DocBooks and DITA considered together since they are closely related http://www.ditawriter.com/sample-dita-produced-output/ Has links to actual documents produced from DITA sources. https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf exhaustive article on ways to deliver help authored by DITA tools. It shows that an investment in DITA content will always be protected even if the OFBiz UI and help delivery technology changes. Table of Contents *Introduction to the DITA Help Best Practices Guide* *Developing DITA-based Help for Existing Help Environments* -Arbortext Digital Media Publisher -Eclipse Help -CSHelp Plug-in -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help -Eclipse Help -Leximation AIR Help Plug-in -Microsoft HTMLHelp -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In -The DITA Open Toolkit HTMLHelp Transform *Developing Custom DITA-based Help Systems** *-DHTML Effects in HTML Generated from DITA -DITA-OT Plug-ins -HTMLSearch Plug-in -TOCJS and TOCJSBIS Plug-ins -Dynamic Rendering of DITA into XHTML -JavaScript-Based Context Sensitive Help -WinANT Options Supporting HTML-Based Output -WinANT Options Supporting Microsoft® HTML Help *Developing DITA-based Help for Existing Help Authoring Tools** *-Converting DITA Content to WebHelp using RoboHelp® There are a lot more articles on using DITA content in On-line help. The same content is available for other uses. Ron -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
Re: Possible Documentation and help solutions - DITA
Hi Sharan, Well thought and makes sense. In a way our problem is in the process rather than the technology. And small steps are one of humanity's best concepts IMHO. So may I suggest a set of actions to move forward: - First, we attempt to fix whatever is wrong in DocBook at the moment. If you can share exactly what you spotted then this would save us a lot of time in trying to dig to the problem. So a repeat process to identify the bugs from you would be great. - Second, we decide on a category structure for the sections of the documentation if we do not like the existing one - We also introduce or enforce a workflow that mandates an update of the documentation on each JIRA that affects functionality that requires documentation. For example, if we add or modify a screen in the party component, then we must provide the documentation for that screen before closing the JIRA for example. - As a last step we decide on the appropriate technology to move forward. Now, in the philosophy of small steps and being a guy who likes to jump into action, I suggest we start with the first point above and move from there. Thoughts? Taher Alkhateeb - Original Message - From: "Sharan-F" To: dev@ofbiz.apache.org Sent: Thursday, 4 June, 2015 11:01:58 AM Subject: Re: Possible Documentation and help solutions - DITA Hi Taher It would be good to understand what exactly is missing from our Docbook implementation. It might be that we have set the tags at a specific level (e.g section etc) which means that we cant use chapters etc. I'm still thinking but the main thing that concerns me is this. There is a lot of focus about changing the technology but no focus on how we integrate it or manage it. It's not only about changing the technology - we need to address the underlying problems. Why is our online documentation not being kept up to date? These are the main reasons I think are: - it is too hard to keep up to date as each change needs to be submitted as a patch - you need to understand and create the new data items for the CMS for each page of documentation - existing items need to be linked into the correct place in the document hierarchy - the docbook implementation isn't complete and there are a lot standard tags that cannot be used One the End User documentation side remember that Confluence is the Apache approved tools for wiki so we still need to work within this constraint for now. In any case – I think we firstly need to do some review of the all the documentation we have before we start structuring it. If changing to another format (DITA, Asciidoc etc) within OFBiz itself is going to generate a lot of work on the framework etc – why don't we try some small steps first just to see what we can do. It will also show if we can really start adding some value. Paul mentioned that Asciidoc could be a good compromise as it converts to Docbook and other formats. What about doing a small proof of concept (PoC) just to see what editing using Asciidoc could be like? The scope would be not to replace Docbook in OFBiz but just to see how we can use and edit in Asciidoc and how it can generate Docbook or other formats. - Could we extract the existing OFBiz online help and put it into Asciidoc format - Put the Online help Asciidoc somewhere where it can be edited and updated - Extract updated Asciidoc back into Docbook (or other) format - See if it can be re-introduced back into OFBiz (e.g. directly as a patch or as part as an ant target) Does this seem reasonable? If so are there any volunteers who'd like to work with me on this PoC? Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/Possible-Documentation-and-help-solutions-DITA-tp4669377p4669411.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Created] (OFBIZ-6449) Update internal Ant from 1.9.0 to 1.9.5
Jacques Le Roux created OFBIZ-6449: -- Summary: Update internal Ant from 1.9.0 to 1.9.5 Key: OFBIZ-6449 URL: https://issues.apache.org/jira/browse/OFBIZ-6449 Project: OFBiz Issue Type: Task Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Upcoming Branch http://ant.apache.org/bindownload.cgi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6327) Make layered-window available in forms
[ https://issues.apache.org/jira/browse/OFBIZ-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574149#comment-14574149 ] Jacques Le Roux commented on OFBIZ-6327: I'd suggest layered-modal :) BTW we spoke about that at OFBIZ-4183 so we could close it after IMO Also while at it you might consider OFBIZ-6359 ;) > Make layered-window available in forms > -- > > Key: OFBIZ-6327 > URL: https://issues.apache.org/jira/browse/OFBIZ-6327 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Jacques Le Roux >Assignee: Nicolas Malin > Fix For: Trunk > > > I don't see a need for menus, but could be. Relates also to OFBIZ-6034 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Possible Documentation and help solutions - DITA
Hi Taher Thanks for the response. I think that working through your action list would be a really good move so am happy to work on it. I think we'll need to take this discussion off the mailing list as it is because we will need to share files (such as the ones that dont work etc) so I will create a Jira to manage it. (The Jira updates will be posted back here anyway!) Thanks Sharan -- View this message in context: http://ofbiz.135035.n4.nabble.com/Possible-Documentation-and-help-solutions-DITA-tp4669377p4669487.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
[jira] [Commented] (OFBIZ-6432) Fully translate OFBiz to Arabic
[ https://issues.apache.org/jira/browse/OFBIZ-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574230#comment-14574230 ] Taher Alkhateeb commented on OFBIZ-6432: Enough time has passed and Jacques already cleaned up duplicates he discovered in the commits. Now given that no one is running around with their hair on fire, I am assuming everything went smoothly and therefore closing this JIRA. > Fully translate OFBiz to Arabic > --- > > Key: OFBIZ-6432 > URL: https://issues.apache.org/jira/browse/OFBIZ-6432 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: arabic, internationalization, language, xml > Fix For: Upcoming Branch > > Attachments: accounting_translation.patch, > multi-component-translation.patch > > > I have a massive amount of translation all throughout the framework. Given > that this will be a large amount of work it deserves its own JIRA. > I currently have translations to commit to these components: > - base > - service > - widget > - accounting > - content > - order > - party > - workeffort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6432) Fully translate OFBiz to Arabic
[ https://issues.apache.org/jira/browse/OFBIZ-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-6432. -- Resolution: Fixed Feature implemented and OFBiz is now translated to Arabic in most of the framework and core applications > Fully translate OFBiz to Arabic > --- > > Key: OFBIZ-6432 > URL: https://issues.apache.org/jira/browse/OFBIZ-6432 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: arabic, internationalization, language, xml > Fix For: Upcoming Branch > > Attachments: accounting_translation.patch, > multi-component-translation.patch > > > I have a massive amount of translation all throughout the framework. Given > that this will be a large amount of work it deserves its own JIRA. > I currently have translations to commit to these components: > - base > - service > - widget > - accounting > - content > - order > - party > - workeffort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6432) Fully translate OFBiz to Arabic
[ https://issues.apache.org/jira/browse/OFBIZ-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574253#comment-14574253 ] Jacques Le Roux commented on OFBIZ-6432: According to Label Manager on trunk demo I'd not say it's fully translated (no languages is) ;) Total labels count: 15437 Existing labels in locale: 6043 Missing labels in locale: 9394 Still 40% is already quite an achievement, especially if the mostly used are done, anyway kudos! BTW I will create a page in wiki with the stats for all currently covered languages :) > Fully translate OFBiz to Arabic > --- > > Key: OFBIZ-6432 > URL: https://issues.apache.org/jira/browse/OFBIZ-6432 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: arabic, internationalization, language, xml > Fix For: Upcoming Branch > > Attachments: accounting_translation.patch, > multi-component-translation.patch > > > I have a massive amount of translation all throughout the framework. Given > that this will be a large amount of work it deserves its own JIRA. > I currently have translations to commit to these components: > - base > - service > - widget > - accounting > - content > - order > - party > - workeffort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6450) Investigate and Fix Docbook Issues
Sharan Foga created OFBIZ-6450: -- Summary: Investigate and Fix Docbook Issues Key: OFBIZ-6450 URL: https://issues.apache.org/jira/browse/OFBIZ-6450 Project: OFBiz Issue Type: Bug Reporter: Sharan Foga -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6450) Docbook and OFBIz Online Help
[ https://issues.apache.org/jira/browse/OFBIZ-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-6450: --- Description: Jira created based on the steps suggested by Taher as follows: - First, we attempt to fix whatever is wrong in DocBook at the moment. If you can share exactly what you spotted then this would save us a lot of time in trying to dig to the problem. So a repeat process to identify the bugs from you would be great. - Second, we decide on a category structure for the sections of the documentation if we do not like the existing one - We also introduce or enforce a workflow that mandates an update of the documentation on each JIRA that affects functionality that requires documentation. For example, if we add or modify a screen in the party component, then we must provide the documentation for that screen before closing the JIRA for example. - As a last step we decide on the appropriate technology to move forward. Summary: Docbook and OFBIz Online Help (was: Investigate and Fix Docbook Issues ) > Docbook and OFBIz Online Help > - > > Key: OFBIZ-6450 > URL: https://issues.apache.org/jira/browse/OFBIZ-6450 > Project: OFBiz > Issue Type: Bug >Reporter: Sharan Foga > > Jira created based on the steps suggested by Taher as follows: > - First, we attempt to fix whatever is wrong in DocBook at the moment. If you > can share exactly what you spotted then this would save us a lot of time in > trying to dig to the problem. So a repeat process to identify the bugs from > you would be great. > - Second, we decide on a category structure for the sections of the > documentation if we do not like the existing one > - We also introduce or enforce a workflow that mandates an update of the > documentation on each JIRA that affects functionality that requires > documentation. For example, if we add or modify a screen in the party > component, then we must provide the documentation for that screen before > closing the JIRA for example. > - As a last step we decide on the appropriate technology to move forward. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6451) Create a wiki page with percentage for translated langues
Jacques Le Roux created OFBIZ-6451: -- Summary: Create a wiki page with percentage for translated langues Key: OFBIZ-6451 URL: https://issues.apache.org/jira/browse/OFBIZ-6451 Project: OFBiz Issue Type: Task Components: ALL COMPONENTS Reporter: Jacques Le Roux Priority: Trivial Just a reminder for myself to complete the page at https://cwiki.apache.org/confluence/display/OFBIZ/Information+on+translated+languages+in+OFBiz -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6432) Fully translate OFBiz to Arabic
[ https://issues.apache.org/jira/browse/OFBIZ-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574253#comment-14574253 ] Jacques Le Roux edited comment on OFBIZ-6432 at 6/5/15 11:04 AM: - According to Label Manager on trunk demo I'd not say it's fully translated (no language is) ;) Total labels count: 15437 Existing labels in locale: 6043 Missing labels in locale: 9394 Still 40% is already quite an achievement, especially if the mostly used are done, anyway kudos! BTW I will create a page in wiki with the stats for all currently covered languages :) was (Author: jacques.le.roux): According to Label Manager on trunk demo I'd not say it's fully translated (no languages is) ;) Total labels count: 15437 Existing labels in locale: 6043 Missing labels in locale: 9394 Still 40% is already quite an achievement, especially if the mostly used are done, anyway kudos! BTW I will create a page in wiki with the stats for all currently covered languages :) > Fully translate OFBiz to Arabic > --- > > Key: OFBIZ-6432 > URL: https://issues.apache.org/jira/browse/OFBIZ-6432 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: arabic, internationalization, language, xml > Fix For: Upcoming Branch > > Attachments: accounting_translation.patch, > multi-component-translation.patch > > > I have a massive amount of translation all throughout the framework. Given > that this will be a large amount of work it deserves its own JIRA. > I currently have translations to commit to these components: > - base > - service > - widget > - accounting > - content > - order > - party > - workeffort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6452) Bad Lookup Field
Gavin Mabie created OFBIZ-6452: -- Summary: Bad Lookup Field Key: OFBIZ-6452 URL: https://issues.apache.org/jira/browse/OFBIZ-6452 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Affects Versions: Bootstrap theme Reporter: Gavin Mabie Assignee: Gavin Mabie Lookup buttons in forms not displaying properly. This is linked to css in legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gavin Mabie updated OFBIZ-5840: --- Attachment: lookupField_patch.patch Comment out .fieldLookup a selector in legacy.css which causes bad lookup field. > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Java 8 and functional programming in trunk
Hi All,
What is the proper process to move to JDK 8? I have a patch ready to move to
JDK 8 and fix an issue which we describe below. Should we create a JIRA or
request a vote or what exactly?
While debugging I discovered a bug that was failing the tests when moving from
JDK 7 to JDK 8 which has to do with the implementation of a HashMap.
Essentially the HashMap in JDK 8 does not care for the insertion order while it
does in JDK 7 (see below). A simple fix is to replace HashMap with
LinkedHashMap. Now all the tests run in JDK 8.
Taher Alkhateeb
debug outcome
substitutionPatternMap.entrySet() under JDK 7 in the test
testConvertOperatorSubstitutions (last assert test)
{&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
substitutionPatternMap.entrySet() under JDK 8 in the test
testConvertOperatorSubstitutions (last assert test)
{&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
- Original Message -
From: "Taher Alkhateeb"
To: dev@ofbiz.apache.org
Sent: Monday, 25 May, 2015 8:08:25 AM
Subject: Re: Java 8 and functional programming in trunk
Hello everyone,
Okay, so it seems there is consensus on going ahead with Java 8. I tried
testing this patch which I believe upgrades OFBiz to JDK 8.
Running "./ant clean-all build load-demo run-tests" delivers a failure in
"testConvertOperatorSubstitutions" (base tests). The error message is shown
below . So the line giving the error is exactly this one in
org.ofbiz.base.util.test.StringUtilTests
assertEquals("all converions", "one && two || three > four >= five < six <=
seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt
four @gteq five @lt six @lteq seven"));
This is weird. I checked JDK 7 and JDK 8 implementations and I think they are
identical in the matcher API. Yet when switching to JDK 8 the matcher evaluates
on "@gt" of the "@qteq " pattern and so you end up with ">eq" instead of ">=" .
This is without even applying the above patch.
I hope I am not running on a wild goose chase and ignoring something simple or
silly? Any Ideas?
error log start
all converions expected:<...wo || three > four >[=] five < six <= seven> but
was:<...wo || three > four >[eq] five < six <= seven>
junit.framework.ComparisonFailure: all converions expected:<...wo || three >
four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five < six
<= seven>
at
org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at
org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
at org.ofbiz.base.start.Start.start(Start.java:434)
at org.ofbiz.base.start.Start.main(Start.java:135)
error log end
Taher Alkhateeb
- Original Message -
From: "Ron Wheeler"
To: dev@ofbiz.apache.org
Sent: Thursday, 7 May, 2015 8:12:20 PM
Subject: Re: Java 8 and functional programming in trunk
On 07/05/2015 12:37 PM, Christian Geisert wrote:
> Well call it "Standards Office" or whatever, the guys who decide which
> platforms are allowed to use in the company.
Java 7 will be coming off the list in most companies if it has not
already been done.
>
> Java 8 is available since just about a year..
> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
> support for 5 years) has no Java 8 in the official repositories.
> Is there a Java 8 for AS/400 ;-)
http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
> Anyway, my point is that there should be good reasons to switch to Java
> 8 only.
>
> Christian
>
> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
>>> Yes, we must support Java 8, but we absolutely have the choice to still
>>> support Java 7 (i.e. no use of Java 8 only features yet)
>>>
>>> IMHO there should be good reasons to use these Java 8 features (not just
>>> because it's cool..)
>>>
>>> It's not a big deal to update a developer machine to Java 8 (well, my
>>> laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
>>> companies (old operating systems, get approvals from security office
>>> etc...)
>> Security officer is going to be insisting on an upgrade to Java 8
>> since Java 7 is no longer going to get security fixes.
>>
>> Have we heard of any OS that supports Java 7 but not Java 8?
>>
>> Ron
>>
>>> Christian
>>>
>>> Am 07.05.2015 15:40, schrieb Adam Heath:
Not a reply to Jacques, but if an absolutely java-8-only feature is
used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
the source/target values in common.xml in the same folder.
ps: I'm fine with moving towards 1.8. It's not a choice that we can
make, act
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574407#comment-14574407 ] Pierre Smits commented on OFBIZ-5840: - I believe it is better to add the patch to its own issue. Best regards, Pierre > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gavin Mabie updated OFBIZ-6452: --- Attachment: lookupField_patch.patch The patch > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574423#comment-14574423 ] Gavin Mabie commented on OFBIZ-5840: Done > Create bootstrap theme > -- > > Key: OFBIZ-5840 > URL: https://issues.apache.org/jira/browse/OFBIZ-5840 > Project: OFBiz > Issue Type: New Feature > Components: framework, themes >Affects Versions: Bootstrap theme >Reporter: Julien NICOLAS > Labels: bootstrap, theme > Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, > GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, > OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, > appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, > bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, > htmlMenuMacroLibrary.patch, lookupField_patch.patch, > pagination_htmlFormMacroLibrary.patch, > panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, > preferences.png, styling_issue_1.png, styling_issue_2.png, > styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, > styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, > styling_issue_9.png, tab-bar.png, workeffort.PNG > > > 1- create a sub-directory called bootstrap under the image webapp to put > the resources over there (js, css and fonts) as indicated earlier by Gavin. > (Julien : not sure about location) > 2- check to make sure that the current version of jQuery is compatible with > the installed version or upgrade it accordingly > 3- Create a new theme based on one of the existing themes as suggested by > Julien and Gavin > 4- Test the theme by switching to it and handle major bugs / issues. > 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6453) does not handle more than one of the same named
Christian Carlow created OFBIZ-6453:
---
Summary: does not handle more than one of the
same named
Key: OFBIZ-6453
URL: https://issues.apache.org/jira/browse/OFBIZ-6453
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow
Priority: Minor
Multi-dropdown widget fields cannot be set to multiple values using
because parameters with the same name get rendered as
whatever what last defined. For example:
{code}
{code}
gets rendered as
https://localhost:8443/ordermgr/control/FindRequest?externalLoginKey=EL632504860157&fromPartyId=Company&statusId=CRQ_SUBMITTED&custRequestTypeId=RF_QUOTE
A workaround is to define same named parameters in the target string but its
insufficient for other link-types like hidden-form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: References for DITA as a tool for on-line help
What tools are you using? Ron On 05/06/2015 4:38 AM, Taher Alkhateeb wrote: Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be nice and powerful. I'm beginning to do some of our own documentation on it. - Original Message - From: "Ron Wheeler" To: "dev" Sent: Thursday, 4 June, 2015 6:14:56 PM Subject: References for DITA as a tool for on-line help http://www.slideshare.net/abelsp/using-dita-for-online-help Slideshare has a lot of other presentations on DITA http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture Short with Hello World example http://en.wikipedia.org/wiki/Online_help Alternatives for producing on-line help - DocBooks and DITA considered together since they are closely related http://www.ditawriter.com/sample-dita-produced-output/ Has links to actual documents produced from DITA sources. https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf exhaustive article on ways to deliver help authored by DITA tools. It shows that an investment in DITA content will always be protected even if the OFBiz UI and help delivery technology changes. Table of Contents *Introduction to the DITA Help Best Practices Guide* *Developing DITA-based Help for Existing Help Environments* -Arbortext Digital Media Publisher -Eclipse Help -CSHelp Plug-in -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help -Eclipse Help -Leximation AIR Help Plug-in -Microsoft HTMLHelp -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In -The DITA Open Toolkit HTMLHelp Transform *Developing Custom DITA-based Help Systems** *-DHTML Effects in HTML Generated from DITA -DITA-OT Plug-ins -HTMLSearch Plug-in -TOCJS and TOCJSBIS Plug-ins -Dynamic Rendering of DITA into XHTML -JavaScript-Based Context Sensitive Help -WinANT Options Supporting HTML-Based Output -WinANT Options Supporting Microsoft® HTML Help *Developing DITA-based Help for Existing Help Authoring Tools** *-Converting DITA Content to WebHelp using RoboHelp® There are a lot more articles on using DITA content in On-line help. The same content is available for other uses. Ron -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
Re: References for DITA as a tool for on-line help
Hi Ron, DITA-OT ! :) Taher Alkhateeb - Original Message - From: "Ron Wheeler" To: dev@ofbiz.apache.org Sent: Friday, 5 June, 2015 4:13:39 PM Subject: Re: References for DITA as a tool for on-line help What tools are you using? Ron On 05/06/2015 4:38 AM, Taher Alkhateeb wrote: > Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be nice and > powerful. I'm beginning to do some of our own documentation on it. > > - Original Message - > > From: "Ron Wheeler" > To: "dev" > Sent: Thursday, 4 June, 2015 6:14:56 PM > Subject: References for DITA as a tool for on-line help > > http://www.slideshare.net/abelsp/using-dita-for-online-help > Slideshare has a lot of other presentations on DITA > > http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture > Short with Hello World example > > http://en.wikipedia.org/wiki/Online_help > Alternatives for producing on-line help - DocBooks and DITA considered > together since they are closely related > > http://www.ditawriter.com/sample-dita-produced-output/ Has links to > actual documents produced from DITA sources. > > https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf > > exhaustive article on ways to deliver help authored by DITA tools. It > shows that an investment in DITA content will always be protected even > if the OFBiz UI and help delivery technology changes. > > Table of Contents > *Introduction to the DITA Help Best Practices Guide* > > *Developing DITA-based Help for Existing Help Environments* > -Arbortext Digital Media Publisher > -Eclipse Help > -CSHelp Plug-in > -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help > -Eclipse Help > -Leximation AIR Help Plug-in > -Microsoft HTMLHelp > -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In > -The DITA Open Toolkit HTMLHelp Transform > > *Developing Custom DITA-based Help Systems** > *-DHTML Effects in HTML Generated from DITA > -DITA-OT Plug-ins > -HTMLSearch Plug-in > -TOCJS and TOCJSBIS Plug-ins > -Dynamic Rendering of DITA into XHTML > -JavaScript-Based Context Sensitive Help > -WinANT Options Supporting HTML-Based Output > -WinANT Options Supporting Microsoft® HTML Help > > *Developing DITA-based Help for Existing Help Authoring Tools** > *-Converting DITA Content to WebHelp using RoboHelp® > > There are a lot more articles on using DITA content in On-line help. > > The same content is available for other uses. > > Ron > -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
Re: References for DITA as a tool for on-line help
I use - Eclipse/STS for authoring http://blog.artifact-software.com/tech/?p=206 - Maven with DITA-OT for publishing in Eclipse - Subversion for SCM - Bugzilla for issue tracking This is all integrated into Eclipse. Ron On 05/06/2015 9:15 AM, Taher Alkhateeb wrote: Hi Ron, DITA-OT ! :) Taher Alkhateeb - Original Message - From: "Ron Wheeler" To: dev@ofbiz.apache.org Sent: Friday, 5 June, 2015 4:13:39 PM Subject: Re: References for DITA as a tool for on-line help What tools are you using? Ron On 05/06/2015 4:38 AM, Taher Alkhateeb wrote: Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be nice and powerful. I'm beginning to do some of our own documentation on it. - Original Message - From: "Ron Wheeler" To: "dev" Sent: Thursday, 4 June, 2015 6:14:56 PM Subject: References for DITA as a tool for on-line help http://www.slideshare.net/abelsp/using-dita-for-online-help Slideshare has a lot of other presentations on DITA http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture Short with Hello World example http://en.wikipedia.org/wiki/Online_help Alternatives for producing on-line help - DocBooks and DITA considered together since they are closely related http://www.ditawriter.com/sample-dita-produced-output/ Has links to actual documents produced from DITA sources. https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf exhaustive article on ways to deliver help authored by DITA tools. It shows that an investment in DITA content will always be protected even if the OFBiz UI and help delivery technology changes. Table of Contents *Introduction to the DITA Help Best Practices Guide* *Developing DITA-based Help for Existing Help Environments* -Arbortext Digital Media Publisher -Eclipse Help -CSHelp Plug-in -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help -Eclipse Help -Leximation AIR Help Plug-in -Microsoft HTMLHelp -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In -The DITA Open Toolkit HTMLHelp Transform *Developing Custom DITA-based Help Systems** *-DHTML Effects in HTML Generated from DITA -DITA-OT Plug-ins -HTMLSearch Plug-in -TOCJS and TOCJSBIS Plug-ins -Dynamic Rendering of DITA into XHTML -JavaScript-Based Context Sensitive Help -WinANT Options Supporting HTML-Based Output -WinANT Options Supporting Microsoft® HTML Help *Developing DITA-based Help for Existing Help Authoring Tools** *-Converting DITA Content to WebHelp using RoboHelp® There are a lot more articles on using DITA content in On-line help. The same content is available for other uses. Ron -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
Re: References for DITA as a tool for on-line help
Have you done a lot of branding and customizing the output from DITA-OT? I have not done anything yet but I will need to do this to make a nice looking manual. I want to do a bit of branding and I need to change the fonts in my code examples since most don't fit the width of the blocks and the font and colors are not very attractive in my opinion. Ron On 05/06/2015 9:15 AM, Taher Alkhateeb wrote: Hi Ron, DITA-OT ! :) Taher Alkhateeb - Original Message - From: "Ron Wheeler" To: dev@ofbiz.apache.org Sent: Friday, 5 June, 2015 4:13:39 PM Subject: Re: References for DITA as a tool for on-line help What tools are you using? Ron On 05/06/2015 4:38 AM, Taher Alkhateeb wrote: Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be nice and powerful. I'm beginning to do some of our own documentation on it. - Original Message - From: "Ron Wheeler" To: "dev" Sent: Thursday, 4 June, 2015 6:14:56 PM Subject: References for DITA as a tool for on-line help http://www.slideshare.net/abelsp/using-dita-for-online-help Slideshare has a lot of other presentations on DITA http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture Short with Hello World example http://en.wikipedia.org/wiki/Online_help Alternatives for producing on-line help - DocBooks and DITA considered together since they are closely related http://www.ditawriter.com/sample-dita-produced-output/ Has links to actual documents produced from DITA sources. https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf exhaustive article on ways to deliver help authored by DITA tools. It shows that an investment in DITA content will always be protected even if the OFBiz UI and help delivery technology changes. Table of Contents *Introduction to the DITA Help Best Practices Guide* *Developing DITA-based Help for Existing Help Environments* -Arbortext Digital Media Publisher -Eclipse Help -CSHelp Plug-in -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help -Eclipse Help -Leximation AIR Help Plug-in -Microsoft HTMLHelp -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In -The DITA Open Toolkit HTMLHelp Transform *Developing Custom DITA-based Help Systems** *-DHTML Effects in HTML Generated from DITA -DITA-OT Plug-ins -HTMLSearch Plug-in -TOCJS and TOCJSBIS Plug-ins -Dynamic Rendering of DITA into XHTML -JavaScript-Based Context Sensitive Help -WinANT Options Supporting HTML-Based Output -WinANT Options Supporting Microsoft® HTML Help *Developing DITA-based Help for Existing Help Authoring Tools** *-Converting DITA Content to WebHelp using RoboHelp® There are a lot more articles on using DITA content in On-line help. The same content is available for other uses. Ron -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
[jira] [Created] (OFBIZ-6454) Label manager generates an error when searching for unused labels
Pierre Smits created OFBIZ-6454:
---
Summary: Label manager generates an error when searching for
unused labels
Key: OFBIZ-6454
URL: https://issues.apache.org/jira/browse/OFBIZ-6454
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
When searching for unused labels in a component the function returns following
error:
{code}
org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
[component://webtools/widget/LabelManagerScreens.xml#SearchLabels]:
java.lang.IllegalArgumentException: Error running script at location
[component://webtools/webapp/webtools/WEB-INF/actions/labelmanager/LabelManager.groovy]:
org.xml.sax.SAXParseException; lineNumber: 58; columnNumber: 103; Attribute
"title" was already specified for element "field". (Error running script at
location
[component://webtools/webapp/webtools/WEB-INF/actions/labelmanager/LabelManager.groovy]:
org.xml.sax.SAXParseException; lineNumber: 58; columnNumber: 103; Attribute
"title" was already specified for element "field".)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6454) Label manager generates an error when searching for unused labels
[
https://issues.apache.org/jira/browse/OFBIZ-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-6454:
Attachment: Screen Shot 2015-06-05 at 15.41.49.png
This screenshot shows what I gave as parameters.
> Label manager generates an error when searching for unused labels
> -
>
> Key: OFBIZ-6454
> URL: https://issues.apache.org/jira/browse/OFBIZ-6454
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Attachments: Screen Shot 2015-06-05 at 15.41.49.png
>
>
> When searching for unused labels in a component the function returns
> following error:
> {code}
> org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen
> [component://webtools/widget/LabelManagerScreens.xml#SearchLabels]:
> java.lang.IllegalArgumentException: Error running script at location
> [component://webtools/webapp/webtools/WEB-INF/actions/labelmanager/LabelManager.groovy]:
> org.xml.sax.SAXParseException; lineNumber: 58; columnNumber: 103; Attribute
> "title" was already specified for element "field". (Error running script at
> location
> [component://webtools/webapp/webtools/WEB-INF/actions/labelmanager/LabelManager.groovy]:
> org.xml.sax.SAXParseException; lineNumber: 58; columnNumber: 103; Attribute
> "title" was already specified for element "field".)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574506#comment-14574506 ] Jacques Le Roux commented on OFBIZ-6452: No impacts on all other themes? > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Commented] (OFBIZ-6452) Bad Lookup Field
Nope. Other themes don't use legacy.css. On 05 Jun 2015 3:51 PM, "Jacques Le Roux (JIRA)" wrote: > > [ > https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574506#comment-14574506 > ] > > Jacques Le Roux commented on OFBIZ-6452: > > > No impacts on all other themes? > > > Bad Lookup Field > > > > > > Key: OFBIZ-6452 > > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > > Project: OFBiz > > Issue Type: Sub-task > > Components: ALL APPLICATIONS > >Affects Versions: Bootstrap theme > >Reporter: Gavin Mabie > >Assignee: Gavin Mabie > > Attachments: lookupField_patch.patch > > > > > > Lookup buttons in forms not displaying properly. This is linked to css > in legacy.css. Comment out .field-lookup a selector line 2112 > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
[jira] [Created] (OFBIZ-6455) Bootstrap modal for lookup screens
Gavin Mabie created OFBIZ-6455: -- Summary: Bootstrap modal for lookup screens Key: OFBIZ-6455 URL: https://issues.apache.org/jira/browse/OFBIZ-6455 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Affects Versions: Bootstrap theme Reporter: Gavin Mabie Assignee: Gavin Mabie Change code in htmlFormMacroLibrary.ftl, specifically the renderLookupField macro to fire a bootstrap modal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574520#comment-14574520 ] Pierre Smits commented on OFBIZ-6452: - This is bootstrap theme related. > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6456) Make sort by field type by default
Christian Carlow created OFBIZ-6456: --- Summary: Make sort by field type by default Key: OFBIZ-6456 URL: https://issues.apache.org/jira/browse/OFBIZ-6456 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow IMO, form widgets are generally easier to interpret when the field types are sorted by type but this has to be done manually using . I propose improving auto-fields-entity to sort fields by type by default such as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574534#comment-14574534 ] Christian Carlow edited comment on OFBIZ-6456 at 6/5/15 2:12 PM: - Once this is implemented I would like to apply at at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. was (Author: ofbizzer): Once this is implemented I would like to test apply at at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[
https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574538#comment-14574538
]
Jacques Le Roux commented on OFBIZ-6452:
OK Gavin replied directly on dev ML
{quote}
Nope. Other themes don't use legacy.css.
{quote}
> Bad Lookup Field
>
>
> Key: OFBIZ-6452
> URL: https://issues.apache.org/jira/browse/OFBIZ-6452
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Bootstrap theme
>Reporter: Gavin Mabie
>Assignee: Gavin Mabie
> Attachments: lookupField_patch.patch
>
>
> Lookup buttons in forms not displaying properly. This is linked to css in
> legacy.css. Comment out .field-lookup a selector line 2112
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: References for DITA as a tool for on-line help
I have found another great reference for planning a DITA project in order to maximize the possibilities for reuse. http://www.stilo.com/article-dita-reuse-conversion-together/ It is useful reading if you want reverse engineer some ideas about where the big benefits will come from DITA. For example, it talks about creating a "warehouse for conrefs" where is recommends writing fragments "conrefs" that are included by name. It suggests that these should be used for * GUI objects, fields, buttons, icons * Frequently used steps, with step results and info * All your notes and warnings * Pre-requisites that are commonly mentioned, like having administrative privileges * Boilerplate - legal, copyright, notices, When you think about each of these as a multilingual fragment that can be called in by referencing a key, you can see that this a) reduces translation - translate the key once and every place it is referenced has the translation done b) improves consistency c) makes customization a lot simpler - if you have changed a field label or button label, you only have to change the conref once and it is changed in your documentation. There is also a discussion on using keys. If we define variables such as version numbers, it makes it easier to ensure that versions (Java, Tomcat, OFBiz, etc.) are consistent everywhere with a single variable to change. If URLs are keys, you only have to change one key when a web page or file moves. Keys can also be used to select or exclude content which will make it easier for System Integrators to prepare manuals related to different configurations - include or exclude e-commerce, control industry specific content, etc. It has specific ideas about how to plan and execute a conversion. Ron - Original Message - From: "Ron Wheeler" To: "dev" Sent: Thursday, 4 June, 2015 6:14:56 PM Subject: References for DITA as a tool for on-line help http://www.slideshare.net/abelsp/using-dita-for-online-help Slideshare has a lot of other presentations on DITA http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture Short with Hello World example http://en.wikipedia.org/wiki/Online_help Alternatives for producing on-line help - DocBooks and DITA considered together since they are closely related http://www.ditawriter.com/sample-dita-produced-output/ Has links to actual documents produced from DITA sources. https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf exhaustive article on ways to deliver help authored by DITA tools. It shows that an investment in DITA content will always be protected even if the OFBiz UI and help delivery technology changes. Table of Contents *Introduction to the DITA Help Best Practices Guide* *Developing DITA-based Help for Existing Help Environments* -Arbortext Digital Media Publisher -Eclipse Help -CSHelp Plug-in -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help -Eclipse Help -Leximation AIR Help Plug-in -Microsoft HTMLHelp -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In -The DITA Open Toolkit HTMLHelp Transform *Developing Custom DITA-based Help Systems** *-DHTML Effects in HTML Generated from DITA -DITA-OT Plug-ins -HTMLSearch Plug-in -TOCJS and TOCJSBIS Plug-ins -Dynamic Rendering of DITA into XHTML -JavaScript-Based Context Sensitive Help -WinANT Options Supporting HTML-Based Output -WinANT Options Supporting Microsoft® HTML Help *Developing DITA-based Help for Existing Help Authoring Tools** *-Converting DITA Content to WebHelp using RoboHelp® There are a lot more articles on using DITA content in On-line help. The same content is available for other uses. Ron -- Ron Wheeler President Artifact Software Inc email: rwhee...@artifact-software.com skype: ronaldmwheeler phone: 866-970-2435, ext 102
[jira] [Comment Edited] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574534#comment-14574534 ] Christian Carlow edited comment on OFBIZ-6456 at 6/5/15 2:13 PM: - Once this is implemented I would like to apply at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. was (Author: ofbizzer): Once this is implemented I would like to apply at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Commented] (OFBIZ-6452) Bad Lookup Field
Keep focused in the Jira issue please ;) I added your comment there Thanks Jacques Le 05/06/2015 15:52, Gavin Mabie a écrit : Nope. Other themes don't use legacy.css.
Re: [jira] [Commented] (OFBIZ-6452) Bad Lookup Field
Still it won't break other themes because each theme loads it's own theme resources. I'm not too clued up with merging practices, but since the other themes do not use a legaccy.css file it should not present a problem. On 05 Jun 2015 4:12 PM, "Jacques Le Roux (JIRA)" wrote: > > [ > https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574533#comment-14574533 > ] > > Jacques Le Roux commented on OFBIZ-6452: > > > OK, but in case of merge later... > > > Bad Lookup Field > > > > > > Key: OFBIZ-6452 > > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > > Project: OFBiz > > Issue Type: Sub-task > > Components: ALL APPLICATIONS > >Affects Versions: Bootstrap theme > >Reporter: Gavin Mabie > >Assignee: Gavin Mabie > > Attachments: lookupField_patch.patch > > > > > > Lookup buttons in forms not displaying properly. This is linked to css > in legacy.css. Comment out .field-lookup a selector line 2112 > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574533#comment-14574533 ] Jacques Le Roux commented on OFBIZ-6452: OK, but in case of merge later... > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574534#comment-14574534 ] Christian Carlow edited comment on OFBIZ-6456 at 6/5/15 2:12 PM: - Once this is implemented I would like to apply at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. was (Author: ofbizzer): Once this is implemented I would like to apply at at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574534#comment-14574534 ] Christian Carlow commented on OFBIZ-6456: - Once this is implemented I would like to test apply at at ordermgr/control/FindRequest for cleaning up the find form which is fairly difficult to interpret as of right now. If it works there it will make find forms faster to deploy only requiring and special find controls like , to be defined. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574543#comment-14574543 ] Gavin Mabie commented on OFBIZ-6452: Sorry about responding on the mailing list - will add future comments here. > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574544#comment-14574544 ] Gavin Mabie commented on OFBIZ-6452: Still it won't break other themes because each theme loads it's own theme resources. I'm not too clued up with merging practices, but since the other themes do not use a legaccy.css file it should not present a problem. > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6457) Label Manager: Have totals show at the top of list too
Pierre Smits created OFBIZ-6457: --- Summary: Label Manager: Have totals show at the top of list too Key: OFBIZ-6457 URL: https://issues.apache.org/jira/browse/OFBIZ-6457 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Currently the totals are only shown at the bottom of the overview. With long lists this will take quit some scrolling. Having the totals at the top also would provide a better user experience. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6452) Bad Lookup Field
[ https://issues.apache.org/jira/browse/OFBIZ-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574635#comment-14574635 ] Jacques Le Roux commented on OFBIZ-6452: Yes sure, no worries > Bad Lookup Field > > > Key: OFBIZ-6452 > URL: https://issues.apache.org/jira/browse/OFBIZ-6452 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Bootstrap theme >Reporter: Gavin Mabie >Assignee: Gavin Mabie > Attachments: lookupField_patch.patch > > > Lookup buttons in forms not displaying properly. This is linked to css in > legacy.css. Comment out .field-lookup a selector line 2112 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot success in ASF Buildbot on ofbiz-trunk
The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/926 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' triggered this build Build Source Stamp: [branch ofbiz/trunk] 1683749 Blamelist: jleroux Build succeeded! Sincerely, -The Buildbot
Re: References for DITA as a tool for on-line help
Hi Ron, You are way ahead of me. I'm still taking baby steps. It's a good solution though. On Jun 5, 2015 4:34 PM, "Ron Wheeler" wrote: > Have you done a lot of branding and customizing the output from DITA-OT? > > I have not done anything yet but I will need to do this to make a nice > looking manual. > I want to do a bit of branding and I need to change the fonts in my code > examples since most don't fit the width of the blocks and the font and > colors are not very attractive in my opinion. > > Ron > > On 05/06/2015 9:15 AM, Taher Alkhateeb wrote: > >> Hi Ron, >> >> DITA-OT ! :) >> >> Taher Alkhateeb >> >> - Original Message - >> >> From: "Ron Wheeler" >> To: dev@ofbiz.apache.org >> Sent: Friday, 5 June, 2015 4:13:39 PM >> Subject: Re: References for DITA as a tool for on-line help >> >> What tools are you using? >> >> Ron >> >> On 05/06/2015 4:38 AM, Taher Alkhateeb wrote: >> >>> Great resources Ron. Thank you for sharing. FYI I find DITA-OT to be >>> nice and powerful. I'm beginning to do some of our own documentation on it. >>> >>> - Original Message - >>> >>> From: "Ron Wheeler" >>> To: "dev" >>> Sent: Thursday, 4 June, 2015 6:14:56 PM >>> Subject: References for DITA as a tool for on-line help >>> >>> http://www.slideshare.net/abelsp/using-dita-for-online-help >>> Slideshare has a lot of other presentations on DITA >>> >>> http://en.wikipedia.org/wiki/Darwin_Information_Typing_Architecture >>> Short with Hello World example >>> >>> http://en.wikipedia.org/wiki/Online_help >>> Alternatives for producing on-line help - DocBooks and DITA considered >>> together since they are closely related >>> >>> http://www.ditawriter.com/sample-dita-produced-output/ Has links to >>> actual documents produced from DITA sources. >>> >>> >>> https://www.oasis-open.org/committees/download.php/30122/DHSC_BestPractices_November20_rdr.pdf >>> exhaustive article on ways to deliver help authored by DITA tools. It >>> shows that an investment in DITA content will always be protected even >>> if the OFBiz UI and help delivery technology changes. >>> >>> Table of Contents >>> *Introduction to the DITA Help Best Practices Guide* >>> >>> *Developing DITA-based Help for Existing Help Environments* >>> -Arbortext Digital Media Publisher >>> -Eclipse Help >>> -CSHelp Plug-in >>> -Eclipse_CSH Plug-in for Dynamic Context-Sensitive Help >>> -Eclipse Help >>> -Leximation AIR Help Plug-in >>> -Microsoft HTMLHelp >>> -Context-Sensitive Help using the Enhanced HTML (htmlhelp2) Plug-In >>> -The DITA Open Toolkit HTMLHelp Transform >>> >>> *Developing Custom DITA-based Help Systems** >>> *-DHTML Effects in HTML Generated from DITA >>> -DITA-OT Plug-ins >>> -HTMLSearch Plug-in >>> -TOCJS and TOCJSBIS Plug-ins >>> -Dynamic Rendering of DITA into XHTML >>> -JavaScript-Based Context Sensitive Help >>> -WinANT Options Supporting HTML-Based Output >>> -WinANT Options Supporting Microsoft® HTML Help >>> >>> *Developing DITA-based Help for Existing Help Authoring Tools** >>> *-Converting DITA Content to WebHelp using RoboHelp® >>> >>> There are a lot more articles on using DITA content in On-line help. >>> >>> The same content is available for other uses. >>> >>> Ron >>> >>> >> > > -- > Ron Wheeler > President > Artifact Software Inc > email: rwhee...@artifact-software.com > skype: ronaldmwheeler > phone: 866-970-2435, ext 102 > >
Re: svn commit: r1683642 - in /ofbiz/trunk/framework/widget: dtd/widget-common.xsd src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java templates/htmlFormMacroLibrary.ftl
Le 05/06/2015 09:10, Jacques Le Roux a écrit : Le 05/06/2015 08:23, Nicolas Malin a écrit : Le 05/06/2015 08:18, Jacopo Cappellato a écrit : Hi Nicolas, if I am not wrong when we modify the attributes set by MacroFormRenderer we need to modify the macros in all the *FormMacroLibrary.ftl, even if some of them don't need and can actually ignore the passed-in values. Yes right Jacopo. I saw yesterday that some macro aren't synchronized. I planned to check all on one pass. In a recent effort at r1671756 and r1680921 at least (maybe also another commit) I completed missing parameters, I could have missed some though Jacques I confirm Jacques, on 1683720 I have some macro difference between csv htm fo xml and text. I will try to synchronize Nicolas
Re: Java 8 and functional programming in trunk
I would recommend committing each fix separately, then log the revision
numbers in a single Jira issue.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/5/2015 5:11 AM, Taher Alkhateeb wrote:
Hi All,
What is the proper process to move to JDK 8? I have a patch ready to move to
JDK 8 and fix an issue which we describe below. Should we create a JIRA or
request a vote or what exactly?
While debugging I discovered a bug that was failing the tests when moving from
JDK 7 to JDK 8 which has to do with the implementation of a HashMap.
Essentially the HashMap in JDK 8 does not care for the insertion order while it
does in JDK 7 (see below). A simple fix is to replace HashMap with
LinkedHashMap. Now all the tests run in JDK 8.
Taher Alkhateeb
debug outcome
substitutionPatternMap.entrySet() under JDK 7 in the test
testConvertOperatorSubstitutions (last assert test)
{&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
substitutionPatternMap.entrySet() under JDK 8 in the test
testConvertOperatorSubstitutions (last assert test)
{&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
- Original Message -
From: "Taher Alkhateeb"
To: dev@ofbiz.apache.org
Sent: Monday, 25 May, 2015 8:08:25 AM
Subject: Re: Java 8 and functional programming in trunk
Hello everyone,
Okay, so it seems there is consensus on going ahead with Java 8. I tried
testing this patch which I believe upgrades OFBiz to JDK 8.
Running "./ant clean-all build load-demo run-tests" delivers a failure in
"testConvertOperatorSubstitutions" (base tests). The error message is shown below . So
the line giving the error is exactly this one in org.ofbiz.base.util.test.StringUtilTests
assertEquals("all converions", "one && two || three > four >= five < six <= seven",
StringUtil.convertOperatorSubstitutions("one @and two @or three @gt four @gteq five @lt six @lteq seven"));
This is weird. I checked JDK 7 and JDK 8 implementations and I think they are identical in the matcher API. Yet when
switching to JDK 8 the matcher evaluates on "@gt" of the "@qteq " pattern and so you end up with
">eq" instead of ">=" . This is without even applying the above patch.
I hope I am not running on a wild goose chase and ignoring something simple or
silly? Any Ideas?
error log start
all converions expected:<...wo || three > four >[=] five < six <= seven> but was:<...wo ||
three > four >[eq] five < six <= seven>
junit.framework.ComparisonFailure: all converions expected:<...wo || three > four >[=] five < six <=
seven> but was:<...wo || three > four >[eq] five < six <= seven>
at
org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at
org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
at org.ofbiz.base.start.Start.start(Start.java:434)
at org.ofbiz.base.start.Start.main(Start.java:135)
error log end
Taher Alkhateeb
- Original Message -
From: "Ron Wheeler"
To: dev@ofbiz.apache.org
Sent: Thursday, 7 May, 2015 8:12:20 PM
Subject: Re: Java 8 and functional programming in trunk
On 07/05/2015 12:37 PM, Christian Geisert wrote:
Well call it "Standards Office" or whatever, the guys who decide which
platforms are allowed to use in the company.
Java 7 will be coming off the list in most companies if it has not
already been done.
Java 8 is available since just about a year..
Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
support for 5 years) has no Java 8 in the official repositories.
Is there a Java 8 for AS/400 ;-)
http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
Anyway, my point is that there should be good reasons to switch to Java
8 only.
Christian
Am 07.05.2015 17:58, schrieb Ron Wheeler:
On 07/05/2015 11:32 AM, Christian Geisert wrote:
Yes, we must support Java 8, but we absolutely have the choice to still
support Java 7 (i.e. no use of Java 8 only features yet)
IMHO there should be good reasons to use these Java 8 features (not just
because it's cool..)
It's not a big deal to update a developer machine to Java 8 (well, my
laptop still runs Kubuntu 12.04 ..) but it's another thing in (big)
companies (old operating systems, get approvals from security office
etc...)
Security officer is going to be insisting on an upgrade to Java 8
since Java 7 is no longer going to get security fixes.
Have we heard of any OS that supports Java 7 but not Java 8?
Ron
Christian
Am 07.05.2015 15:40, schrieb Adam Heath:
Not a reply to Jacques, but if an absolutely java-8-only feature is
used, be sure to update the regex in ${ofbiz.home}/macros.xml, then
the source/target values in common.xml in the same folder.
ps: I'm fine with moving towards 1.8. It's not a choice that w
[jira] [Closed] (OFBIZ-6451) Create a wiki page with percentage for translated langues
[ https://issues.apache.org/jira/browse/OFBIZ-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6451. -- Resolution: Done Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Done, now we will need to maintain it, should not be too hard > Create a wiki page with percentage for translated langues > - > > Key: OFBIZ-6451 > URL: https://issues.apache.org/jira/browse/OFBIZ-6451 > Project: OFBiz > Issue Type: Task > Components: ALL COMPONENTS >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Just a reminder for myself to complete the page at > https://cwiki.apache.org/confluence/display/OFBIZ/Information+on+translated+languages+in+OFBiz -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6451) Create a wiki page with percentage for translated langues
[ https://issues.apache.org/jira/browse/OFBIZ-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574766#comment-14574766 ] Jacques Le Roux edited comment on OFBIZ-6451 at 6/5/15 4:21 PM: Done with the help of Pierre Smits, now we will need to maintain it, should not be too hard was (Author: jacques.le.roux): Done, now we will need to maintain it, should not be too hard > Create a wiki page with percentage for translated langues > - > > Key: OFBIZ-6451 > URL: https://issues.apache.org/jira/browse/OFBIZ-6451 > Project: OFBiz > Issue Type: Task > Components: ALL COMPONENTS >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Just a reminder for myself to complete the page at > https://cwiki.apache.org/confluence/display/OFBIZ/Information+on+translated+languages+in+OFBiz -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6444) Postal Address PDF Formatter Screen Problems
[ https://issues.apache.org/jira/browse/OFBIZ-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574813#comment-14574813 ] Jacques Le Roux commented on OFBIZ-6444: The patch sounds good, I'd have appreciated an URL or steps to reproduce, thanks! > Postal Address PDF Formatter Screen Problems > > > Key: OFBIZ-6444 > URL: https://issues.apache.org/jira/browse/OFBIZ-6444 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Trunk >Reporter: Forrest Rae > Attachments: OFBIZ-6444.patch > > > A couple updates are needed to the postalAddressPdfFormatter screen: > First, the screen template is set to use the HTML renderer which results in > this error in the log: > [java] 2015-06-03 13:44:53,400 |0.0.0.0-8009-exec-13 |ModelScreenWidget > |W| In platform-dependent could not find template for xsl-fo, using the > one for html. > Second, the various PostalAddress.fo.ftl files do not escape XML > properly, and addresses with an & in them end up causing a FreeMarker > template error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
Taher Alkhateeb created OFBIZ-6458: -- Summary: Upgrade OFBiz to Java JDK 8 Key: OFBIZ-6458 URL: https://issues.apache.org/jira/browse/OFBIZ-6458 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Priority: Critical Fix For: Upcoming Branch The following will be tracked through this JIRA: - upgrade the framework to JDK 8 and fix any errors - make sure that ./ant clean-all load-demo run-tests will run after the upgrade - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-6458: --- Attachment: OFBIZ-6458-03-update-to-jdk8.patch OFBIZ-6458-02-fix-eclipse-compiler.patch OFBIZ-6458-01-fix-test-errors.patch Provided are three patches to be applied in order: - the first patch fixes problems with a test not working with JDK 8 - the second patch fixes a problem with compilation error in eclipse only, it works okay in javac but not in eclipse ejc - the third patch actually upgrades OFBiz to jdk 8 > Upgrade OFBiz to Java JDK 8 > --- > > Key: OFBIZ-6458 > URL: https://issues.apache.org/jira/browse/OFBIZ-6458 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Priority: Critical > Labels: java, jdk, jdk8, upgrade > Fix For: Upcoming Branch > > Attachments: OFBIZ-6458-01-fix-test-errors.patch, > OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch > > > The following will be tracked through this JIRA: > - upgrade the framework to JDK 8 and fix any errors > - make sure that ./ant clean-all load-demo run-tests will run after the > upgrade > - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Java 8 and functional programming in trunk
Hi Adrian and everyone,
I have created JIRA OFBIZ-6458 which contains all the patches needed to upgrade
to JDK 8. I do not want to commit because infrastructure is not upgraded. Any
guidance on what to do next is appreciated.
Taher Alkhateeb
- Original Message -
From: "Adrian Crum"
To: dev@ofbiz.apache.org
Sent: Friday, 5 June, 2015 6:48:50 PM
Subject: Re: Java 8 and functional programming in trunk
I would recommend committing each fix separately, then log the revision
numbers in a single Jira issue.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/5/2015 5:11 AM, Taher Alkhateeb wrote:
> Hi All,
>
> What is the proper process to move to JDK 8? I have a patch ready to move to
> JDK 8 and fix an issue which we describe below. Should we create a JIRA or
> request a vote or what exactly?
>
> While debugging I discovered a bug that was failing the tests when moving
> from JDK 7 to JDK 8 which has to do with the implementation of a HashMap.
> Essentially the HashMap in JDK 8 does not care for the insertion order while
> it does in JDK 7 (see below). A simple fix is to replace HashMap with
> LinkedHashMap. Now all the tests run in JDK 8.
>
> Taher Alkhateeb
>
> debug outcome
> substitutionPatternMap.entrySet() under JDK 7 in the test
> testConvertOperatorSubstitutions (last assert test)
> {&&=@and, <==@lteq, ||=@or, >==@gteq, >=@gt, <=@lt}
>
> substitutionPatternMap.entrySet() under JDK 8 in the test
> testConvertOperatorSubstitutions (last assert test)
> {&&=@and, ||=@or, <==@lteq, <=@lt, >=@gt, >==@gteq}
>
> - Original Message -
>
> From: "Taher Alkhateeb"
> To: dev@ofbiz.apache.org
> Sent: Monday, 25 May, 2015 8:08:25 AM
> Subject: Re: Java 8 and functional programming in trunk
>
>
> Hello everyone,
>
> Okay, so it seems there is consensus on going ahead with Java 8. I tried
> testing this patch which I believe upgrades OFBiz to JDK 8.
>
> Running "./ant clean-all build load-demo run-tests" delivers a failure in
> "testConvertOperatorSubstitutions" (base tests). The error message is shown
> below . So the line giving the error is exactly this one in
> org.ofbiz.base.util.test.StringUtilTests
>
> assertEquals("all converions", "one && two || three > four >= five < six <=
> seven", StringUtil.convertOperatorSubstitutions("one @and two @or three @gt
> four @gteq five @lt six @lteq seven"));
>
> This is weird. I checked JDK 7 and JDK 8 implementations and I think they are
> identical in the matcher API. Yet when switching to JDK 8 the matcher
> evaluates on "@gt" of the "@qteq " pattern and so you end up with ">eq"
> instead of ">=" . This is without even applying the above patch.
>
> I hope I am not running on a wild goose chase and ignoring something simple
> or silly? Any Ideas?
>
> error log start
> all converions expected:<...wo || three > four >[=] five < six <= seven> but
> was:<...wo || three > four >[eq] five < six <= seven>
>
> junit.framework.ComparisonFailure: all converions expected:<...wo || three >
> four >[=] five < six <= seven> but was:<...wo || three > four >[eq] five <
> six <= seven>
> at
> org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
>
> at
> org.ofbiz.base.util.test.StringUtilTests.testConvertOperatorSubstitutions(StringUtilTests.java:269)
>
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:408)
> at org.ofbiz.base.start.Start.start(Start.java:434)
> at org.ofbiz.base.start.Start.main(Start.java:135)
> error log end
>
> Taher Alkhateeb
>
>
> - Original Message -
>
> From: "Ron Wheeler"
> To: dev@ofbiz.apache.org
> Sent: Thursday, 7 May, 2015 8:12:20 PM
> Subject: Re: Java 8 and functional programming in trunk
>
> On 07/05/2015 12:37 PM, Christian Geisert wrote:
>> Well call it "Standards Office" or whatever, the guys who decide which
>> platforms are allowed to use in the company.
>
> Java 7 will be coming off the list in most companies if it has not
> already been done.
>
>>
>> Java 8 is available since just about a year..
>> Just the mentioned Ubuntu 12.04 LTS (= Longtime Support, which means
>> support for 5 years) has no Java 8 in the official repositories.
>> Is there a Java 8 for AS/400 ;-)
>
> http://tecadmin.net/install-oracle-java-8-jdk-8-ubuntu-via-ppa/
>
>> Anyway, my point is that there should be good reasons to switch to Java
>> 8 only.
>>
>> Christian
>>
>> Am 07.05.2015 17:58, schrieb Ron Wheeler:
>>> On 07/05/2015 11:32 AM, Christian Geisert wrote:
Yes, we must support Java 8, but we absolutely have the choice to still
support Java 7 (i.e. no use of Java 8 only features yet)
IMHO there should be good reasons to use these Java 8 features (not just
because
[jira] [Created] (OFBIZ-6459) ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for auto-fields-entity
Christian Carlow created OFBIZ-6459: --- Summary: ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for auto-fields-entity Key: OFBIZ-6459 URL: https://issues.apache.org/jira/browse/OFBIZ-6459 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Christian Carlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6460) select survey for product store cause exception
Wai created OFBIZ-6460: -- Summary: select survey for product store cause exception Key: OFBIZ-6460 URL: https://issues.apache.org/jira/browse/OFBIZ-6460 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Wai Using demo data -go to https://localhost:8443/catalog/control/EditProductStore?productStoreId=90101 -click on survey tab ...console output... 2015-06-05 13:56:07,551 |http-bio-8443-exec-7 |RequestHandler |I| Rendering View [EditProductStoreSurveys], sessionId=9B85D3D48AC8A8494125D9C3D64B8C3D.jvm1 2015-06-05 13:56:07,553 |http-bio-8443-exec-7 |ServiceDispatcher |T| Sync service [catalog/getUserPreferenceGroup] finished in [1] milliseconds 2015-06-05 13:56:07,580 |http-bio-8443-exec-7 |ServiceDispatcher |T| Sync service [catalog/getVisualThemeResources] finished in [26] milliseconds 2015-06-05 13:56:07,643 |http-bio-8443-exec-7 |ScreenFactory |I| Got 21 screens in 0.007s from: file:/zzz/ofbiz-trunk-wrk-restapi/applications/product/widget/catalog/StoreScreens.xml 2015-06-05 13:56:07,692 |http-bio-8443-exec-7 |ScriptUtil |W| Error running script at location [component://product/webapp/catalog/WEB-INF/actions/store/EditProductStoreSurveys.groovy]: java.lang.IllegalArgumentException: Passed List had more than one value. java.lang.IllegalArgumentException: Passed List had more than one value. at org.ofbiz.entity.util.EntityUtil.getOnly(EntityUtil.java:107) ~[ofbiz-entity.jar:?] at org.ofbiz.entity.util.EntityQuery.queryOne(EntityQuery.java:417) ~[ofbiz-entity.jar:?] at org.ofbiz.entity.util.EntityQuery$queryOne$3.call(Unknown Source) ~[?:?] at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) ~[groovy-all-2.2.1.jar:2.2.1] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) ~[groovy-all-2.2.1.jar:2.2.1] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112) ~[groovy-all-2.2.1.jar:2.2.1] at EditProductStoreSurveys.run(EditProductStoreSurveys.groovy:35) ~[?:?] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574951#comment-14574951 ] Jacques Le Roux commented on OFBIZ-6458: Thanks Taher, I will take care of that :) > Upgrade OFBiz to Java JDK 8 > --- > > Key: OFBIZ-6458 > URL: https://issues.apache.org/jira/browse/OFBIZ-6458 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Jacques Le Roux >Priority: Critical > Labels: java, jdk, jdk8, upgrade > Fix For: Upcoming Branch > > Attachments: OFBIZ-6458-01-fix-test-errors.patch, > OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch > > > The following will be tracked through this JIRA: > - upgrade the framework to JDK 8 and fix any errors > - make sure that ./ant clean-all load-demo run-tests will run after the > upgrade > - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-6458: -- Assignee: Jacques Le Roux > Upgrade OFBiz to Java JDK 8 > --- > > Key: OFBIZ-6458 > URL: https://issues.apache.org/jira/browse/OFBIZ-6458 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Jacques Le Roux >Priority: Critical > Labels: java, jdk, jdk8, upgrade > Fix For: Upcoming Branch > > Attachments: OFBIZ-6458-01-fix-test-errors.patch, > OFBIZ-6458-02-fix-eclipse-compiler.patch, OFBIZ-6458-03-update-to-jdk8.patch > > > The following will be tracked through this JIRA: > - upgrade the framework to JDK 8 and fix any errors > - make sure that ./ant clean-all load-demo run-tests will run after the > upgrade > - upgrade the infrastructure and demo server to accommodate the new change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6459) ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for auto-fields-entity
[ https://issues.apache.org/jira/browse/OFBIZ-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6459: Attachment: OFBIZ-6459.patch > ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect > FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for > auto-fields-entity > - > > Key: OFBIZ-6459 > URL: https://issues.apache.org/jira/browse/OFBIZ-6459 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6459.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6459) ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for auto-fields-entity
[ https://issues.apache.org/jira/browse/OFBIZ-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow closed OFBIZ-6459. --- Resolution: Implemented Fix Version/s: Upcoming Branch Fixed in: trunk r1683832 > ModelFormFieldBuilder.induceFieldInfoFromEntityField() incorrect > FieldInfo.fieldType of TEXT (3) instead of RANGEQBE (15) for > auto-fields-entity > - > > Key: OFBIZ-6459 > URL: https://issues.apache.org/jira/browse/OFBIZ-6459 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Fix For: Upcoming Branch > > Attachments: OFBIZ-6459.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6456: Attachment: OFBIZ-6456_2.patch This patch renders fields in the following default sort order: display, lookup, text, date, range, dropdown, check, radio, then everything else Display fields are also ordered by the following modelField.type: id fields, name fields, date fields, indicator and other text, special fields like email and blob, fixed-point type fields, and finally currency types. To test the functionality visit ordermgr/control/FindRequest and you'll see a much cleaner find form. Removing the position attributes from the form fields makes the form appear even cleaner. I feel like this functionality could really streamline the creation of find/list forms and provide consistency for users when interpreting forms. I will wait for community review and feedback before attempting to commit. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6456_2.patch > > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6461) Resynchronise template macro form xml, text, csv and fo from html
Nicolas Malin created OFBIZ-6461: Summary: Resynchronise template macro form xml, text, csv and fo from html Key: OFBIZ-6461 URL: https://issues.apache.org/jira/browse/OFBIZ-6461 Project: OFBiz Issue Type: Task Affects Versions: Trunk Reporter: Nicolas Malin Assignee: Nicolas Malin Priority: Minor The MacroFormTemplate for render language xml, csv, text and fo aren't the same than html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6461) Resynchronise template macro form xml, text, csv and fo from html
[ https://issues.apache.org/jira/browse/OFBIZ-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-6461: - Attachment: OFBIZ-6461.patch I finish the macro synchronization but I don't realize the area to validate all like webtools/control/WebtoolsLayoutDemo Maybe on the next step > Resynchronise template macro form xml, text, csv and fo from html > - > > Key: OFBIZ-6461 > URL: https://issues.apache.org/jira/browse/OFBIZ-6461 > Project: OFBiz > Issue Type: Task >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-6461.patch > > > The MacroFormTemplate for render language xml, csv, text and fo aren't the > same than html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1683642 - in /ofbiz/trunk/framework/widget: dtd/widget-common.xsd src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java templates/htmlFormMacroLibrary.ftl
I confirm Jacques, on 1683720 I have some macro difference between csv htm fo xml and text. I will try to synchronize Nicolas Jira open https://issues.apache.org/jira/browse/OFBIZ-6461 :) Nicolas
[jira] [Commented] (OFBIZ-6444) Postal Address PDF Formatter Screen Problems
[ https://issues.apache.org/jira/browse/OFBIZ-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575341#comment-14575341 ] Forrest Rae commented on OFBIZ-6444: Whoops, sorry. For number 1, just get a "Report" for a quote, and then look at your log file. For number 2, add an "General Coorespondence" address to a party that contains an ampersand, like "5th & Oak Street", create a quote for that Party, and then get the "Report" for that quote. > Postal Address PDF Formatter Screen Problems > > > Key: OFBIZ-6444 > URL: https://issues.apache.org/jira/browse/OFBIZ-6444 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 12.04, Release Branch 13.07, Release > Branch 14.12, Trunk >Reporter: Forrest Rae > Attachments: OFBIZ-6444.patch > > > A couple updates are needed to the postalAddressPdfFormatter screen: > First, the screen template is set to use the HTML renderer which results in > this error in the log: > [java] 2015-06-03 13:44:53,400 |0.0.0.0-8009-exec-13 |ModelScreenWidget > |W| In platform-dependent could not find template for xsl-fo, using the > one for html. > Second, the various PostalAddress.fo.ftl files do not escape XML > properly, and addresses with an & in them end up causing a FreeMarker > template error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6456: Attachment: (was: OFBIZ-6456_2.patch) > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6456) Make sort by field type by default
[ https://issues.apache.org/jira/browse/OFBIZ-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6456: Attachment: OFBIZ-6456_2.patch I'm resubmitting the patch so that the functionality only happens when an exists. This functionality would be better implemented by extending the framework so that the default sort for field types could be determined by xml rather than being hardcoded. An xml file needs to exist to map field types like currency-amount and currency-precise to the same default auto-fields-entity sort order. If this patch is approved then should also eventually be handled for its field types. > Make sort by field type by default > --- > > Key: OFBIZ-6456 > URL: https://issues.apache.org/jira/browse/OFBIZ-6456 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow > Attachments: OFBIZ-6456_2.patch > > > IMO, form widgets are generally easier to interpret when the field types are > sorted by type but this has to be done manually using . I > propose improving auto-fields-entity to sort fields by type by default such > as text, then dates, then numbers, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6460) select survey for product store cause exception
[ https://issues.apache.org/jira/browse/OFBIZ-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575420#comment-14575420 ] Pierre Smits commented on OFBIZ-6460: - The same happens in the OFBiz trunk Demo, see http://demo-trunk-ofbiz.apache.org/catalog/control/EditProductStoreSurveys?productStoreId=90101 > select survey for product store cause exception > --- > > Key: OFBIZ-6460 > URL: https://issues.apache.org/jira/browse/OFBIZ-6460 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Wai > > Using demo data > -go to > https://localhost:8443/catalog/control/EditProductStore?productStoreId=90101 > -click on survey tab > ...console output... > 2015-06-05 13:56:07,551 |http-bio-8443-exec-7 |RequestHandler > |I| Rendering View [EditProductStoreSurveys], > sessionId=9B85D3D48AC8A8494125D9C3D64B8C3D.jvm1 > 2015-06-05 13:56:07,553 |http-bio-8443-exec-7 |ServiceDispatcher > |T| Sync service [catalog/getUserPreferenceGroup] finished in [1] milliseconds > 2015-06-05 13:56:07,580 |http-bio-8443-exec-7 |ServiceDispatcher > |T| Sync service [catalog/getVisualThemeResources] finished in [26] > milliseconds > 2015-06-05 13:56:07,643 |http-bio-8443-exec-7 |ScreenFactory > |I| Got 21 screens in 0.007s from: > file:/zzz/ofbiz-trunk-wrk-restapi/applications/product/widget/catalog/StoreScreens.xml > 2015-06-05 13:56:07,692 |http-bio-8443-exec-7 |ScriptUtil > |W| Error running script at location > [component://product/webapp/catalog/WEB-INF/actions/store/EditProductStoreSurveys.groovy]: > java.lang.IllegalArgumentException: Passed List had more than one value. > java.lang.IllegalArgumentException: Passed List had more than one value. > at org.ofbiz.entity.util.EntityUtil.getOnly(EntityUtil.java:107) > ~[ofbiz-entity.jar:?] > at org.ofbiz.entity.util.EntityQuery.queryOne(EntityQuery.java:417) > ~[ofbiz-entity.jar:?] > at org.ofbiz.entity.util.EntityQuery$queryOne$3.call(Unknown Source) > ~[?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) > ~[groovy-all-2.2.1.jar:2.2.1] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) > ~[groovy-all-2.2.1.jar:2.2.1] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112) > ~[groovy-all-2.2.1.jar:2.2.1] > at EditProductStoreSurveys.run(EditProductStoreSurveys.groovy:35) ~[?:?] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6462) Redisign ordermgr/control/EditQuoteRole to resemble ordermgr/control/requestroles
Christian Carlow created OFBIZ-6462: --- Summary: Redisign ordermgr/control/EditQuoteRole to resemble ordermgr/control/requestroles Key: OFBIZ-6462 URL: https://issues.apache.org/jira/browse/OFBIZ-6462 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Christian Carlow Priority: Minor The quote role form requires the create button to unnecessarily be clicked before a new quote can be created and all roles are included in the dropdown rather than those only relevant for the quote. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
Christian Carlow created OFBIZ-6463: --- Summary: ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date Key: OFBIZ-6463 URL: https://issues.apache.org/jira/browse/OFBIZ-6463 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Christian Carlow Priority: Minor Users expect to be able to remove accidentally added faulty CustRequestParty but the current implementation only updates the through date when the delete button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6463: Attachment: OFBIZ-6463.patch This patch replaces order/request/CustRequestServices.xml#deleteCustRequestParty with so CustRequestParty will be removed rather than just the through date updated. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6464) Consolidate name and partyId field of order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles
Christian Carlow created OFBIZ-6464: --- Summary: Consolidate name and partyId field of order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles Key: OFBIZ-6464 URL: https://issues.apache.org/jira/browse/OFBIZ-6464 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Christian Carlow Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6464) Consolidate name and partyId field of order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles
[ https://issues.apache.org/jira/browse/OFBIZ-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6464: Attachment: OFBIZ-6464.patch > Consolidate name and partyId field of > order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles > - > > Key: OFBIZ-6464 > URL: https://issues.apache.org/jira/browse/OFBIZ-6464 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6464.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6464) Consolidate name and partyId field of order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles
[ https://issues.apache.org/jira/browse/OFBIZ-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow closed OFBIZ-6464. --- Resolution: Implemented Fix Version/s: Upcoming Branch Fixed in: trunk r1683879 > Consolidate name and partyId field of > order/widget/ordermgr/CustRequestForms.xml#ListRequestRoles > - > > Key: OFBIZ-6464 > URL: https://issues.apache.org/jira/browse/OFBIZ-6464 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6464.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6465) Replace submit button text with create text order/widget/ordermgr/CustRequestForms.xml#EditRequestRole
Christian Carlow created OFBIZ-6465: --- Summary: Replace submit button text with create text order/widget/ordermgr/CustRequestForms.xml#EditRequestRole Key: OFBIZ-6465 URL: https://issues.apache.org/jira/browse/OFBIZ-6465 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Christian Carlow Priority: Trivial EditRequestRole only allows for creations so having the button indicate that will likely improve user understanding. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6465) Replace submit button text with create text order/widget/ordermgr/CustRequestForms.xml#EditRequestRole
[ https://issues.apache.org/jira/browse/OFBIZ-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6465: Attachment: OFBIZ-6465.patch > Replace submit button text with create text > order/widget/ordermgr/CustRequestForms.xml#EditRequestRole > -- > > Key: OFBIZ-6465 > URL: https://issues.apache.org/jira/browse/OFBIZ-6465 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Trivial > Attachments: OFBIZ-6465.patch > > > EditRequestRole only allows for creations so having the button indicate that > will likely improve user understanding. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6465) Replace submit button text with create text order/widget/ordermgr/CustRequestForms.xml#EditRequestRole
[ https://issues.apache.org/jira/browse/OFBIZ-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow closed OFBIZ-6465. --- Resolution: Implemented Fix Version/s: Upcoming Branch Fixed in: trunk r1683880 > Replace submit button text with create text > order/widget/ordermgr/CustRequestForms.xml#EditRequestRole > -- > > Key: OFBIZ-6465 > URL: https://issues.apache.org/jira/browse/OFBIZ-6465 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: OFBIZ-6465.patch > > > EditRequestRole only allows for creations so having the button indicate that > will likely improve user understanding. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575544#comment-14575544 ] Adrian Crum commented on OFBIZ-6463: The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range a re expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575544#comment-14575544 ] Adrian Crum edited comment on OFBIZ-6463 at 6/6/15 3:11 AM: The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range are expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. was (Author: adri...@hlmksw.com): The attached patch breaks the design pattern that exists throughout the project. Intersection entities that include a date range a re expired, not deleted. Instead of replacing expiration with deletion, maybe deletion could be ADDED to expiration. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1457#comment-1457 ] Christian Carlow commented on OFBIZ-6463: - Thanks for the review Adrian. Expiration is still supported with the update button but I suppose that does require more clicks. Would an expire button to replace current delete button and having the delete actually delete the record be acceptable? This seems like it would be a little easier for users to understand. At the very least it seems the delete button text should be changed to "Expire". > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575559#comment-14575559 ] Adrian Crum commented on OFBIZ-6463: That would make more sense. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6463: Attachment: (was: OFBIZ-6463.patch) > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6463: Attachment: OFBIZ-6463.patch The patch keeps of deleteCustRequestPartyId provided in the previous patch and replaces old deleteCustRequestPartyId with a new expireCustRequestPartyId service that is executed with the new Expire button. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575577#comment-14575577 ] Paul Foxworthy commented on OFBIZ-6463: --- I agree with Adrian. Please don't remove "expire" behaviour. It's standard practice in OFBiz. Many of the "delete" services in fact expire an entity. Where both are really needed, there are two services, e.g.: deletePaymentGroupMember expirePaymentGroupMember I've linked a similar issue OFBIZ-5205 > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6463) ordermgr/control/deleteCustRequestParty should delete the record rather than updating the through date
[ https://issues.apache.org/jira/browse/OFBIZ-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575578#comment-14575578 ] Christian Carlow commented on OFBIZ-6463: - Thanks for the feedback Paul, the new patch follows yours and Adrian's suggested design. Quote roles will be handled similarly for OFBIZ-6462. > ordermgr/control/deleteCustRequestParty should delete the record rather than > updating the through date > -- > > Key: OFBIZ-6463 > URL: https://issues.apache.org/jira/browse/OFBIZ-6463 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Minor > Attachments: OFBIZ-6463.patch > > > Users expect to be able to remove accidentally added faulty CustRequestParty > but the current implementation only updates the through date when the delete > button is clicked. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Possible Documentation and help solutions - DITA
Sharan-F wrote > I'm a bit unclear about what you are suggesting. > > * Is it about replacing the Docbook implementation we currently have > within OFBiz with something else (e.g Asciidoc)? > * Is it about extracting the Docbook content from what we currently > have in OFBiz and then generating it into another format that we > could possibly re-introduce? > * Or is it something else? Hi Sharan, My suggestion is much more modest than that. I think there's no need to replace existing DocBook content, or to totally change the DocBook process we have. All I am suggesting is that people consider AsciiDoc as a first step when authoring help information. If they prefer to work with DocBook directly, fine. There are tools to transform AsciDoc into DocBook XML, such as AsciiDoctor (http://asciidoctor.org/), so in effect (correctly written) AsciiDoc *is* DocBook. I'll repeat the reasons why I like AsciiDoc. It's more human-readable than XML. You can write your documentation in any text editor. Both of these are important. In contrast, requiring XML and some more specialised tool is a barrier to entry, so less people could and would participate in documenting OFBiz. When I last looked into DITA quite a few years ago, it seemed to be a heavyweight thing that only made sense if you wanted multiple destinations and were willing to invest in proprietary tools like Framemaker, Oxygen or Arbortext. I am perfectly willing to believe that DITA is more "complete" than DocBook, and would allow "better" documentation, if only anyone was willing to invest the time, trouble and money to be able to use it. I'm pleased to hear there's now DITA support for Eclipse. Eclipse is not my favourite IDE, but I could be persuaded to use it. How much better would it be to say to potential contributors that they can use their favourite IDE or text editor, whatever that is? If everybody else loves DITA, I would work with it. But I worry that it will put many people off. Thanks Paul Foxworthy - -- Coherent Software Australia Pty Ltd http://www.coherentsoftware.com.au/ Bonsai ERP, the all-inclusive ERP system http://www.bonsaierp.com.au/ -- View this message in context: http://ofbiz.135035.n4.nabble.com/Possible-Documentation-and-help-solutions-DITA-tp4669377p4669576.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
Re: Possible Documentation and help solutions - DITA
Sharan-F wrote > Confluence is the Apache approved tools for wiki so we still need to work > within this constraint for now. In any case – I think we firstly need to > do some review of the all the documentation we have before we start > structuring it. Hi Sharan, There is a free tool to import DocBook into Confluence : https://marketplace.atlassian.com/plugins/org.jboss.labs.confluence.plugin.docbook_import There's also a commercial one to go in the other direction: https://www.k15t.com/software/scroll-docbook-exporter/overview . *If* we wanted to use the wiki as a place to develop help, we could ask the vendor if they were willing to donate their product to an open source project. Cheers Paul Foxworthy - -- Coherent Software Australia Pty Ltd http://www.coherentsoftware.com.au/ Bonsai ERP, the all-inclusive ERP system http://www.bonsaierp.com.au/ -- View this message in context: http://ofbiz.135035.n4.nabble.com/Possible-Documentation-and-help-solutions-DITA-tp4669377p4669577.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
