date:20160622


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7547:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Content' component
> -
>
> Key: OFBIZ-7547
> URL: https://issues.apache.org/jira/browse/OFBIZ-7547
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7546) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Accounting' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7546:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Accounting' component
> 
>
> Key: OFBIZ-7546
> URL: https://issues.apache.org/jira/browse/OFBIZ-7546
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7548) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'WorkEffort' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7548:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'WorkEffort' component
> 
>
> Key: OFBIZ-7548
> URL: https://issues.apache.org/jira/browse/OFBIZ-7548
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7550) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Project' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7550:

Component/s: (was: ALL COMPONENTS)
 specialpurpose/projectmgr

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Project' component
> -
>
> Key: OFBIZ-7550
> URL: https://issues.apache.org/jira/browse/OFBIZ-7550
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7549) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'HR' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7549:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'HR' component
> 
>
> Key: OFBIZ-7549
> URL: https://issues.apache.org/jira/browse/OFBIZ-7549
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7550) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Project' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7550:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Project' component
> -
>
> Key: OFBIZ-7550
> URL: https://issues.apache.org/jira/browse/OFBIZ-7550
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/projectmgr
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7546) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Accounting' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7546:

Component/s: (was: ALL COMPONENTS)
 accounting

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Accounting' component
> 
>
> Key: OFBIZ-7546
> URL: https://issues.apache.org/jira/browse/OFBIZ-7546
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7256) After adding child categories user should remain on the same page

2016-06-22 Thread Ashish Vijaywargiya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7256.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Ravi for the contribution. Your changes are committed in trunk at 
r1749741.

> After adding child categories user should remain on the same page
> -
>
> Key: OFBIZ-7256
> URL: https://issues.apache.org/jira/browse/OFBIZ-7256
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7256_trunk.patch
>
>
> Problem Area:
> 1) Go to Catalog -> Categories
> 2) Find any category and go to the rollup screen.
> 3) Add any child category rollup.
> 4) After adding child category rollup  user is redirected to the newly added 
> child category and displayed rollup of that category.
> This is the case with all the operation Add/Update/Delete. User should remain 
> on the rollup page of the category for which adding child category like when 
> performing Add/Update/Delete with parent category rollup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7259) Hide associated content related section when creating new Product/Category content

2016-06-22 Thread Ashish Vijaywargiya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7259.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Ravi for the contribution. Your patch is committed in trunk at r1749743

> Hide associated content related section when creating new Product/Category 
> content
> --
>
> Key: OFBIZ-7259
> URL: https://issues.apache.org/jira/browse/OFBIZ-7259
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7259_trunk.patch
>
>
> Area:
> 1) Go to Catalog -> Categories
> 2) Find a category and go to Content page.
> 3) Under "Add Product Category Content" section select a content type and go 
> to create new content.
> 4) In this screen last two section are dependent on the first block. So if we 
> are preparing new category content these section should of no use.
> Page shouldn't display "Associated Content Infos" and "Create Simple Text 
> Content For Alternate Locale" sections when creating new content. These 
> section should come only when using this page for editing content.
> Note: The same case when adding product content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7545) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Facility' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7545:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Facility' component
> --
>
> Key: OFBIZ-7545
> URL: https://issues.apache.org/jira/browse/OFBIZ-7545
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7332) Add Product lookup when associating product with location from Edit Facility Location page

2016-06-22 Thread Ashish Vijaywargiya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7332.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Ravi for the contribution. Your changes are committed in trunk at 
r1749739.

> Add Product lookup when associating product with location from Edit Facility 
> Location page
> --
>
> Key: OFBIZ-7332
> URL: https://issues.apache.org/jira/browse/OFBIZ-7332
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7332_trunk.patch
>
>
> Improvement Area:
> 1) Login to Facility component.
> 2) Select a facility and go to the locations page.
> 3) Go to Create/Edit a facility location.
> 4) See the bottom section which is used to associated product with locagtion
> Product lookup will be helpful for user to select product.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7534:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7545) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Facility' component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7545:

Component/s: (was: ALL COMPONENTS)
 product

> OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 
> 'Facility' component
> --
>
> Key: OFBIZ-7545
> URL: https://issues.apache.org/jira/browse/OFBIZ-7545
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7542) Convert search criteria on 'Status' into multi-select pattern on all search screens

Swapnil Shah created OFBIZ-7542:
---

 Summary: Convert search criteria on 'Status' into multi-select 
pattern on all search screens
 Key: OFBIZ-7542
 URL: https://issues.apache.org/jira/browse/OFBIZ-7542
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


There are many screens where search can be performed on on given status at a 
time as its shown in form of dropdown and user can select only one value from 
it.

Like Order list screen, we can try using this multi-select as generic search 
pattern starting with 'Status' and leveraging upon it for any other eligible 
search criteria. It should behave as follows:
# Selecting "All" (via checkbox) should auto-select all applicable statuses 
# De-selecting "All" should remove selection from all selected statuses
# After selecting "All" if any other status(es) are selected and "All" should 
be de-selected automatically
# Multiple statuses should be selectable simultaneously
# The search result should honor the selected statuses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7547) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Content' component

Swapnil Shah created OFBIZ-7547:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'Content' component
 Key: OFBIZ-7547
 URL: https://issues.apache.org/jira/browse/OFBIZ-7547
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7551) Enforce noninstantiability to SSLUtil class

2016-06-22 Thread Rishi Solanki (JIRA)

Rishi Solanki created OFBIZ-7551:


 Summary: Enforce noninstantiability to SSLUtil class
 Key: OFBIZ-7551
 URL: https://issues.apache.org/jira/browse/OFBIZ-7551
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Rishi Solanki
Priority: Minor


- Make class as final.
- Add a private constructor.
- Make the following public static variables as private
{code}
public static final int HOSTCERT_NO_CHECK = 0;
public static final int HOSTCERT_MIN_CHECK = 1;
public static final int HOSTCERT_NORMAL_CHECK = 2;
{code}
- Add getHostCertNoCheck(), getHostCertMinCheck() and getHostCertNormalCheck() 
public static methods and use them in following classes, Also check if any 
class remains;
{code}
HttpClient.java
URLConnector.java
AliasSupportedTransportFactory.java
WidgetMacroLibraryTests.java
OagisServices.java
{code}
- Move following static class at top and make it private.
{code}
static class TrustAnyManager implements X509TrustManager
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7513) alt-target tag is not working as expected in Form Widget

2016-06-22 Thread Montalbano Florian (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344502#comment-15344502
 ] 

Montalbano Florian commented on OFBIZ-7513:
---

Can't we just swap the two adding instructions ?
{code}
ModelForm.java (Line: 380-388)

ArrayList altTargets = new ArrayList();

for (Element altTargetElement : UtilXml.childElementList(formElement, 
"alt-target"))
{ altTargets.add(new AltTarget(altTargetElement)); }

if (parentModel != null)
{ altTargets.addAll(parentModel.altTargets); }

altTargets.trimToSize();
this.altTargets = Collections.unmodifiableList(altTargets);
{code}

Does someone know if something is added to the list when there is no child ?
And what should happen if there is multiple children for the same element ? (is 
that possible ?)

> alt-target tag is not working as expected in Form Widget
> 
>
> Key: OFBIZ-7513
> URL: https://issues.apache.org/jira/browse/OFBIZ-7513
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>
> While working on the issue OFBIZ-7252, I found one problem in Form Widgets. 
> When we use  attribute in child form, the system should consider 
> overridden  in child form. This is default expected behaviour. 
> But in this case, it is always considering the  of the parent 
> form.
> For example:
> 
>
>   
> 
>  
>   
> 
> In above example, expectation is 'executeChildTarget' target should get 
> executed but actually 'executeParentTarget' is getting executed.
> When we looked into framework level code of Form Widgets, we got the 
> following code snippets:
> ModelForm.java (Line: 380-388)
> ArrayList altTargets = new ArrayList();
> if (parentModel != null) {
> altTargets.addAll(parentModel.altTargets);
> }
> for (Element altTargetElement : UtilXml.childElementList(formElement, 
> "alt-target")) {
> altTargets.add(new AltTarget(altTargetElement));
> }
> altTargets.trimToSize();
> this.altTargets = Collections.unmodifiableList(altTargets);
> Here we can see that all alt-targets present in parent form are added to the 
> list first and then all alt-targets present in child form are added.
> This causes a problem as method getTarget() of ModelForm.java (Line: 
> 1352-1384) returns the first element in the list as alt-target.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344512#comment-15344512
 ] 

james yong commented on OFBIZ-7061:
---

Hi [~jacques.le.roux],

Was also looking at this issue. The "field" attribute is actually a tag 
directly under the schema tag in the xsd. Such kind of attribute needs to be 
prefixed in the xml. For example, from ExampleCompoundWidgets.xml, we have on 
line 117
{code}

{code} 
The 'level' attribute is also a direct tag under the schema tag in the xsd.

So the proposed change from
{code}
xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method 
http://ofbiz.apache.org/dtds/simple-methods.xsd;
{code}
to 
{code}
xsi:schemaLocation="http://ofbiz.apache.org/dtds/simple-methods.xsd;
{code}
circumvents the prefix requirement, but introduce another problem :(

I found that the proposed change will result in the default value not being 
recognised. For example, in 
{code}
...
{code}
the validate-method tag has a default value for the 'class' attribute. 
If we go to Party module and create a customer. The email field will fail after 
form submission because the default value for 'class' attribute is not found.

I see there are now 2 possible solutions:
1) Add the prefix to the affected attributes in the simple methods. But the 
change is great.
2) Revert the simple method to use the original schema without namespace



> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7543) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Order' component

Swapnil Shah created OFBIZ-7543:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'Order' component
 Key: OFBIZ-7543
 URL: https://issues.apache.org/jira/browse/OFBIZ-7543
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer the details provided on OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment


[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344395#comment-15344395
 ] 

Pierre Smits commented on OFBIZ-6899:
-

Bank name, routing Id and bank account no are not just notes. These are 
important attributes to get payments out. These are used in the outgoing pdf 
documents, like order, invoice, etc.

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7550) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Project' component

Swapnil Shah created OFBIZ-7550:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'Project' component
 Key: OFBIZ-7550
 URL: https://issues.apache.org/jira/browse/OFBIZ-7550
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS


For me, no problem to drop it.

Julien.

On 22/06/2016 16:23, Taher Alkhateeb wrote:

Hi Michael Jacques and everyone,

So I also want to confirm that you really need the following tasks:

- build-dev
- build-production
- build-qa
- build-test
- revert-dev

Are you using them yourselves? Here are the reasons why I suggest to remove
them:
- First, you must have the patch command existing in your environment, thus
making the build script brittle
- Second, it has this weird naming convention for patches and how they
should be applied. I would imagine that every team and every company has
its own style and methodology for patching and keeping track of files and
changes. They use their own version control system and even different kinds
of patches
- It is dependent on a specific format of diff which you must generate
either with svn diff or diff -Naur.

It seems like it does not make a lot of sense to keep something like that
when companies might completely ignore it and choose their own
implementation strategies. Do you agree? Feedback?

Taher Alkhateeb

On Wed, Jun 22, 2016 at 4:01 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


I wonder though why this was introduced. If we have no feedback from any
member of the community I think we can drop it. I don't see how to use it.

Jacques



Le 22/06/2016 à 14:43, Michael Brohl a écrit :


Hi Taher,

no, I don't use it myself. This was just a guess by looking what the task
does and it seemed to me this should be preserved.
No problem to drop it from my side.

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.06.16 um 14:37 schrieb Taher Alkhateeb:


Hi Michael,

Are you sure you are using "run-test-list"? This is an old task using a
target on the server called --testlist which essentially creates an ant
file of all the suites in OFBiz and runs them one-by-one stopping OFBiz
in
between each run.

To me it seems like run-tests is doing the same thing but faster. Is
this a
typo by you or are you actually using this target? The reason I ask is
because I actually wanted to delete the entire TestListContainer.java and
related files in the future. But now of course I hesitate.

Thanks in advance for your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl <
michael.br...@ecomify.de>
wrote:

Hi Taher,

First question:

Don't drop:

- build-dev
- build-production
- build-qa
- build-test
- refresh
- revert-dev
- run-test-list

Drop:

- clean-ivy (assuming this is not needed if we use Gradle)
- copy-dtds
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC (download tasks: assuming they are not needed if
we
use Gradle/automatic dependency mechanism)


Not sure (I don't use them):

- create-tenant
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- gen-kek
- gitinfo
- run-test-list
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure (...secure: not sure if these are needed anymore, I think
Jacques can give some hints about them)
- svninfo

Second question: +1

but I'm not sure about the load-tenant... tasks (I don't use them).


Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.16 um 22:09 schrieb Taher Alkhateeb:

Hi Everyone,

I have create the JIRA
https://issues.apache.org/jira/browse/OFBIZ-7534
for
this project

I have two questions in this thread

First Question
--
Can I drop the below tasks from the build system? They currently exist
in
Ant but I am not sure whether they are actively used or not. So if you
want
me to add any of these tasks please reply to this thread, otherwise I
will
not include them in gradle. Please note I added all multi tenant tasks
because many of them are broken or have no functionality, so I am
assuming
people are doing multi-tenancy manually but not sure, so please help!

- build-dev
- build-production
- build-qa
- build-test
- clean-ivy
- copy-dtds
- create-tenant
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC
- gen-kek
- gitinfo
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- refresh
- revert-dev
- run-test-list
- start-batch
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure
- svninfo

Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.

If you would like to add the other load data tasks, please specify
which
ones.

Appreciate your early responses.

Taher Alkhateeb

[jira] [Created] (OFBIZ-7552) Clean up of deprecated code or shows warnings

2016-06-22 Thread Harsh Vijaywargiya (JIRA)

Harsh Vijaywargiya created OFBIZ-7552:
-

 Summary: Clean up of deprecated code or shows warnings
 Key: OFBIZ-7552
 URL: https://issues.apache.org/jira/browse/OFBIZ-7552
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Harsh Vijaywargiya
Assignee: Harsh Vijaywargiya


In our Re-Factor To-Do List one of the item is to clean up the code with 
warnings. 
This is the parent ticket and I will further create sub tasks under it for the 
component which shows warning or use the deprecated code.
Essentially this is for Java code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7544) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Manufacturing' component

Swapnil Shah created OFBIZ-7544:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'Manufacturing' component
 Key: OFBIZ-7544
 URL: https://issues.apache.org/jira/browse/OFBIZ-7544
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment


[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344395#comment-15344395
 ] 

Pierre Smits edited comment on OFBIZ-6899 at 6/22/16 2:33 PM:
--

Bank name, routing Id and bank account no are not just notes. These are 
important attributes to get payments out and in. These are used in the outgoing 
pdf documents, like order, invoice, etc.


was (Author: pfm.smits):
Bank name, routing Id and bank account no are not just notes. These are 
important attributes to get payments out. These are used in the outgoing pdf 
documents, like order, invoice, etc.

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7546) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'Accounting' component

Swapnil Shah created OFBIZ-7546:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'Accounting' component
 Key: OFBIZ-7546
 URL: https://issues.apache.org/jira/browse/OFBIZ-7546
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7548) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'WorkEffort' component

Swapnil Shah created OFBIZ-7548:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'WorkEffort' component
 Key: OFBIZ-7548
 URL: https://issues.apache.org/jira/browse/OFBIZ-7548
 Project: OFBiz
  Issue Type: Sub-task
  Components: workeffort
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7549) OFBIZ-7542: Convert search criteria on 'Status' into multi-select pattern for 'HR' component

Swapnil Shah created OFBIZ-7549:
---

 Summary: OFBIZ-7542: Convert search criteria on 'Status' into 
multi-select pattern for 'HR' component
 Key: OFBIZ-7549
 URL: https://issues.apache.org/jira/browse/OFBIZ-7549
 Project: OFBiz
  Issue Type: Sub-task
  Components: humanres
Affects Versions: Upcoming Branch
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Please refer to details shared over OFBIZ-7542



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager


[ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343829#comment-15343829
 ] 

Nicolas Malin commented on OFBIZ-7518:
--

Hi Ankush,
On the other case, ensurePartyRole is call by seca. What advantage to define 
this chain call on a service group ? It seems less adaptive than seca call

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
> Attachments: EnsureAndCreateProductStoreRole.patch, 
> ProductStoreRoleError.png, RenderPartyAssignedRolesInDropDown.patch
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343818#comment-15343818
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Your solutions looks good to me that when we don't have price for variant then 
look for virtual product's price.  This pattern is mostly followed every where 
in OFBiz. I also reviewed your patch and I think you can use getParentProduct 
method of ProductWorker class to fetch virtual of variant product. Rest all 
looks good. 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual

Re: XML autocompletion issue


Hi All,

Fixed at revision: 1749634

We should not have used targetNamespace (should only be used in schema) instead 
of xsi:schemaLocation.

Jacques


Le 21/06/2016 à 22:53, Jacques Le Roux a écrit :

Hi,

I just noticed that we seem to have an issue with XML autocompletion in files concerned (used by the Compound Widget feature) since I committed 
today the last changes for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061


Before reverting anything I will tomorrow check why we have this issue

Thanks for your patience

Jacques

[jira] [Assigned] (OFBIZ-7535) Broken page renders while click on Submit button


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7535:
---

Assignee: Divesh Dutta

> Broken page renders while click on Submit button
> 
>
> Key: OFBIZ-7535
> URL: https://issues.apache.org/jira/browse/OFBIZ-7535
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Ankush Upadhyay
>Assignee: Divesh Dutta
>Priority: Minor
>
> Steps to reproduce:
> 1. Go to party manager.
> 2. Find party Company and navigate to Employment Application tab.
> 3. Now if there is no existing application and Submit button visible then 
> click on submit button.
> 4. Broken page renders with error message "
> :ERROR MESSAGE:
> org.ofbiz.webapp.event.EventHandlerException: No rows to process"
> Ideally system should hide submit button if there is no application to 
> process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343767#comment-15343767
 ] 

Jacques Le Roux commented on OFBIZ-7519:


Thanks for your comprehension Pranay :)

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343780#comment-15343780
 ] 

Jacques Le Roux commented on OFBIZ-7061:


Thanks James,

I did not spot it as well, we should indeed not have used targetNamespace 
(should only be used in schema) instead of xsi:schemaLocation. BTW all files 
were concerned, not only menu.

Fixed at r1749634.


> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-6576:
---

Assignee: Divesh Dutta

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID corresponds to 
>

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343832#comment-15343832
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are 
both taxes levied by tax authority on a sale. I guess we can remove the if and 
else statements in code for SALES_TAX or VAT_TAX.



Also I think Sales tax also be put on Purchase order, when you want to put 
approximate tax  which supplier will take from you. So I think  VAT and Sales 
tax does not differ . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now

[jira] [Closed] (OFBIZ-7526) View Quote screen is broken


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7526.
--
   Resolution: Fixed
 Assignee: Jacques Le Roux
Fix Version/s: Upcoming Branch

Well spotted Pritam,

Fixed at revision: 1749634 

> View Quote screen is broken
> ---
>
> Key: OFBIZ-7526
> URL: https://issues.apache.org/jira/browse/OFBIZ-7526
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: Upcoming Branch
>
>
> Steps to regenerate:
> 1) Login to ordermgr.
> 2) Click on Quotes and find quotes.
> 3) Click on any quote in the search result to go to the overview screen.
> You can see screen is broken with error:
> [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ObjectType  
>   |W| The specified type [] is not a valid class or a known special type, 
> may see more errors later because of this: 
>  [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 
> |AbstractModelCondition|W| Error with comparison in if-compare 
> between field [quote.statusId] with value [QUO_CREATED] and value 
> [QUO_CREATED] with operator [equals] and type []: Type "" specified for 
> compare not supported.
>  [java] 2016-06-21 18:46:33,073 |http-nio-8443-exec-4 |ModelScreen
>|E| Error rendering screen 
> [component://common/widget/CommonScreens.xml#GlobalDecorator]: 
> java.lang.IllegalArgumentException: Error with comparison in if-compare 
> between field [quote.statusId] with value [QUO_CREATED] and value 
> [QUO_CREATED] with operator [equals] and type []: Type "" specified for 
> compare not supported.. Rolling back transaction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item


[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343803#comment-15343803
 ] 

Pierre Smits commented on OFBIZ-7533:
-

The lot management solution in OFBiz is flawed. See 
https://issues.apache.org/jira/browse/OFBIZ-5704

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: II_LOT.png
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7536) Clean up commented out code

2016-06-22 Thread Harsh Vijaywargiya (JIRA)

Harsh Vijaywargiya created OFBIZ-7536:
-

 Summary: Clean up commented out code
 Key: OFBIZ-7536
 URL: https://issues.apache.org/jira/browse/OFBIZ-7536
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Harsh Vijaywargiya
Assignee: Harsh Vijaywargiya
 Fix For: Upcoming Branch


In our Re-Factor To-Do List one of the item is to clean up the commented out 
code. 
This is the parent ticket and I will further create sub tasks under it so that 
we do not push large change in one commit.
This includes Java, Xml, Groovy and FTL files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: (was: OFBIZ-6576.patch)

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID corresponds to 
> SII_CHL Party)
> - Tax Auth Geo Id:CHL
>

[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343993#comment-15343993
 ] 

Jacques Le Roux commented on OFBIZ-7073:


I was thinking at Multitenant, but obviously there is not good solution. 
Because the code is shared between the tenants. So I finally agree with your 
point. But your patch is not complete yet, the part in example is not in ;) And 
yes please a wiki page is welcome, also maybe an unit test?

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7536) Clean up commented out code


[ 
https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344081#comment-15344081
 ] 

Jacques Le Roux commented on OFBIZ-7536:


Yes, +1

> Clean up commented out code
> ---
>
> Key: OFBIZ-7536
> URL: https://issues.apache.org/jira/browse/OFBIZ-7536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
> Fix For: Upcoming Branch
>
>
> In our Re-Factor To-Do List one of the item is to clean up the commented out 
> code. 
> This is the parent ticket and I will further create sub tasks under it so 
> that we do not push large change in one commit.
> This includes Java, Xml, Groovy and FTL files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework


[ 
https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343805#comment-15343805
 ] 

Pierre Smits commented on OFBIZ-7529:
-

If that is part of the POS solution, it should move into the special purpose 
component.

> Delete stale java files from applications and framework
> ---
>
> Key: OFBIZ-7529
> URL: https://issues.apache.org/jira/browse/OFBIZ-7529
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Mridul Pathak
>
> As per the discussions on the thread - 
> http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html,
>  following files and their references needs to be deleted from applications 
> and framework,
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
> applications/content/src/org/ofbiz/content/report
> applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java
> applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java
> applications/product/src/ShipmentScaleApplet.java
> applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb

Hi Jacques,

How about we actually download all JDBC drivers automatically regardless of
the selected database. Their size is very small and it is worth making the
build script smaller no? And also anyway some people use different versions
of the database and have to change the driver version, in this case it
would be a much cleaner solution for them to go to the build script and
change the version (simple string) than to actually download the jar file
or modify the logic for the download tasks.

With that being said, thank you all for your input, I will draft the first
patch based on your feedback very soon. I will try to consolidate your
opinions as much as possible but may differ. So please take it lightly as
everything can be changed upon your request, I'm just trying to balance all
opinions and come up with something nice and clean.

Again, I really appreciate the support! I will update you soon.

On Wed, Jun 22, 2016 at 11:38 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 22/06/2016 à 10:05, Julien NICOLAS a écrit :
>
>>
>>
>> On 22/06/2016 09:53, Julien NICOLAS wrote:
>>
>>>
>>>
>>> On 21/06/2016 22:09, Taher Alkhateeb wrote:
>>>
 - download-PG-JDBC

>>> If it's possible, keep this one :)
>>>
>> Ok, I don't see the information of Michael that with Graddle, we don't
>> need a task for that because of the Graddle dependency functionality. So my
>> mistake, forgot it :)
>>
>
> I think you are right about this one and I believe we should keep all Ant
> JDBC driver download targets. Except if Gradle is able to infer that it
> would be possible in certain circumstances an user could need one of those
> drivers.
> This would need to parse entityengine.xml and I highly doubt this can be
> done w/o some human intervention. On the other hand if similar Gradle
> tasks  are introduced, then of course I'd not see any reasons to not drop
> them. Same for all Ant targets actually.
>
> Hope I'm clear enough :)
>
> Jacques
>
>
 Second Question
 ---

 it seems many of the load tasks are too specific. So I suggest to only
 implement loadDemo and the rest are executed manually by users, for
 example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
 instead of load-extseed.

>>> I think load-seed is important as well, so if you can keep the load-seed
>>> task, it could be fine.
>>>
>>> Thanks!
>>>
>>> Julien.
>>>

 If you would like to add the other load data tasks, please specify which
 ones.

 Appreciate your early responses.

 Taher Alkhateeb

 On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb <
 slidingfilame...@gmail.com

> wrote:
> Hi Everyone,
>
> Thank you all for your support and kinds words. This is truly a
> wonderful
> atmosphere and I am lucky, honoured, and privileged to work with you
> all on
> this project.
>
> My patch is almost done, but definitely there is a lot of work to be
> done
> which includes the following:
> - I have one failing test out of 889 that I need to dig through, maybe
> you
> guy can help
> - I want to change / delete / add some tasks
> - Documentation needs to be updated in multiple areas
> - Testing, testing, testing, testing, testing, testing, testing,
> testing,
> testing
>
> So the plan of action is as follows:
> - I will continue the discussion on this thread for a few questions
> that I
> need an answer for.
> - I will issue a JIRA to hold the patch and everything else
>
> Please consider helping, this is something that definitely needs a
> team,
> more than one brain! If you are working on something not urgent, please
> consider dropping it for a while and jump along for help.
>
> I will post another email soon with the JIRA details and list of
> questions
> I need answer for.
>
> Again, thank you, you guys rock, I love OFBiz and this community!
>
> Regards,
>
> Taher Alkhateeb
>
>
>
> On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin <
> nicolas.ma...@nereide.fr>
> wrote:
>
> I'm in over for these technical aspects but the motivation and
>> enthusiasm
>> for many PMC and commiter tells me that seems a good way.
>>
>> So now I will learn gradle ;) and I'm in favor to realize this change
>> directly on trunk
>>
>> Thks Taher to your engine energy on this subject !
>>
>> Nicolas
>>
>>
>>
>> Le 21/06/2016 10:43, Jacques Le Roux a écrit :
>>
>> As Gavin mentioned, Gradle can run Ant so no worries using only Gradle
>>>
>>> https://docs.gradle.org/current/userguide/ant.html
>>>
>>> Jacques
>>>
>>>
>>> Le 21/06/2016 à 09:59, Michael Brohl a écrit :
>>>
>>> I have no strong opinion for/against Gradle (I simply have no
 experience with it) but I agree that it

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342285#comment-15342285
 ] 

Jacques Le Roux edited comment on OFBIZ-6576 at 6/22/16 8:47 AM:
-

Issue is caused by the code further below in TaxAuthorityServices.java:
_
Since for a variant product the "productPrice" and "taxInPrice" is set only on 
the corresponding virtual product, the Else part of below code becomes active 
and does the following:
{code}
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
{code}
Therewith Sales tax is added later on to the Variant Product.
By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX" 
the issue seems to be resolved.
However this can only be a temporary fix.
{code}
 GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment");

if (productPrice != null && 
"Y".equals(productPrice.getString("taxInPrice"))) {
// tax is in the price already, so we want the adjustment 
to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment 
to be added
taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX");

// the amount will be different because we want to figure 
out how much of the price was tax, and not how much tax needs to be added
// the formula is: taxAmount = priceWithTax - 
(priceWithTax/(1+taxPercentage/100))
BigDecimal taxAmountIncluded = 
itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE,
 4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP));
taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded);
taxAdjValue.set("amount", BigDecimal.ZERO);
} else { 
  taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
  taxAdjValue.set("amount", taxAmount);
}
{code}




was (Author: peter arnold):
Issue is caused by the code further below in TaxAuthorityServices.java:
_
Since for a variant product the "productPrice" and "taxInPrice" is set only on 
the corresponding virtual product, the Else part of below code becomes active 
and does the following:
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
Therewith Sales tax is added later on to the Variant Product.
By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX" 
the issue seems to be resolved.
However this can only be a temporary fix.
___
Code:
___
 GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment");

if (productPrice != null && 
"Y".equals(productPrice.getString("taxInPrice"))) {
// tax is in the price already, so we want the adjustment 
to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment 
to be added
taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX");

// the amount will be different because we want to figure 
out how much of the price was tax, and not how much tax needs to be added
// the formula is: taxAmount = priceWithTax - 
(priceWithTax/(1+taxPercentage/100))
BigDecimal taxAmountIncluded = 
itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE,
 4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP));
taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded);
taxAdjValue.set("amount", BigDecimal.ZERO);
} else { 
  taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
  taxAdjValue.set("amount", taxAmount);
}




> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to

[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application


[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343992#comment-15343992
 ] 

Divesh Dutta commented on OFBIZ-7511:
-

[~jacques.le.roux]  this discussion has been concluded. There was confusion in 
actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg: 

{code}



 
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId 
is mandatory attribute of service. Now if you create same form then where you 
want to use tool tip in exampleFeatureId , 

{code}




 
{code}

In this case, you have overridden the exampleFeatureId field, but during 
overriding required property is lost. And to solve this problem, Deepak is 
recommending that when you override the field , then by default required 
property should be inherited from auto-fields service, so that developer does 
not have to explicitly define required-field=true . And we agreed on this 
proposal of Deepak . 

So we agreed on solution which maximally automates. Hope this helps to 
understand the problem area and solution concluded. 

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7537) Complete the documentation in the XSD files

Jacques Le Roux created OFBIZ-7537:
--

 Summary: Complete the documentation in the XSD files
 Key: OFBIZ-7537
 URL: https://issues.apache.org/jira/browse/OFBIZ-7537
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux


We have already some documentation in the XSD files, but we could clearly do 
better, and that's an important point to achieve a better adoption by new 
comers. And you know what? We need them ;)

Thanks to Paul Piper for a reminder on the subject :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item


[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343846#comment-15343846
 ] 

Swapnil Shah commented on OFBIZ-7533:
-

Thanks for sharing the reference [~pfm.smits]. I have tried to walk through the 
discussion but it seems there is still no conclusion made. But irrespective of 
fact what design approach we follow under OFBIZ-5704, i feel the feature for 
updating Lot id over an inventory item should still be working and hence we can 
possibly attempt to fix this ticket independently for now and later we have 
implementation detail concluded with regard to lot, Lot Id provision via 
inventory item could proved to be an add on.

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: II_LOT.png
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item


[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343846#comment-15343846
 ] 

Swapnil Shah edited comment on OFBIZ-7533 at 6/22/16 7:28 AM:
--

Thanks for sharing the reference [~pfm.smits]. I have tried to walk through the 
discussion but it seems there is still no conclusion made. So irrespective of 
fact what design approach we follow under OFBIZ-5704, i feel the feature for 
updating Lot id over an inventory item should still hold water and hence we can 
possibly attempt to fix this ticket independently for now and later we have 
implementation detail concluded with regard to lot, Lot Id provision via 
inventory item could proved to be an add on.


was (Author: swash78):
Thanks for sharing the reference [~pfm.smits]. I have tried to walk through the 
discussion but it seems there is still no conclusion made. But irrespective of 
fact what design approach we follow under OFBIZ-5704, i feel the feature for 
updating Lot id over an inventory item should still be working and hence we can 
possibly attempt to fix this ticket independently for now and later we have 
implementation detail concluded with regard to lot, Lot Id provision via 
inventory item could proved to be an add on.

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: II_LOT.png
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: OFBIZ-6576.patch

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch, OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or

[jira] [Assigned] (OFBIZ-7537) Complete the documentation in the XSD files


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7537:
---

Assignee: Divesh Dutta

> Complete the documentation in the XSD files
> ---
>
> Key: OFBIZ-7537
> URL: https://issues.apache.org/jira/browse/OFBIZ-7537
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>
> We have already some documentation in the XSD files, but we could clearly do 
> better, and that's an important point to achieve a better adoption by new 
> comers. And you know what? We need them ;)
> Thanks to Paul Piper for a reminder on the subject :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz

2016-06-22 Thread Amardeep Singh Jhajj (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344089#comment-15344089
 ] 

Amardeep Singh Jhajj commented on OFBIZ-7073:
-

Hi [~jacques.le.roux],

Here is the answers to your questions:

But your patch is not complete yet, the part in example is not in 
-- I have created child ticket for example-  OFBIZ-7467. Please refer it.

And yes please a wiki page is welcome
-- I will add wiki page. Here is the link of jira ticket for it - OFBIZ-7538

also maybe an unit test?
-- I love to add unit tests as well. I will wait for Taher to come up with some 
sample units tests in OFBiz, to understand the structure of writing it.


> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7533) Not able to set new Lot Id to existing inventory item


[ 
https://issues.apache.org/jira/browse/OFBIZ-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343846#comment-15343846
 ] 

Swapnil Shah edited comment on OFBIZ-7533 at 6/22/16 7:28 AM:
--

Thanks for sharing the reference [~pfm.smits]. I have tried to walk through the 
discussion but it seems there is still no conclusion made. So irrespective of 
fact what design approach we follow under OFBIZ-5704, i feel the feature for 
updating Lot id over an inventory item should still hold water and hence we can 
possibly attempt to fix this ticket independently for now and later once we 
have implementation detail concluded with regard to lot, Lot Id provision via 
inventory item could proved to be an add on.


was (Author: swash78):
Thanks for sharing the reference [~pfm.smits]. I have tried to walk through the 
discussion but it seems there is still no conclusion made. So irrespective of 
fact what design approach we follow under OFBIZ-5704, i feel the feature for 
updating Lot id over an inventory item should still hold water and hence we can 
possibly attempt to fix this ticket independently for now and later we have 
implementation detail concluded with regard to lot, Lot Id provision via 
inventory item could proved to be an add on.

> Not able to set new Lot Id to existing inventory item
> -
>
> Key: OFBIZ-7533
> URL: https://issues.apache.org/jira/browse/OFBIZ-7533
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: II_LOT.png
>
>
> When any new lot is assigned to exiting inventory item then it ends up 
> throwing foreign key constraint.
> We could allow it by creating first new lot (if its not found already 
> existent in DB) and then associate the same with given inventory item. (Also 
> currently i couldn't find any screen to create new lot in given facility)
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

Le 22/06/2016 à 10:05, Julien NICOLAS a écrit :

On 22/06/2016 09:53, Julien NICOLAS wrote:

On 21/06/2016 22:09, Taher Alkhateeb wrote:

- download-PG-JDBC

If it's possible, keep this one :)
Ok, I don't see the information of Michael that with Graddle, we don't need a task for that because of the Graddle dependency functionality. So my
mistake, forgot it :)

I think you are right about this one and I believe we should keep all Ant JDBC driver download targets. Except if Gradle is able to infer that it
would be possible in certain circumstances an user could need one of those drivers.
This would need to parse entityengine.xml and I highly doubt this can be done w/o some human intervention. On the other hand if similar Gradle tasks
are introduced, then of course I'd not see any reasons to not drop them. Same for all Ant targets actually.

Hope I'm clear enough :)

Jacques

Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.

I think load-seed is important as well, so if you can keep the load-seed task,
it could be fine.

Thanks!

Julien.

If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb

On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb
wrote:

I'm in over for these technical aspects but the motivation and enthusiasm
for many PMC and commiter tells me that seems a good way.

So now I will learn gradle ;) and I'm in favor to realize this change
directly on trunk

Thks Taher to your engine energy on this subject !

Nicolas

Le 21/06/2016 10:43, Jacques Le Roux a écrit :

As Gavin mentioned, Gradle can run Ant so no worries using only Gradle

https://docs.gradle.org/current/userguide/ant.html

Jacques

Le 21/06/2016 à 09:59, Michael Brohl a écrit :

I have no strong opinion for/against Gradle (I simply have no
experience with it) but I agree that it should be either Ant or Gradle.
Running two build tools in parallel would make it too complex an gain
nothing.

I'm in favor for learning new things so Gradle sounds fine for me :-)

Regards,

Michael

Am 21.06.16 um 08:11 schrieb Taher Alkhateeb:

Hi Deepak,

Ant would be removed completely for the following reasons:

- First to resolve the ASF issue about the libraries mentioned by
Sharan
below without expending effort on both build systems.
- Ant is an obstacle to refactoring the framework. If we keep both
systems
side by side we gain nothing, actually we lose value because the builds
become more complex. For example, we will not be able to intrduce the
unit
tests, and we will have two build outputs, and we will have two ways of
running the framework (java -jar ofbiz.jar and gradlew ofbiz) and we
will
have other incompatibility issues.

With that being said, we will not make the switch before a thorough and
full testing. That is why we ask everyone who is willing to please
help us
out to make this transition smooth by testing and providing feedback
and
comments.

Taher Alkhateeb

On Tuesday, 21 June 2016, Deepak Dixit > wrote:

Hi Everyone

This is the second of two emails to inform the community about what
has
been happening around how we are planning to handle external
dependencies
in the trunk. Two weeks ago the community

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343967#comment-15343967
 ] 

Jacques Le Roux commented on OFBIZ-6576:


Ah yes good point, too used to it :D

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever

[jira] [Created] (OFBIZ-7538) Add Wiki page for WebSocket usage

2016-06-22 Thread Amardeep Singh Jhajj (JIRA)

Amardeep Singh Jhajj created OFBIZ-7538:
---

 Summary: Add Wiki page for WebSocket usage
 Key: OFBIZ-7538
 URL: https://issues.apache.org/jira/browse/OFBIZ-7538
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Amardeep Singh Jhajj
Assignee: Amardeep Singh Jhajj






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343908#comment-15343908
 ] 

Ankush Upadhyay commented on OFBIZ-6576:


Thanks for the patch review and suggestion, I have updated patch with suggested 
improvements.

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343939#comment-15343939
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Thanks Ankush for the improvement. One more minor thing, we are already 
discussing in community about directly checking null or not null for 
GenericValue instead of using isNotEmpty method of GenericValue . So in this 
patch, please change it accordingly and then we should be good, 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6576:

Priority: Major  (was: Minor)

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID corresponds to 
> SII_CHL Party)
> - Tax

Re: Important Changes to Trunk and Use of Ant & Gradle

Taher,

Right, it was not a problem of space but licence. With the Gradle solution we no longer have licence issues with external jars, another good point to
this solution :)

Jacques

Le 22/06/2016 à 10:46, Taher Alkhateeb a écrit :

Hi Jacques,

How about we actually download all JDBC drivers automatically regardless of
the selected database. Their size is very small and it is worth making the
build script smaller no? And also anyway some people use different versions
of the database and have to change the driver version, in this case it
would be a much cleaner solution for them to go to the build script and
change the version (simple string) than to actually download the jar file
or modify the logic for the download tasks.

With that being said, thank you all for your input, I will draft the first
patch based on your feedback very soon. I will try to consolidate your
opinions as much as possible but may differ. So please take it lightly as
everything can be changed upon your request, I'm just trying to balance all
opinions and come up with something nice and clean.

Again, I really appreciate the support! I will update you soon.

On Wed, Jun 22, 2016 at 11:38 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Le 22/06/2016 à 10:05, Julien NICOLAS a écrit :

On 22/06/2016 09:53, Julien NICOLAS wrote:

On 21/06/2016 22:09, Taher Alkhateeb wrote:

- download-PG-JDBC

If it's possible, keep this one :)

Ok, I don't see the information of Michael that with Graddle, we don't
need a task for that because of the Graddle dependency functionality. So my
mistake, forgot it :)

I think you are right about this one and I believe we should keep all Ant
JDBC driver download targets. Except if Gradle is able to infer that it
would be possible in certain circumstances an user could need one of those
drivers.
This would need to parse entityengine.xml and I highly doubt this can be
done w/o some human intervention. On the other hand if similar Gradle
tasks are introduced, then of course I'd not see any reasons to not drop
them. Same for all Ant targets actually.

Hope I'm clear enough :)

Jacques

Second Question
---

I think load-seed is important as well, so if you can keep the load-seed
task, it could be fine.

Thanks!

Julien.

If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb

On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb <
slidingfilame...@gmail.com

wrote:
Hi Everyone,

Thank you all for your support and kinds words. This is truly a
wonderful
atmosphere and I am lucky, honoured, and privileged to work with you
all on
this project.

My patch is almost done, but definitely there is a lot of work to be
done
which includes the following:
- I have one failing test out of 889 that I need to dig through, maybe
you
guy can help
- I want to change / delete / add some tasks
- Documentation needs to be updated in multiple areas
- Testing, testing, testing, testing, testing, testing, testing,
testing,
testing

So the plan of action is as follows:
- I will continue the discussion on this thread for a few questions
that I
need an answer for.
- I will issue a JIRA to hold the patch and everything else

Please consider helping, this is something that definitely needs a
team,
more than one brain! If you are working on something not urgent, please
consider dropping it for a while and jump along for help.

I will post another email soon with the JIRA details and list of
questions
I need answer for.

Again, thank you, you guys rock, I love OFBiz and this community!

Regards,

Taher Alkhateeb

On Tue, Jun 21, 2016 at 12:49 PM, Nicolas Malin <
nicolas.ma...@nereide.fr>
wrote:

I'm in over for these technical aspects but the motivation and

enthusiasm
for many PMC and commiter tells me that seems a good way.

So now I will learn gradle ;) and I'm in favor to realize this change
directly on trunk

Thks Taher to your engine energy on this subject !

Nicolas

Le 21/06/2016 10:43, Jacques Le Roux a écrit :

As Gavin mentioned, Gradle can run Ant so no worries using only Gradle

https://docs.gradle.org/current/userguide/ant.html

Jacques

Le 21/06/2016 à 09:59, Michael Brohl a écrit :

I have no strong opinion for/against Gradle (I simply have no

experience with it) but I agree that it should be either Ant or
Gradle.
Running two build tools in parallel would make it too complex an
gain
nothing.

I'm in favor for learning new things so Gradle sounds fine for me
:-)

Regards,

Michael

Am 21.06.16 um 08:11 schrieb Taher Alkhateeb:

Hi Deepak,

Ant would be removed completely for the following reasons:

- First to resolve the ASF issue about the libraries mentioned by
Sharan

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's

2016-06-22 Thread Pranay Pandey (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344002#comment-15344002
 ] 

Pranay Pandey commented on OFBIZ-7519:
--

Hi Jacques,

Thanks for your comment. I don't think both of these are the same thing. The 
changes committed under this patch are to correct server side validations of 
input parameters to a service. [OFBIZ-7511] is talking about enhancement in 
Form-Widget to enforce right client side validation.

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7520) Minilang code readability and consistency improvements


[ 
https://issues.apache.org/jira/browse/OFBIZ-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344001#comment-15344001
 ] 

Jacques Le Roux commented on OFBIZ-7520:


I think one more urgent task would be to complete the documentation in the XSD 
files. I will create a Jira for that!

> Minilang code readability and consistency improvements
> --
>
> Key: OFBIZ-7520
> URL: https://issues.apache.org/jira/browse/OFBIZ-7520
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> Code written in minilang is not consistent through out the application and 
> some times its hard to read. For eg:
> {code}
> 
> {code}
> should be written as :
> {code}
> 
> {code}
> There are many such examples where code for all such tags in minilang can be 
> improved, which will improve code readability and we will have consistency 
> through out the application. This is a parent/place holder ticket, I will 
> create logical sub-tickets for managing the effort. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344079#comment-15344079
 ] 

Jacques Le Roux commented on OFBIZ-7519:


Oops, you are right I mixed the 2 things :(

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344080#comment-15344080
 ] 

Jacques Le Roux commented on OFBIZ-7519:


This was most needed, thanks!

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344094#comment-15344094
 ] 

Jacques Le Roux commented on OFBIZ-7073:


Oops, missed the sub-tasks, quite clear, thanks for the wiki page. And you are 
right about waiting for Taher, he asked so on dev ML indeed.

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application


[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343882#comment-15343882
 ] 

Divesh Dutta commented on OFBIZ-7511:
-

Yea this solution makes sense Deepak. 

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework


[ 
https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343905#comment-15343905
 ] 

Jacques Le Roux commented on OFBIZ-7529:


Yes I had not enough time yesterday to do it

> Delete stale java files from applications and framework
> ---
>
> Key: OFBIZ-7529
> URL: https://issues.apache.org/jira/browse/OFBIZ-7529
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Mridul Pathak
>Assignee: Mridul Pathak
>
> As per the discussions on the thread - 
> http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html,
>  following files and their references needs to be deleted from applications 
> and framework,
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
> applications/content/src/org/ofbiz/content/report
> applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java
> applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java
> applications/product/src/ShipmentScaleApplet.java
> applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java
> framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343930#comment-15343930
 ] 

Jacques Le Roux commented on OFBIZ-6576:


I agree with Divesh, +1 for Ankush's patch!

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax

[jira] [Commented] (OFBIZ-7536) Clean up commented out code


[ 
https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343947#comment-15343947
 ] 

Divesh Dutta commented on OFBIZ-7536:
-

+1 for this effort. 

> Clean up commented out code
> ---
>
> Key: OFBIZ-7536
> URL: https://issues.apache.org/jira/browse/OFBIZ-7536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
> Fix For: Upcoming Branch
>
>
> In our Re-Factor To-Do List one of the item is to clean up the commented out 
> code. 
> This is the parent ticket and I will further create sub tasks under it so 
> that we do not push large change in one commit.
> This includes Java, Xml, Groovy and FTL files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application


[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343963#comment-15343963
 ] 

Jacques Le Roux commented on OFBIZ-7511:


When I have to choice I always prefer the solution which maximally automates 
(and I guess most of us do ;)).

 It seems Deepak proposition fits here. Let me resume to see if we are all on 
the same page. If a form uses a service, instead of using the manual 
auto-field-service element, we would have a widget coded mechanism able to 
automaticaly infer the field to be rendered as required, based on the service 
definition. So auto-field-service would be deprecated, we could remove it. But 
of course in case you would need to change the default behaviour (required true 
from service) and have a field not required a required-field attribute forced 
to false would be used.

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343983#comment-15343983
 ] 

Jacques Le Roux commented on OFBIZ-7519:


Please see my comment at 
https://issues.apache.org/jira/browse/OFBIZ-7511?focusedCommentId=15343963

With Deepak's solution we would no longer need to put the changes you and I did 
:)

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application


[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343867#comment-15343867
 ] 

Deepak Dixit commented on OFBIZ-7511:
-

Make sense Divesh, 

developer should use auto-service-field when ever possible. 
I had a discussion with [~diveshdut] regarding this, and we found that if we 
use auto-field-service and than override field in form than its override the 
required-filed behavior and set it to false. 

I think here we can fix/improve the auto-field-service behavior, If an field is 
set required true by auto-field-service than form field should not override 
this behavior until unless explicitly set required-fiedd in overridden attribute

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS




On 21/06/2016 22:09, Taher Alkhateeb wrote:

- download-PG-JDBC

If it's possible, keep this one :)


Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.
I think load-seed is important as well, so if you can keep the load-seed 
task, it could be fine.


Thanks!

Julien.


If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb

On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb 
wrote:


I'm in over for these technical aspects but the motivation and enthusiasm
for many PMC and commiter tells me that seems a good way.

So now I will learn gradle ;) and I'm in favor to realize this change
directly on trunk

Thks Taher to your engine energy on this subject !

Nicolas



Le 21/06/2016 10:43, Jacques Le Roux a écrit :


As Gavin mentioned, Gradle can run Ant so no worries using only Gradle

https://docs.gradle.org/current/userguide/ant.html

Jacques


Le 21/06/2016 à 09:59, Michael Brohl a écrit :


I have no strong opinion for/against Gradle (I simply have no
experience with it) but I agree that it should be either Ant or Gradle.
Running two build tools in parallel would make it too complex an gain
nothing.

I'm in favor for learning new things so Gradle sounds fine for me :-)

Regards,

Michael


Am 21.06.16 um 08:11 schrieb Taher Alkhateeb:


Hi Deepak,

Ant would be removed completely for the following reasons:

- First to resolve the ASF issue about the libraries mentioned by
Sharan
below without expending effort on both build systems.
- Ant is an obstacle to refactoring the framework. If we keep both
systems
side by side we gain nothing, actually we lose value because the builds
become more complex. For example, we will not be able to intrduce the
unit
tests, and we will have two build outputs, and we will have two ways of
running the framework (java -jar ofbiz.jar and gradlew ofbiz) and we
will
have other incompatibility issues.

With that being said, we will not make the switch before a thorough and
full testing. That is why we ask everyone who is willing to please
help us
out to make this transition smooth by testing and providing feedback
and
comments.

Taher Alkhateeb

On Tuesday, 21 June 2016, Deepak Dixit > wrote:

Hi Everyone

This is the second of two emails to inform the community about what
has
been happening around how we are planning to handle external
dependencies
in the trunk. Two weeks ago the community discussed and agreed to
the use
of Gradle to help us put together a unit test framework. While
trying to
get this set up while Ant remained as our build tool became very


difficult.


This was because our Ant scripts:

 - are massive and contain a lot of code
 - are complex
 - are very brittle and make it very hard to change things
 - have no dependency management
 - need everything to be declared

We realised very quickly that the re-factoring issues and
limitations we
are facing are because of our build tool – Ant.

Ant is verbose so it needs everything to be declared. We did a brief
assessment of Maven and found it better than Ant but not a good fit
for
OFBiz because it has strict requirements for the
convention-over-configuration rules to work. Instead we

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS




On 22/06/2016 09:53, Julien NICOLAS wrote:



On 21/06/2016 22:09, Taher Alkhateeb wrote:

- download-PG-JDBC

If it's possible, keep this one :)
Ok, I don't see the information of Michael that with Graddle, we don't 
need a task for that because of the Graddle dependency functionality. So 
my mistake, forgot it :)


Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.
I think load-seed is important as well, so if you can keep the 
load-seed task, it could be fine.


Thanks!

Julien.


If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb

On Tue, Jun 21, 2016 at 1:02 PM, Taher Alkhateeb 


wrote:

I'm in over for these technical aspects but the motivation and 
enthusiasm

for many PMC and commiter tells me that seems a good way.

So now I will learn gradle ;) and I'm in favor to realize this change
directly on trunk

Thks Taher to your engine energy on this subject !

Nicolas



Le 21/06/2016 10:43, Jacques Le Roux a écrit :

As Gavin mentioned, Gradle can run Ant so no worries using only 
Gradle


https://docs.gradle.org/current/userguide/ant.html

Jacques


Le 21/06/2016 à 09:59, Michael Brohl a écrit :


I have no strong opinion for/against Gradle (I simply have no
experience with it) but I agree that it should be either Ant or 
Gradle.
Running two build tools in parallel would make it too complex an 
gain

nothing.

I'm in favor for learning new things so Gradle sounds fine for me 
:-)


Regards,

Michael


Am 21.06.16 um 08:11 schrieb Taher Alkhateeb:


Hi Deepak,

Ant would be removed completely for the following reasons:

- First to resolve the ASF issue about the libraries mentioned by
Sharan
below without expending effort on both build systems.
- Ant is an obstacle to refactoring the framework. If we keep both
systems
side by side we gain nothing, actually we lose value because the 
builds
become more complex. For example, we will not be able to 
intrduce the

unit
tests, and we will have two build outputs, and we will have two 
ways of
running the framework (java -jar ofbiz.jar and gradlew ofbiz) 
and we

will
have other incompatibility issues.

With that being said, we will not make the switch before a 
thorough and

full testing. That is why we ask everyone who is willing to please
help us
out to make this transition smooth by testing and providing 
feedback

and
comments.

Taher Alkhateeb

On Tuesday, 21 June 2016, Deepak Dixit 
> wrote:

Hi Everyone
This is the second of two emails to inform the community about 
what

has
been happening around how we are planning to handle external
dependencies
in the trunk. Two weeks ago the community discussed and agreed to
the use
of Gradle to help us put together a unit test framework. While
trying to
get this set up while Ant remained as our build tool became very


difficult.


This was because our Ant scripts:

 - are massive and contain a lot of code
 - are complex
 - are very brittle and make it very hard to change things
 - have no dependency management
 - need everything to be declared

We realised very quickly that the re-factoring issues and
limitations we
are facing are because of our build tool –

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: OFBIZ-6576.patch

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID corresponds

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: (was: OFBIZ-6576.patch)

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: (was: OFBIZ-6576.patch)

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID

[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343832#comment-15343832
 ] 

Divesh Dutta edited comment on OFBIZ-6576 at 6/22/16 8:53 AM:
--

Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are 
both taxes levied by tax authority on a sale. I guess we can remove the if and 
else statements in code for SALES_TAX or VAT_TAX.



Also I think Sales tax can also be put on Purchase order, when you want to put 
approximate tax  which supplier will take from you. So I think  VAT and Sales 
tax does not differ . 


was (Author: diveshdut):
Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are 
both taxes levied by tax authority on a sale. I guess we can remove the if and 
else statements in code for SALES_TAX or VAT_TAX.



Also I think Sales tax also be put on Purchase order, when you want to put 
approximate tax  which supplier will take from you. So I think  VAT and Sales 
tax does not differ . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue:

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343962#comment-15343962
 ] 

Ankush Upadhyay commented on OFBIZ-6576:


I have updated patch with null check improvements.

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-6576:
---
Attachment: OFBIZ-6576.patch

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
> Now the products should be visible in the E-Shop. 
> The Virtual Products Price appears at USD 14.16 If I Select the blue or the 
> red T-Shirt Price is 11.9USD
> Now I modify the Product Pricing on the Virtual Product. 
> On Default- and List- Prices add:
> - Tax Percentage:19
> - Tax Authority Party (ID):1 (Or whatever ID corresponds to 
> SII_CHL Party)
> -

[jira] [Comment Edited] (OFBIZ-7073) Add websocket support in OFBiz


[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343993#comment-15343993
 ] 

Jacques Le Roux edited comment on OFBIZ-7073 at 6/22/16 9:57 AM:
-

I was thinking at Multitenant, but obviously there is not a good solution. 
Because the code is shared between the tenants. So I finally agree with your 
point. But your patch is not complete yet, the part in example is not in ;) And 
yes please a wiki page is welcome, also maybe an unit test?


was (Author: jacques.le.roux):
I was thinking at Multitenant, but obviously there is not good solution. 
Because the code is shared between the tenants. So I finally agree with your 
point. But your patch is not complete yet, the part in example is not in ;) And 
yes please a wiki page is welcome, also maybe an unit test?

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344573#comment-15344573
 ] 

james yong commented on OFBIZ-7061:
---

A 3rd possible solution is to change simple-methods.xsd to avoid using 
top-level attributes. I am not sure if attribute groups are also affected.

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

2016-06-22 Thread Mohammad Kathawala (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344123#comment-15344123
 ] 

Mohammad Kathawala commented on OFBIZ-7061:
---

Getting following or similar errors on console while going through any 
application.


bq. [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml   
|E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 25. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 25. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 28. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'now-timestamp'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 28. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'now-timestamp'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 29. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'sequenced-id'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 29. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'sequenced-id'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 30. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 30. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 40. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 40. Error message: cvc-co
 

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
>

[jira] [Commented] (OFBIZ-7537) Complete the documentation in the XSD files


[ 
https://issues.apache.org/jira/browse/OFBIZ-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344129#comment-15344129
 ] 

Divesh Dutta commented on OFBIZ-7537:
-

Thanks Jacques for the details. I will create child tickets for each xsd file 
and get this work done.

> Complete the documentation in the XSD files
> ---
>
> Key: OFBIZ-7537
> URL: https://issues.apache.org/jira/browse/OFBIZ-7537
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>
> We have already some documentation in the XSD files, but we could clearly do 
> better, and that's an important point to achieve a higher adoption by new 
> comers. And you know what? We need them ;)
> Thanks to Paul Piper for a reminder on the subject :)
> When I speak about documentation I speak about the blocks you can find in 
> XSDs elements and attributes like in widget-form.xsd:
> {code}
> 
> 
> This is just like display but looks up a 
> description using the Entity Engine; note that if also-hidden is true then it 
> uses the key as the value, not the shown description.
> 
> [...]
> {code}
> {code}
> 
> 
> Specifies the size of the field (as a 
> number of characters), when the text to display exceed the given size it is 
> truncated and add the complete text as a hint
> 
> 
> {code}
> BTW I personnaly prefer this formatting when the lines are long
> {code}
> 
> 
> 
> This is just like display but looks up a description using 
> the Entity Engine; note that if also-hidden is true then it uses the key as 
> the value, not the shown description.
> 
> 
> [...]
> 
> 
> 
> Specifies the size of the field (as a number of 
> characters), when the text to display exceed the given size it is truncated 
> and add the complete text as a hint
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344151#comment-15344151
 ] 

Jacques Le Roux commented on OFBIZ-7061:


Thanks for report, checking...

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application


[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344183#comment-15344183
 ] 

Nicolas Malin edited comment on OFBIZ-7511 at 6/22/16 12:02 PM:


Thanks Diversh for the explanation, I had some difficulty than Jacques to 
understand exactly the problem.

When we extend a form we can surcharge a field with only the wanted attribute 
to complete or change. Maybe override a field came from auto-field-* element 
would be treated like that.

{code}




 
{code}

Or for not disturbing developer and xsd, we can change the field analyse like 
service definition 

{code}




 
{code}

I quite aware of going off on a tangent, but sometime a hight level idea can 
resolve a specific case and some others ! :)


was (Author: soledad):
Thanks Diversh for the explanation, I had some difficulty than Jacques to 
understand exactly the problem.

When we extend a form we can surcharge a field with only the wanted attribute 
to complete or change. Maybe override a field came from auto-field-* element 
would be treated like that.

{code}




 
{code}

Or for not disturbing developer and xsd, we can change the field analyse like 
service definition 

{code}




 
{code}

I quite aware of going off on a tangent, but sometime an hight level idea can 
resolve a specif case and some others ! :)

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344199#comment-15344199
 ] 

james yong commented on OFBIZ-7061:
---

Hi [~Mohammad K],

I am not able to reproduce the error message. Can you provide a url that I can 
try on?

Regards,
James

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Michael Brohl


Hi Taher,

no, I don't use it myself. This was just a guess by looking what the 
task does and it seemed to me this should be preserved.

No problem to drop it from my side.

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.06.16 um 14:37 schrieb Taher Alkhateeb:

Hi Michael,

Are you sure you are using "run-test-list"? This is an old task using a
target on the server called --testlist which essentially creates an ant
file of all the suites in OFBiz and runs them one-by-one stopping OFBiz in
between each run.

To me it seems like run-tests is doing the same thing but faster. Is this a
typo by you or are you actually using this target? The reason I ask is
because I actually wanted to delete the entire TestListContainer.java and
related files in the future. But now of course I hesitate.

Thanks in advance for your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl 
wrote:


Hi Taher,

First question:

Don't drop:

- build-dev
- build-production
- build-qa
- build-test
- refresh
- revert-dev
- run-test-list

Drop:

- clean-ivy (assuming this is not needed if we use Gradle)
- copy-dtds
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC (download tasks: assuming they are not needed if we
use Gradle/automatic dependency mechanism)


Not sure (I don't use them):

- create-tenant
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- gen-kek
- gitinfo
- run-test-list
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure (...secure: not sure if these are needed anymore, I think
Jacques can give some hints about them)
- svninfo

Second question: +1

but I'm not sure about the load-tenant... tasks (I don't use them).


Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.16 um 22:09 schrieb Taher Alkhateeb:


Hi Everyone,

I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534
for
this project

I have two questions in this thread

First Question
--
Can I drop the below tasks from the build system? They currently exist in
Ant but I am not sure whether they are actively used or not. So if you
want
me to add any of these tasks please reply to this thread, otherwise I will
not include them in gradle. Please note I added all multi tenant tasks
because many of them are broken or have no functionality, so I am assuming
people are doing multi-tenancy manually but not sure, so please help!

- build-dev
- build-production
- build-qa
- build-test
- clean-ivy
- copy-dtds
- create-tenant
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC
- gen-kek
- gitinfo
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- refresh
- revert-dev
- run-test-list
- start-batch
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure
- svninfo

Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.

If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb









smime.p7s
Description: S/MIME Cryptographic Signature

[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment


[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344277#comment-15344277
 ] 

Jacques Le Roux commented on OFBIZ-6899:


Thanks Divesh for the proposition, I think these information would more easily 
found in "a new table with name Check similar to CreditCard, EftAccount, etc.", 
and treated in case of need.

I'd just wait feedbacks from the community, if any I'd do.

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's

2016-06-22 Thread Pranay Pandey (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344100#comment-15344100
 ] 

Pranay Pandey commented on OFBIZ-7519:
--

Thanks for the confirmation Jacques :).

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb

Hi Michael,

Are you sure you are using "run-test-list"? This is an old task using a
target on the server called --testlist which essentially creates an ant
file of all the suites in OFBiz and runs them one-by-one stopping OFBiz in
between each run.

To me it seems like run-tests is doing the same thing but faster. Is this a
typo by you or are you actually using this target? The reason I ask is
because I actually wanted to delete the entire TestListContainer.java and
related files in the future. But now of course I hesitate.

Thanks in advance for your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl 
wrote:

> Hi Taher,
>
> First question:
>
> Don't drop:
>
> - build-dev
> - build-production
> - build-qa
> - build-test
> - refresh
> - revert-dev
> - run-test-list
>
> Drop:
>
> - clean-ivy (assuming this is not needed if we use Gradle)
> - copy-dtds
> - download-PG-JDBC
> - download-activemq
> - download-mySQL-JDBC (download tasks: assuming they are not needed if we
> use Gradle/automatic dependency mechanism)
>
>
> Not sure (I don't use them):
>
> - create-tenant
> - load-all-tenants
> - load-demo-multitenant
> - load-tenant
> - load-tenant-data-readers
> - gen-kek
> - gitinfo
> - run-test-list
> - start-batch-secure
> - start-both-secure
> - start-pos-secure
> - start-secure (...secure: not sure if these are needed anymore, I think
> Jacques can give some hints about them)
> - svninfo
>
> Second question: +1
>
> but I'm not sure about the load-tenant... tasks (I don't use them).
>
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 21.06.16 um 22:09 schrieb Taher Alkhateeb:
>
>> Hi Everyone,
>>
>> I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534
>> for
>> this project
>>
>> I have two questions in this thread
>>
>> First Question
>> --
>> Can I drop the below tasks from the build system? They currently exist in
>> Ant but I am not sure whether they are actively used or not. So if you
>> want
>> me to add any of these tasks please reply to this thread, otherwise I will
>> not include them in gradle. Please note I added all multi tenant tasks
>> because many of them are broken or have no functionality, so I am assuming
>> people are doing multi-tenancy manually but not sure, so please help!
>>
>> - build-dev
>> - build-production
>> - build-qa
>> - build-test
>> - clean-ivy
>> - copy-dtds
>> - create-tenant
>> - download-PG-JDBC
>> - download-activemq
>> - download-mySQL-JDBC
>> - gen-kek
>> - gitinfo
>> - load-all-tenants
>> - load-demo-multitenant
>> - load-tenant
>> - load-tenant-data-readers
>> - refresh
>> - revert-dev
>> - run-test-list
>> - start-batch
>> - start-batch-secure
>> - start-both-secure
>> - start-pos-secure
>> - start-secure
>> - svninfo
>>
>> Second Question
>> ---
>>
>> it seems many of the load tasks are too specific. So I suggest to only
>> implement loadDemo and the rest are executed manually by users, for
>> example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
>> instead of load-extseed.
>>
>> If you would like to add the other load data tasks, please specify which
>> ones.
>>
>> Appreciate your early responses.
>>
>> Taher Alkhateeb
>>
>>
>
>

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's

2016-06-22 Thread Pranay Pandey (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344239#comment-15344239
 ] 

Pranay Pandey commented on OFBIZ-7519:
--

Thanks for the confirmation Nicolas.

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344279#comment-15344279
 ] 

james yong commented on OFBIZ-7061:
---

I got the error too after updating from SVN.

Can you try replacing in the minilangs
{code}
xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method 
http://ofbiz.apache.org/dtds/simple-methods.xsd;
{code}
with
{code}
xsi:schemaLocation="http://ofbiz.apache.org/dtds/simple-methods.xsd;
{code}
?


> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7537) Complete the documentation in the XSD files


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7537:
---
Description: 
We have already some documentation in the XSD files, but we could clearly do 
better, and that's an important point to achieve a higher adoption by new 
comers. And you know what? We need them ;)

Thanks to Paul Piper for a reminder on the subject :)

When I speak about documentation I speak about the blocks you can find in XSDs 
elements and attributes like in widget-form.xsd:
{code}


This is just like display but looks up a 
description using the Entity Engine; note that if also-hidden is true then it 
uses the key as the value, not the shown description.

[...]
{code}
{code}


Specifies the size of the field (as a 
number of characters), when the text to display exceed the given size it is 
truncated and add the complete text as a hint


{code}

  was:
We have already some documentation in the XSD files, but we could clearly do 
better, and that's an important point to achieve a better adoption by new 
comers. And you know what? We need them ;)

Thanks to Paul Piper for a reminder on the subject :)


> Complete the documentation in the XSD files
> ---
>
> Key: OFBIZ-7537
> URL: https://issues.apache.org/jira/browse/OFBIZ-7537
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>
> We have already some documentation in the XSD files, but we could clearly do 
> better, and that's an important point to achieve a higher adoption by new 
> comers. And you know what? We need them ;)
> Thanks to Paul Piper for a reminder on the subject :)
> When I speak about documentation I speak about the blocks you can find in 
> XSDs elements and attributes like in widget-form.xsd:
> {code}
> 
> 
> This is just like display but looks up a 
> description using the Entity Engine; note that if also-hidden is true then it 
> uses the key as the value, not the shown description.
> 
> [...]
> {code}
> {code}
> 
> 
> Specifies the size of the field (as a 
> number of characters), when the text to display exceed the given size it is 
> truncated and add the complete text as a hint
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7061) Autocompletion for Compound Widget

2016-06-22 Thread Mohammad Kathawala (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344123#comment-15344123
 ] 

Mohammad Kathawala edited comment on OFBIZ-7061 at 6/22/16 11:07 AM:
-

Getting following or similar errors on console while going through any 
application.

bq.Error message: cvc-complex-type.3.2.2: Attribute 'field' is not allowed to 
appear in element 'set'.



was (Author: mohammad k):
Getting following or similar errors on console while going through any 
application.


bq. [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml   
|E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 25. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 25. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 28. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'now-timestamp'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 28. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'now-timestamp'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 29. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'sequenced-id'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 29. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'sequenced-id'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 30. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 30. Error message: cvc-complex-type.4: Attribute 'field' 
must appear on element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 40. Error message: cvc-complex-type.3.2.2: Attribute 
'field' is not allowed to appear in element 'set'.
 [java] 2016-06-22 16:30:10,128 |http-nio-8443-exec-7 |UtilXml  
 |E| XmlFileLoader: File 
file:/home/mohammad/ofbiz-trunk/applications/commonext/minilang/SystemInfoServices.xml
 process error. Line: 40. Error message: cvc-co
 

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
>

[jira] [Commented] (OFBIZ-7519) Some entity-auto services fields doesn't have optional false in case of multiple PK's


[ 
https://issues.apache.org/jira/browse/OFBIZ-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344167#comment-15344167
 ] 

Nicolas Malin commented on OFBIZ-7519:
--

I confirm, this patch is good. When I converted simple to entity-auto I just 
control that we haven't regression to centralise the modification only on the 
engine, and with this issue you finish to correct the service definition. 

Thanks for that

> Some entity-auto services fields doesn't have optional false in case of 
> multiple PK's
> -
>
> Key: OFBIZ-7519
> URL: https://issues.apache.org/jira/browse/OFBIZ-7519
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, marketing
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7519-Screen-Shot.png, OFBIZ-7519.patch
>
>
> Some services with entity-auto doesn't have optional false in case of 
> multiple PK's. In this cases if any of the PK is missing then sql error 
> returns.
> Please find attached screenshot of error.
> According to my analysis of entity auto engine, Here are some cases:
> 1. One primary key: Takes new sequence if PK not passed.
> 2. Two primary key: Both PK should be mandatory except the case of secondary 
> primary key (like agreementItemSeqId) where next subsequence is generated.
> 3. More than two PK's, all PK's should be mandatory except the fromDate.
> Here is the list of services which need to be fixed according to above points.
> 1. createAgreementItem
> 2. updateAgreementItem
> 3. deleteAgreementItem
> 4. updateAgreementTerm
> 5. deleteAgreementTerm
> 6. createContentMetaData
> 7. createContentPurpose
> 8. createContentPurposeOperation
> 9. createContentAttribute
> 10. createContentRevisionItem
> 11. createContentTypeAttr
> 12. createDataResourceMetaData
> 13. createDataResourcePurpose
> 14. createSurveyTrigger
> 15. createDataResourceAttribute
> 16. createSalesOpportunityRole
> I am working on it and will add patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7248) Improve the layout of PDF documents


[ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344217#comment-15344217
 ] 

Nicolas Malin commented on OFBIZ-7248:
--

I wrote an example here OFBIZ-5759, but we can extend this idea to all generic 
document.

Now the first step proposed by Mohammad is also good, more easier to resolve 
and nice for end user when discover OFBiz the first time ;)

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
> Fix For: Trunk
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7155) Remove jce-jdk13-154.jar


[ 
https://issues.apache.org/jira/browse/OFBIZ-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344225#comment-15344225
 ] 

Nicolas Malin commented on OFBIZ-7155:
--

I loaded this library needed by tika to analyse on test case the screen engine 
result on page rendering by view type screenfop.

If jce-jdk13-154.jar is problematic when can disable this test and remove it

> Remove jce-jdk13-154.jar
> 
>
> Key: OFBIZ-7155
> URL: https://issues.apache.org/jira/browse/OFBIZ-7155
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Christian Geisert
>Assignee: Christian Geisert
> Fix For: Upcoming Branch, 15.12.01
>
>
> After updating our project to the latest release15.12 branch we got the 
> following error when accessing OFBiz pages:
> {code}
> 2016-06-01 14:37:14,040 |http-nio-8443-exec-2 |NioEndpoint   
> |E|
> java.lang.RuntimeException: Could not generate DH keypair
> at sun.security.ssl.Handshaker.checkThrown(Handshaker.java:1429) 
> ~[?:1.8.0_77]
> ...
> Caused by: java.security.InvalidAlgorithmParameterException: parameter object 
> not a ECParameterSpec
> at 
> org.bouncycastle.jcajce.provider.asymmetric.ec.KeyPairGeneratorSpi$EC.initialize(Unknown
>  Source) ~[jce-jdk13-154.jar:1.54.0]
> ...
> {code}
> It turned out that jce-jdk13-154.jar was the culprit. After removing this Jar 
> everything worked as expected. As this jar is an optional dependency of 
> PDFBox (which is used by Tika) and is only need for Java < 1.7 I propose to 
> remove it from OFBiz.
> I'll wait a few days and if there are no objections I'll remove the jar



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle


I wonder though why this was introduced. If we have no feedback from any member 
of the community I think we can drop it. I don't see how to use it.

Jacques


Le 22/06/2016 à 14:43, Michael Brohl a écrit :

Hi Taher,

no, I don't use it myself. This was just a guess by looking what the task does 
and it seemed to me this should be preserved.
No problem to drop it from my side.

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.06.16 um 14:37 schrieb Taher Alkhateeb:

Hi Michael,

Are you sure you are using "run-test-list"? This is an old task using a
target on the server called --testlist which essentially creates an ant
file of all the suites in OFBiz and runs them one-by-one stopping OFBiz in
between each run.

To me it seems like run-tests is doing the same thing but faster. Is this a
typo by you or are you actually using this target? The reason I ask is
because I actually wanted to delete the entire TestListContainer.java and
related files in the future. But now of course I hesitate.

Thanks in advance for your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl 
wrote:


Hi Taher,

First question:

Don't drop:

- build-dev
- build-production
- build-qa
- build-test
- refresh
- revert-dev
- run-test-list

Drop:

- clean-ivy (assuming this is not needed if we use Gradle)
- copy-dtds
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC (download tasks: assuming they are not needed if we
use Gradle/automatic dependency mechanism)


Not sure (I don't use them):

- create-tenant
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- gen-kek
- gitinfo
- run-test-list
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure (...secure: not sure if these are needed anymore, I think
Jacques can give some hints about them)
- svninfo

Second question: +1

but I'm not sure about the load-tenant... tasks (I don't use them).


Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 21.06.16 um 22:09 schrieb Taher Alkhateeb:


Hi Everyone,

I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534
for
this project

I have two questions in this thread

First Question
--
Can I drop the below tasks from the build system? They currently exist in
Ant but I am not sure whether they are actively used or not. So if you
want
me to add any of these tasks please reply to this thread, otherwise I will
not include them in gradle. Please note I added all multi tenant tasks
because many of them are broken or have no functionality, so I am assuming
people are doing multi-tenancy manually but not sure, so please help!

- build-dev
- build-production
- build-qa
- build-test
- clean-ivy
- copy-dtds
- create-tenant
- download-PG-JDBC
- download-activemq
- download-mySQL-JDBC
- gen-kek
- gitinfo
- load-all-tenants
- load-demo-multitenant
- load-tenant
- load-tenant-data-readers
- refresh
- revert-dev
- run-test-list
- start-batch
- start-batch-secure
- start-both-secure
- start-pos-secure
- start-secure
- svninfo

Second Question
---

it seems many of the load tasks are too specific. So I suggest to only
implement loadDemo and the rest are executed manually by users, for
example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext'
instead of load-extseed.

If you would like to add the other load data tasks, please specify which
ones.

Appreciate your early responses.

Taher Alkhateeb

[jira] [Updated] (OFBIZ-7537) Complete the documentation in the XSD files