Clarify the deprecation and removing strategies
Hi, We already clarified things for services: https://markmail.org/message/ohzbubwacoyp6gpf While working on OFBIZ-12168 "Rename some connoted words like blacklist and whitelist." I found these: 1. Three "Deprecated since branch release: Upcoming branch" in datamodel files 2. One "Update service for Deprecate since: branch release" in migration groovy files. I added another by copying :/ 3. Three "Upcoming branch" (once removed point 1). 1 of these 3 is in DATAMODEL_CHANGES.adoc I guess we agree that the same pattern used for services can be used for other things like entities, fields of entities or documentation. It has been used by https://github.com/apache/ofbiz-framework/commit/44c374a/ So points 1 and 3 are not a problem But it can't be applied to the second point where a service is not replaced but used to migrate data from an entity to another. So it's impossible to use the "deprecated since" pattern and it's not of the Release Manager responsibility. I suggest rather put a date there. It will allow to decide when to remove these services from time to time. I propose something like "Update service created 2021-02". Done at https://github.com/apache/ofbiz-framework/commit/a608fa4b562bd9ea484785c0b1cde3f9305c8539/ Jacques
FYI: 18.12.01 release and more
Hi, We started a discussion in the PMC private ML and I think we should continue here. Notably because of the Jcenter issue, Jacopo and Michael proposed to create a last R17 release: 17.12.06, nobody opposed. Michael also proposed: 1. solve the jCenter problem (should also be adressed for r17 as it will most likely be the last release!). 2. release 17.12.06 asap 3. stabilize/bugfix r18.12 asap and release (March/April?) 4. migrate trunk to jdk11 5. create r21 branch (around June?) 6. after September 21: migrate trunk to jdk17 7. release r21 in the 1st half of 2022 create r22 after that Feedback from my side: 1. I just tested, applying PR 270+53.I got some issues[1]/ @MIchael, may I miss something (note: I'm on Windows 7)? 2. +1 3. +1, the sooner the better 4. +1 5. +1, I think we can create the R21 just after releasing R18 where all bug fix should be, no reasons to wait, again the sooner the better 6. +1 7. +1, again the sooner the better I use a lot of "the sooner the better". What do you think about doing the 1st release of R18 2 years after its creation? in our (PMC) defense, we had to treat a lot of vulnerabilities between. Good side of the coin, OFBiz has never been as secured (logical you'd say ;)) [1] The integration tests (cleanAll eclipse loadAll testIntegration) failed: java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Got these errors running OFBiz just after (clean state): 2021-02-11 10:05:23,386 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: org/apache/logging/log4j/util/ReflectionUtil of course 2021-02-11 10:05:23,392 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Feb 11, 2021 10:05:24 AM org.apache.catalina.core.StandardContext filterStart SEVERE: Exception starting filter [SameSiteFilter] java.lang.NoClassDefFoundError: Could not initialize class org.apache.ofbiz.webapp.control.SameSiteFilter [...] SEVERE: Context [/ebay] startup failed due to previous errors Feb 11, 2021 10:05:24 AM org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads WARNING: The web application [ebay] appears to have started a thread named [Log4j2-TF-10-Scheduled-3] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method) [...] SEVERE: One or more Filters failed to start. Full details will be found in the appropriate container log file [...] SEVERE: Context [/marketing] startup failed due to previous errors [...] SEVERE: Context [/exampleext] startup failed due to previous errors [...] SEVERE: Context [/rest] startup failed due to previous errors Etc. Jacques
Re: FYI: 18.12.01 release and more
Hi Jacques, +1 to all the points raised by Michael. It can be a bit disheartening knowing that changes we make to trunk today probably won't be used by the stable-branch user community for a few years. Anything that can be done to shorten the major release cycle will be a net positive in my view, but I appreciate that a too rapid release cycle might result in some users being reluctant to upgrade and remain on very old branches. Thanks, Dan. On Thu, 11 Feb 2021 at 09:15, Jacques Le Roux wrote: > Hi, > > We started a discussion in the PMC private ML and I think we should > continue here. > > Notably because of the Jcenter issue, Jacopo and Michael proposed to > create a last R17 release: 17.12.06, nobody opposed. > > Michael also proposed: > > 1. solve the jCenter problem (should also be adressed for r17 as it will > most likely be the last release!). > 2. release 17.12.06 asap > 3. stabilize/bugfix r18.12 asap and release (March/April?) > 4. migrate trunk to jdk11 > 5. create r21 branch (around June?) > 6. after September 21: migrate trunk to jdk17 > 7. release r21 in the 1st half of 2022 create r22 after that > > Feedback from my side: > > 1. I just tested, applying PR 270+53.I got some issues[1]/ @MIchael, may > I miss something (note: I'm on Windows 7)? > 2. +1 > 3. +1, the sooner the better > 4. +1 > 5. +1, I think we can create the R21 just after releasing R18 where all > bug fix should be, no reasons to wait, again the sooner the better > 6. +1 > 7. +1, again the sooner the better > > I use a lot of "the sooner the better". What do you think about doing the > 1st release of R18 2 years after its creation? in our (PMC) defense, we had > to treat a lot of vulnerabilities between. Good side of the coin, OFBiz > has never been as secured (logical you'd say ;)) > > [1] > The integration tests (cleanAll eclipse loadAll testIntegration) failed: > java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: > Could not initialize class > org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory > Got these errors running OFBiz just after (clean state): > > 2021-02-11 10:05:23,386 |delegator-startup-1 > |ExecutionPool |E| null > java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: > org/apache/logging/log4j/util/ReflectionUtil > > of course > 2021-02-11 10:05:23,392 |delegator-startup-1 > |ExecutionPool |E| null > java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: > Could not initialize class > org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory > > Feb 11, 2021 10:05:24 AM org.apache.catalina.core.StandardContext > filterStart > SEVERE: Exception starting filter [SameSiteFilter] > java.lang.NoClassDefFoundError: Could not initialize class > org.apache.ofbiz.webapp.control.SameSiteFilter > [...] > SEVERE: Context [/ebay] startup failed due to previous errors > Feb 11, 2021 10:05:24 AM org.apache.catalina.loader.WebappClassLoaderBase > clearReferencesThreads > WARNING: The web application [ebay] appears to have started a thread named > [Log4j2-TF-10-Scheduled-3] but has failed to stop it. This is very likely > to create a memory leak. Stack trace of thread: > sun.misc.Unsafe.park(Native Method) > [...] > SEVERE: One or more Filters failed to start. Full details will be found in > the appropriate container log file > [...] > SEVERE: Context [/marketing] startup failed due to previous errors > [...] > SEVERE: Context [/exampleext] startup failed due to previous errors > [...] > SEVERE: Context [/rest] startup failed due to previous errors > > Etc. > > Jacques > > -- Daniel Watford
Re: FYI: 18.12.01 release and more
Hi Jacques, thanks for summing up the state of this topic and bringing the discussion back to the dev list. I think it would be best to separate the discussion of the release plan from the report of issues regarding the jCenter migration work. Else it will get confusing soon. Can you please report the issues in the corresponding Jira for the jCenter handling here: https://issues.apache.org/jira/browse/OFBIZ-12171 I will work on making the tests pass. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 11.02.21 um 10:44 schrieb Jacques Le Roux: Le 11/02/2021 à 10:13, Jacques Le Roux a écrit : Got these errors running OFBiz just after (clean state): It's not really a clean state, of course the data are not loaded correctly because of the dbcp2 issue. I tried to add mavenLocal() to no avail. Reverting both PRs works Jacques
Re: FYI: 18.12.01 release and more
Hi Daniel, We decided in the past that we would wait at least 1 year before releasing a freezed branch. We did not exclude to release more often... This could be discussed again with pro and cons... Jacques Le 11/02/2021 à 10:37, Daniel Watford a écrit : Hi Jacques, +1 to all the points raised by Michael. It can be a bit disheartening knowing that changes we make to trunk today probably won't be used by the stable-branch user community for a few years. Anything that can be done to shorten the major release cycle will be a net positive in my view, but I appreciate that a too rapid release cycle might result in some users being reluctant to upgrade and remain on very old branches. Thanks, Dan. On Thu, 11 Feb 2021 at 09:15, Jacques Le Roux wrote: Hi, We started a discussion in the PMC private ML and I think we should continue here. Notably because of the Jcenter issue, Jacopo and Michael proposed to create a last R17 release: 17.12.06, nobody opposed. Michael also proposed: 1. solve the jCenter problem (should also be adressed for r17 as it will most likely be the last release!). 2. release 17.12.06 asap 3. stabilize/bugfix r18.12 asap and release (March/April?) 4. migrate trunk to jdk11 5. create r21 branch (around June?) 6. after September 21: migrate trunk to jdk17 7. release r21 in the 1st half of 2022 create r22 after that Feedback from my side: 1. I just tested, applying PR 270+53.I got some issues[1]/ @MIchael, may I miss something (note: I'm on Windows 7)? 2. +1 3. +1, the sooner the better 4. +1 5. +1, I think we can create the R21 just after releasing R18 where all bug fix should be, no reasons to wait, again the sooner the better 6. +1 7. +1, again the sooner the better I use a lot of "the sooner the better". What do you think about doing the 1st release of R18 2 years after its creation? in our (PMC) defense, we had to treat a lot of vulnerabilities between. Good side of the coin, OFBiz has never been as secured (logical you'd say ;)) [1] The integration tests (cleanAll eclipse loadAll testIntegration) failed: java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Got these errors running OFBiz just after (clean state): 2021-02-11 10:05:23,386 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: org/apache/logging/log4j/util/ReflectionUtil of course 2021-02-11 10:05:23,392 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Feb 11, 2021 10:05:24 AM org.apache.catalina.core.StandardContext filterStart SEVERE: Exception starting filter [SameSiteFilter] java.lang.NoClassDefFoundError: Could not initialize class org.apache.ofbiz.webapp.control.SameSiteFilter [...] SEVERE: Context [/ebay] startup failed due to previous errors Feb 11, 2021 10:05:24 AM org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads WARNING: The web application [ebay] appears to have started a thread named [Log4j2-TF-10-Scheduled-3] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method) [...] SEVERE: One or more Filters failed to start. Full details will be found in the appropriate container log file [...] SEVERE: Context [/marketing] startup failed due to previous errors [...] SEVERE: Context [/exampleext] startup failed due to previous errors [...] SEVERE: Context [/rest] startup failed due to previous errors Etc. Jacques
Re: FYI: 18.12.01 release and more
Done, thanks! Le 11/02/2021 à 10:54, Michael Brohl a écrit : Can you please report the issues in the corresponding Jira for the jCenter handling here: https://issues.apache.org/jira/browse/OFBIZ-12171
Re: FYI: 18.12.01 release and more
Le 11/02/2021 à 10:13, Jacques Le Roux a écrit : Got these errors running OFBiz just after (clean state): It's not really a clean state, of course the data are not loaded correctly because of the dbcp2 issue. I tried to add mavenLocal() to no avail. Reverting both PRs works Jacques
Re: FYI: 18.12.01 release and more
Hi Everyone, +1 for release 17.12.06 asap. +1 for release 18.12 asap. We should start migrating the trunk to JDK11 then create R21 asap. Stabilize and release R21 maybe in 2021 itself or in the first half of 2022 sooner the better. -- Thanks & Regards Pawan Verma ofbiz.apache.org On Thu, Feb 11, 2021 at 3:46 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done, thanks! > > Le 11/02/2021 à 10:54, Michael Brohl a écrit : > > Can you please report the issues in the corresponding Jira for the > jCenter handling here: https://issues.apache.org/jira/browse/OFBIZ-12171 > >
Re: FYI: 18.12.01 release and more
Hi folks, I did a cleanup of the Jira issues with focus on the upcoming r18.12 release. After this we currently have 40 open issues to get fixed for the release [1]. I have commented and mentioned reporters / assignees to check their issues and encourage everyone to check [1] if you can pick up some work to get finished for the release. Every bit helps. Thanks and regards, Michael Brohl ecomify GmbH - www.ecomify.de [1] https://issues.apache.org/jira/browse/OFBIZ-12173?jql=project%20%3D%20OFBIZ%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch%20Available%22)%20AND%20affectedVersion%20in%20(18.12.01%2C%20%22Release%20Branch%2018.12%22) Am 11.02.21 um 10:13 schrieb Jacques Le Roux: Hi, We started a discussion in the PMC private ML and I think we should continue here. Notably because of the Jcenter issue, Jacopo and Michael proposed to create a last R17 release: 17.12.06, nobody opposed. Michael also proposed: 1. solve the jCenter problem (should also be adressed for r17 as it will most likely be the last release!). 2. release 17.12.06 asap 3. stabilize/bugfix r18.12 asap and release (March/April?) 4. migrate trunk to jdk11 5. create r21 branch (around June?) 6. after September 21: migrate trunk to jdk17 7. release r21 in the 1st half of 2022 create r22 after that Feedback from my side: 1. I just tested, applying PR 270+53.I got some issues[1]/ @MIchael, may I miss something (note: I'm on Windows 7)? 2. +1 3. +1, the sooner the better 4. +1 5. +1, I think we can create the R21 just after releasing R18 where all bug fix should be, no reasons to wait, again the sooner the better 6. +1 7. +1, again the sooner the better I use a lot of "the sooner the better". What do you think about doing the 1st release of R18 2 years after its creation? in our (PMC) defense, we had to treat a lot of vulnerabilities between. Good side of the coin, OFBiz has never been as secured (logical you'd say ;)) [1] The integration tests (cleanAll eclipse loadAll testIntegration) failed: java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Got these errors running OFBiz just after (clean state): 2021-02-11 10:05:23,386 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: org/apache/logging/log4j/util/ReflectionUtil of course 2021-02-11 10:05:23,392 |delegator-startup-1 |ExecutionPool |E| null java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory Feb 11, 2021 10:05:24 AM org.apache.catalina.core.StandardContext filterStart SEVERE: Exception starting filter [SameSiteFilter] java.lang.NoClassDefFoundError: Could not initialize class org.apache.ofbiz.webapp.control.SameSiteFilter [...] SEVERE: Context [/ebay] startup failed due to previous errors Feb 11, 2021 10:05:24 AM org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads WARNING: The web application [ebay] appears to have started a thread named [Log4j2-TF-10-Scheduled-3] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method) [...] SEVERE: One or more Filters failed to start. Full details will be found in the appropriate container log file [...] SEVERE: Context [/marketing] startup failed due to previous errors [...] SEVERE: Context [/exampleext] startup failed due to previous errors [...] SEVERE: Context [/rest] startup failed due to previous errors Etc. Jacques
