[jira] [Commented] (OLINGO-1109) JPA silently dropping navigation properties if not found
[
https://issues.apache.org/jira/browse/OLINGO-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968077#comment-15968077
]
Michael Bolz commented on OLINGO-1109:
--
Hi [~patrickmhaller],
The OData specification itself does not documents how to handle such a case.
This is more based on the (server side) implementation and in our case in the
JPA Processor.
I will take a look into but currently I think your suggestion with throwing an
exception (instead of loosing the link) would be a good solution.
Best Regards, Michael
> JPA silently dropping navigation properties if not found
>
>
> Key: OLINGO-1109
> URL: https://issues.apache.org/jira/browse/OLINGO-1109
> Project: Olingo
> Issue Type: Improvement
> Components: odata2-jpa
>Affects Versions: V2 2.0.8
>Reporter: Patrick Haller
>Assignee: Michael Bolz
>
> We encountered an issue when creating a ProjectCost record, directly to be
> associated with its parent Project by setting a navigation property. The
> information encoded in { '__metadata': { uri: 'xyz' } } was correctly parsed
> in the Olingo stack, but in
> {{JPALink.create() #174}}, the {{targetJPAEntity}} could not be resolved as
> the value 'xyz' was indeed wrong. The created data in persistence was missing
> the link to the parent entity, but the error went unnoticed as no exception
> was thrown.
> I would suggest that {{JPALink.create}} should also {{throw
> ODataJPARuntimeException.throwException(ODataJPARuntimeException.RESOURCE_X_NOT_FOUND}}
> like {{JPALink.delete}}. It seems that {{JPALink.modifyLink}} is also
> intentionally ignoring if the target entity cannot be found.
> Not sure what behavior the OData specification documents here, but data loss
> should not go unnoticed, I think.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (OLINGO-1109) JPA silently dropping navigation properties if not found
[
https://issues.apache.org/jira/browse/OLINGO-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Bolz reassigned OLINGO-1109:
Assignee: Michael Bolz
> JPA silently dropping navigation properties if not found
>
>
> Key: OLINGO-1109
> URL: https://issues.apache.org/jira/browse/OLINGO-1109
> Project: Olingo
> Issue Type: Improvement
> Components: odata2-jpa
>Affects Versions: V2 2.0.8
>Reporter: Patrick Haller
>Assignee: Michael Bolz
>
> We encountered an issue when creating a ProjectCost record, directly to be
> associated with its parent Project by setting a navigation property. The
> information encoded in { '__metadata': { uri: 'xyz' } } was correctly parsed
> in the Olingo stack, but in
> {{JPALink.create() #174}}, the {{targetJPAEntity}} could not be resolved as
> the value 'xyz' was indeed wrong. The created data in persistence was missing
> the link to the parent entity, but the error went unnoticed as no exception
> was thrown.
> I would suggest that {{JPALink.create}} should also {{throw
> ODataJPARuntimeException.throwException(ODataJPARuntimeException.RESOURCE_X_NOT_FOUND}}
> like {{JPALink.delete}}. It seems that {{JPALink.modifyLink}} is also
> intentionally ignoring if the target entity cannot be found.
> Not sure what behavior the OData specification documents here, but data loss
> should not go unnoticed, I think.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968072#comment-15968072
]
Ramesh Reddy commented on OLINGO-1107:
--
[~mirbo] This always in encoding side, as long as decoding side can handle both
+ and %20 we will be fine. We know that %20 is already handled in server, +
may not be handled as noted as in OLINGO-752 for possible issues. In this
particular issue client may be inadvertently passing + instead of %20, which
will be corrected with the patch
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968058#comment-15968058
]
Michael Bolz commented on OLINGO-1107:
--
Hi,
as long the relaxation only affects the client it is fine for me.
As far as I understand the change, afterwards the client can handle {{+}} as
empty space
and for the server the behaviour will not be changed, right?
Best Regards, Michael
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OLINGO-933) Few terms missing in Org.OData.Core.V1.xml
[ https://issues.apache.org/jira/browse/OLINGO-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Reddy updated OLINGO-933: Labels: ODATA-4.0.1 (was: ) > Few terms missing in Org.OData.Core.V1.xml > -- > > Key: OLINGO-933 > URL: https://issues.apache.org/jira/browse/OLINGO-933 > Project: Olingo > Issue Type: Bug > Components: odata4-server >Affects Versions: (Java) V4 4.2.0 >Reporter: VIJAYASIMHA R NAGA >Assignee: Ramesh Reddy > Labels: ODATA-4.0.1 > > Org.OData.Core.V1.xml contained in odata-server-core-ext missing terms > AutoExpand, AutoExpandReference -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (OLINGO-956) I would like to use my service with Excel
[ https://issues.apache.org/jira/browse/OLINGO-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Reddy resolved OLINGO-956. - Resolution: Won't Fix This is out of scope for Olingo library to provide functionality for a specific source. > I would like to use my service with Excel > - > > Key: OLINGO-956 > URL: https://issues.apache.org/jira/browse/OLINGO-956 > Project: Olingo > Issue Type: Wish > Components: odata4-server >Affects Versions: (Java) V4 4.3.0 >Reporter: Juozas Baliuks >Priority: Trivial > > Currently Excel can not open service document, metadata and I am not sure > about data. Actually Excel OData capabilities is my only reason to use > OData protocol and would like my services to support Excel 2016. > Issues seem trivial e.g. Excel requires absolute metadata URL in service > document but It is complicated to maintain fixes in custom processors because > tests have to use ODataLib whitch depends on .NET -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (OLINGO-983) Not able to access property annotations
[ https://issues.apache.org/jira/browse/OLINGO-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Reddy resolved OLINGO-983. - Resolution: Information Provided OLINGO-992 will fix the issue, I see no reason to keep this open thus closed before. Workaround is to specify the core libraries with valid URLs in your $metadata > Not able to access property annotations > --- > > Key: OLINGO-983 > URL: https://issues.apache.org/jira/browse/OLINGO-983 > Project: Olingo > Issue Type: Improvement > Components: odata4-commons >Affects Versions: (Java) V4 4.2.0 >Reporter: Punith DG > Labels: annotations, newbie > Attachments: EdmAnnotationImpl.java > > > Not able to consume CsdlAnnotation data from > "org.apache.olingo.commons.core.edm.EdmAnnotationImpl" class. > There is no API that returns CsdlAnnotation data which contains annotations > details like Permissions, Description, Immutatable, etc. > This is much required to read the annotation information which describes much > about the field behavior like creatable or just readable field or immutable. > Could we have a method like getAnnotation() which returns the > "CsdlAnnotation" data. > Please point me if there is any other way to do so :) That will be more > helpful. > Thanks & Regards, > Punith DG -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OLINGO-992) Load OData "CORE" Terms implicitly
[ https://issues.apache.org/jira/browse/OLINGO-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967890#comment-15967890 ] Ramesh Reddy commented on OLINGO-992: - Possible duplicate with OLINGO-1062 depending upon the solution. > Load OData "CORE" Terms implicitly > -- > > Key: OLINGO-992 > URL: https://issues.apache.org/jira/browse/OLINGO-992 > Project: Olingo > Issue Type: Improvement > Components: odata4-commons >Affects Versions: (Java) V4 4.2.0 >Reporter: Punith DG > Labels: newbie, usability > > As many OData provides doesn't iclude OData Core definitions of "Term, thus > the EdmAnnotation.getTerm() retunrs NULLs. One could argue that these are > "core" vocabularies they need to be always available with whatever $metadata > document, which I agree as they are put forward by the OData Specification. > However, right now, Olingo client side library does not automatically add > these vocabularies into the Edm object, which does not have any of these > "core" terms. Hence users can't read the terms of Entity/Property annotations. > It would help solve pro to request to add them implicitly on client side. > BTW, I see the server side MetadataParser does add these implicitly by > default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OLINGO-1037) V4: Support Geotypes on server in JSON
[ https://issues.apache.org/jira/browse/OLINGO-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967880#comment-15967880 ] Ramesh Reddy commented on OLINGO-1037: -- Duplicate of OLINGO-918 ? > V4: Support Geotypes on server in JSON > -- > > Key: OLINGO-1037 > URL: https://issues.apache.org/jira/browse/OLINGO-1037 > Project: Olingo > Issue Type: New Feature > Components: odata4-server >Affects Versions: (Java) V4 4.3.0 >Reporter: Christian Amend >Assignee: Christian Amend > Fix For: (Java) V4 4.4.0 > > > Support GeoTypes in the serializer and deserializer for the json format -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OLINGO-1040) Insert /Update operation fails with 400 bad request
[
https://issues.apache.org/jira/browse/OLINGO-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy updated OLINGO-1040:
-
Issue Type: Question (was: Bug)
> Insert /Update operation fails with 400 bad request
> ---
>
> Key: OLINGO-1040
> URL: https://issues.apache.org/jira/browse/OLINGO-1040
> Project: Olingo
> Issue Type: Question
> Components: odata4-client
>Affects Versions: (Java) V4 4.3.0
>Reporter: Archana
>Assignee: Ramesh Reddy
>
> Hi ,
> I am using Olingo 4.3.0 client core api and trying to do CUD operations.
> I am able to do select /delete operations but my insert and update code fails
> throwing 400 bad request.
> I was able to see my POST request and header but not sure if the body is sent
> correctly.Here's code snippet I used:
> URI insertUri = coreclient.newURIBuilder(serviceRoot)
> .appendEntitySetSegment("contacts").build();
> ClientEntity contact = coreclient.getObjectFactory().newEntity(
> new
> FullQualifiedName("Microsoft.Dynamics.CRM.contact"));
> contact.getProperties().add(
>
> coreclient.getObjectFactory().newPrimitiveProperty(
> "firstname",
> coreclient.getObjectFactory()
>
> .newPrimitiveValueBuilder()
>
> .buildString("InsertTest")));
> contact.getProperties().add(
>
> coreclient.getObjectFactory().newPrimitiveProperty(
> "lastname",
> coreclient.getObjectFactory()
>
> .newPrimitiveValueBuilder()
>
> .buildString("InsertTestlastname")));
> ODataEntityCreateRequest req = coreclient
> .getCUDRequestFactory().getEntityCreateRequest(insertUri,contact);
> System.out.println(req.execute().getStatusCode());
> I get below exception :
> Exception in thread "main"
> org.apache.olingo.client.api.communication.ODataClientErrorException: entity
> [HTTP/1.1 400 Bad Request]
> at
> org.apache.olingo.client.core.communication.header.ODataErrorResponseChecker.checkResponse(ODataErrorResponseChecker.java:75)
> at
> org.apache.olingo.client.core.communication.request.AbstractRequest.checkResponse(AbstractRequest.java:54)
> at
> org.apache.olingo.client.core.communication.request.AbstractODataRequest.doExecute(AbstractODataRequest.java:310)
> at
> org.apache.olingo.client.core.communication.request.cud.ODataEntityCreateRequestImpl.execute(ODataEntityCreateRequestImpl.java:88)
> at
> org.apache.olingo.client.core.communication.request.cud.ODataEntityCreateRequestImpl.execute(ODataEntityCreateRequestImpl.java:47)
> Can anyone please assist?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (OLINGO-1040) Insert /Update operation fails with 400 bad request
[
https://issues.apache.org/jira/browse/OLINGO-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy resolved OLINGO-1040.
--
Resolution: Information Provided
Assignee: Ramesh Reddy
https://github.com/apache/olingo-odata4/blob/master/fit/src/test/java/org/apache/olingo/fit/base/EntityCreateTestITCase.java
> Insert /Update operation fails with 400 bad request
> ---
>
> Key: OLINGO-1040
> URL: https://issues.apache.org/jira/browse/OLINGO-1040
> Project: Olingo
> Issue Type: Bug
> Components: odata4-client
>Affects Versions: (Java) V4 4.3.0
>Reporter: Archana
>Assignee: Ramesh Reddy
>
> Hi ,
> I am using Olingo 4.3.0 client core api and trying to do CUD operations.
> I am able to do select /delete operations but my insert and update code fails
> throwing 400 bad request.
> I was able to see my POST request and header but not sure if the body is sent
> correctly.Here's code snippet I used:
> URI insertUri = coreclient.newURIBuilder(serviceRoot)
> .appendEntitySetSegment("contacts").build();
> ClientEntity contact = coreclient.getObjectFactory().newEntity(
> new
> FullQualifiedName("Microsoft.Dynamics.CRM.contact"));
> contact.getProperties().add(
>
> coreclient.getObjectFactory().newPrimitiveProperty(
> "firstname",
> coreclient.getObjectFactory()
>
> .newPrimitiveValueBuilder()
>
> .buildString("InsertTest")));
> contact.getProperties().add(
>
> coreclient.getObjectFactory().newPrimitiveProperty(
> "lastname",
> coreclient.getObjectFactory()
>
> .newPrimitiveValueBuilder()
>
> .buildString("InsertTestlastname")));
> ODataEntityCreateRequest req = coreclient
> .getCUDRequestFactory().getEntityCreateRequest(insertUri,contact);
> System.out.println(req.execute().getStatusCode());
> I get below exception :
> Exception in thread "main"
> org.apache.olingo.client.api.communication.ODataClientErrorException: entity
> [HTTP/1.1 400 Bad Request]
> at
> org.apache.olingo.client.core.communication.header.ODataErrorResponseChecker.checkResponse(ODataErrorResponseChecker.java:75)
> at
> org.apache.olingo.client.core.communication.request.AbstractRequest.checkResponse(AbstractRequest.java:54)
> at
> org.apache.olingo.client.core.communication.request.AbstractODataRequest.doExecute(AbstractODataRequest.java:310)
> at
> org.apache.olingo.client.core.communication.request.cud.ODataEntityCreateRequestImpl.execute(ODataEntityCreateRequestImpl.java:88)
> at
> org.apache.olingo.client.core.communication.request.cud.ODataEntityCreateRequestImpl.execute(ODataEntityCreateRequestImpl.java:47)
> Can anyone please assist?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (OLINGO-1057) Annotations in an Edmx:Reference aren't serialized
[
https://issues.apache.org/jira/browse/OLINGO-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy reassigned OLINGO-1057:
Assignee: Ramesh Reddy
> Annotations in an Edmx:Reference aren't serialized
> --
>
> Key: OLINGO-1057
> URL: https://issues.apache.org/jira/browse/OLINGO-1057
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Mike Mansell
>Assignee: Ramesh Reddy
>Priority: Minor
>
> According to the CSDL Spec v4.0 section 3.3, it's valid to have annotations
> within an Edmx:Reference element. The underlying EdmxReference Java class
> does support setting an CsdlAnnotation. However, the
> MetadataDocumentXmlSerializer does not write them out.
> {code:title=Test.java|borderstyle=solid}
> EdmxReference ref = new EdmxReference(new
> URI("http://docs.oasis-open.org/odata/odata/v4.0/errata03/os/complete/vocabularies/Org.OData.Core.V1.xml";));
> ref.addInclude(new EdmxReferenceInclude("Org.OData.Core.V1", "Core"));
> CsdlAnnotation anno = new CsdlAnnotation();
> anno.setTerm("Core.Description");
> anno.setExpression(new CsdlConstantExpression(ConstantExpressionType.String,
> "Sample Annotation"));
> ref.setAnnotations(Collections.singletonList(anno));
> {code}
> I would expect to see something like:
> {code:title=ExpectedMetaData.xml|borderStyle=solid}
> Uri="http://docs.oasis-open.org/odata/odata/v4.0/errata03/os/complete/vocabularies/Org.OData.Core.V1.xml";>
>
> http://docs.oasis-open.org/odata/ns/edm";
> Term="Core.Description">
> Sample Annotation
>
>
> {code}
> Instead, I just get:
> {code:title=ExpectedMetaData.xml|borderStyle=solid}
> Uri="http://docs.oasis-open.org/odata/odata/v4.0/errata03/os/complete/vocabularies/Org.OData.Core.V1.xml";>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1060) Unable to retrieve a referenced metadata document referenced by Microsoft dynamics metadata document
[
https://issues.apache.org/jira/browse/OLINGO-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967860#comment-15967860
]
Ramesh Reddy commented on OLINGO-1060:
--
[~susharm] Can we close this?
> Unable to retrieve a referenced metadata document referenced by Microsoft
> dynamics metadata document
>
>
> Key: OLINGO-1060
> URL: https://issues.apache.org/jira/browse/OLINGO-1060
> Project: Olingo
> Issue Type: Bug
> Components: odata4-client
>Affects Versions: (Java) V4 4.3.0
>Reporter: Sumit
>
> Below is a sample metadata document as given by a microsoft dynamics instance
> {code}
>
> xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx";>
> Uri="http://vocabularies.odata.org/OData.Community.Keys.V1.xml";>
>
>
>
> Uri="http://vocabularies.odata.org/OData.Community.Display.V1.xml";>
> />
>
>
>
> xmlns="http://docs.oasis-open.org/odata/ns/edm";>
>
>
>
>
> {code}
> The referenced metadata document
> http://vocabularies.odata.org/OData.Community.Keys.V1.xml has 'Content-Type'
> header set to "text/xml" in response. But olingo's
> AbstractMetadataRequestImpl[0] sets 'Accept' header to "application/xml" in
> the request for fetching the metadata document. As a result we get 406
> response code (since the accept header does not contain the type as specified
> in the respone.
> Should "text/html" be added to Accept header of metadata request ? (I have
> tried and tested this solution)
> [0] -
> https://github.com/apache/olingo-odata4/blob/8515b48dd5e09e4597d0b396326bd6a074efa1f5/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/retrieve/AbstractMetadataRequestImpl.java#L32
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1062) Cannot consume Odata Reference Services with Annotations
[
https://issues.apache.org/jira/browse/OLINGO-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967854#comment-15967854
]
Ramesh Reddy commented on OLINGO-1062:
--
[~RalfHandl] when "odata.core" libraries are not defined in $metadata as
References, does spec any way imply to have these annotations are available
implicitly?
> Cannot consume Odata Reference Services with Annotations
>
>
> Key: OLINGO-1062
> URL: https://issues.apache.org/jira/browse/OLINGO-1062
> Project: Olingo
> Issue Type: Bug
> Components: odata4-client
>Affects Versions: (Java) V4 4.3.0
>Reporter: Lars Laegner
>
> The http://services.odata.org/TripPinRESTierService/ service returns the
> following annotation:
> ...
> EntityType="Microsoft.OData.Service.Sample.TrippinInMemory.Models.Airline">
>
> Name...
> unfortunately, the used Org.OData.Core.V1 namespace is not referencing
> anywhere an alias or namespace in the schema.
> This results, when retrieving the code with the latest available OData V4 Lib
> for Java, in the EdmAnnotationClass Code
> public EdmTerm getTerm() {
> if (term == null) {
> if (annotation.getTerm() == null) { throw new EdmException("Term must not be
> null for an annotation."); }
> term = edm.getTerm(new FullQualifiedName(annotation.getTerm()));
> }
> return term; }
> that in debugging the
> annotation.getTerm()=="Org.OData.Core.V1.OptimisticConcurrency" but the term
> is then set to null from edm.getTerm() as it seems to check for available
> namespace/aliases in the schema and cannot find one.
> So practically, this annotation does not exist for the currently latest
> Olingo-OData-Client-for-Java-4.3.0
> The same for
> http://services.odata.org/V4/(S(tauqx0n1pg4nytucatnssdwb))/TripPinServiceRW/
> I have cross created this issue in
> https://github.com/OData/odataorg.github.io/issues/117 as i am not sure,
> wether the service is not correct or the client should be more forgiving
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (OLINGO-1071) Getting primitive with 'null' value throws serialization exception.
[
https://issues.apache.org/jira/browse/OLINGO-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy resolved OLINGO-1071.
--
Resolution: Not A Problem
Assignee: Ramesh Reddy
> Getting primitive with 'null' value throws serialization exception.
> ---
>
> Key: OLINGO-1071
> URL: https://issues.apache.org/jira/browse/OLINGO-1071
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Ruslan Didyk
>Assignee: Ramesh Reddy
>
> Do GET request to get primitive property which has 'nul' value:
> Example: http://localhost:8080/OData.svc/author('1')/name
> Actual result: Error is displayed:
> response:
> Status: 400 Bad request
> Body: {"error":null, "message": "The input 'null' is not allowed here."}}
> Expected result:
> response:
> Status: 200 OK
> Body:
> {"@odata.context":"http://http://localhost:8080/OData.svc/$metadata#author('1')/name",
> "@odata.null": true}
> Code place where exception is throwing: ODataJsonSerializer.class - line 850
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OLINGO-1084) Support URI format /localhost:8080/redfish/v1/StorageSystems/
[ https://issues.apache.org/jira/browse/OLINGO-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Reddy updated OLINGO-1084: - Labels: ODATA-4.0.1 (was: ) > Support URI format /localhost:8080/redfish/v1/StorageSystems/ > -- > > Key: OLINGO-1084 > URL: https://issues.apache.org/jira/browse/OLINGO-1084 > Project: Olingo > Issue Type: New Feature > Components: odata4-server >Affects Versions: (Java) V4 4.3.0 >Reporter: Jay Xu > Labels: ODATA-4.0.1 > > I am using Olingo library to support Swordfish and Redfish specification > designed by DMTF and SNIA, In the specification, it is defined the URI format > to support both "/redfish/v1/StorageServices/1/Volumes/4/Metrics" and "GET > /redfish/v1/StorageServices(1)/Volumes(4)/Metrics". is there any plan to > support it? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (OLINGO-1089) AtomDeserializer does not handle multi-line values correctly
[ https://issues.apache.org/jira/browse/OLINGO-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Reddy resolved OLINGO-1089. -- Resolution: Not A Problem Assignee: Ramesh Reddy > AtomDeserializer does not handle multi-line values correctly > > > Key: OLINGO-1089 > URL: https://issues.apache.org/jira/browse/OLINGO-1089 > Project: Olingo > Issue Type: Bug > Components: odata4-client >Affects Versions: (Java) V4 4.0.0 >Reporter: Torgil Zethson >Assignee: Ramesh Reddy > Attachments: pam_test_metadata, pam_test_payload.xml > > > We are receiving an OData4 atom payload from a customer, where the value of > one of the fields contain multiple line breaks. (See attachment.) The field > is of type Edm.String. The value that comes out of the olingo > deserialization, however, only has the two last lines of the value. > The field in the payload looks like so: > 1 > 2 > 3 > 4 > 5 > 6 > 7 > 8 > 9 > 10 > 11 > 12 > What comes out of the deserialization is > "11 > 12" > I believe the problem is in AtomDeserializer, in the method fromPrimitive(). > There is a while-loop there, that loops until the end of the property has > been read. However, only the value of the last chunk is retained. In our > case, the StAX parser delivers the character data of this fields two lines at > a time. As a result, the end result contains only the last two lines of the > value. > As far as I can tell, the payload follows the OData4 Atom standard as defined > here: > http://docs.oasis-open.org/odata/odata-atom-format/v4.0/odata-atom-format-v4.0.html > The standard also has an example that explicitly mentions line breaks, > "Example 8" here: > http://docs.oasis-open.org/odata/odata-atom-format/v4.0/cs02/odata-atom-format-v4.0-cs02.html#_Toc372792712 > I'm attaching the payload in question, as well as the metadata for the entity. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967821#comment-15967821
]
Ramesh Reddy edited comment on OLINGO-1107 at 4/13/17 4:21 PM:
---
[~chrisam] or [~mirbo] are you guys OK if we changes this to
https://github.com/rareddy/olingo-odata4/commit/41038bf162173d9a7d9044061a164314e3fc2861
was (Author: rareddy):
[~chrisam] or [~mibo] are you guys OK if we changes this to
https://github.com/rareddy/olingo-odata4/commit/41038bf162173d9a7d9044061a164314e3fc2861
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967821#comment-15967821
]
Ramesh Reddy commented on OLINGO-1107:
--
[~chrisam] or [~mibo] are you guys OK if we changes this to
https://github.com/rareddy/olingo-odata4/commit/41038bf162173d9a7d9044061a164314e3fc2861
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967712#comment-15967712
]
Ramesh Reddy commented on OLINGO-1107:
--
Ah! That seems legitimate :)
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1107) UriDecoder should use java.net.URLDecoder
[
https://issues.apache.org/jira/browse/OLINGO-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967706#comment-15967706
]
Jon McEwen commented on OLINGO-1107:
In that case, the bug is in the client:
https://github.com/apache/olingo-odata4/blob/8515b48dd5e09e4597d0b396326bd6a074efa1f5/lib/client-core/src/main/java/org/apache/olingo/client/core/uri/URIUtils.java#L27
> UriDecoder should use java.net.URLDecoder
> -
>
> Key: OLINGO-1107
> URL: https://issues.apache.org/jira/browse/OLINGO-1107
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> Query filters are incorrectly parsed, because the
> org.apache.olingo.commons.core.Decoder doesn't convert '+' to space.
> Simple fix is to use java.net.URLDecoder instead (line 85):
> {{return URLDecoder.decode(encoded, "UTF-8");}}
> Additional unit test:
> {code:Java}
> @Test
> public void decodePlusAsSpace() throws Exception{
> checkOption("%24filter=PaymentStatus+eq+%27Cleared%27", "$filter",
> "PaymentStatus eq 'Cleared'");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (OLINGO-1008) Metadata Parser is unable to parse external references of Microsoft dynamics CRM Odata metadata
[
https://issues.apache.org/jira/browse/OLINGO-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy resolved OLINGO-1008.
--
Resolution: Fixed
Assignee: Ramesh Reddy
Fix Version/s: (Java) V4 4.4.0
I modified your commit to not remove the method, but provide no-op method as
similar check in the {{super.checkRequest}} which would have called when the
derived class method is not existed.
I really do wish the solution is broadened where the ReferenceResolver is
presented to avoid cross-site calls to load the metadata all the time, but the
Olingo client code has so many wrappers, it will surely break some API.
Although I encourage someone to provide a patch to it.
> Metadata Parser is unable to parse external references of Microsoft dynamics
> CRM Odata metadata
> ---
>
> Key: OLINGO-1008
> URL: https://issues.apache.org/jira/browse/OLINGO-1008
> Project: Olingo
> Issue Type: Bug
> Components: odata4-client
>Affects Versions: (Java) V4 4.2.0
>Reporter: Prashant Singh
>Assignee: Ramesh Reddy
> Fix For: (Java) V4 4.4.0
>
> Attachments:
> 0001-OLINGO-1008-Removing-the-restriction-of-referenced-d.patch
>
>
> I am currently using Apache olingo 4.2.0 and facing issue while accessing the
> microsoft CRM metadata and getting following exception:
> java.lang.IllegalArgumentException: The referenced EDMX document has the URI
> 'http://vocabularies.odata.org/OData.Community.Keys.V1.xml' where scheme,
> host, or port is different from the main metadata document URI
> 'https://crmonlinebcone.crm8.dynamics.com/api/data/v8.1/$metadata'.
> at
> org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.checkRequest(XMLMetadataRequestImpl.java:154)
> at
> org.apache.olingo.client.core.communication.request.AbstractODataRequest.doExecute(AbstractODataRequest.java:271)
> at
> org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.execute(XMLMetadataRequestImpl.java:164)
> at
> org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:74)
> at
> org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:40)
> at
> org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.getPrivateResponse(EdmMetadataRequestImpl.java:58)
> at
> org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:72)
> at
> org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:35)
> at com.bcone.apache.plingo.odata.TestOData.main(TestOData.java:40)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1104) NavigationLink missing from JSON with expand and metadata=full
[
https://issues.apache.org/jira/browse/OLINGO-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967671#comment-15967671
]
Jon McEwen commented on OLINGO-1104:
Your fix looks good. Thanks!
> NavigationLink missing from JSON with expand and metadata=full
> --
>
> Key: OLINGO-1104
> URL: https://issues.apache.org/jira/browse/OLINGO-1104
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>Assignee: Ramesh Reddy
> Fix For: (Java) V4 4.4.0
>
>
> When a client request is like
> {{http://server/service/Entities?$expand=Children}}
> with header
> {{Accept: application/json;odata.metadata=full}}
> then the response should include in each Entity a navigationLink
> corresponding to the Children, as described here:
> http://docs.oasis-open.org/odata/odata-json-format/v4.0/errata03/os/odata-json-format-v4.0-errata03-os-complete.html#_Toc453766637
> e.g.
> {{"Items@odata.navigationLink" :
> "http://server/service/Entities(123)/Children"}}
> Suggested fix:
> https://github.com/apache/olingo-odata4/pull/17
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (OLINGO-1104) NavigationLink missing from JSON with expand and metadata=full
[
https://issues.apache.org/jira/browse/OLINGO-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ramesh Reddy resolved OLINGO-1104.
--
Resolution: Fixed
Assignee: Ramesh Reddy
Fix Version/s: (Java) V4 4.4.0
You are saying that when there is a explicit "expand" then the annotation is
not present. I see that, I made required changes. I broadened your patch to
include all the navigation properties in the entity, not just the ones expanded.
See
https://github.com/apache/olingo-odata4/commit/3a8cbcc337577a1cf56cf77383d62edcf2fea857
Thank you for caching this!!!
> NavigationLink missing from JSON with expand and metadata=full
> --
>
> Key: OLINGO-1104
> URL: https://issues.apache.org/jira/browse/OLINGO-1104
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>Assignee: Ramesh Reddy
> Fix For: (Java) V4 4.4.0
>
>
> When a client request is like
> {{http://server/service/Entities?$expand=Children}}
> with header
> {{Accept: application/json;odata.metadata=full}}
> then the response should include in each Entity a navigationLink
> corresponding to the Children, as described here:
> http://docs.oasis-open.org/odata/odata-json-format/v4.0/errata03/os/odata-json-format-v4.0-errata03-os-complete.html#_Toc453766637
> e.g.
> {{"Items@odata.navigationLink" :
> "http://server/service/Entities(123)/Children"}}
> Suggested fix:
> https://github.com/apache/olingo-odata4/pull/17
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OLINGO-1104) NavigationLink missing from JSON with expand and metadata=full
[
https://issues.apache.org/jira/browse/OLINGO-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967543#comment-15967543
]
Jon McEwen commented on OLINGO-1104:
That code is not hit, because the code path is through the preceding {{if}}
block, due to the $expand
> NavigationLink missing from JSON with expand and metadata=full
> --
>
> Key: OLINGO-1104
> URL: https://issues.apache.org/jira/browse/OLINGO-1104
> Project: Olingo
> Issue Type: Bug
> Components: odata4-server
>Affects Versions: (Java) V4 4.3.0
>Reporter: Jon McEwen
>
> When a client request is like
> {{http://server/service/Entities?$expand=Children}}
> with header
> {{Accept: application/json;odata.metadata=full}}
> then the response should include in each Entity a navigationLink
> corresponding to the Children, as described here:
> http://docs.oasis-open.org/odata/odata-json-format/v4.0/errata03/os/odata-json-format-v4.0-errata03-os-complete.html#_Toc453766637
> e.g.
> {{"Items@odata.navigationLink" :
> "http://server/service/Entities(123)/Children"}}
> Suggested fix:
> https://github.com/apache/olingo-odata4/pull/17
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (OLINGO-1008) Metadata Parser is unable to parse external references of Microsoft dynamics CRM Odata metadata
[ https://issues.apache.org/jira/browse/OLINGO-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967400#comment-15967400 ] Sumit edited comment on OLINGO-1008 at 4/13/17 10:52 AM: - Added Patch file for the fix was (Author: susharm): Patch file for the fix > Metadata Parser is unable to parse external references of Microsoft dynamics > CRM Odata metadata > --- > > Key: OLINGO-1008 > URL: https://issues.apache.org/jira/browse/OLINGO-1008 > Project: Olingo > Issue Type: Bug > Components: odata4-client >Affects Versions: (Java) V4 4.2.0 >Reporter: Prashant Singh > Attachments: > 0001-OLINGO-1008-Removing-the-restriction-of-referenced-d.patch > > > I am currently using Apache olingo 4.2.0 and facing issue while accessing the > microsoft CRM metadata and getting following exception: > java.lang.IllegalArgumentException: The referenced EDMX document has the URI > 'http://vocabularies.odata.org/OData.Community.Keys.V1.xml' where scheme, > host, or port is different from the main metadata document URI > 'https://crmonlinebcone.crm8.dynamics.com/api/data/v8.1/$metadata'. > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.checkRequest(XMLMetadataRequestImpl.java:154) > at > org.apache.olingo.client.core.communication.request.AbstractODataRequest.doExecute(AbstractODataRequest.java:271) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.execute(XMLMetadataRequestImpl.java:164) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:74) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:40) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.getPrivateResponse(EdmMetadataRequestImpl.java:58) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:72) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:35) > at com.bcone.apache.plingo.odata.TestOData.main(TestOData.java:40) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OLINGO-1008) Metadata Parser is unable to parse external references of Microsoft dynamics CRM Odata metadata
[ https://issues.apache.org/jira/browse/OLINGO-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit updated OLINGO-1008: -- Attachment: 0001-OLINGO-1008-Removing-the-restriction-of-referenced-d.patch Patch file for the fix > Metadata Parser is unable to parse external references of Microsoft dynamics > CRM Odata metadata > --- > > Key: OLINGO-1008 > URL: https://issues.apache.org/jira/browse/OLINGO-1008 > Project: Olingo > Issue Type: Bug > Components: odata4-client >Affects Versions: (Java) V4 4.2.0 >Reporter: Prashant Singh > Attachments: > 0001-OLINGO-1008-Removing-the-restriction-of-referenced-d.patch > > > I am currently using Apache olingo 4.2.0 and facing issue while accessing the > microsoft CRM metadata and getting following exception: > java.lang.IllegalArgumentException: The referenced EDMX document has the URI > 'http://vocabularies.odata.org/OData.Community.Keys.V1.xml' where scheme, > host, or port is different from the main metadata document URI > 'https://crmonlinebcone.crm8.dynamics.com/api/data/v8.1/$metadata'. > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.checkRequest(XMLMetadataRequestImpl.java:154) > at > org.apache.olingo.client.core.communication.request.AbstractODataRequest.doExecute(AbstractODataRequest.java:271) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl$SingleXMLMetadatRequestImpl.execute(XMLMetadataRequestImpl.java:164) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:74) > at > org.apache.olingo.client.core.communication.request.retrieve.XMLMetadataRequestImpl.execute(XMLMetadataRequestImpl.java:40) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.getPrivateResponse(EdmMetadataRequestImpl.java:58) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:72) > at > org.apache.olingo.client.core.communication.request.retrieve.EdmMetadataRequestImpl.execute(EdmMetadataRequestImpl.java:35) > at com.bcone.apache.plingo.odata.TestOData.main(TestOData.java:40) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OLINGO-1110) REPLACE method is not supported at Odata V2
Victor created OLINGO-1110: -- Summary: REPLACE method is not supported at Odata V2 Key: OLINGO-1110 URL: https://issues.apache.org/jira/browse/OLINGO-1110 Project: Olingo Issue Type: Bug Affects Versions: V2 2.0.8, V2 2.0.7, V2 2.0.6 Reporter: Victor Folks, I have not found REPLACE method support. According to "Filter System Query Option" http://www.odata.org/documentation/odata-version-2-0/uri-conventions/#FilterSystemQueryOption replace method is a part of OData V2. See current supported methods list: https://olingo.apache.org/javadoc/odata2/org/apache/olingo/odata2/api/uri/expression/MethodOperator.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
