[jira] [Updated] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonatan Gottesman updated OMID-110:
---
Attachment: omid110.patch
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch, omid110.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-omid issue #43: [OMID-110]
Github user ohadshacham commented on the issue: https://github.com/apache/incubator-omid/pull/43 +1 ---
[GitHub] incubator-omid pull request #43: [OMID-110]
GitHub user yonigottesman opened a pull request: https://github.com/apache/incubator-omid/pull/43 [OMID-110] You can merge this pull request into a Git repository by running: $ git pull https://github.com/yonigottesman/incubator-omid phoenix-integration Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-omid/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit cedfe50ed15cc407ca7d840a9477afac62aaab24 Author: Yonatan Gottesman Date: 2018-09-04T18:12:19Z omid-110 ---
[GitHub] incubator-omid pull request #42: [OMID-110]
Github user yonigottesman closed the pull request at: https://github.com/apache/incubator-omid/pull/42 ---
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616742#comment-16616742
]
ASF GitHub Bot commented on OMID-110:
-
Github user ohadshacham commented on the issue:
https://github.com/apache/incubator-omid/pull/43
+1
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: September 2018 incubator report
Yonatan Gottesman is the only active contributor that is not committer yet. I will start a vote for new committer shortly. Thanks, Ohad On Thu, Sep 6, 2018 at 8:28 PM, Alan Gates wrote: > I have signed off on the September report, but I added the following > comment: > A criterion for graduation is adding at least one committer to the > project. So I believe "Community building" would be a more accurate > assessment of your podling's maturity. > > It looks like from the report that there is at least one new contributor. > Are there others who might be ready or near ready to be added as > committers? > > Alan. >
[jira] [Assigned] (OMID-109) Unable to build phoenix-integration branch through Jenkins job
[ https://issues.apache.org/jira/browse/OMID-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham reassigned OMID-109: - Assignee: Yonatan Gottesman > Unable to build phoenix-integration branch through Jenkins job > -- > > Key: OMID-109 > URL: https://issues.apache.org/jira/browse/OMID-109 > Project: Apache Omid > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Yonatan Gottesman >Priority: Major > Attachments: OMID-109.patch > > > Based on Jenkins job failures > (https://builds.apache.org/job/Phoenix-omid2/81/), the repo URL in the pom > needs to be updated to > https://raw.githubusercontent.com/synergian/wagon-git/releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OMID-109) Unable to build phoenix-integration branch through Jenkins job
[ https://issues.apache.org/jira/browse/OMID-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham updated OMID-109: -- Issue Type: Sub-task (was: Bug) Parent: OMID-82 > Unable to build phoenix-integration branch through Jenkins job > -- > > Key: OMID-109 > URL: https://issues.apache.org/jira/browse/OMID-109 > Project: Apache Omid > Issue Type: Sub-task >Reporter: James Taylor >Priority: Major > Attachments: OMID-109.patch > > > Based on Jenkins job failures > (https://builds.apache.org/job/Phoenix-omid2/81/), the repo URL in the pom > needs to be updated to > https://raw.githubusercontent.com/synergian/wagon-git/releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ohad Shacham updated OMID-110:
--
Issue Type: Sub-task (was: Improvement)
Parent: OMID-82
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616631#comment-16616631
]
ASF GitHub Bot commented on OMID-110:
-
GitHub user yonigottesman opened a pull request:
https://github.com/apache/incubator-omid/pull/43
[OMID-110]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yonigottesman/incubator-omid
phoenix-integration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
commit cedfe50ed15cc407ca7d840a9477afac62aaab24
Author: Yonatan Gottesman
Date: 2018-09-04T18:12:19Z
omid-110
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OMID-107) Replace pre 1.0 deprecated HBase APIs
[ https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616630#comment-16616630 ] Ohad Shacham commented on OMID-107: --- You are right [~jamestaylor]. However, the current changes are only for Phoenix support, therefore, if Phoenix does not support 0.98 then I assume that we also don't need the latest changes in Omid to support 0.98. Therefore, if someone needs 0.98 then it should use Omid 0.9.0 because the latest changes are irrelevant for him. Do you agree? I committed your patch to let Yoni rebase OMID-110. > Replace pre 1.0 deprecated HBase APIs > - > > Key: OMID-107 > URL: https://issues.apache.org/jira/browse/OMID-107 > Project: Apache Omid > Issue Type: Sub-task >Reporter: James Taylor >Priority: Major > Attachments: OMID-107.patch, OMID-107_v2.patch > > > In HBase 2.0, the HTableInterface has been replaced with the Table interface. > Thus, in Omid, this same replacement should take place. This will mostly be > isolated to having TTable implement Table instead of HTableInterface. This > will be required to check-in Omid support in Phoenix, since Phoenix 5.x is > based on HBase 2.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OMID-110) Support HBase 2.0
[
https://issues.apache.org/jira/browse/OMID-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616629#comment-16616629
]
ASF GitHub Bot commented on OMID-110:
-
Github user yonigottesman closed the pull request at:
https://github.com/apache/incubator-omid/pull/42
> Support HBase 2.0
> -
>
> Key: OMID-110
> URL: https://issues.apache.org/jira/browse/OMID-110
> Project: Apache Omid
> Issue Type: Improvement
>Reporter: James Taylor
>Assignee: Yonatan Gottesman
>Priority: Major
> Attachments: 0001-omid-110.patch, OMID-110_wip1.patch
>
>
> Once OMID-107 is committed (which replaced all deprecated methods), the only
> things I've identified that need to change are:
> * Instantiation of CellComparator should be done through HBaseShims since
> it's different between HBase 1.x and 2.x. In HBase 2.0, CellComparator was
> changed to an interface. Another alternative would be to write our own
> CellComparator.
> {code:java}
> public static SortedMap>
> mapCellsToShadowCells(List cells) {
> // Move CellComparator to HBaseSims for 2.0 support
> // Need to access through CellComparatorImpl.COMPARATOR
> SortedMap> cellToShadowCellMap
> = new TreeMap>(new CellComparator());{code}
> The HBase 2.0 version would use CellComparatorImpl.COMPARATOR instead of
> instantiating a CellComparator.
> * Add createTable method to HBaseShims. Instead of HTableDescriptor, HBase
> 2.0 uses TableDescriptor and TableDescriptorBuilder.
> [~chrajeshbab...@gmail.com] and [~an...@apache.org] - do you know why
> existing admin.createTable(HTableDescriptor) wouldn't work? HTableDescriptor
> implements TableDescriptor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OMID-111) Apache Incubator report - September 2018
[ https://issues.apache.org/jira/browse/OMID-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham resolved OMID-111. --- Resolution: Fixed > Apache Incubator report - September 2018 > > > Key: OMID-111 > URL: https://issues.apache.org/jira/browse/OMID-111 > Project: Apache Omid > Issue Type: Task >Reporter: Ohad Shacham >Assignee: Ohad Shacham >Priority: Major > > Provide a report for June 1, 2018 - August 31, 2018 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OMID-111) Apache Incubator report - September 2018
[ https://issues.apache.org/jira/browse/OMID-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham closed OMID-111. - > Apache Incubator report - September 2018 > > > Key: OMID-111 > URL: https://issues.apache.org/jira/browse/OMID-111 > Project: Apache Omid > Issue Type: Task >Reporter: Ohad Shacham >Assignee: Ohad Shacham >Priority: Major > > Provide a report for June 1, 2018 - August 31, 2018 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
