Review Request: Drop Spring logging levels from WARNING to SEVERE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/ --- Review request for oodt and brian Foster. Summary --- Drop Spring logging levels from WARNING to SEVERE This addresses issue OODT-408: https://issues.apache.org/jira/browse/OODT-408 Diffs - /trunk/catalog/src/main/resources/logging.properties 1300513 /trunk/crawler/src/main/resources/logging.properties 1300513 /trunk/filemgr/src/main/resources/logging.properties 1300513 /trunk/resource/src/main/resources/logging.properties 1300513 /trunk/workflow/src/main/resources/logging.properties 1300513 Diff: https://reviews.apache.org/r/4342/diff Testing --- Thanks, Thomas
Re: Review Request: Drop Spring logging levels from WARNING to SEVERE
On 2012-03-14 15:57:26, Paul Ramirez wrote: Looks good to me. Next time you can link this to the Jira issue if you want by putting the OODT-408 in the bugs field in the review request. +1! Also feel free to add me, or pramirez and rickdn as we all seem to be using RB too. It rox! - Chris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/#review5942 --- On 2012-03-14 13:33:35, Thomas Bennett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/ --- (Updated 2012-03-14 13:33:35) Review request for oodt and brian Foster. Summary --- Drop Spring logging levels from WARNING to SEVERE This addresses issue OODT-408: https://issues.apache.org/jira/browse/OODT-408 Diffs - /trunk/catalog/src/main/resources/logging.properties 1300513 /trunk/crawler/src/main/resources/logging.properties 1300513 /trunk/filemgr/src/main/resources/logging.properties 1300513 /trunk/resource/src/main/resources/logging.properties 1300513 /trunk/workflow/src/main/resources/logging.properties 1300513 Diff: https://reviews.apache.org/r/4342/diff Testing --- Thanks, Thomas
Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/#review5959 --- trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java https://reviews.apache.org/r/4326/#comment12928 What a fantastic way of supporting this! - Chris On 2012-03-14 05:18:33, brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/ --- (Updated 2012-03-14 05:18:33) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- The enum for met keys will allow for backwards compatibility to be toggled on/off easily This addresses bug OODT-409. https://issues.apache.org/jira/browse/OODT-409 Diffs - trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION Diff: https://reviews.apache.org/r/4326/diff Testing --- Added/Updated Unit-Tests Thanks, brian
Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/#review5960 --- Ship it! LGTM! - Chris On 2012-03-14 05:18:33, brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/ --- (Updated 2012-03-14 05:18:33) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- The enum for met keys will allow for backwards compatibility to be toggled on/off easily This addresses bug OODT-409. https://issues.apache.org/jira/browse/OODT-409 Diffs - trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java PRE-CREATION trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java 1300432 trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java PRE-CREATION trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java PRE-CREATION Diff: https://reviews.apache.org/r/4326/diff Testing --- Added/Updated Unit-Tests Thanks, brian
