Re: Review Request: CAS-Pushpull uniqueMetadataElement is being loaded as empty String instead of null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6301/#review9719 --- Ship it! Ship It! - Chris Mattmann On Aug. 1, 2012, 9:15 p.m., brian Foster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6301/ > --- > > (Updated Aug. 1, 2012, 9:15 p.m.) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Description > --- > > Element.getAttribute returns an empty String instead of NULL when the > attribute doesn't exist... this causes Pushpull to think that the > uniqueMetadataElement is set and thus causes a NullPointerException > > > This addresses bug OODT-481. > https://issues.apache.org/jira/browse/OODT-481 > > > Diffs > - > > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/config/RemoteSpecs.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java > 1366499 > > Diff: https://reviews.apache.org/r/6301/diff/ > > > Testing > --- > > Ran download with config provided by YunHee > > > Thanks, > > brian Foster > >
Re: Review Request: CAS-Pushpull uniqueMetadataElement is being loaded as empty String instead of null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6301/#review9720 --- Ship it! LGTM - Chris Mattmann On Aug. 1, 2012, 9:15 p.m., brian Foster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6301/ > --- > > (Updated Aug. 1, 2012, 9:15 p.m.) > > > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and > Thomas Bennett. > > > Description > --- > > Element.getAttribute returns an empty String instead of NULL when the > attribute doesn't exist... this causes Pushpull to think that the > uniqueMetadataElement is set and thus causes a NullPointerException > > > This addresses bug OODT-481. > https://issues.apache.org/jira/browse/OODT-481 > > > Diffs > - > > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/config/RemoteSpecs.java > 1365306 > > trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java > 1366499 > > Diff: https://reviews.apache.org/r/6301/diff/ > > > Testing > --- > > Ran download with config provided by YunHee > > > Thanks, > > brian Foster > >
