Re: Review Request: Crawler command line bugs

2012-05-04 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4989/#review7564
---



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
https://reviews.apache.org/r/4989/#comment16751

Interesting, so this has to be expanded out -- was this because of the 
Spring API here and the way that you set these types of properties?



trunk/crawler/src/main/resources/cmd-line-options.xml
https://reviews.apache.org/r/4989/#comment16752

Hey Tom, nothing to do with you here, but (maybe for bfost) -- why did this 
action name change to TriggerPostIngestWorkflow?


- Chris


On 2012-05-03 12:03:13, Thomas Bennett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/4989/
 ---
 
 (Updated 2012-05-03 12:03:13)
 
 
 Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
 Sheryl John.
 
 
 Summary
 ---
 
 1) In handleOption(), test for multiple options and handle appropriately.
 
 2) Set the value for Unique.filemgrUlr in filemgrUrl bean.
 
 3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be 
 TriggerPostIngestWorkflow.workflowMgrUrl
 
 
 This addresses bug OODT-454.
 https://issues.apache.org/jira/browse/OODT-454
 
 
 Diffs
 -
 
   trunk/crawler/src/main/resources/cmd-line-options.xml 1332980 
   
 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
  1305264 
 
 Diff: https://reviews.apache.org/r/4989/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Thomas
 




Re: Review Request: Crawler command line bugs

2012-05-04 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4989/#review7565
---

Ship it!


LGTM.

- Chris


On 2012-05-03 12:03:13, Thomas Bennett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/4989/
 ---
 
 (Updated 2012-05-03 12:03:13)
 
 
 Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
 Sheryl John.
 
 
 Summary
 ---
 
 1) In handleOption(), test for multiple options and handle appropriately.
 
 2) Set the value for Unique.filemgrUlr in filemgrUrl bean.
 
 3) UpdateWorkflowStatusToIngest.workflowMgrUrl should be 
 TriggerPostIngestWorkflow.workflowMgrUrl
 
 
 This addresses bug OODT-454.
 https://issues.apache.org/jira/browse/OODT-454
 
 
 Diffs
 -
 
   trunk/crawler/src/main/resources/cmd-line-options.xml 1332980 
   
 trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
  1305264 
 
 Diff: https://reviews.apache.org/r/4989/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Thomas