Re: Review Request: XMLPS should provided ordered results based on requested fields

2013-02-14 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9438/
---

(Updated Feb. 14, 2013, 3:50 p.m.)


Review request for oodt.


Changes
---

Unit tests pass. Tested on sample EDRN dataset. Seems to work fine.


Description
---

Patch augments CDEResult with an ordering of the fields, and then uses that and 
a few other functions to make sure that the result row is populated in order, 
pulling from dyn, and const fields where needed.


This addresses bug OODT-564.
https://issues.apache.org/jira/browse/OODT-564


Diffs (updated)
-

  
./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java
 1444629 
  ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 
1444629 

Diff: https://reviews.apache.org/r/9438/diff/


Testing
---

none yet.


Thanks,

Chris Mattmann



Re: Review Request: XMLPS should provided ordered results based on requested fields

2013-02-14 Thread Michael Joyce

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9438/#review16585
---

Ship it!


Ship It!

- Michael Joyce


On Feb. 14, 2013, 3:50 p.m., Chris Mattmann wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/9438/
 ---
 
 (Updated Feb. 14, 2013, 3:50 p.m.)
 
 
 Review request for oodt.
 
 
 Description
 ---
 
 Patch augments CDEResult with an ordering of the fields, and then uses that 
 and a few other functions to make sure that the result row is populated in 
 order, pulling from dyn, and const fields where needed.
 
 
 This addresses bug OODT-564.
 https://issues.apache.org/jira/browse/OODT-564
 
 
 Diffs
 -
 
   
 ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java
  1444629 
   ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 
 1444629 
 
 Diff: https://reviews.apache.org/r/9438/diff/
 
 
 Testing
 ---
 
 none yet.
 
 
 Thanks,
 
 Chris Mattmann
 




Re: Review Request: XMLPS should provided ordered results based on requested fields

2013-02-14 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9438/#review16586
---

Ship it!


Ship It!

- Chris Mattmann


On Feb. 14, 2013, 3:50 p.m., Chris Mattmann wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/9438/
 ---
 
 (Updated Feb. 14, 2013, 3:50 p.m.)
 
 
 Review request for oodt.
 
 
 Description
 ---
 
 Patch augments CDEResult with an ordering of the fields, and then uses that 
 and a few other functions to make sure that the result row is populated in 
 order, pulling from dyn, and const fields where needed.
 
 
 This addresses bug OODT-564.
 https://issues.apache.org/jira/browse/OODT-564
 
 
 Diffs
 -
 
   
 ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java
  1444629 
   ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 
 1444629 
 
 Diff: https://reviews.apache.org/r/9438/diff/
 
 
 Testing
 ---
 
 none yet.
 
 
 Thanks,
 
 Chris Mattmann