Re: Review Request: CAS-CLI CmdLineAction modification to take a printer which CmdLineActions should print output messages to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/#review3448 --- Ship it! +1 - Paul On 2011-11-17 09:21:33, brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/ --- (Updated 2011-11-17 09:21:33) Review request for oodt and Chris Mattmann. Summary --- issue tracked here: https://issues.apache.org/jira/browse/OODT-349 Diffs - trunk/CHANGES.txt 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineUtility.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/CmdLineAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/PrintMessageAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/CmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/StdCmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/CmdLinePrinter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/StdCmdLinePrinter.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/action/store/spring/TestSpringCmdLineActionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToActionHandler.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/store/spring/TestSpringCmdLineOptionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestSetContextInjectTypeAction.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestUtils.java 1203120 trunk/cli/src/testdata/cmd-line-options.xml 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeToQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetExecNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetJobInfoCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeByIdCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeLoadCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesInQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesWithNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/KillCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeFromQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SetNodeCapacityCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SubmitJobCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/DynWorkflowCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetConditionByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetRegisteredEventsCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskWallClockTimeCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWallClockTimeCliAction.java 1203120
Re: Review Request: CAS-CLI CmdLineAction modification to take a printer which CmdLineActions should print output messages to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/#review3351 --- Ship it! Super +1. - Chris On 2011-11-17 09:21:33, brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/ --- (Updated 2011-11-17 09:21:33) Review request for oodt and Chris Mattmann. Summary --- issue tracked here: https://issues.apache.org/jira/browse/OODT-349 Diffs - trunk/CHANGES.txt 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineUtility.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/CmdLineAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/PrintMessageAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/CmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/StdCmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/CmdLinePrinter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/StdCmdLinePrinter.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/action/store/spring/TestSpringCmdLineActionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToActionHandler.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/store/spring/TestSpringCmdLineOptionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestSetContextInjectTypeAction.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestUtils.java 1203120 trunk/cli/src/testdata/cmd-line-options.xml 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeToQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetExecNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetJobInfoCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeByIdCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeLoadCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesInQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesWithNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/KillCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeFromQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SetNodeCapacityCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SubmitJobCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/DynWorkflowCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetConditionByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetRegisteredEventsCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskWallClockTimeCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWallClockTimeCliAction.java 1203120
Review Request: CAS-CLI CmdLineAction modification to take a printer which CmdLineActions should print output messages to
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/ --- Review request for oodt and Chris Mattmann. Summary --- issue tracked here: https://issues.apache.org/jira/browse/OODT-349 Diffs - trunk/CHANGES.txt 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineUtility.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/CmdLineAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/PrintMessageAction.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/CmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/presenter/StdCmdLinePresenter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/CmdLinePrinter.java 1203120 trunk/cli/src/main/java/org/apache/oodt/cas/cli/printer/StdCmdLinePrinter.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/action/store/spring/TestSpringCmdLineActionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToActionHandler.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/option/store/spring/TestSpringCmdLineOptionStore.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestSetContextInjectTypeAction.java 1203120 trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestUtils.java 1203120 trunk/cli/src/testdata/cmd-line-options.xml 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddNodeToQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/AddQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetExecNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetJobInfoCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeByIdCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodeLoadCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetNodesInQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/GetQueuesWithNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/KillCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveNodeFromQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/RemoveQueueCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SetNodeCapacityCliAction.java 1203120 trunk/resource/src/main/java/org/apache/oodt/cas/resource/cli/action/SubmitJobCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/DynWorkflowCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetConditionByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetRegisteredEventsCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetTaskWallClockTimeCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWallClockTimeCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowByIdCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstMetCliAction.java 1203120 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstsCliAction.java 1203120
