Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

[brian Foster]

> On 2012-03-14 16:05:06, Paul Ramirez wrote:
> > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java,
> >  line 47
> > 
> >
> > shouldn't this be:
> > 
> > return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ? 
> > legacyName : name;
> > 
> >

hey paul... i think you are think of Boolean.parseBoolean(String)... here is 
the javadoc on: Boolean.getBoolean(String):

Returns true if and only if the system property named by the argument exists 
and is equal to the string "true". (Beginning with version 1.0.2 of the JavaTM 
platform, the test of this string is case insensitive.) A system property is 
accessible through getProperty, a method defined by the System class.
If there is no property with the specified name, or if the specified name is 
empty or null, then false is returned.


- brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
---


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> ---
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> The enum for met keys will allow for backwards compatibility to be toggled 
> on/off easily
> 
> 
> This addresses bug OODT-409.
> https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
>  1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
> PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> ---
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

[Paul Ramirez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
---

Ship it!


That was the only change I saw. Otherwise looks good.


trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java


shouldn't this be:

return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ? 
legacyName : name;




- Paul


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> ---
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> The enum for met keys will allow for backwards compatibility to be toggled 
> on/off easily
> 
> 
> This addresses bug OODT-409.
> https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
>  1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
> PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> ---
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5960
---

Ship it!


LGTM!

- Chris


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> ---
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> The enum for met keys will allow for backwards compatibility to be toggled 
> on/off easily
> 
> 
> This addresses bug OODT-409.
> https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
>  1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
> PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> ---
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5959
---



trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java


What a fantastic way of supporting this!


- Chris


On 2012-03-14 05:18:33, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4326/
> ---
> 
> (Updated 2012-03-14 05:18:33)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Summary
> ---
> 
> The enum for met keys will allow for backwards compatibility to be toggled 
> on/off easily
> 
> 
> This addresses bug OODT-409.
> https://issues.apache.org/jira/browse/OODT-409
> 
> 
> Diffs
> -
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 
> 1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
>  1300432 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
> PRE-CREATION 
>   
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
>  1300432 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
> PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4326/diff
> 
> 
> Testing
> ---
> 
> Added/Updated Unit-Tests
> 
> 
> Thanks,
> 
> brian
> 
>

Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/
---

Review request for oodt, Chris Mattmann and Paul Ramirez.


Summary
---

The enum for met keys will allow for backwards compatibility to be toggled 
on/off easily


This addresses bug OODT-409.
https://issues.apache.org/jira/browse/OODT-409


Diffs
-

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1300432 
  
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
 1300432 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 
PRE-CREATION 
  
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
 1300432 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java 
PRE-CREATION 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1300432 
  trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/4326/diff


Testing
---

Added/Updated Unit-Tests


Thanks,

brian