Jenkins build is back to normal : oozie-trunk-find-patches-available #153129

2017-03-13 Thread Apache Jenkins Server 
See

Build failed in Jenkins: oozie-trunk-find-patches-available #153128

2017-03-13 Thread Apache Jenkins Server 
See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 2b655d746f7da689f3d99c18b240f4d7ea6bfad9 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2b655d746f7da689f3d99c18b240f4d7ea6bfad9
 > git rev-list 2b655d746f7da689f3d99c18b240f4d7ea6bfad9 # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson8476420414873000701.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:--  0:00:01 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:02 --:--:-- 0  0   
  00 00 0  0  0 --:--:--  0:00:03 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:04 --:--:-- 0  0 0 
   0 00 0  0  0 --:--:--  0:00:05 --:--:-- 0  0 0   
 0 00 0  0  0 --:--:--  0:00:06 --:--:-- 0  0 0
0 00 0  0  0 --:--:--  0:00:07 --:--:-- 0  0 00 
00 0  0  0 --:--:--  0:00:08 --:--:-- 0  0 00   
  00 0  0  0 --:--:--  0:00:09 --:--:-- 0  0 00 
00 0  0  0 --:--:--  0:00:10 --:--:-- 0  0 00 0 
   0 0  0  0 --:--:--  0:00:11 --:--:-- 0  0 00 0   
 0 0  0  0 --:--:--  0:00:12 --:--:-- 0  0 00 0
0 0  0  0 --:--:--  0:00:13 --:--:-- 0  0 00 00 
0  0  0 --:--:--  0:00:14 --:--:-- 0  0 00 00   
  0  0  0 --:--:--  0:00:15 --:--:-- 0  0 00 00 
0  0  0 --:--:--  0:00:16 --:--:-- 0  0 00 00 0 
 0  0 --:--:--  0:00:17 --:--:-- 0  0 00 00 0   
   0  0 --:--:--  0:00:18 --:--:-- 0  0 00 00 0 
 0  0 --:--:--  0:00:19 --:--:-- 0  0 00 00 0  
0  0 --:--:--  0:00:20 --:--:-- 0  0 00 00 0  0 
 0 --:--:--  0:00:21 --:--:-- 0  0 00 00 0  0   
   0 --:--:--  0:00:22 --:--:-- 0  0 00 00 0  0 
 0 --:--:--  0:00:23 --:--:-- 0  0 00 00 0  0  
0 --:--:--  0:00:24 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:25 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:26 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:27 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:28 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:29 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:30 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:31 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:32 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:33 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:34 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:35 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:36 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:37 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:38 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:39 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:40 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:41 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:42 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:43 -

Re: Review Request 57107: OOZIE-2815 oozie not always display job log

2017-03-13 Thread Purshotam Shah via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57107/
---

(Updated March 14, 2017, 2:03 a.m.)


Review request for oozie.


Bugs: OOZIE-2815
https://issues.apache.org/jira/browse/OOZIE-2815


Repository: oozie-git


Description
---

OOZIE-2815 oozie not always display job log


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/BaseEngine.java 
50df8978773ed54fb5a39bb142d7235de1ed396f 
  core/src/main/java/org/apache/oozie/BundleEngine.java 
d0099b48772069217375c032d171e8dc6b1d 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
2f9f8227f1b2bbb0074cfa19aac37ab9a3fe7c0f 
  core/src/main/java/org/apache/oozie/DagEngine.java 
57d276199de149b294f64570a8878b660e9a5a0c 
  core/src/main/java/org/apache/oozie/service/XLogService.java 
04f04f41403fc6446967524124b8cf86f816d71c 
  core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 
c15c4c1731838655d8f899f9c0405b226f8111b0 
  core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 
97771ad22be84d1a8167c69a6b48b7012652cf8b 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 
d3b468965f33e300d7ca0f31efc596fd969b47a5 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
9356768639e6e3ea548b25baa75d576351fa80e3 
  core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 
b45a96acc397c26cdba8d5c62503013dd572f247 
  core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java 
a676f4d35a49147aadde73357397b211ab829c85 
  core/src/main/java/org/apache/oozie/util/XLogAuditFilter.java 
c377db5df5dd0bbeed77b4d5c88e1c4e2e64a51e 
  core/src/main/java/org/apache/oozie/util/XLogAuditStreamer.java 
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  core/src/main/java/org/apache/oozie/util/XLogErrorStreamer.java 
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
  core/src/main/java/org/apache/oozie/util/XLogFilter.java 
3b49f77e016cbeaedfa03708dbc680e68f40ca16 
  core/src/main/java/org/apache/oozie/util/XLogStreamer.java 
19f1fee55ba8d6c456e798f01e55cfe84cfb5803 
  core/src/main/resources/oozie-default.xml 
95e0c36e1b2f5aef18637f6f956a990ba36166f2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
3eb1016f3ffccaa9db077580b90cc1b3c53fd479 
  core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 
42ffdbeb41e5829cdf814cf13ada331973fc33bd 
  core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java 
bebb678798ec4a01c9710660d4b99fddd5167560 
  core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 
fca8d844f1563da5856eff36f53f21d519630d31 
  core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 
f90f784503e101ae2f96fee52977ee83f3098301 
  
core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java
 ea899faf00aa2f98f43838987c9b716321a50dea 
  core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java 
9e28cbc77129bb2675b92ec9c18c77accfd78a55 
  core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java 
46f273fde7f14b446463448c90f22519761997b6 
  webapp/src/main/webapp/oozie-console.js 
76864a9a06e98357c2d17e35609e2a76afbd595c 


Diff: https://reviews.apache.org/r/57107/diff/2/

Changes: https://reviews.apache.org/r/57107/diff/1-2/


Testing
---


Thanks,

Purshotam Shah

Re: Review Request 57107: OOZIE-2815 oozie not always display job log

2017-03-13 Thread Purshotam Shah via Review Board 


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/BaseEngine.java
> > Line 192 (original), 197-203 (patched)
> > 
> >
> > Code duplication: can you just please use template method pattern?

It's not duplicate code. Each function takes different streamer.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/BaseEngine.java
> > Line 204 (original), 216-221 (patched)
> > 
> >
> > Code duplication: can you just please use template method pattern?

It's not duplicate code. Each function takes different streamer.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/util/XLogFilter.java
> > Lines 302-305 (patched)
> > 
> >
> > This check should come just after `startDate` and `endDate` have both 
> > been set.

Not sure what you mean by this?


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/util/XLogStreamer.java
> > Lines 62-64 (patched)
> > 
> >
> > Since the parameter `logFile` shadows the field `logFile`, and the 
> > field `logFile` has already been set, no effect is taken by that, breaking 
> > the functionality.
> > 
> > Either move that check-and-set back to its original place or remove it 
> > completely.

You are right. Intention was to set this.logFile = "oozie-app.log"; not logFile 
= "oozie-app.log". This is one of the reasons we should avoid the same name for 
global and local variables.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/util/XLogStreamer.java
> > Lines 318-327 (patched)
> > 
> >
> > Parameter `writtenBytes` is not used. Is it intentional? If so, please 
> > rename it, like `byteCountIgnored`.
> > 
> > Moreover, please rename the method to e.g. `checkAndFlush()` to better 
> > reflect what it actually does.

writtenBytes is used. checkAndFlush may not be an appropriate name because the 
function doesn't call flush. It only says should caller flush or not.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/util/XLogStreamer.java
> > Lines 334-335 (patched)
> > 
> >
> > Using `String.format()`, a `StringBuilder` instance, or Guava's 
> > `Objects.toStringHelper()` would be way sexier.

Agree.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/resources/oozie-default.xml
> > Lines 207 (patched)
> > 
> >
> > `oozie.service.XLogStreamingService.audit.buffer.lineCount` would be a 
> > better name.

This is debatbale. In most of the we just replace the type to change to value.


> On March 9, 2017, 1:36 p.m., András Piros wrote:
> > core/src/main/resources/oozie-default.xml
> > Lines 2235 (patched)
> > 
> >
> > `oozie.server.connection.timeout.seconds` would be a better name.

hmmm... Most of are value connection timeouts are set in millisecond like 
oozie.command.default.lock.timeout, oozie.notification.url.connection.timeout.

Setting in seconds is more favorable because we are never going to set it in ms.


- Purshotam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57107/#review168443
---


On March 14, 2017, 2:03 a.m., Purshotam Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57107/
> ---
> 
> (Updated March 14, 2017, 2:03 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2815
> https://issues.apache.org/jira/browse/OOZIE-2815
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2815 oozie not always display job log
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BaseEngine.java 
> 50df8978773ed54fb5a39bb142d7235de1ed396f 
>   core/src/main/java/org/apache/oozie/BundleEngine.java 
> d0099b48772069217375c032d171e8dc6b1d 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 
> 2f9f8227f1b2bbb0074cfa19aac37ab9a3fe7c0f 
>   core/src/main/java/org/apache/oozie/DagEngine.java 
> 57d276199de149b294f64570a8878b660e9a5a0c 
>   core/src/main/java/org/apache/oozie/service/XLogService.java 
> 04

[jira] [Updated] (OOZIE-2812) SparkConfigurationService should support loading configurations from multiple Spark versions

2017-03-13 Thread Peter Cseh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OOZIE-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-2812:
--
Attachment: OOZIE-2812.001.patch

First patch. I'll add some test coverage and test out things on a real cluster 
as our tests don't cover yarn-mode in spark.

> SparkConfigurationService should support loading configurations from multiple 
> Spark versions
> 
>
> Key: OOZIE-2812
> URL: https://issues.apache.org/jira/browse/OOZIE-2812
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Attachments: OOZIE-2812.001.patch
>
>
> Right now SparkConfigruationService serves one Spark configuration set by
> {{oozie.service.SparkConfigurationService.spark.configurations}}
> We cloud improve this to support more versions depending on the name of the 
> sharelib.
> E.g. the property could change to
> oozie.service.SparkConfigurationService..configurations
> This would be backward compatible as the name for the default Spark sharelib 
> is spark while it would be possible to add a sharelib named spark2 or 
> spark2.1 and define itheir configuration via 
> oozie.service.SparkConfigurationService.spark2.configurations and
> oozie.service.SparkConfigurationService.spark2.1.configurations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-2812) SparkConfigurationService should support loading configurations from multiple Spark versions

2017-03-13 Thread Peter Cseh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OOZIE-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh reassigned OOZIE-2812:
-

Assignee: Peter Cseh

> SparkConfigurationService should support loading configurations from multiple 
> Spark versions
> 
>
> Key: OOZIE-2812
> URL: https://issues.apache.org/jira/browse/OOZIE-2812
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Peter Cseh
>Assignee: Peter Cseh
>
> Right now SparkConfigruationService serves one Spark configuration set by
> {{oozie.service.SparkConfigurationService.spark.configurations}}
> We cloud improve this to support more versions depending on the name of the 
> sharelib.
> E.g. the property could change to
> oozie.service.SparkConfigurationService..configurations
> This would be backward compatible as the name for the default Spark sharelib 
> is spark while it would be possible to add a sharelib named spark2 or 
> spark2.1 and define itheir configuration via 
> oozie.service.SparkConfigurationService.spark2.configurations and
> oozie.service.SparkConfigurationService.spark2.1.configurations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging

2017-03-13 Thread Robert Kanter (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922835#comment-15922835
 ] 

Robert Kanter commented on OOZIE-2820:
--

[~lzeke], I think you should be able to attach a file and do most things other 
than assign a JIRA to yourself without being a contributor.  In any case I've 
just made you one, so you should be able to do that now.

> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java: 
> sb.append("  Deamon 
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging

2017-03-13 Thread Grant Sohn (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922712#comment-15922712
 ] 

Grant Sohn commented on OOZIE-2820:
---

[~rkanter], can you add Laszlo to the contributors list?

Thanks,

Grant

> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java: 
> sb.append("  Deamon 
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OOZIE-2820) more spelling errors in exceptions and logging

2017-03-13 Thread Grant Sohn (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906994#comment-15906994
 ] 

Grant Sohn edited comment on OOZIE-2820 at 3/13/17 6:47 PM:


Laszlo,

Thanks for contributing your changes!  However, there is a slight problem with 
fixing all spelling typos in one patch which is this will be difficult to 
backport since all the changes to all these files will be tied together.  For 
that reason, I've limited my changes and JIRAs to user-facing typos (CLI usage, 
logging, exception messages: like OOZIE-2740 for example).  That said, you 
could definitely use this approach for the docs since non-code changes wouldn't 
suffer from this backporting-to-release-branches issue.

You can refer to 
https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute on how to 
create and submit patches.

Thanks,

Grant


was (Author: gsohn):
Lazlo,

Thanks for contributing your changes!  However, there is a slight problem with 
fixing all spelling typos in one patch which is this will be difficult to 
backport since all the changes to all these files will be tied together.  For 
that reason, I've limited my changes and JIRAs to user-facing typos (CLI usage, 
logging, exception messages: like OOZIE-2740 for example).  That said, you 
could definitely use this approach for the docs since non-code changes wouldn't 
suffer from this backporting-to-release-branches issue.

You can refer to 
https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute on how to 
create and submit patches.

Thanks,

Grant

> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java: 
> sb.append("  Deamon 
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2823) hadoop.security.credstore.java-keystore-provider.password-file is ignored by Oozie Sqoop actions when using the password-alias option with a passworded keystore.

2017-03-13 Thread Thomas Scott (JIRA) 
Thomas Scott created OOZIE-2823:
---

 Summary: 
hadoop.security.credstore.java-keystore-provider.password-file is ignored by 
Oozie Sqoop actions when using the password-alias option with a passworded 
keystore.
 Key: OOZIE-2823
 URL: https://issues.apache.org/jira/browse/OOZIE-2823
 Project: Oozie
  Issue Type: Improvement
  Components: action
Reporter: Thomas Scott
Priority: Minor


The --password-alias option in Sqoop allows you to retrieve the password for a 
connection from a keystore. 

As per 
https://hadoop.apache.org/docs/r3.0.0-alpha1/hadoop-project-dist/hadoop-common/CredentialProviderAPI.html
 this keystore can also have a password and this can be stored in a file using 
the hadoop.security.credstore.java-keystore-provider.password-file option

Oozie doesn't currently seem to support this and instead we use the workaround:

 
oozie.launcher.mapred.map.child.env 
HADOOP_CREDSTORE_PASSWORD=`cat some_password_file` 


Oozie Sqoop actions should support the neater  
hadoop.security.credstore.java-keystore-provider.password-file method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57546: OOZIE-2820: Fix typos throughout the codebase

2017-03-13 Thread András Piros 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57546/#review168764
---


Ship it!




Ship It!

- András Piros


On March 13, 2017, 3:15 p.m., Laszlo Zeke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57546/
> ---
> 
> (Updated March 13, 2017, 3:15 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> OOZIE-2820: Fix typos throughout the codebase
> 
> This patch mostly includes small typo fixes in comments
> and simple log strings where the name or comment was 
> clearly wrong.
> 
> The names in the code changed where either a private
> or local name was affected or it was a test name.
> 
> No functionality change was intended in this patch.
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 
> dd9e1c9 
>   
> core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorPhaseOne.java
>  6525125 
>   core/src/main/java/org/apache/oozie/servlet/JVMInfo.java dac199d 
>   core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
> 7631fc9 
>   core/src/main/java/org/apache/oozie/util/db/SqlStatement.java b739da5 
> 
> 
> Diff: https://reviews.apache.org/r/57546/diff/2/
> 
> 
> Testing
> ---
> 
> Build succeeded
> 
> 
> Thanks,
> 
> Laszlo Zeke
> 
>

Re: Review Request 57546: OOZIE-2820: Fix typos throughout the codebase

2017-03-13 Thread Laszlo Zeke 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57546/
---

(Updated March 13, 2017, 3:15 p.m.)


Review request for oozie.


Changes
---

Reduced scope to only user-faced typos.


Repository: oozie-git


Description
---

OOZIE-2820: Fix typos throughout the codebase

This patch mostly includes small typo fixes in comments
and simple log strings where the name or comment was 
clearly wrong.

The names in the code changed where either a private
or local name was affected or it was a test name.

No functionality change was intended in this patch.


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java dd9e1c9 
  
core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorPhaseOne.java
 6525125 
  core/src/main/java/org/apache/oozie/servlet/JVMInfo.java dac199d 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
7631fc9 
  core/src/main/java/org/apache/oozie/util/db/SqlStatement.java b739da5 


Diff: https://reviews.apache.org/r/57546/diff/2/

Changes: https://reviews.apache.org/r/57546/diff/1-2/


Testing
---

Build succeeded


Thanks,

Laszlo Zeke

[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging

2017-03-13 Thread Laszlo Zeke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907318#comment-15907318
 ] 

Laszlo Zeke commented on OOZIE-2820:


Hi [~grant.sohn],

I understand your approach. I'm willing to limit my changes to the things you 
listed. I'm wondering if backporting this particular change beforehand and deal 
with the conflicts sooner rather then when a dependent change is backported 
would make this issue easier.

Anyway, I still can't post patches which makes me wonder if I have to wait 24 
hours after registration to do that or something is not right with my 
permissions.

Thanks,
Laszlo

> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java: 
> sb.append("  Deamon 
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-find-patches-available #153054

2017-03-13 Thread Apache Jenkins Server 
See

Build failed in Jenkins: oozie-trunk-find-patches-available #153053

2017-03-13 Thread Apache Jenkins Server 
See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 2b655d746f7da689f3d99c18b240f4d7ea6bfad9 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2b655d746f7da689f3d99c18b240f4d7ea6bfad9
 > git rev-list 2b655d746f7da689f3d99c18b240f4d7ea6bfad9 # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson8104744870770033930.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:--  0:00:01 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:02 --:--:-- 0  0   
  00 00 0  0  0 --:--:--  0:00:03 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:04 --:--:-- 0  0 0 
   0 00 0  0  0 --:--:--  0:00:05 --:--:-- 0  0 0   
 0 00 0  0  0 --:--:--  0:00:06 --:--:-- 0  0 0
0 00 0  0  0 --:--:--  0:00:07 --:--:-- 0  0 00 
00 0  0  0 --:--:--  0:00:08 --:--:-- 0  0 00   
  00 0  0  0 --:--:--  0:00:09 --:--:-- 0  0 00 
00 0  0  0 --:--:--  0:00:10 --:--:-- 0  0 00 0 
   0 0  0  0 --:--:--  0:00:11 --:--:-- 0  0 00 0   
 0 0  0  0 --:--:--  0:00:12 --:--:-- 0  0 00 0
0 0  0  0 --:--:--  0:00:13 --:--:-- 0  0 00 00 
0  0  0 --:--:--  0:00:14 --:--:-- 0  0 00 00   
  0  0  0 --:--:--  0:00:15 --:--:-- 0  0 00 00 
0  0  0 --:--:--  0:00:16 --:--:-- 0  0 00 00 0 
 0  0 --:--:--  0:00:17 --:--:-- 0  0 00 00 0   
   0  0 --:--:--  0:00:18 --:--:-- 0  0 00 00 0 
 0  0 --:--:--  0:00:19 --:--:-- 0  0 00 00 0  
0  0 --:--:--  0:00:20 --:--:-- 0  0 00 00 0  0 
 0 --:--:--  0:00:21 --:--:-- 0  0 00 00 0  0   
   0 --:--:--  0:00:22 --:--:-- 0  0 00 00 0  0 
 0 --:--:--  0:00:23 --:--:-- 0  0 00 00 0  0  
0 --:--:--  0:00:24 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:25 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:26 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:27 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:28 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:29 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:30 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:31 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:32 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:33 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:34 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:35 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:36 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:37 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:38 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:39 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:40 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:41 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:42 --:--:-- 0  0 00 00 0  0  0 
--:--:--  0:00:43 -

[jira] [Created] (OOZIE-2822) Killed instance state tends to stay in Killed state upon rerun if concurrency is already hit

2017-03-13 Thread sandeep samudrala (JIRA) 
sandeep samudrala created OOZIE-2822:


 Summary: Killed instance state tends to stay in Killed state upon 
rerun if concurrency is already hit
 Key: OOZIE-2822
 URL: https://issues.apache.org/jira/browse/OOZIE-2822
 Project: Oozie
  Issue Type: Bug
Reporter: sandeep samudrala


Killed instance state tends to stay in Killed state upon rerun if concurrency 
is already hit. Although the instance will be rerun once one of the RUNNING 
instance finishes, the rerun instance(initially killed) will move to READY and 
then to RUNNING, but this happens only if there is room for concurrency 
availability yet. Ideally it should have moved to READY state as and when the 
rerun is issued, which is the case with WAITING instance to READY as and when 
the input data is available.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2820) more spelling errors in exceptions and logging

2017-03-13 Thread Grant Sohn (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906994#comment-15906994
 ] 

Grant Sohn commented on OOZIE-2820:
---

Lazlo,

Thanks for contributing your changes!  However, there is a slight problem with 
fixing all spelling typos in one patch which is this will be difficult to 
backport since all the changes to all these files will be tied together.  For 
that reason, I've limited my changes and JIRAs to user-facing typos (CLI usage, 
logging, exception messages: like OOZIE-2740 for example).  That said, you 
could definitely use this approach for the docs since non-code changes wouldn't 
suffer from this backporting-to-release-branches issue.

You can refer to 
https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute on how to 
create and submit patches.

Thanks,

Grant

> more spelling errors in exceptions and logging
> --
>
> Key: OOZIE-2820
> URL: https://issues.apache.org/jira/browse/OOZIE-2820
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Reporter: Grant Sohn
>Priority: Trivial
>
> core/src/main/java/org/apache/oozie/servlet/JVMInfo.java: 
> sb.append("  Deamon 
> Threads=").append(threadMXBean.getDaemonThreadCount());
> Deamon -> Daemon
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Table !!");
> core/src/main/java/org/apache/oozie/util/db/SqlStatement.java:
> throw new RuntimeException("Need atleast 1 Column !!");
> atleast -> at least
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> INSTACE -> INSTANCE
> core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
> UNKOWN_ERROR -> UNKNOWN_ERROR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] Subscription: Oozie Patch Available

2017-03-13 Thread jira 
Issue Subscription
Filter: Oozie Patch Available (86 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2619  Make  Hive action defaults to match hive defaults when running from 
command line
https://issues-test.apache.org/jira/browse/OOZIE-2619
OOZIE-2618  Include hive-common in hive-beeline as compile component for 
hive-server2 (hive2 action)
https://issues-test.apache.org/jira/browse/OOZIE-2618
OOZIE-2617  Read properties files in action configurations
https://issues-test.apache.org/jira/browse/OOZIE-2617
OOZIE-2616  Add Tez profile for Hive and Pig sharelibs
https://issues-test.apache.org/jira/browse/OOZIE-2616
OOZIE-2606  Set spark.yarn.jars to fix Spark 2.0 with Oozie
https://issues-test.apache.org/jira/browse/OOZIE-2606
OOZIE-2589  CompletedActionXCommand priority param is of no effect
https://issues-test.apache.org/jira/browse/OOZIE-2589
OOZIE-2588  Support getting credentials for same cluster hcat when credentials 
config is empty
https://issues-test.apache.org/jira/browse/OOZIE-2588
OOZIE-2585  Disable or remove test case 
TestPartitionDependencyManagerEhcache.testMemoryUsageAndSpeedOverflowToDisk and 
testMemoryUsageAndSpeed
https://issues-test.apache.org/jira/browse/OOZIE-2585
OOZIE-2584  Eliminate Thread.sleep() calls in TestMemoryLocks
https://issues-test.apache.org/jira/browse/OOZIE-2584
OOZIE-2583  oozie throws EL Exception when reference variable name containing 
dot
https://issues-test.apache.org/jira/browse/OOZIE-2583
OOZIE-2582  Populating external child Ids for action failures
https://issues-test.apache.org/jira/browse/OOZIE-2582
OOZIE-2573  dataset url  which contains spaces can not be handled rightly
https://issues-test.apache.org/jira/browse/OOZIE-2573
OOZIE-2572  SLA DURATION miss not shown when job is running for longer than 
expected time
https://issues-test.apache.org/jira/browse/OOZIE-2572
OOZIE-2571  Add scala.binary.version Maven property so that Scala 2.11 can be 
used
https://issues-test.apache.org/jira/browse/OOZIE-2571
OOZIE-2569  Adding yarn-site, core-site, hdfs-site and mapred-site into spark 
launcher 
https://issues-test.apache.org/jira/browse/OOZIE-2569
OOZIE-2568  SSH  action pretends to retry automaticly when it failed
https://issues-test.apache.org/jira/browse/OOZIE-2568
OOZIE-2564  Create new log4j config for unit tests so that logged messages 
contain threads
https://issues-test.apache.org/jira/browse/OOZIE-2564
OOZIE-2552  Update ActiveMQ version for security and other fixes
https://issues-test.apache.org/jira/browse/OOZIE-2552
OOZIE-2538  Update HttpClient versions to close security vulnerabilities
https://issues-test.apache.org/jira/browse/OOZIE-2538
OOZIE-2534  Versioned action libs (similar to how SharedLibs works)
https://issues-test.apache.org/jira/browse/OOZIE-2534
OOZIE-2530  Remove jline from parent and sharelib pig pom
https://issues-test.apache.org/jira/browse/OOZIE-2530
OOZIE-2528  Print out environment variables in LauncherMapper
https://issues-test.apache.org/jira/browse/OOZIE-2528
OOZIE-2521  Filter options are case sensitive for jobtye=bundle
https://issues-test.apache.org/jira/browse/OOZIE-2521
OOZIE-2518  Oozie is creating many files and directories in /tmp per day
https://issues-test.apache.org/jira/browse/OOZIE-2518
OOZIE-2517  Add support for startCreatedTime and endCreatedTime filters for 
coord and bundles
https://issues-test.apache.org/jira/browse/OOZIE-2517
OOZIE-2513  log.scan.duration should not be used for error and audit logs
https://issues-test.apache.org/jira/browse/OOZIE-2513
OOZIE-2512  ShareLibservice returns incorrect path for jar
https://issues-test.apache.org/jira/browse/OOZIE-2512
OOZIE-2508  Documentation change for Coord action rerun [OOZIE-1735]
https://issues-test.apache.org/jira/browse/OOZIE-2508
OOZIE-2501  ZK reentrant lock doesn't work for few cases
https://issues-test.apache.org/jira/browse/OOZIE-2501
OOZIE-2500  -DtestJarSimple option mentioned in minioozie doc does not work
https://issues-test.apache.org/jira/browse/OOZIE-2500
OOZIE-2499  map-reduce launcher does not need distributed files, archives 
except  jar of input/outputformat class
https://issues-test.apache.org/jira/browse/OOZIE-2499
OOZIE-2498  Oozie CallerId configuration for downstream components 
https://issues-test.apache.org/jira/browse/OOZIE-2498
OOZIE-2495  change action status from  ErrorType.NON_TRANSIENT to TRANSIENT 
when SSH action occurs AUTH_FAILED occasionally
https://issues-test.apache.org/jira/browse/OOZIE-2495
OOZIE-2491  oozie acl cannot specify group,it does`t work
https://issues-test.apache.org/jira/browse/OOZIE-2491
OOZIE

[jira] Subscription: Oozie Patch Available

2017-03-13 Thread jira 
Issue Subscription
Filter: Oozie Patch Available (90 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2817  Increase test case stability in pre-commit job
https://issues.apache.org/jira/browse/OOZIE-2817
OOZIE-2816  Strip out the first command word from Sqoop action if its "sqoop"
https://issues.apache.org/jira/browse/OOZIE-2816
OOZIE-2813  Remove tabs and trailing whitespaces from oozie-defaul.xml
https://issues.apache.org/jira/browse/OOZIE-2813
OOZIE-2796  oozie.action.keep.action.dir not getting noticed
https://issues.apache.org/jira/browse/OOZIE-2796
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters
https://issues.apache.org/jira/browse/OOZIE-2791
OOZIE-2785  Master is not compiling with hadoop-1 profile
https://issues.apache.org/jira/browse/OOZIE-2785
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2780  Upgrade hadoop-common version to 2.6.0
https://issues.apache.org/jira/browse/OOZIE-2780
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues.apache.org/jira/browse/OOZIE-2779
OOZIE-2769  Extend FS action to allow setrep on a file
https://issues.apache.org/jira/browse/OOZIE-2769
OOZIE-2753  Update Docs for Jetty Tomcat changes
https://issues.apache.org/jira/browse/OOZIE-2753
OOZIE-2751  LocalOozieClient is missing methods from OozieClient
https://issues.apache.org/jira/browse/OOZIE-2751
OOZIE-2746  Several tests failure in TestV2ValidateServlet.java
https://issues.apache.org/jira/browse/OOZIE-2746
OOZIE-2739  Remove property expansion pattern from ShellMain's log4j properties 
content
https://issues.apache.org/jira/browse/OOZIE-2739
OOZIE-2736  Reduce the number of threads during test execution
https://issues.apache.org/jira/browse/OOZIE-2736
OOZIE-2733  change org.apache.hadoop.fs.permission.AccessControlException to 
org.apache.hadoop.security.AccessControlException
https://issues.apache.org/jira/browse/OOZIE-2733
OOZIE-2726  Flaky test due to daylight saving changes
https://issues.apache.org/jira/browse/OOZIE-2726
OOZIE-2718  Improve -dryrun for bundles
https://issues.apache.org/jira/browse/OOZIE-2718
OOZIE-2713  Provide an option to log out contents of the localized jar files
https://issues.apache.org/jira/browse/OOZIE-2713
OOZIE-2701  Oozie to support Multiple HCatalog URIs
https://issues.apache.org/jira/browse/OOZIE-2701
OOZIE-2694  Add logging for FsActionExecutor 
https://issues.apache.org/jira/browse/OOZIE-2694
OOZIE-2693  SimpleHCatDependencyCache.removeMissingDependency can throw NPE
https://issues.apache.org/jira/browse/OOZIE-2693
OOZIE-2692  Oozie job submit doesn't report error message to user if there is 
any issue with job conf
https://issues.apache.org/jira/browse/OOZIE-2692
OOZIE-2684  Bad database schema error for WF_ACTIONS table
https://issues.apache.org/jira/browse/OOZIE-2684
OOZIE-2681  fix javadoc to compile on JDK8 again
https://issues.apache.org/jira/browse/OOZIE-2681
OOZIE-2670  Upgrade Hbase to 1.2
https://issues.apache.org/jira/browse/OOZIE-2670
OOZIE-2668  Status update and recovery problems when coord action and its 
children not in sync
https://issues.apache.org/jira/browse/OOZIE-2668
OOZIE-2662  DB migration fails if DB is too big
https://issues.apache.org/jira/browse/OOZIE-2662
OOZIE-2652  Skip trash while deleting hive table partition
https://issues.apache.org/jira/browse/OOZIE-2652
OOZIE-2650  Retry coord start on database exceptions
https://issues.apache.org/jira/browse/OOZIE-2650
OOZIE-2644  Skip queuing Notification Commands when there's nothing to notify
https://issues.apache.org/jira/browse/OOZIE-2644
OOZIE-2641  rerunning an oozie coordinator job stucks on waiting
https://issues.apache.org/jira/browse/OOZIE-2641
OOZIE-2629  Get OozieShareLibCLI to perform a final rename to destPath when 
creating a Sharelib
https://issues.apache.org/jira/browse/OOZIE-2629
OOZIE-2618  Include hive-common in hive-beeline as compile component for 
hive-server2 (hive2 action)
https://issues.apache.org/jira/browse/OOZIE-2618
OOZIE-2608  Comma in oozie.service.JPAService.jdbc.password value results in 
authentication error
https://issues.apache.org/jira/browse/OOZIE-2608
OOZIE-2585  Disable or remove test case 
TestPartitionDependencyManagerEhcache.testMemoryUsageAndSpeedOverflowToDisk and 
testMemoryUsageAndSpeed
https://issues.apache.org/jira/browse/OOZIE-2585
OOZIE-2573  dataset url  whic