[jira] [Commented] (OOZIE-2651) Set javax.xml.parsers.DocumentBuilderFactory sys prop to make XML handling faster

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941525#comment-15941525
 ] 

Hadoop QA commented on OOZIE-2651:
--

Testing JIRA OOZIE-2651

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
.Tests rerun: 66
.Tests failed at first run: 
org.apache.oozie.command.coord.TestCoordUpdateXCommand,org.apache.oozie.command.coord.TestCoordMaterializeTransitionXCommand,org.apache.oozie.command.coord.TestCoordRerunXCommand,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3732/

> Set javax.xml.parsers.DocumentBuilderFactory sys prop to make XML handling 
> faster
> -
>
> Key: OOZIE-2651
> URL: https://issues.apache.org/jira/browse/OOZIE-2651
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-2651.001.patch, OOZIE-2651.002.patch
>
>
> We noticed from some jstacks that Oozie was spending a lot of time looking 
> for XML related jars (we do a lot of XML parsing in Oozie and Hadoop code).  
> For instance, we'd see hundreds of threads blocked here
> {noformat}
> "pool-5-thread-57" prio=10 tid=0x7f9579923000 nid=0x6b7f waiting for 
> monitor entry [0x7f94225e3000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1559)
> - waiting to lock <0x000500026148> (a 
> org.apache.catalina.loader.WebappClassLoader)
> at 
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1526)
> at 
> javax.xml.parsers.FactoryFinder.getProviderClass(FactoryFinder.java:117)
> at javax.xml.parsers.FactoryFinder.newInstance(FactoryFinder.java:178)
> at 
> javax.xml.parsers.FactoryFinder.findJarServiceProvider(FactoryFinder.java:333)
> at javax.xml.parsers.FactoryFinder.find(FactoryFinder.java:255)
> at 
> javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java

Build failed in Jenkins: oozie-trunk-precommit-build #3732

[Apache Jenkins Server]

See 


--
[...truncated 1.21 MB...]
[INFO] commons-collections:commons-collections:jar:3.2.1 already exists in 
destination.
[INFO] org.apache.geronimo.specs:geronimo-jpa_2.0_spec:jar:1.1 already exists 
in destination.
[INFO] org.json:json:jar:20090211 already exists in destination.
[INFO] com.sun.jersey:jersey-client:jar:1.9 already exists in destination.
[INFO] org.eclipse.jetty.toolchain:jetty-schemas:jar:3.1.M0 already exists in 
destination.
[INFO] org.apache.hadoop:hadoop-annotations:jar:2.4.0 already exists in 
destination.
[INFO] org.apache.xbean:xbean-asm5-shaded:jar:3.17 already exists in 
destination.
[INFO] net.sourceforge.serp:serp:jar:1.15.1 already exists in destination.
[INFO] org.ow2.asm:asm:jar:5.0.1 already exists in destination.
[INFO] org.apache.openjpa:openjpa-lib:jar:2.4.1 already exists in destination.
[INFO] net.sf.opencsv:opencsv:jar:2.3 already exists in destination.
[INFO] tomcat:jasper-runtime:jar:5.5.23 already exists in destination.
[INFO] org.apache.curator:curator-client:jar:2.5.0 already exists in 
destination.
[INFO] org.eclipse.jetty:jetty-annotations:jar:9.2.19.v20160908 already exists 
in destination.
[INFO] com.sun.jersey:jersey-server:jar:1.9 already exists in destination.
[INFO] com.fasterxml.jackson.core:jackson-core:jar:2.2.2 already exists in 
destination.
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-r

[jira] [Updated] (OOZIE-2651) Set javax.xml.parsers.DocumentBuilderFactory sys prop to make XML handling faster

[Robert Kanter (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Kanter updated OOZIE-2651:
-
Attachment: OOZIE-2651.002.patch

I've just verified that this doesn't seem to be a problem for the Web UI with 
Jetty.  I'm uploading a 002 patch that's rebased on the latest master, but is 
otherwise the same.

> Set javax.xml.parsers.DocumentBuilderFactory sys prop to make XML handling 
> faster
> -
>
> Key: OOZIE-2651
> URL: https://issues.apache.org/jira/browse/OOZIE-2651
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: OOZIE-2651.001.patch, OOZIE-2651.002.patch
>
>
> We noticed from some jstacks that Oozie was spending a lot of time looking 
> for XML related jars (we do a lot of XML parsing in Oozie and Hadoop code).  
> For instance, we'd see hundreds of threads blocked here
> {noformat}
> "pool-5-thread-57" prio=10 tid=0x7f9579923000 nid=0x6b7f waiting for 
> monitor entry [0x7f94225e3000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1559)
> - waiting to lock <0x000500026148> (a 
> org.apache.catalina.loader.WebappClassLoader)
> at 
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1526)
> at 
> javax.xml.parsers.FactoryFinder.getProviderClass(FactoryFinder.java:117)
> at javax.xml.parsers.FactoryFinder.newInstance(FactoryFinder.java:178)
> at 
> javax.xml.parsers.FactoryFinder.findJarServiceProvider(FactoryFinder.java:333)
> at javax.xml.parsers.FactoryFinder.find(FactoryFinder.java:255)
> at 
> javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:121)
> at 
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2526)
> at 
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2503)
> at 
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2409)
> - locked <0x0007eac5ea28> (a org.apache.hadoop.conf.Configuration)
> at org.apache.hadoop.conf.Configuration.set(Configuration.java:1144)
> at org.apache.hadoop.conf.Configuration.set(Configuration.java:1116)
> at org.apache.oozie.util.XConfiguration.copy(XConfiguration.java:206)
> ...
> {noformat}
> There's nothing we can do about the lock at the {{WebappClassLoader}}, but by 
> setting the {{javax.xml.parsers.DocumentBuilderFactory}} system property to 
> {{org.apache.xerces.jaxp.DocumentBuilderFactoryImpl}}, we can speed this up a 
> lot by getting rid of all of the searching that it's doing to find the 
> implementation.  
> See 
> https://docs.oracle.com/javase/7/docs/api/javax/xml/parsers/DocumentBuilderFactory.html#newInstance()
>  
> and 
> https://www.databasesandlife.com/java-always-explicitly-specify-which-xml-parser-to-use/
> In our testing, we had a metric around creating a new {{JobClient}}, which 
> also calls {{DocumentBuilderFactory.newInstance}}, and it dropped from ~3min 
> max to ~2sec max (not an exact test of the savings here).  And we also didn't 
> see so much blocking on this in the jstacks anymore.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-find-patches-available #154411

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154410

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 1392eeaf8397a6c6814607cf61cb962403df1447 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1392eeaf8397a6c6814607cf61cb962403df1447
 > git rev-list 1392eeaf8397a6c6814607cf61cb962403df1447 # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson698253200142619714.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 327600 327600 0  48670  0 --:--:-- --:--:-- --:--:-- 
48677100  783k0  783k0 0   473k  0 --:--:--  0:00:01 --:--:--  
473k100 1383k0 1383k0 0   513k  0 --:--:--  0:00:02 --:--:--  
513k100 1607k0 1607k0 0   505k  0 --:--:--  0:00:03 --:--:--  
505k
curl: (18) transfer closed with outstanding read data remaining
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

Jenkins build is back to normal : oozie-trunk-find-patches-available #154409

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154408

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 1392eeaf8397a6c6814607cf61cb962403df1447 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1392eeaf8397a6c6814607cf61cb962403df1447
 > git rev-list 1392eeaf8397a6c6814607cf61cb962403df1447 # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson1553794257470168769.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 819120 819120 0   103k  0 --:--:-- --:--:-- --:--:--  
103k100  871k0  871k0 0   483k  0 --:--:--  0:00:01 --:--:--  
483k100 1447k0 1447k0 0   519k  0 --:--:--  0:00:02 --:--:--  
518k100 1711k0 1711k0 0   490k  0 --:--:--  0:00:03 --:--:--  
490k
curl: (18) transfer closed with outstanding read data remaining
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

Jenkins build is back to normal : oozie-trunk-find-patches-available #154405

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154404

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 1392eeaf8397a6c6814607cf61cb962403df1447 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1392eeaf8397a6c6814607cf61cb962403df1447
 > git rev-list 1392eeaf8397a6c6814607cf61cb962403df1447 # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson3033107101579010848.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
 223k0  223k0 0   197k  0 --:--:--  0:00:01 --:--:--  197k
curl: (18) transfer closed with outstanding read data remaining
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

[jira] [Commented] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940755#comment-15940755
 ] 

Hadoop QA commented on OOZIE-2843:
--

Testing JIRA OOZIE-2843

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:red}-1{color} There are [1] new bugs found below threshold in 
[core] that must be fixed.
.You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The most important FindBugs errors are:
.At ZKLocksService.java:[line 67]: Write to static field 
org.apache.oozie.service.ZKLocksService.LOG from instance method new 
org.apache.oozie.service.ZKLocksService(XLog)
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1907
.Tests rerun: 50
.Tests failed at first run: 
org.apache.oozie.service.TestStatusTransitService,org.apache.oozie.command.coord.TestCoordActionsKillXCommand,org.apache.oozie.sla.TestSLAEventGeneration,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3731/

> Enhance logging inside ZKLocksService and MemoryLocksService
> 
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
>  Issue Type: New Feature
>  Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch
>
>
> Sometimes when Oozie tries to acquire lock [via 
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
>  or 
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
>  we don't get enough information whether the action succeeded or not. Also 
> other details like retry count, timeout applied, etc. are not logged. 
> Enhancing logging here would benefit debugging of lock handling within 
> {{XCommand}} instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3731

[Apache Jenkins Server]

See 


--
[...truncated 1.20 MB...]
[INFO] org.eclipse.jetty.toolchain:jetty-schemas:jar:3.1.M0 already exists in 
destination.
[INFO] org.apache.hadoop:hadoop-annotations:jar:2.4.0 already exists in 
destination.
[INFO] org.apache.xbean:xbean-asm5-shaded:jar:3.17 already exists in 
destination.
[INFO] net.sourceforge.serp:serp:jar:1.15.1 already exists in destination.
[INFO] org.ow2.asm:asm:jar:5.0.1 already exists in destination.
[INFO] org.apache.openjpa:openjpa-lib:jar:2.4.1 already exists in destination.
[INFO] net.sf.opencsv:opencsv:jar:2.3 already exists in destination.
[INFO] tomcat:jasper-runtime:jar:5.5.23 already exists in destination.
[INFO] org.apache.curator:curator-client:jar:2.5.0 already exists in 
destination.
[INFO] org.eclipse.jetty:jetty-annotations:jar:9.2.19.v20160908 already exists 
in destination.
[INFO] com.sun.jersey:jersey-server:jar:1.9 already exists in destination.
[INFO] com.fasterxml.jackson.core:jackson-core:jar:2.2.2 already exists in 
destination.
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940612#comment-15940612
 ] 

Hadoop QA commented on OOZIE-2701:
--

Testing JIRA OOZIE-2701

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1912
.Tests rerun: 7
.Tests failed at first run: 
org.apache.oozie.service.TestPauseTransitService,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3730/

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-precommit-build #3730

[Apache Jenkins Server]

See 

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940591#comment-15940591
 ] 

Hadoop QA commented on OOZIE-2841:
--

Testing JIRA OOZIE-2841

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 11 line(s) longer than 132 
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:red}-1{color} patch does not compile
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3729/

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3729

[Apache Jenkins Server]

See 


Changes:

[harsh] OOZIE-2739 Remove property expansion pattern from ShellMain's log4j

--
[...truncated 720.23 KB...]
[INFO] Copying jung-algorithms-2.0.1.jar to 

[INFO] Copying libfb303-0.9.2.jar to 

[INFO] Copying stringtemplate-3.2.1.jar to 

[INFO] Copying stax-api-1.0-2.jar to 

[INFO] Copying hive-metastore-1.2.0.jar to 

[INFO] Copying jetty-util-9.2.19.v20160908.jar to 

[INFO] Copying calcite-core-1.2.0-incubating.jar to 

[INFO] Copying oozie-core-4.4.0-SNAPSHOT.jar to 

[INFO] Copying hive-service-1.2.0.jar to 

[INFO] Copying jetty-jndi-9.2.19.v20160908.jar to 

[INFO] Copying curator-framework-2.5.0.jar to 

[INFO] Copying servlet-api-2.5.jar to 

[INFO] Copying libthrift-0.9.2.jar to 

[INFO] Copying antlr-runtime-3.4.jar to 

[INFO] Copying geronimo-jms_1.1_spec-1.1.1.jar to 

[INFO] Copying ivy-2.4.0.jar to 

[INFO] Copying metrics-core-3.0.2.jar to 

[INFO] Copying jackson-core-asl-1.9.13.jar to 

[INFO] Copying commons-jexl-2.1.1.jar to 

[INFO] Copying commons-pool-1.5.4.jar to 

[INFO] Copying jaxb-impl-2.2.3-1.jar to 

[INFO] Copying jets3t-0.9.0.jar to 

[INFO] Copying datanucleus-rdbms-3.2.9.jar to 

[INFO] Copying hive-common-1.2.0.jar to 

[INFO] Copying snappy-java-1.0.4.1.jar to 

[INFO] Copying javax.annotation-api-1.2.jar to 

[INFO] Copying commons-compiler-2.7.6.jar to 

[INFO] Copying ant-1.9.1.jar to 

[INFO] Copying janino-2.7.6.jar to 

[INFO] Copying activemq-client-5.13.3.jar to 

[INFO] Copying guice-3.0.jar to 

[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2843:

Attachment: OOZIE-2843.002.patch

Addressing the only FindBugs issue and introducing a new unit test for logging.

> Enhance logging inside ZKLocksService and MemoryLocksService
> 
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
>  Issue Type: New Feature
>  Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch, OOZIE-2843.002.patch
>
>
> Sometimes when Oozie tries to acquire lock [via 
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
>  or 
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
>  we don't get enough information whether the action succeeded or not. Also 
> other details like retry count, timeout applied, etc. are not logged. 
> Enhancing logging here would benefit debugging of lock handling within 
> {{XCommand}} instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940478#comment-15940478
 ] 

Attila Sasvari commented on OOZIE-2833:
---

[~abhishekbafna], [~gezapeti] can you take a look? Thanks.

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch, OOZIE-2833.02.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940475#comment-15940475
 ] 

Hadoop QA commented on OOZIE-2833:
--

Testing JIRA OOZIE-2833

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1915
.Tests rerun: 50
.Tests failed at first run: 
org.apache.oozie.service.TestStatusTransitService,org.apache.oozie.command.coord.TestCoordActionsKillXCommand,org.apache.oozie.sla.TestSLAEventGeneration,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3728/

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch, OOZIE-2833.02.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940380#comment-15940380
 ] 

Hadoop QA commented on OOZIE-2833:
--

Testing JIRA OOZIE-2833

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1915
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3727/

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch, OOZIE-2833.02.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-precommit-build #3727

[Apache Jenkins Server]

See 

[jira] [Updated] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Abhishek Bafna (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Bafna updated OOZIE-2701:
--
Attachment: OOZIE-2701-08.patch

Thanks for identifying. Moved the test {{TestHCatURIParser}} into core module.

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2841:

Attachment: OOZIE-2841.002.patch

New patch that addresses flakiness by issuing:
{noformat}
mvn clean compile test-compile findbugs:check -Dfindbugs.failOnError=false 
-Dcheckstyle.failOnViolation=false
{noformat}

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.wrong.patch, test-patch-reports.after.tar.gz, 
> test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3726

[Apache Jenkins Server]

See 


Changes:

[pbacsko] OOZIE-2838 TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils

--
[...truncated 2.57 MB...]
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ 
oozie-zookeeper-security-tests ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
oozie-zookeeper-security-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Oozie Main .. SUCCESS [  2.090 s]
[INFO] Apache Oozie Hadoop Utils hadoop-2-4.4.0-SNAPSHOT .. SUCCESS [  2.788 s]
[INFO] Apache Oozie Hadoop Distcp hadoop-2-4.4.0-SNAPSHOT . SUCCESS [  0.225 s]
[INFO] Apache Oozie Hadoop Auth hadoop-2-4.4.0-SNAPSHOT Test SUCCESS [  0.299 s]
[INFO] Apache Oozie Hadoop Libs ... SUCCESS [  0.029 s]
[INFO] Apache Oozie Client  SUCCESS [ 27.283 s]
[INFO] Apache Oozie Share Lib Oozie ... SUCCESS [  2.183 s]
[INFO] Apache Oozie Share Lib HCatalog  SUCCESS [  1.862 s]
[INFO] Apache Oozie Share Lib Distcp .. SUCCESS [  0.404 s]
[INFO] Apache Oozie Core .. SUCCESS [ 43.811 s]
[INFO] Apache Oozie Share Lib Streaming ... SUCCESS [  3.214 s]
[INFO] Apache Oozie Share Lib Pig . SUCCESS [  2.377 s]
[INFO] Apache Oozie Share Lib Hive  SUCCESS [  4.147 s]
[INFO] Apache Oozie Share Lib Hive 2 .. SUCCESS [  3.385 s]
[INFO] Apache Oozie Share Lib Sqoop ... SUCCESS [  0.579 s]
[INFO] Apache Oozie Examples .. SUCCESS [  2.104 s]
[INFO] Apache Oo

[jira] [Commented] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940264#comment-15940264
 ] 

Hadoop QA commented on OOZIE-2843:
--

Testing JIRA OOZIE-2843

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
.{color:red}-1{color} There are [1] new bugs found below threshold in 
[core] that must be fixed.
.You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
.The most important FindBugs errors are:
.At ZKLocksService.java:[line 147]: Synchronization performed on 
java.util.concurrent.ConcurrentMap in 
org.apache.oozie.service.ZKLocksService.acquireLock(String, 
MemoryLocksService$Type, long)
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3726/

> Enhance logging inside ZKLocksService and MemoryLocksService
> 
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
>  Issue Type: New Feature
>  Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch
>
>
> Sometimes when Oozie tries to acquire lock [via 
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
>  or 
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
>  we don't get enough information whether the action succeeded or not. Also 
> other details like retry count, timeout applied, etc. are not logged. 
> Enhancing logging here would benefit debugging of lock handling within 
> {{XCommand}} instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2681) fix javadoc to compile on JDK8 again

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940248#comment-15940248
 ] 

Abhishek Bafna commented on OOZIE-2681:
---

[~pbacsko] I will take a another look and fix them. Thanks.

> fix javadoc to compile on JDK8 again
> 
>
> Key: OOZIE-2681
> URL: https://issues.apache.org/jira/browse/OOZIE-2681
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-2681-00.patch, OOZIE-2681-01.patch, 
> OOZIE-2681-02.patch
>
>
> We have a lot of Javadoc build failures, which causes Oozie to fail to build 
> on Java 8, which is more strict than Java 6 or 7 was.  OOZIE-2178 fixed all 
> of these that existed at that time, but we've since introduced a lot more.  
> OOZIE-2487 made a workaround to prevent this from causing the build to fail, 
> but we should fix these (again) and remove the OOZIE-2487 workaround.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2681) fix javadoc to compile on JDK8 again

[Peter Bacsko (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940246#comment-15940246
 ] 

Peter Bacsko commented on OOZIE-2681:
-

Looks good, I just have a single comment. Some grammatical mistakes should be 
fixed, like "if any error" should be " if any error occurs".

Example:
"if any error suspending the jobs" should be "if any error occurs while 
suspending the jobs".

There some mistakes like this scattered around the code. Not a big deal, but 
should be fixed nonetheless. Thanks.


> fix javadoc to compile on JDK8 again
> 
>
> Key: OOZIE-2681
> URL: https://issues.apache.org/jira/browse/OOZIE-2681
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
>Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-2681-00.patch, OOZIE-2681-01.patch, 
> OOZIE-2681-02.patch
>
>
> We have a lot of Javadoc build failures, which causes Oozie to fail to build 
> on Java 8, which is more strict than Java 6 or 7 was.  OOZIE-2178 fixed all 
> of these that existed at that time, but we've since introduced a lot more.  
> OOZIE-2487 made a workaround to prevent this from causing the build to fail, 
> but we should fix these (again) and remove the OOZIE-2487 workaround.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2817) Increase test case stability in pre-commit job

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940236#comment-15940236
 ] 

Peter Cseh commented on OOZIE-2817:
---

Thanks for the review [~abhishekbafna]!
I promise I won't do an other amend commit for this jira :)

> Increase test case stability in pre-commit job
> --
>
> Key: OOZIE-2817
> URL: https://issues.apache.org/jira/browse/OOZIE-2817
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Fix For: 5.0.0
>
> Attachments: OOZIE-2817-001.patch, OOZIE-2817-002.patch, 
> OOZIE-2817-003.patch, OOZIE-2817-amend2.patch, OOZIE-2817-amend.patch
>
>
> We could collect the failed tests and rerun them in the pre-commit hook.
> They will still fail if they are broken, but they'll probably pass if they 
> are just flaky.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940232#comment-15940232
 ] 

Peter Cseh commented on OOZIE-2701:
---

We should make sure that the regex in the {{oozie-default.xml}} and in 
{{TestHCatURIParser}} are the same.
They are not quite the same in patch-07.
This is the one in {{oozie-default.xml}} and in the test after removing the 
escaping characters:
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+[/\w+=;\-]*
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+/[\w+=;\-]*

Notice the extra "/" before the last pair of brackets. [~abhishekbafna], could 
you check which one is correct?
Also, I think moving the test to core would worth it to ensure the tested regex 
is the same everywhere.


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940232#comment-15940232
 ] 

Peter Cseh edited comment on OOZIE-2701 at 3/24/17 12:25 PM:
-

We should make sure that the regex in the {{oozie-default.xml}} and in 
{{TestHCatURIParser}} are the same.
They are not quite the same in patch-07.
This is the one in {{oozie-default.xml}} and in the test after removing the 
escaping characters:
{noformat}
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+[/\w+=;\-]*
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+/[\w+=;\-]*
{noformat}
Notice the extra "/" before the last pair of brackets. [~abhishekbafna], could 
you check which one is correct?
Also, I think moving the test to core would worth it to ensure the tested regex 
is the same everywhere.



was (Author: gezapeti):
We should make sure that the regex in the {{oozie-default.xml}} and in 
{{TestHCatURIParser}} are the same.
They are not quite the same in patch-07.
This is the one in {{oozie-default.xml}} and in the test after removing the 
escaping characters:
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+[/\w+=;\-]*
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+/[\w+=;\-]*

Notice the extra "/" before the last pair of brackets. [~abhishekbafna], could 
you check which one is correct?
Also, I think moving the test to core would worth it to ensure the tested regex 
is the same everywhere.


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

[Peter Bacsko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54383/#review16
---




core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 54 (patched)


Minor: Preconditions.checkNotNull() is useful here IMO.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 68 (patched)


Is this method ever called? If not, it should be abstract.

If it is, please add a small "// no-op" comment to indicate that it is a 
valid implementation.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 82 (patched)


Is this method ever called? If not, it should be abstract.

If it is, please add a small "// no-op" comment to indicate that it is a 
valid implementation.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 91 (patched)


Is this method ever called? If not, it should be abstract.

If it is, please add a small "// no-op" comment to indicate that it is a 
valid implementation.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 95 (patched)


Unnecessary @SuppressWarnings



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 345 (patched)


Please refactor these nested classes (make them non-nested). The whole 
class is too big with these classes being defined here.



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 453 (patched)


As I can see it, this is not the visitor pattern.

Traditionally, when you use the visitor pattern, the classes that are to be 
visited implement the accept() method which takes the visitor implementation as 
an argument. Then, if the class contains other classes that can be visited, it 
calls the accept() method on the embedded object again, effectively passing the 
visitor implementation down the call stack.

Also, the visitation begins by calling the accept() method on the top-most 
(external) object.

There is a very good, simple example here:
https://en.wikipedia.org/wiki/Visitor_pattern#Java_example

I think this is just having different implementations, which are hidden 
under an interface (which is good)/

I suggest doing the following rename:
- OozieActionVisitor --> OozieActionHandler
- AbstractOozieActionVisitor --> AbstractOozieActionHandler
- Killing/Resuming/SuspendingVisitor --> Killing/Resuming/SuspendingHandler



core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
Lines 457 (patched)


Extract cases to constants.

Optional: if it's not too much work, pls also take care of replacing the 
other occurrences.



core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java
Lines 79 (patched)


Non-typesafe cast. Do we even need to cast here at all?



core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java
Lines 88 (patched)


Non-typesafe cast. Do we even need to cast here at all?



core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java
Lines 263 (patched)


Non-typesafe cast. Do we even need to cast here at all?



core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java
Lines 272 (patched)


Non-typesafe cast. Do we even need to cast here at all?



core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java
Lines 281 (patched)


Non-typesafe cast. Do we even need to cast here at all?



core/src/main/java/org/apache/oozie/OozieJsonFactory.java
Lines 24 (patched)


If it's meant to be an utility class, then it should be final instead of 
abstract.

Also, consider adding a private constuctor to prevent instantiation.



core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java
Line 316 (original), 314 (patched)


Minor: trailing whitespace



core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java
Line 349 (original), 342 (patched)


Minor: trailing whitespace



core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java
Line 378 (original), 366 (patched)

[jira] [Commented] (OOZIE-2817) Increase test case stability in pre-commit job

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940228#comment-15940228
 ] 

Abhishek Bafna commented on OOZIE-2817:
---

+1. Committed to master. Thanks [~gezapeti].

Just a thought, going forward we should create a separate issue for this, as we 
have already done two amends. :)

> Increase test case stability in pre-commit job
> --
>
> Key: OOZIE-2817
> URL: https://issues.apache.org/jira/browse/OOZIE-2817
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Fix For: 5.0.0
>
> Attachments: OOZIE-2817-001.patch, OOZIE-2817-002.patch, 
> OOZIE-2817-003.patch, OOZIE-2817-amend2.patch, OOZIE-2817-amend.patch
>
>
> We could collect the failed tests and rerun them in the pre-commit hook.
> They will still fail if they are broken, but they'll probably pass if they 
> are just flaky.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2844) Increase stability of Oozie actions when log4j.properties is missing or not readable

[Andras Piros (JIRA)]

Andras Piros created OOZIE-2844:
---

 Summary: Increase stability of Oozie actions when log4j.properties 
is missing or not readable
 Key: OOZIE-2844
 URL: https://issues.apache.org/jira/browse/OOZIE-2844
 Project: Oozie
  Issue Type: Improvement
  Components: action
Affects Versions: 4.3.0
Reporter: Andras Piros


In several Oozie actions we face the problem that if {{log4j.properties}} is 
not readable by current thread, or not present on the classpath, while taking 
an {{URL.openStream()}} call afterwards, an {{IOException}} is thrown and the 
action won't run.

Such actions are:
* 
[*{{DistcpMain}}*|https://github.com/apache/oozie/blob/master/sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java#L135]
* 
[*{{HiveMain}}*|https://github.com/apache/oozie/blob/master/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java#L146]
* 
[*{{PigMain}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java#L173]
* 
[*{{PigMainWithOldApi}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java#L160]
* 
[*{{SparkMain}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L430]
* 
[*{{SqoopMain}}*|https://github.com/apache/oozie/blob/master/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java#L124]

Extend 
[*{{LauncherMain.run()}}*|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L62-L65]
 by a convenience method that loads Hadoop's {{log4j.properties}} in 
beforehand. In case {{URL.openStream()}} would throw {{IOException}} we resort 
to a call to a new file {{hadoop-default-log4j.properties}} on the classpath 
(packaged along w/ {{LauncherMain.class}}) that has the same contents as the 
{{log4j.properties}} that is not accessible / readable / present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2833:
--
Attachment: OOZIE-2833.02.patch

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch, OOZIE-2833.02.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2833:
--
Attachment: (was: OOZIE-2833.02.patch)

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940190#comment-15940190
 ] 

Hadoop QA commented on OOZIE-2701:
--

Testing JIRA OOZIE-2701

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1912
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3725/

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2833:
--
Attachment: OOZIE-2833.02.patch

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch, OOZIE-2833.02.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2833) when using uber mode the regex pattern used in the extractHeapSizeMB method does not allow heap sizes specified in bytes.

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940177#comment-15940177
 ] 

Attila Sasvari commented on OOZIE-2833:
---

[~zhengxb2005] thanks for the review! I see your point, I will upload a new 
patch soon.

> when using uber mode the regex pattern used in the extractHeapSizeMB method 
> does not allow heap sizes specified in bytes.
> -
>
> Key: OOZIE-2833
> URL: https://issues.apache.org/jira/browse/OOZIE-2833
> Project: Oozie
>  Issue Type: Bug
>Reporter: Thomas Scott
>Assignee: Attila Sasvari
>Priority: Minor
> Attachments: OOZIE-2833.01.patch
>
>
> The extractHeapSizeMB method used here:
> https://github.com/apache/oozie/blob/9c0516608bdd0787b1fac3a69ccfe9d36cbb2d15/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L401
> Uses the following pattern:
> -Xmx(([0-9]+)[mMgG])
> This requires that the -Xmx configuration option end in "m" or "g". However, 
> it is valid to configure this option in bytes without the "m" or "g" and this 
> will not be picked up. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2838) TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an Oozie XTestCase

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940170#comment-15940170
 ] 

Attila Sasvari commented on OOZIE-2838:
---

[~pbacsko] thanks a lot!

> TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an 
> Oozie  XTestCase
> 
>
> Key: OOZIE-2838
> URL: https://issues.apache.org/jira/browse/OOZIE-2838
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Fix For: 5.0.0
>
> Attachments: OOZIE-2838.01.patch
>
>
> TestClassUtils,TestIOUtils,TestWritableUtils,TestXmlUtils (like TestIOUtils 
> covered by OOZIE-2835) unnecessary extend Oozie custom XTestCase / TestCase 
> that are intended for more complex tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2817) Increase test case stability in pre-commit job

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-2817:
--
Attachment: OOZIE-2817-amend2.patch

Attaching amend patch with fix.

> Increase test case stability in pre-commit job
> --
>
> Key: OOZIE-2817
> URL: https://issues.apache.org/jira/browse/OOZIE-2817
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Fix For: 5.0.0
>
> Attachments: OOZIE-2817-001.patch, OOZIE-2817-002.patch, 
> OOZIE-2817-003.patch, OOZIE-2817-amend2.patch, OOZIE-2817-amend.patch
>
>
> We could collect the failed tests and rerun them in the pre-commit hook.
> They will still fail if they are broken, but they'll probably pass if they 
> are just flaky.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940134#comment-15940134
 ] 

Peter Cseh commented on OOZIE-2841:
---

Thanks for the patch [~andras.piros]! 
We're having builds like the last one in OOZIE-1770, with lots of false alarms 
in the report.
Could you tweak this step to make it more robust somehow? Do you have guesses 
why this is happening?

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2843:

Attachment: OOZIE-2843.001.patch

Apart from enhancing the logging in those classes, also reworked the 
synchronization pattern of {{ZKLocksService.acquireLock()}}: helping ZooKeeper 
keep up w/ the load by trying to acquire a lock on a single thread per JVM.

> Enhance logging inside ZKLocksService and MemoryLocksService
> 
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
>  Issue Type: New Feature
>  Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
> Attachments: OOZIE-2843.001.patch
>
>
> Sometimes when Oozie tries to acquire lock [via 
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
>  or 
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
>  we don't get enough information whether the action succeeded or not. Also 
> other details like retry count, timeout applied, etc. are not logged. 
> Enhancing logging here would benefit debugging of lock handling within 
> {{XCommand}} instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OOZIE-2818) Can't overwrite oozie.action.max.output.data on a per-workflow basis

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari reassigned OOZIE-2818:
-

Assignee: Attila Sasvari

> Can't overwrite oozie.action.max.output.data on a per-workflow basis
> 
>
> Key: OOZIE-2818
> URL: https://issues.apache.org/jira/browse/OOZIE-2818
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Attila Sasvari
>
> It's not possible to raise the limit of the output on a per-action basis. 
> With the workflow:
> {quote}
> 
> 
> 
> Action failed, error 
> message\[$\{wf:errorMessage(wf:lastErrorNode())}]
> 
> 
> 
> $\{jobTracker}
> $\{nameNode}
> 
> 
> oozie.action.max.output.data
> 10
> 
> 
> oozie.launcher.oozie.action.max.output.data
> 10
> 
> 
> /user/admin/large_output.sh
>   10
> /user/admin/large_output.sh#large_output.sh
>   
> 
> 
> 
> 
> 
> 
> {quote}
> In the localized files in the job.xml the value of this property gets 
> overwritten:
> {quote}
> # cat 
> /yarn/nm/usercache/admin/appcache/application_1489145190857_0001/container_1489145190857_0001_01_02/job.xml
>  |grep max.outp
> oozie.launcher.oozie.action.max.output.data10programaticallyjob.xml
> oozie.action.max.output.data2048programaticallyjob.xml
> # cat 
> /yarn/nm/usercache/admin/appcache/application_1489145190857_0001/container_1489145190857_0001_01_02/action.xml
>  |grep max.outp
> oozie.launcher.oozie.action.max.output.data10programatically
> oozie.action.max.output.data10programatically
> {quote}
> I could not find a reason for this behavior, so I think it's a bug.
> The value is read from 
> [ConfigurationService|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L175]
>  and set in 
> [createLauncherConf|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L986]
>  in JavaActionExecutor. There could be a check to see if it's already set.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2838) TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an Oozie XTestCase

[Peter Bacsko (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940110#comment-15940110
 ] 

Peter Bacsko commented on OOZIE-2838:
-

+1

thanks Attila, committed to master!

> TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an 
> Oozie  XTestCase
> 
>
> Key: OOZIE-2838
> URL: https://issues.apache.org/jira/browse/OOZIE-2838
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2838.01.patch
>
>
> TestClassUtils,TestIOUtils,TestWritableUtils,TestXmlUtils (like TestIOUtils 
> covered by OOZIE-2835) unnecessary extend Oozie custom XTestCase / TestCase 
> that are intended for more complex tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2838) TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an Oozie XTestCase

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940104#comment-15940104
 ] 

Attila Sasvari commented on OOZIE-2838:
---

[~pbacsko] could you please take a look? thanks!

> TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall not be an 
> Oozie  XTestCase
> 
>
> Key: OOZIE-2838
> URL: https://issues.apache.org/jira/browse/OOZIE-2838
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2838.01.patch
>
>
> TestClassUtils,TestIOUtils,TestWritableUtils,TestXmlUtils (like TestIOUtils 
> covered by OOZIE-2835) unnecessary extend Oozie custom XTestCase / TestCase 
> that are intended for more complex tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940056#comment-15940056
 ] 

Attila Sasvari commented on OOZIE-2701:
---

+1 (non-binding)

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Abhishek Bafna (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Bafna updated OOZIE-2701:
--
Attachment: OOZIE-2701-07.patch

[~asasvari] Thanks for helping in improving the regex.

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940037#comment-15940037
 ] 

Attila Sasvari commented on OOZIE-2701:
---

[~abhishekbafna] thanks a lot for the updated patch, in the regex 

{code}
[\w+\.\-]
{code}

I guess + after \w is not needed here. Other than that, I don't have other 
comments.


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Andras Piros (JIRA)]

Andras Piros created OOZIE-2843:
---

 Summary: Enhance logging inside ZKLocksService and 
MemoryLocksService
 Key: OOZIE-2843
 URL: https://issues.apache.org/jira/browse/OOZIE-2843
 Project: Oozie
  Issue Type: New Feature
  Components: action, coordinator
Affects Versions: 4.3.0
Reporter: Andras Piros
Assignee: Andras Piros


Sometimes when Oozie tries to acquire lock [via 
ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
 or 
[in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
 we don't get enough information whether the action succeeded or not. Also 
other details like retry count, timeout applied, etc. are not logged. Enhancing 
logging here would benefit debugging of lock handling within {{XCommand}} 
instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2843) Enhance logging inside ZKLocksService and MemoryLocksService

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2843:

Priority: Minor  (was: Major)

> Enhance logging inside ZKLocksService and MemoryLocksService
> 
>
> Key: OOZIE-2843
> URL: https://issues.apache.org/jira/browse/OOZIE-2843
> Project: Oozie
>  Issue Type: New Feature
>  Components: action, coordinator
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Minor
>
> Sometimes when Oozie tries to acquire lock [via 
> ZooKeeper|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ZKLocksService.java#L144]
>  or 
> [in-memory|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java]
>  we don't get enough information whether the action succeeded or not. Also 
> other details like retry count, timeout applied, etc. are not logged. 
> Enhancing logging here would benefit debugging of lock handling within 
> {{XCommand}} instances.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-find-patches-available #154355

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154354

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 669cea997b2d12310e86c0af57e5d3f98aef66dd 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 669cea997b2d12310e86c0af57e5d3f98aef66dd
 > git rev-list 669cea997b2d12310e86c0af57e5d3f98aef66dd # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson6914415754126249889.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 982960 982960 0   113k  0 --:--:-- --:--:-- --:--:--  
113k100  295k0  295k0 0   237k  0 --:--:--  0:00:01 --:--:--  
237k
curl: (18) transfer closed with outstanding read data remaining
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939934#comment-15939934
 ] 

Hadoop QA commented on OOZIE-2701:
--

Testing JIRA OOZIE-2701

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1912
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3724/

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-precommit-build #3724

[Apache Jenkins Server]

See 

[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (95 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2841  Limit FindBugs diff errors in JIRA comments
https://issues.apache.org/jira/browse/OOZIE-2841
OOZIE-2838  TestClassUtils,TestJsonUtils,TestWritableUtils,TestXmlUtils shall 
not be an Oozie  XTestCase
https://issues.apache.org/jira/browse/OOZIE-2838
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2831  Update maven-project-info-reports-plugin to 2.9
https://issues.apache.org/jira/browse/OOZIE-2831
OOZIE-2827  More directly view of the coordinator’s history from perspective of 
workflow action.
https://issues.apache.org/jira/browse/OOZIE-2827
OOZIE-2825  Custom Authentication doc page is not well formatted
https://issues.apache.org/jira/browse/OOZIE-2825
OOZIE-2824  Fix typos in documentation
https://issues.apache.org/jira/browse/OOZIE-2824
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2796  oozie.action.keep.action.dir not getting noticed
https://issues.apache.org/jira/browse/OOZIE-2796
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters
https://issues.apache.org/jira/browse/OOZIE-2791
OOZIE-2785  Master is not compiling with hadoop-1 profile
https://issues.apache.org/jira/browse/OOZIE-2785
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2780  Upgrade hadoop-common version to 2.6.0
https://issues.apache.org/jira/browse/OOZIE-2780
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues.apache.org/jira/browse/OOZIE-2779
OOZIE-2769  Extend FS action to allow setrep on a file
https://issues.apache.org/jira/browse/OOZIE-2769
OOZIE-2753  Update Docs for Jetty Tomcat changes
https://issues.apache.org/jira/browse/OOZIE-2753
OOZIE-2751  LocalOozieClient is missing methods from OozieClient
https://issues.apache.org/jira/browse/OOZIE-2751
OOZIE-2746  Several tests failure in TestV2ValidateServlet.java
https://issues.apache.org/jira/browse/OOZIE-2746
OOZIE-2739  Remove property expansion pattern from ShellMain's log4j properties 
content
https://issues.apache.org/jira/browse/OOZIE-2739
OOZIE-2736  Reduce the number of threads during test execution
https://issues.apache.org/jira/browse/OOZIE-2736
OOZIE-2733  change org.apache.hadoop.fs.permission.AccessControlException to 
org.apache.hadoop.security.AccessControlException
https://issues.apache.org/jira/browse/OOZIE-2733
OOZIE-2726  Flaky test due to daylight saving changes
https://issues.apache.org/jira/browse/OOZIE-2726
OOZIE-2718  Improve -dryrun for bundles
https://issues.apache.org/jira/browse/OOZIE-2718
OOZIE-2713  Provide an option to log out contents of the localized jar files
https://issues.apache.org/jira/browse/OOZIE-2713
OOZIE-2701  Oozie to support Multiple HCatalog URIs
https://issues.apache.org/jira/browse/OOZIE-2701
OOZIE-2694  Add logging for FsActionExecutor 
https://issues.apache.org/jira/browse/OOZIE-2694
OOZIE-2693  SimpleHCatDependencyCache.removeMissingDependency can throw NPE
https://issues.apache.org/jira/browse/OOZIE-2693
OOZIE-2692  Oozie job submit doesn't report error message to user if there is 
any issue with job conf
https://issues.apache.org/jira/browse/OOZIE-2692
OOZIE-2684  Bad database schema error for WF_ACTIONS table
https://issues.apache.org/jira/browse/OOZIE-2684
OOZIE-2681  fix javadoc to compile on JDK8 again
https://issues.apache.org/jira/browse/OOZIE-2681
OOZIE-2670  Upgrade Hbase to 1.2
https://issues.apache.org/jira/browse/OOZIE-2670
OOZIE-2668  Status update and recovery problems when coord action and its 
children not in sync
https://issues.apache.org/jira/browse/OOZIE-2668
OOZIE-2662  DB migration fails if DB is too big
https://issues.apache.org/jira/browse/OOZIE-2662
OOZIE-2652  Skip trash while deleting hive table partition
https://issues.apache.org/jira/browse/OOZIE-2652
OOZIE-2650  Retry coord start on database exceptions
https://issues.apache.org/jira/browse/OOZIE-2650
OOZIE-2644  Skip queuing Notification Commands when there's nothing to notify