[jira] [Commented] (OOZIE-2729) Use MiniMRYARNCluster in tests

[Robert Kanter (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946327#comment-15946327
 ] 

Robert Kanter commented on OOZIE-2729:
--

You might want to take a look at YARN-2415

> Use MiniMRYARNCluster in tests
> --
>
> Key: OOZIE-2729
> URL: https://issues.apache.org/jira/browse/OOZIE-2729
> Project: Oozie
>  Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Peter Cseh
>Assignee: Andras Piros
> Attachments: OOZIE-2729.002.patch
>
>
> {{MiniMRCluster}} is deprecated, we should replace it using 
> {{MiniYARNCluster}}.
> Also {{MiniDFSCluster}} should be created via builder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3746

[Apache Jenkins Server]

See 


--
[...truncated 858.58 KB...]
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
oozie-zookeeper-security-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Oozie Main .. SUCCESS [  8.397 s]
[INFO] Apache Oozie Hadoop Utils hadoop-2-4.4.0-SNAPSHOT .. SUCCESS [  5.662 s]
[INFO] Apache Oozie Hadoop Distcp hadoop-2-4.4.0-SNAPSHOT . SUCCESS [  0.594 s]
[INFO] Apache Oozie Hadoop Auth hadoop-2-4.4.0-SNAPSHOT Test SUCCESS [  1.105 s]
[INFO] Apache Oozie Hadoop Libs ... SUCCESS [  0.077 s]
[INFO] Apache Oozie Client  SUCCESS [ 47.838 s]
[INFO] Apache Oozie Share Lib Oozie ... SUCCESS [  4.537 s]
[INFO] Apache Oozie Share Lib HCatalog  SUCCESS [  6.325 s]
[INFO] Apache Oozie Share Lib Distcp .. SUCCESS [  1.564 s]
[INFO] Apache Oozie Core .. SUCCESS [01:47 min]
[INFO] Apache Oozie Share Lib Streaming ... SUCCESS [  6.296 s]
[INFO] Apache Oozie Share Lib Pig . SUCCESS [ 10.265 s]
[INFO] Apache Oozie Share Lib Hive  SUCCESS [ 18.950 s]
[INFO] Apache Oozie Share Lib Hive 2 .. SUCCESS [ 12.372 s]
[INFO] Apache Oozie Share Lib Sqoop ... SUCCESS [  1.516 s]
[INFO] Apache Oozie Examples .. SUCCESS [  7.097 s]
[INFO] Apache Oozie Share Lib Spark ... SUCCESS [ 33.294 s]
[INFO] Apache Oozie Share Lib . SUCCESS [01:34 min]
[INFO] Apache Oozie Docs .. SUCCESS [ 39.613 s]
[INFO] Apache Oozie WebApp  SUCCESS [01:45 min]
[INFO] Apache Oozie Tools . SUCCESS [  5.429 s]
[INFO] Apache Oozie MiniOozie . SUCCESS [  1.726 s]
[INFO] Apache Oozie Server  SUCCESS [  9.532 s]
[INFO] Apache Oozie Distro  SUCCESS [03:21 min]
[INFO] Apache Oozie ZooKeeper Security Tests .. SUCCESS [  5.168 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 12:20 min
[INFO] Finished at: 2017-03-29T00:35:57+00:00
[INFO] Final Memory: 113M/1031M
[INFO] 

Reports
  Running test-patch task CLEAN
  Running test-patch task RAW_PATCH_ANALYSIS
  Running test-patch task RAT
  Running test-patch task JAVADOC
  Running test-patch task COMPILE
  Running test-patch task FINDBUGS_DIFF
[TRACE] Downloading FindBugs diff JAR from 
https://repo1.maven.org/maven2/me/andrz/findbugs/findbugs-diff/0.1.0/findbugs-diff-0.1.0-all.jar
[TRACE] FindBugs diff JAR downloaded
grep: 
:
 No such file or directory
[TRACE] FindBugs diff JAR checked, is safe to use
[TRACE] Performing FindBugs diffs
bin/test-patch-11-findbugs-diff: line 253: : No such file or directory
bin/test-patch-11-findbugs-diff: line 255: [: -le: unary operator expected
Exception in thread "main" groovy.lang.GroovyRuntimeException: Ambiguous method 
overloading for method java.io.File#.
Cannot resolve which method to invoke for [null] due to overlapping prototypes 
between:
[class java.lang.String]
[class java.net.URI]
at 
groovy.lang.MetaClassImpl.chooseMostSpecificParams(MetaClassImpl.java:3202)
at 
groovy.lang.MetaClassImpl.chooseMethodInternal(MetaClassImpl.java:3154)
at groovy.lang.MetaClassImpl.chooseMethod(MetaClassImpl.java:3097)
at 
groovy.lang.MetaClassImpl.createConstructorSite(MetaClassImpl.java:3384)
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.createCallConstructorSite(CallSiteArray.java:88)
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:57)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:182)
at 

[jira] [Commented] (OOZIE-2845) Replace reflection-based code which sets variable in HiveConf

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946302#comment-15946302
 ] 

Hadoop QA commented on OOZIE-2845:
--

Testing JIRA OOZIE-2845

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [333] new bugs found below threshold in total 
that must be fixed.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:red}-1{color} There are [327] new bugs found below threshold in 
[server] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones): 
server/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At BinaryBlob.java:[line 68]: org.apache.oozie.BinaryBlob.getBytes() may 
expose internal representation by returning BinaryBlob.bytes
. org.apache.oozie.BinaryBlob.getRawBlob() may expose internal representation 
by returning BinaryBlob.rawBlob: Another occurrence at BinaryBlob.java:[line 88]
. Another occurrence at BinaryBlob.java:[line 116]: At BinaryBlob.java:[line 99]
. At BinaryBlob.java:[line 43]: new org.apache.oozie.BinaryBlob(byte[], 
boolean) may expose internal representation by storing an externally mutable 
object into BinaryBlob.bytes
. At BinaryBlob.java:[line 47]: new org.apache.oozie.BinaryBlob(byte[], 
boolean) may expose internal representation by storing an externally mutable 
object into BinaryBlob.rawBlob
. {color:green}+1{color} There are no new bugs found in [core].
. {color:red}-1{color} There are [6] new bugs found below threshold in 
[hadooplibs/hadoop-utils-2] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones): 
hadooplibs/hadoop-utils-2/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At DateList.java:[line 55]: Nullcheck of date at line 55 of value previously 
dereferenced in org.apache.oozie.example.DateList.main(String[])
. Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is 
never called: Redundant null check at DateList.java:[line 62]
. org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to 
clean up java.io.InputStream: At DateList.java:[line 97]
. Path continues at LocalOozieExample.java:[line 76]: Obligation to clean up 
resource created at LocalOozieExample.java:[line 72] is not discharged
. Path continues at LocalOozieExample.java:[line 78]: Path continues at 
LocalOozieExample.java:[line 77]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3746/

> Replace reflection-based code which sets variable in HiveConf
> -
>
> Key: OOZIE-2845
> 

[jira] [Commented] (OOZIE-2387) Oozie is Unable to handle Spaces in file/archive tag.

[Robert Kanter (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946275#comment-15946275
 ] 

Robert Kanter commented on OOZIE-2387:
--

I was talking to [~sai-krish] about this and you can use {{%20}} instead of a 
space as a workaround.  
I believe this is probably an HDFS issue, but we should double check.

> Oozie is Unable to handle Spaces in file/archive tag.
> -
>
> Key: OOZIE-2387
> URL: https://issues.apache.org/jira/browse/OOZIE-2387
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Affects Versions: 4.1.0, 4.2.0
> Environment: Hadoop 2.6,Oozie 4.1, Hortonworks2.2
>Reporter: shiv pratap singh
>
> Oozie file tag is unable to handle white spaces and other special characters.
> Error - 
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.addToCache(JavaActionExecutor.java:529)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.setLibFilesArchives(JavaActionExecutor.java:678)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:884)
> Sample XML File --
> 
>  xmlns:ns5="uri:oozie:shell-action:0.2"
>   xmlns:ns4="uri:oozie:workflow:0.4" 
> xmlns:ns3="uri:oozie:sqoop-action:0.2"
>   xmlns:ns2="uri:oozie:hive-action:0.3" name="test-shell-space">
>   
>   
>   
>   ${wf_hadoop_resourceManager}
>   ${wf_hadoop_nameNode}
>   shell 1.sh
>   /user/map-dev/test-case-dir/shell/script/shell 
> 1.sh
>   
>   
>   
>   
>   
>   shell-decision job failed
>   
>   
> 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2849) Fix build warnings when assembling directories

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946186#comment-15946186
 ] 

Hadoop QA commented on OOZIE-2849:
--

Testing JIRA OOZIE-2849

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
.Tests rerun: 29
.Tests failed at first run: 
org.apache.oozie.coord.TestCoordUtils,org.apache.oozie.command.wf.TestSubmitPigXCommand,org.apache.oozie.client.TestLocalOozie,org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC,org.apache.oozie.command.coord.TestCoordActionsKillXCommand,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3744/

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3744

[Apache Jenkins Server]

See 


--
[...truncated 954.02 KB...]
[INFO] Copying json-20090211.jar to 

[INFO] Copying jersey-client-1.9.jar to 

[INFO] Copying jetty-schemas-3.1.M0.jar to 

[INFO] Copying hadoop-annotations-2.4.0.jar to 

[INFO] Copying xbean-asm5-shaded-3.17.jar to 

[INFO] Copying oozie-client-4.4.0-SNAPSHOT.jar to 

[INFO] Copying serp-1.15.1.jar to 

[INFO] Copying asm-5.0.1.jar to 

[INFO] Copying openjpa-lib-2.4.1.jar to 

[INFO] Copying opencsv-2.3.jar to 

[INFO] Copying jasper-runtime-5.5.23.jar to 

[INFO] Copying curator-client-2.5.0.jar to 

[INFO] Copying jetty-annotations-9.2.19.v20160908.jar to 

[INFO] Copying jersey-server-1.9.jar to 

[INFO] Copying jackson-core-2.2.2.jar to 

[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache 

[jira] [Commented] (OOZIE-2848) Override sharelib.tgz in distro when rebuilding Oozie

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946159#comment-15946159
 ] 

Hadoop QA commented on OOZIE-2848:
--

Testing JIRA OOZIE-2848

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1906
.Tests failed: 5
.Tests errors: 3

.The patch failed the following testcases:

.  testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.  testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.  testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)

.Tests failing with errors:
.  testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
.  testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
.  testLoadDump(org.apache.oozie.tools.TestDBLoadDump)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3745/

> Override sharelib.tgz in distro when rebuilding Oozie
> -
>
> Key: OOZIE-2848
> URL: https://issues.apache.org/jira/browse/OOZIE-2848
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2848-01.patch
>
>
> Building Oozie with {{mvn package assembly:single -Dfindbugs.skip=true 
> -DskipTests -DjavaVersion=1.8 -DtargetVersion=1.7 -Puber}} twice in a row 
> results in the following error:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default-cli) on 
> project oozie-distro: Failed to create assembly: Error creating assembly 
> archive distro: Problem copying files : 
> /Users/asasvari/workspace/apache/oozie_dup/distro/target/oozie-4.4.0-SNAPSHOT-distro/oozie-4.4.0-SNAPSHOT/oozie-sharelib-4.4.0-SNAPSHOT.tar.gz
>  (Permission denied) -> [Help 1]
> {code}
> We can override the target like it is done for Oozie Client and TAR.GZ-s.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3745

[Apache Jenkins Server]

See 


--
[...truncated 966.76 KB...]
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ 
oozie-zookeeper-security-tests ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
oozie-zookeeper-security-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO] 

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946057#comment-15946057
 ] 

Hadoop QA commented on OOZIE-2753:
--

Testing JIRA OOZIE-2753

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 2 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
.Tests rerun: 56
.Tests failed at first run: 
org.apache.oozie.action.oozie.TestSubWorkflowActionExecutor,org.apache.oozie.command.coord.TestCoordRerunXCommand,org.apache.oozie.jms.TestJMSJobEventListener,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3743/

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch, 
> OOZIE-2753-06.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3743

[Apache Jenkins Server]

See 


--
[...truncated 962.36 KB...]
[INFO] Copying jersey-client-1.9.jar to 

[INFO] Copying jetty-schemas-3.1.M0.jar to 

[INFO] Copying hadoop-annotations-2.4.0.jar to 

[INFO] Copying xbean-asm5-shaded-3.17.jar to 

[INFO] Copying oozie-client-4.4.0-SNAPSHOT.jar to 

[INFO] Copying serp-1.15.1.jar to 

[INFO] Copying asm-5.0.1.jar to 

[INFO] Copying openjpa-lib-2.4.1.jar to 

[INFO] Copying opencsv-2.3.jar to 

[INFO] Copying jasper-runtime-5.5.23.jar to 

[INFO] Copying curator-client-2.5.0.jar to 

[INFO] Copying jetty-annotations-9.2.19.v20160908.jar to 

[INFO] Copying jersey-server-1.9.jar to 

[INFO] Copying jackson-core-2.2.2.jar to 

[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO]

[jira] [Commented] (OOZIE-2849) Fix build warnings when assembling directories

[Robert Kanter (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945948#comment-15945948
 ] 

Robert Kanter commented on OOZIE-2849:
--

I've moved this to a subtask of OOZIE-1702 because this JIRA is fixing one of 
the types of build warnings that we categorized there.

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Robert Kanter (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Kanter updated OOZIE-2849:
-
Issue Type: Sub-task  (was: Improvement)
Parent: OOZIE-1702

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Sub-task
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2849:
--
Attachment: OOZIE-2849-01.patch

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2849:
--
Attachment: (was: OOZIE-2849-01.patch)

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2849:
--
Attachment: (was: OOZIE-2849-01.patch)

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2849:
--
Attachment: OOZIE-2849-01.patch

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch, OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2849:
--
Attachment: OOZIE-2849-01.patch

> Fix build warnings when assembling directories
> --
>
> Key: OOZIE-2849
> URL: https://issues.apache.org/jira/browse/OOZIE-2849
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2849-01.patch, OOZIE-2849-01.patch
>
>
> When building oozie we can observe a lot of warning
> {code}
> [WARNING] Assembly file: 
> /Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
>  is not a regular file (it may be a directory). It cannot be attached to the 
> project build for installation or deployment.
> {code}
> This behaviour can be explained by 
> https://issues.apache.org/jira/browse/MASSEMBLY-628



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OOZIE-2849) Fix build warnings when assembling directories

[Attila Sasvari (JIRA)]

Attila Sasvari created OOZIE-2849:
-

 Summary: Fix build warnings when assembling directories
 Key: OOZIE-2849
 URL: https://issues.apache.org/jira/browse/OOZIE-2849
 Project: Oozie
  Issue Type: Improvement
Reporter: Attila Sasvari
Assignee: Attila Sasvari
Priority: Trivial


When building oozie we can observe a lot of warning
{code}
[WARNING] Assembly file: 
/Users/asasvari/workspace/apache/oozie_dup/tools/target/oozie-tools-4.4.0-SNAPSHOT-tools
 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
{code}

This behaviour can be explained by 
https://issues.apache.org/jira/browse/MASSEMBLY-628




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2848) Override sharelib.tgz in distro when rebuilding Oozie

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2848:
--
Attachment: OOZIE-2848-01.patch

> Override sharelib.tgz in distro when rebuilding Oozie
> -
>
> Key: OOZIE-2848
> URL: https://issues.apache.org/jira/browse/OOZIE-2848
> Project: Oozie
>  Issue Type: Improvement
>Reporter: Attila Sasvari
>Assignee: Attila Sasvari
>Priority: Trivial
> Attachments: OOZIE-2848-01.patch
>
>
> Building Oozie with {{mvn package assembly:single -Dfindbugs.skip=true 
> -DskipTests -DjavaVersion=1.8 -DtargetVersion=1.7 -Puber}} twice in a row 
> results in the following error:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default-cli) on 
> project oozie-distro: Failed to create assembly: Error creating assembly 
> archive distro: Problem copying files : 
> /Users/asasvari/workspace/apache/oozie_dup/distro/target/oozie-4.4.0-SNAPSHOT-distro/oozie-4.4.0-SNAPSHOT/oozie-sharelib-4.4.0-SNAPSHOT.tar.gz
>  (Permission denied) -> [Help 1]
> {code}
> We can override the target like it is done for Oozie Client and TAR.GZ-s.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945841#comment-15945841
 ] 

Attila Sasvari commented on OOZIE-2753:
---

[~abhishekbafna] please note {{git grep -i catalina}} still shows references at 
various places, e.g
sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestPasswordMasker.java
sharelib/oozie/src/test/resources/instrumentation-os-env.json
sharelib/oozie/src/test/resources/instrumentation-system-properties.json

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch, 
> OOZIE-2753-06.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2845) Replace reflection-based code which sets variable in HiveConf

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945621#comment-15945621
 ] 

Hadoop QA commented on OOZIE-2845:
--

Testing JIRA OOZIE-2845

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3742/

> Replace reflection-based code which sets variable in HiveConf
> -
>
> Key: OOZIE-2845
> URL: https://issues.apache.org/jira/browse/OOZIE-2845
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
> Attachments: OOZIE-2845-001.patch
>
>
> In different places, we use the following reflection-based code to reset a 
> variable inside {{HiveConf.java}}
> {code}
> public static void resetHiveConfStaticVariables() throws Exception {
> // HiveConf initializes location of hive-site.xml in static block.
> // So this is needed so that tests like TestHiveMain that create 
> hive-site.xml don't fail.
> Field declaredField = HiveConf.class.getDeclaredField("hiveSiteURL");
> declaredField.setAccessible(true);
> declaredField.set(null, 
> HiveConf.class.getClassLoader().getResource("hive-site.xml"));
> }
> {code}
> Note that HiveConf has supported setting {{hiveSiteURL}} for a long time. 
> Even version 0.13.0 has the static setter method:
> https://github.com/apache/hive/blob/branch-0.13/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L1493-L1495
> Therefore reflection-based solution should be modified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3742

[Apache Jenkins Server]

See 


--
[...truncated 861.92 KB...]
[INFO] Copying jetty-schemas-3.1.M0.jar to 

[INFO] Copying hadoop-annotations-2.4.0.jar to 

[INFO] Copying xbean-asm5-shaded-3.17.jar to 

[INFO] Copying oozie-client-4.4.0-SNAPSHOT.jar to 

[INFO] Copying serp-1.15.1.jar to 

[INFO] Copying asm-5.0.1.jar to 

[INFO] Copying openjpa-lib-2.4.1.jar to 

[INFO] Copying opencsv-2.3.jar to 

[INFO] Copying jasper-runtime-5.5.23.jar to 

[INFO] Copying curator-client-2.5.0.jar to 

[INFO] Copying jetty-annotations-9.2.19.v20160908.jar to 

[INFO] Copying jersey-server-1.9.jar to 

[INFO] Copying jackson-core-2.2.2.jar to 

[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

[Alonzo Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57870/
---

(Updated 三月 28, 2017, 5:41 p.m.)


Review request for oozie.


Changes
---

1 Update CoordWfActionInfoXCommand : move some SQLs and JPA calls from 
execute() to loadState(). 
2 Change the method getWfActionByJobIdAndName in BaseJobServlet from abstract 
to protected.
could you please take a look? thanks!


Repository: oozie-git


Description
---

More detailed view of the coordinator’s history can be observed from 
perspective of  workflow action.


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 
  core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 
  
core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
 PRE-CREATION 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java
 PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
4fc8653 
  core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 


Diff: https://reviews.apache.org/r/57870/diff/3/

Changes: https://reviews.apache.org/r/57870/diff/2-3/


Testing
---


Thanks,

Alonzo Zhou

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

[Alonzo Zhou]

> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
> > Lines 280-285 (patched)
> > 
> >
> > Why not have this default implementation in `BaseJobServlet` instead?
> 
> Alonzo Zhou wrote:
> hi, i noticed that the methods in BaseJobServlet was defined as an 
> abstract method in addition to doGet and doPut. in order to maintain 
> consistency, then i defined getWfActionsInCoord as an abstract.
> 
> András Piros wrote:
> There are already non-abstract methods like `checkAuthorizationForApp()` 
> present in `BaseJobServlet`, so I wouldn't mind putting there a `protected` 
> method those implementation is the same for all children. Having duplicate 
> code is never OK - [DRY 
> principle](https://en.wikipedia.org/wiki/Don't_repeat_yourself).

Thanks for your advice, i'll fix it right away.  and I will remember that 
"Having duplicate code is never OK".


- Alonzo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57870/#review169856
---


On 三月 28, 2017, 9:36 a.m., Alonzo Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57870/
> ---
> 
> (Updated 三月 28, 2017, 9:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> More detailed view of the coordinator’s history can be observed from 
> perspective of  workflow action.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 8ddb1f8 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 
>   core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 4fc8653 
>   core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 
> 
> 
> Diff: https://reviews.apache.org/r/57870/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alonzo Zhou
> 
>

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945519#comment-15945519
 ] 

Hadoop QA commented on OOZIE-2701:
--

Testing JIRA OOZIE-2701

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1912
.Tests rerun: 15
.Tests failed at first run: org.apache.oozie.jms.TestJMSJobEventListener,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3741/

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch, OOZIE-2701-09.patch, OOZIE-2701-10.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Jenkins build is back to normal : oozie-trunk-precommit-build #3741

[Apache Jenkins Server]

See 

Jenkins build is back to normal : oozie-trunk-find-patches-available #154918

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154917

[Apache Jenkins Server]

See 


--
Started by timer
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 890f69ead827467381983b185fd4fa9a6a0780cd 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 890f69ead827467381983b185fd4fa9a6a0780cd
 > git rev-list 890f69ead827467381983b185fd4fa9a6a0780cd # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson5250574371792009610.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:--  0:00:01 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:02 --:--:-- 0  0   
  00 00 0  0  0 --:--:--  0:00:03 --:--:-- 0  0 
00 00 0  0  0 --:--:--  0:00:04 --:--:-- 0  0 0 
   0 00 0  0  0 --:--:--  0:00:05 --:--:-- 0  0 0   
 0 00 0  0  0 --:--:--  0:00:05 --:--:-- 0  0 0
0 00 0  0  0 --:--:--  0:00:05 --:--:-- 0
curl: (52) Empty reply from server
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

[jira] [Updated] (OOZIE-2845) Replace reflection-based code which sets variable in HiveConf

[Peter Bacsko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated OOZIE-2845:

Attachment: OOZIE-2845-001.patch

> Replace reflection-based code which sets variable in HiveConf
> -
>
> Key: OOZIE-2845
> URL: https://issues.apache.org/jira/browse/OOZIE-2845
> Project: Oozie
>  Issue Type: Improvement
>  Components: core
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
> Attachments: OOZIE-2845-001.patch
>
>
> In different places, we use the following reflection-based code to reset a 
> variable inside {{HiveConf.java}}
> {code}
> public static void resetHiveConfStaticVariables() throws Exception {
> // HiveConf initializes location of hive-site.xml in static block.
> // So this is needed so that tests like TestHiveMain that create 
> hive-site.xml don't fail.
> Field declaredField = HiveConf.class.getDeclaredField("hiveSiteURL");
> declaredField.setAccessible(true);
> declaredField.set(null, 
> HiveConf.class.getClassLoader().getResource("hive-site.xml"));
> }
> {code}
> Note that HiveConf has supported setting {{hiveSiteURL}} for a long time. 
> Even version 0.13.0 has the static setter method:
> https://github.com/apache/hive/blob/branch-0.13/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L1493-L1495
> Therefore reflection-based solution should be modified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Abhishek Bafna (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Bafna updated OOZIE-2701:
--
Attachment: OOZIE-2701-10.patch

[~gezapeti] Thank You. it was left from local testing. Removed it.

> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch, OOZIE-2701-09.patch, OOZIE-2701-10.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945258#comment-15945258
 ] 

Abhishek Bafna commented on OOZIE-2841:
---

[~gezapeti]  I think this can be committed directly without any amend patch. 
Otherwise, we can take care of this into our next commit. Thanks.

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945248#comment-15945248
 ] 

Peter Cseh commented on OOZIE-2701:
---

[~abhishekbafna], I'm working on testing out this patch.
Until I manage to test it out on a cluster here is a minor thing:
There is a {{System.out}} left in HCatELFunctions. Please replace it with XLog 
:)


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch, OOZIE-2701-09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2841) Limit FindBugs diff errors in JIRA comments

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-2841:
--
Attachment: OOZIE-2841.amend.patch

> Limit FindBugs diff errors in JIRA comments
> ---
>
> Key: OOZIE-2841
> URL: https://issues.apache.org/jira/browse/OOZIE-2841
> Project: Oozie
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
> Attachments: OOZIE-2841.001.patch, OOZIE-2841.002.patch, 
> OOZIE-2841.amend.patch, OOZIE-2841.wrong.patch, 
> test-patch-reports.after.tar.gz, test-patch-reports.before.tar.gz
>
>
> In OOZIE-1986 the FindBugs diff functionality was introduced. At times, 
> however, there are cases when it's painful that we print out each and every 
> FindBugs error (the ones considered mandatory to be fixed) [*to the JIRA 
> comment*|https://issues.apache.org/jira/browse/OOZIE-2812?focusedCommentId=15937447=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937447].
> We'll limit the FindBugs errors to be displayed within a module (let's say, 
> top 5 from a module). This limitation will only be valid for 
> {{TEST-SUMMARY.jira}} and {{TEST-SUMMARY.txt}} - for 
> {{TEST-SUMMARY-FULL.jira}} and {{TEST-SUMMARY-FULL.txt}} the output remains 
> unchanged.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945222#comment-15945222
 ] 

Abhishek Bafna commented on OOZIE-2753:
---

[~asasvari] Sorry missed some of the points in the last review:

We should clean up the {{oozie-env.sh}}. Also it is referred into 
{{AG_install}} in the end. Can we update that well.


> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2847) Oozie Ha timing issue

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945204#comment-15945204
 ] 

Andras Piros commented on OOZIE-2847:
-

[~bpgergo] thanks for the contribution!

My thoughts:
* in the original stack trace I cannot see the log message {{Hadoop job id 
mismatch}} that would suggest the code path affected by the fix is being run
* how can Oozie be sure about that when a job Id file is present but empty, 
it's for sure the actual job Id of the {{JobConf}} entry {{mapred.job.id}}? The 
patch would always overwrite the empty file w/ the actual one
* from the unit test method name alone I cannot conclude what are the 
prerequisites, and what is the observable behavior. If possible, please use 
better naming, and multiple test methods each testing only one piece of 
functionality / use case

> Oozie Ha timing issue
> -
>
> Key: OOZIE-2847
> URL: https://issues.apache.org/jira/browse/OOZIE-2847
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Affects Versions: 4.3.0
>Reporter: Péter Gergő Barna
>Priority: Minor
> Attachments: OOZIE-2847.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Oozie Ha timing issue
> When Oozie is launching the mapper, it is writing a job id into a file on 
> hdfs. Let's assume the ApplicationMaster is killed, and Oozie will make a 
> second try, during recovery. On the second try, Oozie is trying to see if the 
> previously written job id on hdfs matches the current job id. In most 
> occasion, this will match. However, in the event when Oozie launcher is 
> killed right in the middle when Oozie is in the process of writing id in the 
> file, the Oozie file in hdfs is created, but the id has yet to be written to 
> the file. During the next recovery, Oozie will mistakenly think the id exists 
> in the file while the file is actually empty, therefore throwing this 
> exception: 
> {noformat}
> 2015-07-10 
> 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|
> 2015-07-10 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|Console URL  
>  : http://dal-ha21:8088/proxy/application_1436507526035_0001/
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Code   
>  : JA018
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error 
> Message : Hadoop job Id mismatch, action file 
> [hdfs://hdp2-ha2/user/hadoopqa/oozie-hado/003-150710041341636-oozie-hado-W/pig-node--pig/003-150710041341636-oozie-hado-W@pig-node@0]
>  declares Id [null] current Id [job_1436507526035_0001]
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External ID  
>  : job_1436507526035_0001
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External 
> Status   : FAILED/KILLED
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Name 
>  : pig-node
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Retries  
>  : 0
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Tracker URI  
>  : dal-ha21:8032
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Type 
>  : pig
> 2015-07-10 05:56:58,158|beaver.machine|INFO|5208|1344|MainThread|Started  
>  : 2015-07-10 05:55:19 GMT
> 2015-07-10 05:56:58,160|beaver.machine|INFO|5208|1344|MainThread|Status   
>  : ERROR
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|Ended
>  : 2015-07-10 05:56:42 GMT
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
> Stats: null
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
> ChildIDs : null
> 2015-07-10 
> 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|
> Exception:
> 2015-07-10 05:56:18,658 INFO [main] 
> org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file 
> system [hdfs://hdp2-ha2:8020]
> 2015-07-10 05:56:18,665 INFO [main] 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Previous history file is at 
> hdfs://hdp2-ha2:8020/user/hadoopqa/.staging/job_1436507526035_0001/job_1436507526035_0001_1.jhist
> 2015-07-10 05:56:18,693 WARN [main] 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Unable to parse prior job 
> history, aborting recovery
> java.io.IOException: Incompatible event log version: null
>   at 
> org.apache.hadoop.mapreduce.jobhistory.EventReader.(EventReader.java:71)
>   at 
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser.parse(JobHistoryParser.java:139)
>   at 
> 

[jira] [Updated] (OOZIE-2847) Oozie Ha timing issue

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-2847:

Description: 
Oozie Ha timing issue

When Oozie is launching the mapper, it is writing a job id into a file on hdfs. 
Let's assume the ApplicationMaster is killed, and Oozie will make a second try, 
during recovery. On the second try, Oozie is trying to see if the previously 
written job id on hdfs matches the current job id. In most occasion, this will 
match. However, in the event when Oozie launcher is killed right in the middle 
when Oozie is in the process of writing id in the file, the Oozie file in hdfs 
is created, but the id has yet to be written to the file. During the next 
recovery, Oozie will mistakenly think the id exists in the file while the file 
is actually empty, therefore throwing this exception: 

{noformat}
2015-07-10 
05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|
2015-07-10 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|Console URL
   : http://dal-ha21:8088/proxy/application_1436507526035_0001/
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Code 
   : JA018
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Message  
   : Hadoop job Id mismatch, action file 
[hdfs://hdp2-ha2/user/hadoopqa/oozie-hado/003-150710041341636-oozie-hado-W/pig-node--pig/003-150710041341636-oozie-hado-W@pig-node@0]
 declares Id [null] current Id [job_1436507526035_0001]
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External ID
   : job_1436507526035_0001
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External 
Status   : FAILED/KILLED
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Name   
   : pig-node
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Retries
   : 0
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Tracker URI
   : dal-ha21:8032
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Type   
   : pig
2015-07-10 05:56:58,158|beaver.machine|INFO|5208|1344|MainThread|Started
   : 2015-07-10 05:55:19 GMT
2015-07-10 05:56:58,160|beaver.machine|INFO|5208|1344|MainThread|Status 
   : ERROR
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|Ended  
   : 2015-07-10 05:56:42 GMT
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External Stats 
   : null
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
ChildIDs : null
2015-07-10 
05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|
Exception:
2015-07-10 05:56:18,658 INFO [main] 
org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file system 
[hdfs://hdp2-ha2:8020]
2015-07-10 05:56:18,665 INFO [main] 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Previous history file is at 
hdfs://hdp2-ha2:8020/user/hadoopqa/.staging/job_1436507526035_0001/job_1436507526035_0001_1.jhist
2015-07-10 05:56:18,693 WARN [main] 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Unable to parse prior job 
history, aborting recovery
java.io.IOException: Incompatible event log version: null
at 
org.apache.hadoop.mapreduce.jobhistory.EventReader.(EventReader.java:71)
at 
org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser.parse(JobHistoryParser.java:139)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.parsePreviousJobHistory(MRAppMaster.java:1206)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.processRecovery(MRAppMaster.java:1175)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStart(MRAppMaster.java:1039)
at 
org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster$4.run(MRAppMaster.java:1519)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.initAndStartAppMaster(MRAppMaster.java:1515)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.main(MRAppMaster.java:1448)
2015-07-10 05:56:18,737 INFO [main] 
org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file system 
[hdfs://hdp2-ha2:8020]
2015-07-10 05:56:18,745 INFO [main] 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Previous history file is at 
hdfs://hdp2-ha2:8020/user/hadoopqa/.staging/job_1436507526035_0001/job_1436507526035_0001_1.jhist
{noformat}

  was:
Oozie Ha timing 

[jira] [Updated] (OOZIE-2847) Oozie Ha timing issue

[JIRA]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Péter Gergő Barna updated OOZIE-2847:
-
Attachment: OOZIE-2847.patch

> Oozie Ha timing issue
> -
>
> Key: OOZIE-2847
> URL: https://issues.apache.org/jira/browse/OOZIE-2847
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Affects Versions: 4.3.0
>Reporter: Péter Gergő Barna
>Priority: Minor
> Attachments: OOZIE-2847.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Oozie Ha timing issue
> When Oozie is launching the mapper, it is writing a job id into a file on 
> hdfs. Let's assume the ApplicationMaster is killed, and Oozie will make a 
> second try, during recovery. On the second try, Oozie is trying to see if the 
> previously written job id on hdfs matches the current job id. In most 
> occasion, this will match. However, in the event when Oozie launcher is 
> killed right in the middle when Oozie is in the process of writing id in the 
> file, the Oozie file in hdfs is created, but the id has yet to be written to 
> the file. During the next recovery, Oozie will mistakenly think the id exists 
> in the file while the file is actually empty, therefore throwing this 
> exception: 
> {{monospaced}}
> 2015-07-10 
> 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|
> 2015-07-10 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|Console URL  
>  : http://dal-ha21:8088/proxy/application_1436507526035_0001/
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Code   
>  : JA018
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error 
> Message : Hadoop job Id mismatch, action file 
> [hdfs://hdp2-ha2/user/hadoopqa/oozie-hado/003-150710041341636-oozie-hado-W/pig-node--pig/003-150710041341636-oozie-hado-W@pig-node@0]
>  declares Id [null] current Id [job_1436507526035_0001]
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External ID  
>  : job_1436507526035_0001
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External 
> Status   : FAILED/KILLED
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Name 
>  : pig-node
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Retries  
>  : 0
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Tracker URI  
>  : dal-ha21:8032
> 2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Type 
>  : pig
> 2015-07-10 05:56:58,158|beaver.machine|INFO|5208|1344|MainThread|Started  
>  : 2015-07-10 05:55:19 GMT
> 2015-07-10 05:56:58,160|beaver.machine|INFO|5208|1344|MainThread|Status   
>  : ERROR
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|Ended
>  : 2015-07-10 05:56:42 GMT
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
> Stats: null
> 2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
> ChildIDs : null
> 2015-07-10 
> 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|
> Exception:
> 2015-07-10 05:56:18,658 INFO [main] 
> org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file 
> system [hdfs://hdp2-ha2:8020]
> 2015-07-10 05:56:18,665 INFO [main] 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Previous history file is at 
> hdfs://hdp2-ha2:8020/user/hadoopqa/.staging/job_1436507526035_0001/job_1436507526035_0001_1.jhist
> 2015-07-10 05:56:18,693 WARN [main] 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Unable to parse prior job 
> history, aborting recovery
> java.io.IOException: Incompatible event log version: null
>   at 
> org.apache.hadoop.mapreduce.jobhistory.EventReader.(EventReader.java:71)
>   at 
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser.parse(JobHistoryParser.java:139)
>   at 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.parsePreviousJobHistory(MRAppMaster.java:1206)
>   at 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.processRecovery(MRAppMaster.java:1175)
>   at 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStart(MRAppMaster.java:1039)
>   at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
>   at 
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster$4.run(MRAppMaster.java:1519)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:415)
>   at 
> 

[jira] [Created] (OOZIE-2847) Oozie Ha timing issue

[JIRA]

Péter Gergő Barna created OOZIE-2847:


 Summary: Oozie Ha timing issue
 Key: OOZIE-2847
 URL: https://issues.apache.org/jira/browse/OOZIE-2847
 Project: Oozie
  Issue Type: Bug
  Components: HA
Affects Versions: 4.3.0
Reporter: Péter Gergő Barna
Priority: Minor


Oozie Ha timing issue

When Oozie is launching the mapper, it is writing a job id into a file on hdfs. 
Let's assume the ApplicationMaster is killed, and Oozie will make a second try, 
during recovery. On the second try, Oozie is trying to see if the previously 
written job id on hdfs matches the current job id. In most occasion, this will 
match. However, in the event when Oozie launcher is killed right in the middle 
when Oozie is in the process of writing id in the file, the Oozie file in hdfs 
is created, but the id has yet to be written to the file. During the next 
recovery, Oozie will mistakenly think the id exists in the file while the file 
is actually empty, therefore throwing this exception: 

{{monospaced}}
2015-07-10 
05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|
2015-07-10 05:56:58,137|beaver.machine|INFO|5208|1344|MainThread|Console URL
   : http://dal-ha21:8088/proxy/application_1436507526035_0001/
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Code 
   : JA018
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Error Message  
   : Hadoop job Id mismatch, action file 
[hdfs://hdp2-ha2/user/hadoopqa/oozie-hado/003-150710041341636-oozie-hado-W/pig-node--pig/003-150710041341636-oozie-hado-W@pig-node@0]
 declares Id [null] current Id [job_1436507526035_0001]
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External ID
   : job_1436507526035_0001
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|External 
Status   : FAILED/KILLED
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Name   
   : pig-node
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Retries
   : 0
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Tracker URI
   : dal-ha21:8032
2015-07-10 05:56:58,138|beaver.machine|INFO|5208|1344|MainThread|Type   
   : pig
2015-07-10 05:56:58,158|beaver.machine|INFO|5208|1344|MainThread|Started
   : 2015-07-10 05:55:19 GMT
2015-07-10 05:56:58,160|beaver.machine|INFO|5208|1344|MainThread|Status 
   : ERROR
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|Ended  
   : 2015-07-10 05:56:42 GMT
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External Stats 
   : null
2015-07-10 05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|External 
ChildIDs : null
2015-07-10 
05:56:58,161|beaver.machine|INFO|5208|1344|MainThread|
Exception:
2015-07-10 05:56:18,658 INFO [main] 
org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file system 
[hdfs://hdp2-ha2:8020]
2015-07-10 05:56:18,665 INFO [main] 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Previous history file is at 
hdfs://hdp2-ha2:8020/user/hadoopqa/.staging/job_1436507526035_0001/job_1436507526035_0001_1.jhist
2015-07-10 05:56:18,693 WARN [main] 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Unable to parse prior job 
history, aborting recovery
java.io.IOException: Incompatible event log version: null
at 
org.apache.hadoop.mapreduce.jobhistory.EventReader.(EventReader.java:71)
at 
org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser.parse(JobHistoryParser.java:139)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.parsePreviousJobHistory(MRAppMaster.java:1206)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.processRecovery(MRAppMaster.java:1175)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStart(MRAppMaster.java:1039)
at 
org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster$4.run(MRAppMaster.java:1519)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.initAndStartAppMaster(MRAppMaster.java:1515)
at 
org.apache.hadoop.mapreduce.v2.app.MRAppMaster.main(MRAppMaster.java:1448)
2015-07-10 05:56:18,737 INFO [main] 
org.apache.hadoop.mapreduce.v2.jobhistory.JobHistoryUtils: Default file system 
[hdfs://hdp2-ha2:8020]
2015-07-10 05:56:18,745 INFO [main] 

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

[András Piros]

> On March 24, 2017, 12:24 p.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
> > Lines 345 (patched)
> > 
> >
> > Please refactor these nested classes (make them non-nested). The whole 
> > class is too big with these classes being defined here.

+1 on extracting nested classes, and applying SRP.


> On March 24, 2017, 12:24 p.m., Peter Bacsko wrote:
> > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java
> > Lines 453 (patched)
> > 
> >
> > As I can see it, this is not the visitor pattern.
> > 
> > Traditionally, when you use the visitor pattern, the classes that are 
> > to be visited implement the accept() method which takes the visitor 
> > implementation as an argument. Then, if the class contains other classes 
> > that can be visited, it calls the accept() method on the embedded object 
> > again, effectively passing the visitor implementation down the call stack.
> > 
> > Also, the visitation begins by calling the accept() method on the 
> > top-most (external) object.
> > 
> > There is a very good, simple example here:
> > https://en.wikipedia.org/wiki/Visitor_pattern#Java_example
> > 
> > I think this is just having different implementations, which are hidden 
> > under an interface (which is good)/
> > 
> > I suggest doing the following rename:
> > - OozieActionVisitor --> OozieActionHandler
> > - AbstractOozieActionVisitor --> AbstractOozieActionHandler
> > - Killing/Resuming/SuspendingVisitor --> 
> > Killing/Resuming/SuspendingHandler

Visitor pattern can be heavyweight here, agreed. Renaming `*Visitor` to 
`*Handler` would remove confusion.


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54383/#review16
---


On Jan. 5, 2017, 5:34 p.m., Abhishek Bafna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54383/
> ---
> 
> (Updated Jan. 5, 2017, 5:34 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2751
> https://issues.apache.org/jira/browse/OOZIE-2751
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> LocalOozieClient is missing methods from OozieClient
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 12c80cb 
>   core/src/main/java/org/apache/oozie/BaseEngine.java 50df897 
>   core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java PRE-CREATION 
>   core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76 
>   core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0 
>   core/src/main/java/org/apache/oozie/OozieJsonFactory.java PRE-CREATION 
>   core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java 2c79ef0 
>   core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 80c8ec4 
>   core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 4decd52 
> 
> 
> Diff: https://reviews.apache.org/r/54383/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Bafna
> 
>

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945024#comment-15945024
 ] 

Hadoop QA commented on OOZIE-2753:
--

Testing JIRA OOZIE-2753

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 2 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
.Tests rerun: 15
.Tests failed at first run: org.apache.oozie.jms.TestJMSJobEventListener,
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3740/

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3740

[Apache Jenkins Server]

See 


--
[...truncated 958.42 KB...]
[INFO] Copying jersey-client-1.9.jar to 

[INFO] Copying jetty-schemas-3.1.M0.jar to 

[INFO] Copying hadoop-annotations-2.4.0.jar to 

[INFO] Copying xbean-asm5-shaded-3.17.jar to 

[INFO] Copying oozie-client-4.4.0-SNAPSHOT.jar to 

[INFO] Copying serp-1.15.1.jar to 

[INFO] Copying asm-5.0.1.jar to 

[INFO] Copying openjpa-lib-2.4.1.jar to 

[INFO] Copying opencsv-2.3.jar to 

[INFO] Copying jasper-runtime-5.5.23.jar to 

[INFO] Copying curator-client-2.5.0.jar to 

[INFO] Copying jetty-annotations-9.2.19.v20160908.jar to 

[INFO] Copying jersey-server-1.9.jar to 

[INFO] Copying jackson-core-2.2.2.jar to 

[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO]

[jira] [Commented] (OOZIE-2846) TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944985#comment-15944985
 ] 

Hadoop QA commented on OOZIE-2846:
--

Testing JIRA OOZIE-2846

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1906
.Tests failed: 5
.Tests errors: 3

.The patch failed the following testcases:

.  testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.  testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.  testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.  testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)

.Tests failing with errors:
.  testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
.  testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
.  testLoadDump(org.apache.oozie.tools.TestDBLoadDump)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3739/

> TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4
> --
>
> Key: OOZIE-2846
> URL: https://issues.apache.org/jira/browse/OOZIE-2846
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Attachments: OOZIE-2846.001.patch, OOZIE-2846.002.patch
>
>
> We've tested using Oozie with different Jetty versions and found that the 
> test TestSSLServerConnectorFactory is failing for newer Jetty versions.
> Changing the @Mock to @Spy on the Server solves the issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3739

[Apache Jenkins Server]

See 


--
[...truncated 967.06 KB...]
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
oozie-zookeeper-security-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-zookeeper-security-tests ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-zookeeper-security-tests ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ 
oozie-zookeeper-security-tests ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
oozie-zookeeper-security-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-zookeeper-security-tests ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ 
oozie-zookeeper-security-tests ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO] 

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

[András Piros]

> On March 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
> > Lines 102-105 (patched)
> > 
> >
> > I'm wondering whether some of the SQLs and JPA calls of `execute()` 
> > couldn't be done here. `loadState()` is called only once, but `execute()` 
> > possibly many times.
> 
> Alonzo Zhou wrote:
> hi , if call XCommand.call(), loadState() and execute() will both 
> execute, so i think this doesnt much matter. did i think wrong?

You're right, these are meant to be called exactly the same times. 
Nevertheless, semantically it would be much nicer to use `loadState()` for - 
err, loading the state of the command :D


> On March 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
> > Lines 280-285 (patched)
> > 
> >
> > Why not have this default implementation in `BaseJobServlet` instead?
> 
> Alonzo Zhou wrote:
> hi, i noticed that the methods in BaseJobServlet was defined as an 
> abstract method in addition to doGet and doPut. in order to maintain 
> consistency, then i defined getWfActionsInCoord as an abstract.

There are already non-abstract methods like `checkAuthorizationForApp()` 
present in `BaseJobServlet`, so I wouldn't mind putting there a `protected` 
method those implementation is the same for all children. Having duplicate code 
is never OK - [DRY 
principle](https://en.wikipedia.org/wiki/Don't_repeat_yourself).


> On March 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
> > Lines 1142-1146 (patched)
> > 
> >
> > Why not have this default implementation in `BaseJobServlet` instead?
> 
> Alonzo Zhou wrote:
> hi, i noticed that the methods in BaseJobServlet was defined as an 
> abstract method in addition to doGet and doPut. in order to maintain 
> consistency, then i defined getWfActionsInCoord as an abstract.

There are already non-abstract methods like `checkAuthorizationForApp()` 
present in `BaseJobServlet`, so I wouldn't mind putting there a `protected` 
method those implementation is the same for all children. Having duplicate code 
is never OK - [DRY 
principle](https://en.wikipedia.org/wiki/Don't_repeat_yourself).


- András


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57870/#review169856
---


On March 28, 2017, 9:36 a.m., Alonzo Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57870/
> ---
> 
> (Updated March 28, 2017, 9:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> More detailed view of the coordinator’s history can be observed from 
> perspective of  workflow action.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 8ddb1f8 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 
>   core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 
>   core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 
>   core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
> 4fc8653 
>   core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 
> 
> 
> Diff: https://reviews.apache.org/r/57870/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alonzo Zhou
> 
>

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Peter Bacsko (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944941#comment-15944941
 ] 

Peter Bacsko commented on OOZIE-2753:
-

+1 LGTM

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: oozie-trunk-precommit-build #3738

[Apache Jenkins Server]

See 


--
[...truncated 916.17 KB...]
[INFO] Copying hadoop-annotations-2.4.0.jar to 

[INFO] Copying xbean-asm5-shaded-3.17.jar to 

[INFO] Copying oozie-client-4.4.0-SNAPSHOT.jar to 

[INFO] Copying serp-1.15.1.jar to 

[INFO] Copying asm-5.0.1.jar to 

[INFO] Copying openjpa-lib-2.4.1.jar to 

[INFO] Copying opencsv-2.3.jar to 

[INFO] Copying jasper-runtime-5.5.23.jar to 

[INFO] Copying curator-client-2.5.0.jar to 

[INFO] Copying jetty-annotations-9.2.19.v20160908.jar to 

[INFO] Copying jersey-server-1.9.jar to 

[INFO] Copying jackson-core-2.2.2.jar to 

[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-server ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/empty.xml
[INFO] 
[INFO] 
[INFO] Building Apache Oozie Distro 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ oozie-distro 
---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ oozie-distro 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
oozie-distro ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
oozie-distro ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.2:test (default-test) @ oozie-distro ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ oozie-distro ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:2.0-beta-6:attach-descriptor (attach-descriptor) @ 
oozie-distro ---
[INFO] 
[INFO] --- maven-assembly-plugin:2.2.1:single (default-cli) @ oozie-distro ---
[INFO] Reading assembly descriptor: ../src/main/assemblies/distro.xml
[INFO] Copying files to 

[WARNING] Assembly file: 

 is not a regular file (it may be a directory). It cannot be attached to the 
project build for installation or deployment.
[INFO] Building tar : 

[INFO] 
[INFO] 
[INFO] Building Apache Oozie ZooKeeper Security Tests 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944883#comment-15944883
 ] 

Hadoop QA commented on OOZIE-2753:
--

Testing JIRA OOZIE-2753

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 2 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in 
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1906
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/oozie-trunk-precommit-build/3738/

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

[Alonzo Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57870/
---

(Updated 三月 28, 2017, 9:36 a.m.)


Review request for oozie.


Repository: oozie-git


Description
---

More detailed view of the coordinator’s history can be observed from 
perspective of  workflow action.


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 8ddb1f8 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 
  core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 
  
core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
 PRE-CREATION 
  core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 
  core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java d3b4689 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 9356768 
  core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d 
  core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java
 PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 
4fc8653 
  core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 


Diff: https://reviews.apache.org/r/57870/diff/2/

Changes: https://reviews.apache.org/r/57870/diff/1-2/


Testing
---


Thanks,

Alonzo Zhou

[jira] [Assigned] (OOZIE-2844) Increase stability of Oozie actions when log4j.properties is missing or not readable

[Andras Piros (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros reassigned OOZIE-2844:
---

Assignee: Andras Piros

> Increase stability of Oozie actions when log4j.properties is missing or not 
> readable
> 
>
> Key: OOZIE-2844
> URL: https://issues.apache.org/jira/browse/OOZIE-2844
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 4.3.0
>Reporter: Andras Piros
>Assignee: Andras Piros
>
> In several Oozie actions we face the problem that if {{log4j.properties}} is 
> not readable by current thread, or not present on the classpath, while taking 
> an {{URL.openStream()}} call afterwards, an {{IOException}} is thrown and the 
> action won't run.
> Such actions are:
> * 
> [*{{DistcpMain}}*|https://github.com/apache/oozie/blob/master/sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java#L135]
> * 
> [*{{HiveMain}}*|https://github.com/apache/oozie/blob/master/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java#L146]
> * 
> [*{{PigMain}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java#L173]
> * 
> [*{{PigMainWithOldApi}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java#L160]
> * 
> [*{{SparkMain}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L430]
> * 
> [*{{SqoopMain}}*|https://github.com/apache/oozie/blob/master/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java#L124]
> Extend 
> [*{{LauncherMain.run()}}*|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L62-L65]
>  by a convenience method that loads Hadoop's {{log4j.properties}} in 
> beforehand. In case {{URL.openStream()}} would throw {{IOException}} we 
> resort to a call to a new file {{hadoop-default-log4j.properties}} on the 
> classpath (packaged along w/ {{LauncherMain.class}}) that has the same 
> contents as the {{log4j.properties}} that is not accessible / readable / 
> present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2846) TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4

[Andras Piros (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944836#comment-15944836
 ] 

Andras Piros commented on OOZIE-2846:
-

[~gezapeti] thanks for the patch! +1 (non-binding)

> TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4
> --
>
> Key: OOZIE-2846
> URL: https://issues.apache.org/jira/browse/OOZIE-2846
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Attachments: OOZIE-2846.001.patch, OOZIE-2846.002.patch
>
>
> We've tested using Oozie with different Jetty versions and found that the 
> test TestSSLServerConnectorFactory is failing for newer Jetty versions.
> Changing the @Mock to @Spy on the Server solves the issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944828#comment-15944828
 ] 

Abhishek Bafna edited comment on OOZIE-2701 at 3/28/17 9:09 AM:


[~gezapeti] There was change in regex used for identifying the URLs and moved 
the test cases also into the core module. Can you take another look, for 
resolving this. Thanks.



was (Author: abhishekbafna):
[~gezapeti] There was change in regex used of identifying the URLs and moved 
the test cases also into the core module. Can you take another look, for 
resolving this. Thanks.


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch, OOZIE-2701-09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Attila Sasvari (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Sasvari updated OOZIE-2753:
--
Attachment: OOZIE-2753-05.patch

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch, OOZIE-2753-05.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2701) Oozie to support Multiple HCatalog URIs

[Abhishek Bafna (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944828#comment-15944828
 ] 

Abhishek Bafna commented on OOZIE-2701:
---

[~gezapeti] There was change in regex used of identifying the URLs and moved 
the test cases also into the core module. Can you take another look, for 
resolving this. Thanks.


> Oozie to support Multiple HCatalog URIs
> ---
>
> Key: OOZIE-2701
> URL: https://issues.apache.org/jira/browse/OOZIE-2701
> Project: Oozie
>  Issue Type: New Feature
>  Components: core
>Reporter: Abhishek Bafna
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch, 
> OOZIE-2701-08.patch, OOZIE-2701-09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (OOZIE-2846) TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4

[Peter Cseh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OOZIE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Cseh updated OOZIE-2846:
--
Attachment: OOZIE-2846.002.patch

> TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4
> --
>
> Key: OOZIE-2846
> URL: https://issues.apache.org/jira/browse/OOZIE-2846
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Attachments: OOZIE-2846.001.patch, OOZIE-2846.002.patch
>
>
> We've tested using Oozie with different Jetty versions and found that the 
> test TestSSLServerConnectorFactory is failing for newer Jetty versions.
> Changing the @Mock to @Spy on the Server solves the issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2846) TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4

[Peter Cseh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944808#comment-15944808
 ] 

Peter Cseh commented on OOZIE-2846:
---

This is affecting TestEmbeddedOozieServer as well. Will attach a second patch 
soon.

> TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4
> --
>
> Key: OOZIE-2846
> URL: https://issues.apache.org/jira/browse/OOZIE-2846
> Project: Oozie
>  Issue Type: Bug
>Reporter: Peter Cseh
>Assignee: Peter Cseh
> Attachments: OOZIE-2846.001.patch
>
>
> We've tested using Oozie with different Jetty versions and found that the 
> test TestSSLServerConnectorFactory is failing for newer Jetty versions.
> Changing the @Mock to @Spy on the Server solves the issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Attila Sasvari (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944809#comment-15944809
 ] 

Attila Sasvari commented on OOZIE-2753:
---

[~pbacsko] thanks. Earlier it contained rkanter, but I can change it to oozie. 

> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Peter Bacsko (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944789#comment-15944789
 ] 

Peter Bacsko edited comment on OOZIE-2753 at 3/28/17 8:52 AM:
--

Minor:

This line (and several ones below it) contains your username (asasvari), IMO 
it's better to change it to "oozie":

{code}
JETTY_OPTS :  -Doozie.home.dir=/Users/asasvari/dev/oozie 
-Doozie.config.dir=/Users/asasvari/dev/oozie/conf 
-Doozie.log.dir=/Users/asasvari/dev/oozie/logs 
-Doozie.data.dir=/Users/asasvari/dev/oozie/data 
-Doozie.config.file=oozie-site.xml -Doozie.log4j.file=oozie-log4j.properties 
-Doozie.log4j.reload=10 -Djava.library.path= -cp 
/Users/asasvari/dev/oozie/embedded-oozie-server/*:/Users/asasvari/dev/oozie/embedded-oozie-server/dependency/*:/Users/asasvari/dev/oozie/lib/*:/Users/asasvari/dev/oozie/libtools/*:/Users/asasvari/dev/oozie/embedded-oozie-server
{code}


was (Author: pbacsko):
Minor:

This line (and several ones below it) contains your username (asasvari), IMO 
it's better to change it to "oozie":

{{+JETTY_OPTS :  -Doozie.home.dir=/Users/asasvari/dev/oozie 
-Doozie.config.dir=/Users/asasvari/dev/oozie/conf 
-Doozie.log.dir=/Users/asasvari/dev/oozie/logs 
-Doozie.data.dir=/Users/asasvari/dev/oozie/data 
-Doozie.config.file=oozie-site.xml -Doozie.log4j.file=oozie-log4j.properties 
-Doozie.log4j.reload=10 -Djava.library.path= -cp 
/Users/asasvari/dev/oozie/embedded-oozie-server/*:/Users/asasvari/dev/oozie/embedded-oozie-server/dependency/*:/Users/asasvari/dev/oozie/lib/*:/Users/asasvari/dev/oozie/libtools/*:/Users/asasvari/dev/oozie/embedded-oozie-server}}



> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OOZIE-2753) Update Docs for Jetty Tomcat changes

[Peter Bacsko (JIRA)]

[ 
https://issues.apache.org/jira/browse/OOZIE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944789#comment-15944789
 ] 

Peter Bacsko commented on OOZIE-2753:
-

Minor:

This line (and several ones below it) contains your username (asasvari), IMO 
it's better to change it to "oozie":

{{+JETTY_OPTS :  -Doozie.home.dir=/Users/asasvari/dev/oozie 
-Doozie.config.dir=/Users/asasvari/dev/oozie/conf 
-Doozie.log.dir=/Users/asasvari/dev/oozie/logs 
-Doozie.data.dir=/Users/asasvari/dev/oozie/data 
-Doozie.config.file=oozie-site.xml -Doozie.log4j.file=oozie-log4j.properties 
-Doozie.log4j.reload=10 -Djava.library.path= -cp 
/Users/asasvari/dev/oozie/embedded-oozie-server/*:/Users/asasvari/dev/oozie/embedded-oozie-server/dependency/*:/Users/asasvari/dev/oozie/lib/*:/Users/asasvari/dev/oozie/libtools/*:/Users/asasvari/dev/oozie/embedded-oozie-server}}



> Update Docs for Jetty Tomcat changes
> 
>
> Key: OOZIE-2753
> URL: https://issues.apache.org/jira/browse/OOZIE-2753
> Project: Oozie
>  Issue Type: Sub-task
>  Components: docs
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Attila Sasvari
> Fix For: 5.0.0
>
> Attachments: OOZIE-2753-01.patch, OOZIE-2753-02.patch, 
> OOZIE-2753-03.patch, OOZIE-2753-04.patch
>
>
> Update the docs based on the changes for Jetty and Tomcat (OOZIE-2317 and 
> child JIRAs).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

[Alonzo Zhou]

> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > Overall direction is OK, please see my comments.

Thanks for your reviewing man! I changed some following your advices, yet 
there're still some places that confuse me and I wrote them in comments.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
> > Lines 78 (patched)
> > 
> >
> > Logging a `WARN` here wouldn't hurt.
> > 
> > Why not return `Collections.emptyList()`?

wfAction is a element of List , in order to keep the length 
and order of the list returned. So add a null element.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
> > Lines 81 (patched)
> > 
> >
> > Logging a `WARN` here wouldn't hurt.
> > 
> > Why not return `Collections.emptyList()`?

wfAction is a element of List , in order to keep the length 
and order of the list returned. So add a null element.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
> > Lines 87 (patched)
> > 
> >
> > Explaining a bit more w/ a decent log message wouldn't hurt.

Yet after careful consideration, I still hold my point that this logging 
message is decent enough.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java
> > Lines 102-105 (patched)
> > 
> >
> > I'm wondering whether some of the SQLs and JPA calls of `execute()` 
> > couldn't be done here. `loadState()` is called only once, but `execute()` 
> > possibly many times.

hi , if call XCommand.call(), loadState() and execute() will both execute, so i 
think this doesnt much matter. did i think wrong?


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java
> > Lines 280-285 (patched)
> > 
> >
> > Why not have this default implementation in `BaseJobServlet` instead?

hi, i noticed that the methods in BaseJobServlet was defined as an abstract 
method in addition to doGet and doPut. in order to maintain consistency, then i 
defined getWfActionsInCoord as an abstract.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
> > Lines 1142-1146 (patched)
> > 
> >
> > Why not have this default implementation in `BaseJobServlet` instead?

hi, i noticed that the methods in BaseJobServlet was defined as an abstract 
method in addition to doGet and doPut. in order to maintain consistency, then i 
defined getWfActionsInCoord as an abstract.


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java
> > Lines 401 (patched)
> > 
> >
> > Please make it more resilient to `NumberFormatException`.

hi, the method service(HttpServletRequest request, HttpServletResponse 
response) in JsonRestServlet catch the IllegalArgumentException and handle it ,
I'm wondering whether we should catch the NumberFormatException here?


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java
> > Lines 408 (patched)
> > 
> >
> > Please make it more resilient to `NumberFormatException`.

hi, the method service(HttpServletRequest request, HttpServletResponse 
response) in JsonRestServlet catch the IllegalArgumentException and handle it ,
so I'm wondering whether we should catch the NumberFormatException here?


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java
> > Lines 70 (patched)
> > 
> >
> > Why 2?

no particular reason, just a value I picked, as I think it doesn't matter anyway


> On 三月 23, 2017, 11:35 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java
> > Lines 261 (patched)
> > 
> >
> > Great idea to add functional tests as well :)
> > 
> > However, I'd focus more on the edge cases that can happen when calling 
> > `V2JobServlet` and weren't covered in other unit tests: 

Jenkins build is back to normal : oozie-trunk-find-patches-available #154883

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154882

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 890f69ead827467381983b185fd4fa9a6a0780cd 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 890f69ead827467381983b185fd4fa9a6a0780cd
 > git rev-list 890f69ead827467381983b185fd4fa9a6a0780cd # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson3107592710684103812.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
 255k0  255k0 0   227k  0 --:--:--  0:00:01 --:--:--  227k100  
967k0  967k0 0   454k  0 --:--:--  0:00:02 --:--:--  454k100 
1431k0 1431k0 0   456k  0 --:--:--  0:00:03 --:--:--  456k100 
1759k0 1759k0 0   443k  0 --:--:--  0:00:03 --:--:--  443k
curl: (18) transfer closed with outstanding read data remaining
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

Jenkins build is back to normal : oozie-trunk-find-patches-available #154881

[Apache Jenkins Server]

See 

Build failed in Jenkins: oozie-trunk-find-patches-available #154880

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H1 (Hadoop) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/oozie.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/oozie.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/oozie.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 890f69ead827467381983b185fd4fa9a6a0780cd 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 890f69ead827467381983b185fd4fa9a6a0780cd
 > git rev-list 890f69ead827467381983b185fd4fa9a6a0780cd # timeout=10
[oozie-trunk-find-patches-available] $ /bin/bash 
/tmp/hudson5203807667483503499.sh
mkdir: cannot create directory 
':
 File exists
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  0 
00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0
curl: (52) Empty reply from server
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (94 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2843  Enhance logging inside ZKLocksService and MemoryLocksService
https://issues-test.apache.org/jira/browse/OOZIE-2843
OOZIE-2841  Limit FindBugs diff errors in JIRA comments
https://issues-test.apache.org/jira/browse/OOZIE-2841
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues-test.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues-test.apache.org/jira/browse/OOZIE-2833
OOZIE-2831  Update maven-project-info-reports-plugin to 2.9
https://issues-test.apache.org/jira/browse/OOZIE-2831
OOZIE-2827  More directly view of the coordinator’s history from perspective of 
workflow action.
https://issues-test.apache.org/jira/browse/OOZIE-2827
OOZIE-2825  Custom Authentication doc page is not well formatted
https://issues-test.apache.org/jira/browse/OOZIE-2825
OOZIE-2824  Fix typos in documentation
https://issues-test.apache.org/jira/browse/OOZIE-2824
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues-test.apache.org/jira/browse/OOZIE-2812
OOZIE-2796  oozie.action.keep.action.dir not getting noticed
https://issues-test.apache.org/jira/browse/OOZIE-2796
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues-test.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters
https://issues-test.apache.org/jira/browse/OOZIE-2791
OOZIE-2785  Master is not compiling with hadoop-1 profile
https://issues-test.apache.org/jira/browse/OOZIE-2785
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues-test.apache.org/jira/browse/OOZIE-2784
OOZIE-2780  Upgrade hadoop-common version to 2.6.0
https://issues-test.apache.org/jira/browse/OOZIE-2780
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues-test.apache.org/jira/browse/OOZIE-2779
OOZIE-2769  Extend FS action to allow setrep on a file
https://issues-test.apache.org/jira/browse/OOZIE-2769
OOZIE-2753  Update Docs for Jetty Tomcat changes
https://issues-test.apache.org/jira/browse/OOZIE-2753
OOZIE-2751  LocalOozieClient is missing methods from OozieClient
https://issues-test.apache.org/jira/browse/OOZIE-2751
OOZIE-2746  Several tests failure in TestV2ValidateServlet.java
https://issues-test.apache.org/jira/browse/OOZIE-2746
OOZIE-2736  Reduce the number of threads during test execution
https://issues-test.apache.org/jira/browse/OOZIE-2736
OOZIE-2733  change org.apache.hadoop.fs.permission.AccessControlException to 
org.apache.hadoop.security.AccessControlException
https://issues-test.apache.org/jira/browse/OOZIE-2733
OOZIE-2726  Flaky test due to daylight saving changes
https://issues-test.apache.org/jira/browse/OOZIE-2726
OOZIE-2718  Improve -dryrun for bundles
https://issues-test.apache.org/jira/browse/OOZIE-2718
OOZIE-2713  Provide an option to log out contents of the localized jar files
https://issues-test.apache.org/jira/browse/OOZIE-2713
OOZIE-2701  Oozie to support Multiple HCatalog URIs
https://issues-test.apache.org/jira/browse/OOZIE-2701
OOZIE-2694  Add logging for FsActionExecutor 
https://issues-test.apache.org/jira/browse/OOZIE-2694
OOZIE-2693  SimpleHCatDependencyCache.removeMissingDependency can throw NPE
https://issues-test.apache.org/jira/browse/OOZIE-2693
OOZIE-2692  Oozie job submit doesn't report error message to user if there is 
any issue with job conf
https://issues-test.apache.org/jira/browse/OOZIE-2692
OOZIE-2684  Bad database schema error for WF_ACTIONS table
https://issues-test.apache.org/jira/browse/OOZIE-2684
OOZIE-2681  fix javadoc to compile on JDK8 again
https://issues-test.apache.org/jira/browse/OOZIE-2681
OOZIE-2670  Upgrade Hbase to 1.2
https://issues-test.apache.org/jira/browse/OOZIE-2670
OOZIE-2668  Status update and recovery problems when coord action and its 
children not in sync
https://issues-test.apache.org/jira/browse/OOZIE-2668
OOZIE-2662  DB migration fails if DB is too big
https://issues-test.apache.org/jira/browse/OOZIE-2662
OOZIE-2652  Skip trash while deleting hive table partition
https://issues-test.apache.org/jira/browse/OOZIE-2652
OOZIE-2650  Retry coord start on database exceptions
https://issues-test.apache.org/jira/browse/OOZIE-2650
OOZIE-2644  Skip queuing Notification Commands when there's nothing to notify
   

[jira] Subscription: Oozie Patch Available

[jira]

Issue Subscription
Filter: Oozie Patch Available (95 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-2846  TestSSLServerConnectorFactory fails with Jetty 9.3 and 9.4
https://issues.apache.org/jira/browse/OOZIE-2846
OOZIE-2843  Enhance logging inside ZKLocksService and MemoryLocksService
https://issues.apache.org/jira/browse/OOZIE-2843
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2831  Update maven-project-info-reports-plugin to 2.9
https://issues.apache.org/jira/browse/OOZIE-2831
OOZIE-2827  More directly view of the coordinator’s history from perspective of 
workflow action.
https://issues.apache.org/jira/browse/OOZIE-2827
OOZIE-2825  Custom Authentication doc page is not well formatted
https://issues.apache.org/jira/browse/OOZIE-2825
OOZIE-2824  Fix typos in documentation
https://issues.apache.org/jira/browse/OOZIE-2824
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2796  oozie.action.keep.action.dir not getting noticed
https://issues.apache.org/jira/browse/OOZIE-2796
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2791  ShareLib installation may fail on busy Hadoop clusters
https://issues.apache.org/jira/browse/OOZIE-2791
OOZIE-2785  Master is not compiling with hadoop-1 profile
https://issues.apache.org/jira/browse/OOZIE-2785
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2780  Upgrade hadoop-common version to 2.6.0
https://issues.apache.org/jira/browse/OOZIE-2780
OOZIE-2779  Mask Hive2 action Beeline JDBC password
https://issues.apache.org/jira/browse/OOZIE-2779
OOZIE-2769  Extend FS action to allow setrep on a file
https://issues.apache.org/jira/browse/OOZIE-2769
OOZIE-2753  Update Docs for Jetty Tomcat changes
https://issues.apache.org/jira/browse/OOZIE-2753
OOZIE-2751  LocalOozieClient is missing methods from OozieClient
https://issues.apache.org/jira/browse/OOZIE-2751
OOZIE-2746  Several tests failure in TestV2ValidateServlet.java
https://issues.apache.org/jira/browse/OOZIE-2746
OOZIE-2736  Reduce the number of threads during test execution
https://issues.apache.org/jira/browse/OOZIE-2736
OOZIE-2733  change org.apache.hadoop.fs.permission.AccessControlException to 
org.apache.hadoop.security.AccessControlException
https://issues.apache.org/jira/browse/OOZIE-2733
OOZIE-2726  Flaky test due to daylight saving changes
https://issues.apache.org/jira/browse/OOZIE-2726
OOZIE-2718  Improve -dryrun for bundles
https://issues.apache.org/jira/browse/OOZIE-2718
OOZIE-2713  Provide an option to log out contents of the localized jar files
https://issues.apache.org/jira/browse/OOZIE-2713
OOZIE-2701  Oozie to support Multiple HCatalog URIs
https://issues.apache.org/jira/browse/OOZIE-2701
OOZIE-2694  Add logging for FsActionExecutor 
https://issues.apache.org/jira/browse/OOZIE-2694
OOZIE-2693  SimpleHCatDependencyCache.removeMissingDependency can throw NPE
https://issues.apache.org/jira/browse/OOZIE-2693
OOZIE-2692  Oozie job submit doesn't report error message to user if there is 
any issue with job conf
https://issues.apache.org/jira/browse/OOZIE-2692
OOZIE-2684  Bad database schema error for WF_ACTIONS table
https://issues.apache.org/jira/browse/OOZIE-2684
OOZIE-2681  fix javadoc to compile on JDK8 again
https://issues.apache.org/jira/browse/OOZIE-2681
OOZIE-2670  Upgrade Hbase to 1.2
https://issues.apache.org/jira/browse/OOZIE-2670
OOZIE-2668  Status update and recovery problems when coord action and its 
children not in sync
https://issues.apache.org/jira/browse/OOZIE-2668
OOZIE-2662  DB migration fails if DB is too big
https://issues.apache.org/jira/browse/OOZIE-2662
OOZIE-2652  Skip trash while deleting hive table partition
https://issues.apache.org/jira/browse/OOZIE-2652
OOZIE-2651  Set javax.xml.parsers.DocumentBuilderFactory sys prop to make XML 
handling faster
https://issues.apache.org/jira/browse/OOZIE-2651
OOZIE-2650  Retry coord start on database exceptions
https://issues.apache.org/jira/browse/OOZIE-2650
OOZIE-2644  Skip queuing Notification Commands when there's nothing to notify