[jira] Subscription: Oozie Patch Available

2018-08-14 Thread jira
Issue Subscription
Filter: Oozie Patch Available (97 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3326  Sqoop Action should support tez delegation tokens for hive-import
https://issues.apache.org/jira/browse/OOZIE-3326
OOZIE-3324  Cannot compile with findbugs check
https://issues.apache.org/jira/browse/OOZIE-3324
OOZIE-3320  Oozie ShellAction should support absolute bash file path
https://issues.apache.org/jira/browse/OOZIE-3320
OOZIE-3319  Log SSH action callback error output
https://issues.apache.org/jira/browse/OOZIE-3319
OOZIE-3318  Fix Javadoc check in the pre-commit
https://issues.apache.org/jira/browse/OOZIE-3318
OOZIE-3317  Fix false positive precommit reports
https://issues.apache.org/jira/browse/OOZIE-3317
OOZIE-3301  Update NOTICE file
https://issues.apache.org/jira/browse/OOZIE-3301
OOZIE-3298  OYA: external ID is not filled properly and failing MR job is 
treated as SUCCEEDED
https://issues.apache.org/jira/browse/OOZIE-3298
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3266  Coord action rerun support RERUN_SKIP_NODES option
https://issues.apache.org/jira/browse/OOZIE-3266
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3229  Improved filtering options in V2SLAServlet
https://issues.apache.org/jira/browse/OOZIE-3229
OOZIE-3218  Oozie Sqoop action with command splits the select clause into 
multiple parts due to delimiter being space
https://issues.apache.org/jira/browse/OOZIE-3218
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3194  Oozie should set proper permissions to sharelib after upload
https://issues.apache.org/jira/browse/OOZIE-3194
OOZIE-3186  Oozie is unable to use configuration linked using jceks://file/...
https://issues.apache.org/jira/browse/OOZIE-3186
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3160  PriorityDelayQueue put()/take() can cause significant CPU load due 
to busy waiting
https://issues.apache.org/jira/browse/OOZIE-3160
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-3061  Kill only those child jobs which are not already killed
https://issues.apache.org/jira/browse/OOZIE-3061
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2949  Escape quotes whitespaces in Sqoop  field
https://issues.apache.org/jira/browse/OOZIE-2949
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2877  Oozie Git Action
https://issues.apache.org/jira/browse/OOZIE-2877
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Language 
Evaulator
https://issues.apache.org/jira/browse/OOZIE-2784
OOZIE-2779  Mask Hive2 action Beeline JDBC passw

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580039#comment-16580039
 ] 

Andras Piros commented on OOZIE-2734:
-

[~asalamon74] can you please look into the pre-commit issues, mainly why 
{{DISTRO}} step keeps failing? Thanks!

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580034#comment-16580034
 ] 

Hadoop QA commented on OOZIE-2734:
--


Testing JIRA OOZIE-2734

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 3 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 281 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2918
.{color:orange}Tests failed at first run:{color}
TestZKLocksService#testTimeoutTimingOutWriteLockOozies
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/756/



> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Failed: OOZIE-2734 PreCommit Build #756

2018-08-14 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-2734
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/756/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 408.90 KB...]
[INFO] Total time: 01:48 min
[INFO] Finished at: 2018-08-14T16:38:33Z
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-war-plugin:3.2.0:war (default-war) on project 
oozie-docs: Execution default-war of goal 
org.apache.maven.plugins:maven-war-plugin:3.2.0:war failed: basedir 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/docs/target/site 
does not exist -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :oozie-docs

Reports
  Running test-patch task CLEAN
  Running test-patch task RAW_PATCH_ANALYSIS
  Running test-patch task RAT
  Running test-patch task JAVADOC
  Running test-patch task COMPILE
  Running test-patch task FINDBUGS_DIFF
[TRACE] Downloading FindBugs diff JAR from 
https://repo1.maven.org/maven2/me/andrz/findbugs/findbugs-diff/0.1.0/findbugs-diff-0.1.0-all.jar
[TRACE] FindBugs diff JAR downloaded
grep: 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/bin/findbugs-diff-0.1.0-all.jar.md5sum:
 No such file or directory
[TRACE] FindBugs diff JAR checked, is safe to use
[TRACE] Performing FindBugs diffs
[TRACE] FindBugs diffs performed
[TRACE] Checking FindBugs diffs and creating reports
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 1243 bytes
[TRACE] Full summary file size is 184 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2734

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
-1 the patch contains 3 line(s) with tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 281 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2918
Tests failed at first run:
TestZKLocksService#testTimeoutTimingOutWriteLockOozies
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
-1 DISTRO
-1 distro tarball fails with the patch


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/756/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  21220 0  100  2122  0   2230 --:--:-- --:--:-- --:--:--  
2228100  56200  3498  100  2122   3676   2230 --:--:-- --:--:-- --:--:--  
3674
{"self":"https://issues.apache.org/jira/rest/api/2/issue/13019874/comment/16580034","id":"16580034","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&owner

[jira] [Commented] (OOZIE-3320) Oozie ShellAction should support absolute bash file path

2018-08-14 Thread Roey Shem Tov (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580024#comment-16580024
 ] 

Roey Shem Tov commented on OOZIE-3320:
--

[~andras.piros] any suggestion?

> Oozie ShellAction should support absolute bash file path
> 
>
> Key: OOZIE-3320
> URL: https://issues.apache.org/jira/browse/OOZIE-3320
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Roey Shem Tov
>Assignee: Roey Shem Tov
>Priority: Major
>  Labels: patch
> Attachments: OOZIE-3086.patch, OOZIE-3320.patch
>
>
> bash files that saved on shared mount, cannot be execute by the ShellAction 
> in proper way.
> Example:
> Worker-1,Worker-2,Worker-3 have shared mount /mnt/hadoop
> on /mnt/hadoop there is a file script.sh
> Right now there is two options to submit it using ShellAction:
>  # Upload it to hdfs, add it as a file and submit script.sh
>  # use bash as exec and file location (/mnt/hadoop/script.sh) as argument 
> (e.g bash>/exec>/mnt/hadoop/script.sh
> Best option is that the  command will support shared mounted file :
> /mnt/hadoop/script.sh
>  
> This code is taking only the file name instead it full path:
> {code:java}
> String exec = actionXml.getChild("exec", ns).getTextTrim(); 
> String execName = new Path(exec).getName(); 
> actionConf.set(ShellMain.CONF_OOZIE_SHELL_EXEC, execName);
> {code}
>  
> Best option to support shared mount file is to support file:// starting for 
> bash files that are local (or shared by mount), e.g:
> {code:java}
> String exec = actionXml.getChild("exec", ns).getTextTrim(); String execName; 
> String localFilePrefix = "file://";
>  // When exec starts with 'file://' refer it as local file. 
> if (exec.startsWith(localFilePrefix)) 
> execName = exec.substring(localFilePrefix.length()); 
> else execName = new Path(exec).getName(); 
> actionConf.set(ShellMain.CONF_OOZIE_SHELL_EXEC, execName);
> {code}
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579946#comment-16579946
 ] 

Hadoop QA commented on OOZIE-2734:
--

PreCommit-OOZIE-Build started


> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579913#comment-16579913
 ] 

Hadoop QA commented on OOZIE-2734:
--


Testing JIRA OOZIE-2734

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 3 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 281 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2918
.{color:orange}Tests failed at first run:{color}
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:red}-1 DISTRO{color}
.{color:red}-1{color} distro tarball fails with the patch


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/755/



> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Failed: OOZIE-2734 PreCommit Build #755

2018-08-14 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-2734
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/755/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 416.27 KB...]
[INFO] Total time: 01:55 min
[INFO] Finished at: 2018-08-14T14:57:21Z
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-war-plugin:3.2.0:war (default-war) on project 
oozie-docs: Execution default-war of goal 
org.apache.maven.plugins:maven-war-plugin:3.2.0:war failed: basedir 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/docs/target/site 
does not exist -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :oozie-docs

Reports
  Running test-patch task CLEAN
  Running test-patch task RAW_PATCH_ANALYSIS
  Running test-patch task RAT
  Running test-patch task JAVADOC
  Running test-patch task COMPILE
  Running test-patch task FINDBUGS_DIFF
[TRACE] Downloading FindBugs diff JAR from 
https://repo1.maven.org/maven2/me/andrz/findbugs/findbugs-diff/0.1.0/findbugs-diff-0.1.0-all.jar
[TRACE] FindBugs diff JAR downloaded
grep: 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/bin/findbugs-diff-0.1.0-all.jar.md5sum:
 No such file or directory
[TRACE] FindBugs diff JAR checked, is safe to use
[TRACE] Performing FindBugs diffs
[TRACE] FindBugs diffs performed
[TRACE] Checking FindBugs diffs and creating reports
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 1243 bytes
[TRACE] Full summary file size is 184 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-2734

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
-1 the patch contains 3 line(s) with tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 281 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2918
Tests failed at first run:
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
-1 DISTRO
-1 distro tarball fails with the patch


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/755/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  21500 0  100  2150  0   2249 --:--:-- --:--:-- --:--:--  
2248100  56760  3526  100  2150   3686   2247 --:--:-- --:--:-- --:--:--  
3684
{"self":"https://issues.apache.org/jira/rest/api/2/issue/13019874/comment/16579913","id":"16579913","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/

[jira] [Commented] (OOZIE-3328) Create Hive compatibility action executor to run hive actions using beeline

2018-08-14 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579885#comment-16579885
 ] 

Peter Cseh commented on OOZIE-3328:
---

What would be the point of that? If I know correctly there are 
incompatibilities between the two command line tools. The first one that comes 
to mind is that Beeline uses jdbc url while HiveCLI uses the thrift uri to the 
HMS. 

Or would it be enough to simply change [this 
line|https://github.com/apache/oozie/blob/master/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java#L310]
 to call beeline?

> Create Hive compatibility action executor to run hive actions using beeline
> ---
>
> Key: OOZIE-3328
> URL: https://issues.apache.org/jira/browse/OOZIE-3328
> Project: Oozie
>  Issue Type: Task
>  Components: action, core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
>  Labels: features, usability
>
> If I am correct then Hive will not support HiveCli for long and Oozie may 
> have to handle this.
> A new executor shall be created which can understand the original hive action 
> format while this executor shall run the action using beeline.
> What are your thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3328) Create Hive compatibility action executor to run hive actions using beeline

2018-08-14 Thread Denes Bodo (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579814#comment-16579814
 ] 

Denes Bodo commented on OOZIE-3328:
---

[~andras.piros] Actually no. I am looking for an action, which understands the 
 (not ) tag in the workflow xml and uses beeline instead of 
HiveCli.

> Create Hive compatibility action executor to run hive actions using beeline
> ---
>
> Key: OOZIE-3328
> URL: https://issues.apache.org/jira/browse/OOZIE-3328
> Project: Oozie
>  Issue Type: Task
>  Components: action, core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
>  Labels: features, usability
>
> If I am correct then Hive will not support HiveCli for long and Oozie may 
> have to handle this.
> A new executor shall be created which can understand the original hive action 
> format while this executor shall run the action using beeline.
> What are your thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3328) Create Hive compatibility action executor to run hive actions using beeline

2018-08-14 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579808#comment-16579808
 ] 

Andras Piros commented on OOZIE-3328:
-

[~dionusos] actually we do have [*a Hive2 
action*|https://oozie.apache.org/docs/5.0.0/DG_Hive2ActionExtension.html] that 
[*uses 
{{Beeline}}*|https://github.com/apache/oozie/blob/master/sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java#L264-L273].
 Is this you're looking for?

> Create Hive compatibility action executor to run hive actions using beeline
> ---
>
> Key: OOZIE-3328
> URL: https://issues.apache.org/jira/browse/OOZIE-3328
> Project: Oozie
>  Issue Type: Task
>  Components: action, core
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Denes Bodo
>Assignee: Denes Bodo
>Priority: Major
>  Labels: features, usability
>
> If I am correct then Hive will not support HiveCli for long and Oozie may 
> have to handle this.
> A new executor shall be created which can understand the original hive action 
> format while this executor shall run the action using beeline.
> What are your thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OOZIE-3328) Create Hive compatibility action executor to run hive actions using beeline

2018-08-14 Thread Denes Bodo (JIRA)
Denes Bodo created OOZIE-3328:
-

 Summary: Create Hive compatibility action executor to run hive 
actions using beeline
 Key: OOZIE-3328
 URL: https://issues.apache.org/jira/browse/OOZIE-3328
 Project: Oozie
  Issue Type: Task
  Components: action, core
Affects Versions: 4.3.1, 5.0.0
Reporter: Denes Bodo
Assignee: Denes Bodo


If I am correct then Hive will not support HiveCli for long and Oozie may have 
to handle this.

A new executor shall be created which can understand the original hive action 
format while this executor shall run the action using beeline.

What are your thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Andras Salamon (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579795#comment-16579795
 ] 

Andras Salamon commented on OOZIE-2734:
---

[~gezapeti] Thanks for checking. I've uploaded version5 of the patch which 
fixes the problem. It does not change the HTML output, so I don't uploaded the 
HTML files this time.

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579793#comment-16579793
 ] 

Hadoop QA commented on OOZIE-2734:
--

PreCommit-OOZIE-Build started


> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Andras Salamon (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-2734:
--
Attachment: OOZIE-2734-5.patch

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, OOZIE-2734-5.patch, 
> oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OOZIE-3327) TestConcurrentCopyFromLocal is flaky

2018-08-14 Thread Julia Kinga Marton (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton reassigned OOZIE-3327:
-

Assignee: Julia Kinga Marton

> TestConcurrentCopyFromLocal is flaky
> 
>
> Key: OOZIE-3327
> URL: https://issues.apache.org/jira/browse/OOZIE-3327
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Assignee: Julia Kinga Marton
>Priority: Major
>
> There are some unit tests last modified by OOZIE-2829 that [*are 
> flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3327) TestConcurrentCopyFromLocal is flaky

2018-08-14 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579757#comment-16579757
 ] 

Julia Kinga Marton commented on OOZIE-3327:
---

Yes, I will assign it to me.

> TestConcurrentCopyFromLocal is flaky
> 
>
> Key: OOZIE-3327
> URL: https://issues.apache.org/jira/browse/OOZIE-3327
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Priority: Major
>
> There are some unit tests last modified by OOZIE-2829 that [*are 
> flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3327) TestConcurrentCopyFromLocal is flaky

2018-08-14 Thread Andras Piros (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579754#comment-16579754
 ] 

Andras Piros commented on OOZIE-3327:
-

[~kmarton] if you have a chance, can you please look into this? Thanks!

> TestConcurrentCopyFromLocal is flaky
> 
>
> Key: OOZIE-3327
> URL: https://issues.apache.org/jira/browse/OOZIE-3327
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Priority: Major
>
> There are some unit tests last modified by OOZIE-2829 that [*are 
> flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OOZIE-3327) TestConcurrentCopyFromLocal is flaky

2018-08-14 Thread Andras Piros (JIRA)
Andras Piros created OOZIE-3327:
---

 Summary: TestConcurrentCopyFromLocal is flaky
 Key: OOZIE-3327
 URL: https://issues.apache.org/jira/browse/OOZIE-3327
 Project: Oozie
  Issue Type: Sub-task
Affects Versions: 5.1.0
Reporter: Andras Piros


There are some unit tests last modified by OOZIE-2829 that [*are 
flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3327) TestConcurrentCopyFromLocal is flaky

2018-08-14 Thread Andras Piros (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Piros updated OOZIE-3327:

Description: 
There are some unit tests last modified by OOZIE-2829 that [*are 
flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}

  was:
There are some unit tests last modified by OOZIE-2829 that [*are 
flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}
* 
{{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}


> TestConcurrentCopyFromLocal is flaky
> 
>
> Key: OOZIE-3327
> URL: https://issues.apache.org/jira/browse/OOZIE-3327
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: 5.1.0
>Reporter: Andras Piros
>Priority: Major
>
> There are some unit tests last modified by OOZIE-2829 that [*are 
> flaky*|https://builds.apache.org/job/PreCommit-OOZIE-Build/752/testReport/]:
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalHighThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalSameFileNrAndThreadNr()}}
> * 
> {{org.apache.oozie.tools.TestConcurrentCopyFromLocal#testConcurrentCopyFromLocalMoreThreadsThanFiles()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3326) Sqoop Action should support tez delegation tokens for hive-import

2018-08-14 Thread Brian Goerlitz (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579734#comment-16579734
 ] 

Brian Goerlitz commented on OOZIE-3326:
---

[~dionusos] - many thanks for uploading the patch for me and for the test 
modifications.

> Sqoop Action should support tez delegation tokens for hive-import
> -
>
> Key: OOZIE-3326
> URL: https://issues.apache.org/jira/browse/OOZIE-3326
> Project: Oozie
>  Issue Type: Bug
>  Components: action
>Reporter: Brian Goerlitz
>Assignee: Brian Goerlitz
>Priority: Major
> Attachments: OZIE-3326_001.patch, OZIE-3326_002.patch
>
>
> SqoopMain needs to support tez delegation tokens for hive-imports. 
> Implementation is similar to that of HiveMain and Hive2Main.
> At present, hive-import will fail to start a tez session in secure 
> environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3324) Cannot compile with findbugs check

2018-08-14 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579712#comment-16579712
 ] 

Peter Cseh commented on OOZIE-3324:
---

I think the regex breaks the pre-commit:  
""^spark-assembly((?:(-|_|(\\d+\\.))\\d+(?:\\.\\d+)*))*\\.jar$""
+1 for the patch as it fixes findbugs and build in general

> Cannot compile with findbugs check
> --
>
> Key: OOZIE-3324
> URL: https://issues.apache.org/jira/browse/OOZIE-3324
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: 5.1.0
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Critical
> Attachments: OOZIE-3324-1.patch
>
>
> Latest snapshot compilation fails because of missing findbugs-filter.xml file:
> {noformat}
> $ mvn clean install -DskipTests
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 11.852 s
> [INFO] Finished at: 2018-08-09T09:11:41+02:00
> [INFO] 
> 
> [ERROR] Could not find resource 
> '/Users/andrassalamon/src/oozie/fluent-job/fluent-job-api/findbugs-filter.xml'.
>  -> [Help 1]{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3324) Cannot compile with findbugs check

2018-08-14 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579703#comment-16579703
 ] 

Peter Cseh commented on OOZIE-3324:
---

the pre-commit fails exceptionally:
{noformat}


+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
ERROR: the current HEAD has 2 Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
-1 There are [522] new bugs found below threshold in total that must be fixed.
 +1 There are no new bugs found in [webapp].
 -1 There are [344] new bugs found below threshold in [core] that must be 
fixed, listing only the first [5] ones.
 You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
 The top [5] most important FindBugs errors are:
 At BinaryBlob.java:[line 70]: org.apache.oozie.BinaryBlob.getBytes() may 
expose internal representation by returning BinaryBlob.bytes
 org.apache.oozie.BinaryBlob.getRawBlob() may expose internal representation by 
returning BinaryBlob.rawBlob: Another occurrence at BinaryBlob.java:[line 90]
 Another occurrence at BinaryBlob.java:[line 118]: At BinaryBlob.java:[line 101]
 In BundleActionBean.java: org.apache.oozie.BundleActionBean.pcIsDetached() has 
Boolean return type and returns explicit null
 In BundleJobBean.java: org.apache.oozie.BundleJobBean.pcIsDetached() has 
Boolean return type and returns explicit null
 -1 There are [74] new bugs found below threshold in [tools] that must be 
fixed, listing only the first [5] ones.
 You can find the FindBugs diff here (look for the red and orange ones): 
tools/findbugs-new.html
 The top [5] most important FindBugs errors are:
 At OozieDBCLI.java:[line 562]: Found reliance on default encoding in 
org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection): 
new java.io.FileWriter(String, boolean)
 At OozieDBCLI.java:[line 591]: Found reliance on default encoding in 
org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInPostgres(String, 
Connection, String): new java.io.FileWriter(String, boolean)
 At OozieDBCLI.java:[line 1034]: Found reliance on default encoding in 
org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String): 
new java.io.FileWriter(String, boolean)
 At OozieDBCLI.java:[line 810]: Found reliance on default encoding in 
org.apache.oozie.tools.OozieDBCLI.ddlTweaks(String, boolean): new 
java.io.FileWriter(String, boolean)
 At OozieDBCLI.java:[line 770]: Found reliance on default encoding in 
org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean): new 
java.io.FileWriter(String, boolean)
 0 There are [2] new bugs found in [fluent-job/fluent-job-api] that would be 
nice to have fixed.
 You can find the FindBugs diff here: 
fluent-job/fluent-job-api/findbugs-new.html
 -1 There are [4] new bugs found below threshold in [sharelib/hive2] that must 
be fixed.
 You can find the FindBugs diff here (look for the red and orange ones): 
sharelib/hive2/findbugs-new.html
 The most important FindBugs errors are:
 At Hive2Main.java:[line 271]: 
org.apache.oozie.action.hadoop.Hive2Main.runBeeline(String[], String) invokes 
System.exit(...), which shuts down the entire virtual machine
 At Hive2Main.java:[line 279]: 
java/io/FileInputStream.(Ljava/lang/String;)V reads a file whose 
location might be specified by user input
 At Hive2Main.java:[line 165]: At Hive2Main.java:[line 146]
 At Hive2Main.java:[line 149]: java/io/File.(Ljava/lang/String;)V 
reads a file whose location might be specified by user input
 java/io/FileOutputStream.(Ljava/lang/String;)V writes to a file 
whose location might be specified by user input: At Hive2Main.java:[line 146]
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/sqoop].
 -1 There are [26] new bugs found below threshold in [sharelib/oozie] that must 
be fixed, listing only the first [5] ones.
 You can find the FindBugs diff here (look for the red and orange ones): 
sharelib/oozie/findbugs-new.html
 The top [5] most important FindBugs errors are:
 At ActionStats.java:[line 37]: Unwritten public or protected field: 
org.apache.oozie.action.hadoop.ActionStats.currentActionType
 At LauncherAMUtils.java:[line 64]: Found rel

[jira] [Commented] (OOZIE-2734) Switch docs from twiki to markdown

2018-08-14 Thread Peter Cseh (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579691#comment-16579691
 ] 

Peter Cseh commented on OOZIE-2734:
---

I get an error when I execute mvn clean install site:
{noformat}
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 3.854 s
[INFO] Finished at: 2018-08-14T13:55:12+02:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on project 
oozie-main: Execution default-site of goal 
org.apache.maven.plugins:maven-site-plugin:3.7:site failed: A required class 
was missing while executing 
org.apache.maven.plugins:maven-site-plugin:3.7:site: 
org/apache/maven/doxia/sink/impl/XhtmlBaseSink
[ERROR] -
[ERROR] realm =plugin>org.apache.maven.plugins:maven-site-plugin:3.7
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy

{noformat}

> Switch docs from twiki to markdown
> --
>
> Key: OOZIE-2734
> URL: https://issues.apache.org/jira/browse/OOZIE-2734
> Project: Oozie
>  Issue Type: Improvement
>  Components: docs
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2734-1.patch, OOZIE-2734-2.patch, 
> OOZIE-2734-3.patch, OOZIE-2734-4.patch, oozie_generated_html_20180731.zip, 
> oozie_generated_html_markdown_20180802.zip, twiki2md_20180730.zip
>
>
> This won't be a fun JIRA, but it would be great if we could switch to 
> something easier to work with and better supported like markdown, and get rid 
> of the super old twiki we're using for docs.
> I found two tools that I haven't tried out that claim to be able to convert 
> this for us:
> # http://pandoc.org/
> # https://github.com/jcodagnone/twiki2markdown
> The former supports a lot of different formats, and according to [this blog 
> post|http://goer.org/Journal/2013/02/converting_twiki_foswiki_to_markdown_restructuredtext.html]
>  it's better to convert from the rendered html instead of the twiki.  But who 
> knows which is better, or if the second tool is better than either.
> I think once we switch to a better format, it will be easier to keep the docs 
> in better shape, as they could really use some reorganizing.  Though we can 
> keep that for a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3229) Improved filtering options in V2SLAServlet

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579627#comment-16579627
 ] 

Hadoop QA commented on OOZIE-3229:
--


Testing JIRA OOZIE-3229

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:green}+1{color} the patch adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
error(s)
.{color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2963
.{color:orange}Tests failed at first run:{color}
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/754/



> Improved filtering options in V2SLAServlet
> --
>
> Key: OOZIE-3229
> URL: https://issues.apache.org/jira/browse/OOZIE-3229
> Project: Oozie
>  Issue Type: New Feature
>  Components: client
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Andras Piros
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3229-1.patch, OOZIE-3229-2.patch, 
> OOZIE-3229-3.patch, OOZIE-3229-4.patch, OOZIE-3229-5.patch
>
>
> Currently we can apply a range of filters on top of {{V2SLAServlet}} that can 
> be used in a rich but undocumented set of ways:
> * {{id}}
> * {{parent_id}}
> * {{event_status}}
> * {{app_name}}
> * {{nominal_start}}
> * {{nominal_end}}
> Need to refactor {{V2SLAServlet}} to feature:
> * a richer set of {{SLAEvent}}, {{SLARegistration}}, and {{SLASummary}} 
> filtering based on their attributes
> * filter options will always be {{AND}}-ed, never {{OR}}-ed to each other
> * maintain compatibility with the parameter names and behavior used thus far
> * remove {{SLASummaryFilter}} and refactor 
> {{SLASummaryGetForFilterJPAExecutor}} as just another possibility for 
> confusion
> * document new functionality with rich use case / example library so that 
> users can leverage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Failed: OOZIE-3229 PreCommit Build #754

2018-08-14 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/OOZIE-3229
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/754/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 460.15 KB...]
[INFO] Apache Oozie Docs .. SUCCESS [ 10.059 s]
[INFO] Apache Oozie WebApp  SUCCESS [ 30.479 s]
[INFO] Apache Oozie Tools . SUCCESS [  1.248 s]
[INFO] Apache Oozie MiniOozie . SUCCESS [  1.309 s]
[INFO] Apache Oozie Fluent Job Client . SUCCESS [  0.176 s]
[INFO] Apache Oozie Server  SUCCESS [  3.788 s]
[INFO] Apache Oozie Distro  SUCCESS [01:00 min]
[INFO] Apache Oozie ZooKeeper Security Tests 5.1.0-SNAPSHOT SUCCESS [  2.353 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 03:39 min
[INFO] Finished at: 2018-08-14T10:40:59Z
[INFO] 

Reports
  Running test-patch task CLEAN
  Running test-patch task RAW_PATCH_ANALYSIS
  Running test-patch task RAT
  Running test-patch task JAVADOC
  Running test-patch task COMPILE
  Running test-patch task FINDBUGS_DIFF
[TRACE] Downloading FindBugs diff JAR from 
https://repo1.maven.org/maven2/me/andrz/findbugs/findbugs-diff/0.1.0/findbugs-diff-0.1.0-all.jar
[TRACE] FindBugs diff JAR downloaded
grep: 
/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/bin/findbugs-diff-0.1.0-all.jar.md5sum:
 No such file or directory
[TRACE] FindBugs diff JAR checked, is safe to use
[TRACE] Performing FindBugs diffs
[TRACE] FindBugs diffs performed
[TRACE] Checking FindBugs diffs and creating reports
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 1233 bytes
[TRACE] Full summary file size is 184 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3229

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
-1 the patch contains 1 line(s) longer than 132 characters
+1 the patch adds/modifies 3 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warning(s)
+1 the patch does not seem to introduce new Javadoc error(s)
ERROR: the current HEAD has 2 Javadoc error(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 2963
Tests failed at first run:
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)


The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/754/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  21340 0  100  2134  0   2171 --:--:-- --:--:-- --:--:--  
2170100  56440  3510  100  2134   3571   2171 --:--:-- --:--:-- --:--:--  
3570
{"self":"https://issues.apache.org/jira/rest/api/2/issue/13155493/comment/16579627","id":"16579627","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?si

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-08-14 Thread Andras Salamon


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > client/src/main/java/org/apache/oozie/client/OozieClient.java
> > Lines 177-204 (patched)
> > 
> >
> > Can you please structure that a bit more? Like having not `String` but 
> > `enum` instances, having a nested wrapper class...

Removed the filter field listing from this class.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/conf/action-conf/hive.xml
> > Line 28 (original), 28 (patched)
> > 
> >
> > Please revert this change.

Ooops. Missing git merge. Reverted.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/action/ActionExecutor.java
> > Line 606 (original), 606 (patched)
> > 
> >
> > Please revert this change.

Ooops. Missing git merge. Reverted.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Line 1780 (original), 1780 (patched)
> > 
> >
> > Please revert this change.

Ooops. Missing git merge. Reverted.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1831-1834 (original)
> > 
> >
> > Please revert this change.

Ooops. Missing git merge. Reverted.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
> > Lines 51-78 (patched)
> > 
> >
> > Can we extract that to a state object? Too many fields here, we're far 
> > away from Single Responsibility Principle.

Instead of using lots of fields, I store the (converted) values in a HashMap, 
which means we don't have to add a new field if we add additional filter fields.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
> > Lines 267-277 (original), 294-311 (patched)
> > 
> >
> > Please extract method.

jobExists variable has been eliminated. Most of this code moved to the SQL 
builder class.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
> > Lines 425-426 (patched)
> > 
> >
> > Here we're changing existing behavior. Any chance to create separate 
> > test for the change, plus document that?

I think the existing behaviour was incorrect, the second set call should 
overwrite the value and not only modify it. I've created a test method to check 
this. Same applies for the eventStatus field.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java
> > Line 115 (original), 131 (patched)
> > 
> >
> > Can we please apply some kind of object-oriented design pattern, like 
> > Builder, here? One huge builder with multiple child builders.
> > 
> > I feel that too many `if-then-else` and too long methods are disturbing 
> > beyond readability / comprehension.
> > 
> > I also would separate out different responsibilities to different, 
> > maybe nested, classes - and test them separately.

I simplified the V2SLAServet class, it does not deal with the filter fields 
directly anymore. Adding a new field will be possible without modifing this 
class.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java
> > Lines 136-141 (original), 153-175 (patched)
> > 
> >
> > This looks pretty terrible, again. What about applying some design 
> > pattern / restructuring the code?

I removed this whole part, this was not too useful.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java
> > Lines 144-147 (original), 178-198 (patched)
> > 
> >
> > This looks pretty terrible, again. What about applying some design 
> > pattern / restructuring the code?

I also removed this part.


> On Aug. 6, 2018, 12:14 p.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java
> > Line 16 (original), 

Re: Review Request 68140: OOZIE-3229 Improved filtering options in V2SLAServlet

2018-08-14 Thread Andras Salamon

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68140/
---

(Updated Aug. 14, 2018, 9:22 a.m.)


Review request for oozie, András Piros and Kinga Marton.


Changes
---

Refactored the code, to keep filter field listing in a single class 
(SLASummaryGetForFilterJPAExecutor).


Repository: oozie-git


Description
---

Added lots of new filter fields, also refactored 
SLASummaryGetForFilterJPAExecutor class to eliminate FindBugs errors. I'm not 
sure about the filter field names.


Diffs (updated)
-

  client/src/main/java/org/apache/oozie/client/OozieClient.java 949b4532 
  
core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
 b54161e9 
  core/src/main/java/org/apache/oozie/executor/jpa/sla/SelectQuery.java 
PRE-CREATION 
  core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 3982d1e0 
  
core/src/test/java/org/apache/oozie/executor/jpa/sla/TestSLASummaryGetForFilterJPAExecutor.java
 PRE-CREATION 
  core/src/test/java/org/apache/oozie/executor/jpa/sla/TestSelectQuery.java 
PRE-CREATION 
  core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java aa633225 
  docs/src/site/twiki/DG_SLAMonitoring.twiki c91c227d 
  webapp/src/main/webapp/console/sla/css/oozie-sla.css d2f2deee 
  webapp/src/main/webapp/console/sla/js/oozie-sla.js 2ecad228 
  webapp/src/main/webapp/console/sla/oozie-sla.html e5bf6275 


Diff: https://reviews.apache.org/r/68140/diff/3/

Changes: https://reviews.apache.org/r/68140/diff/2-3/


Testing
---


Thanks,

Andras Salamon



[jira] [Commented] (OOZIE-3229) Improved filtering options in V2SLAServlet

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579488#comment-16579488
 ] 

Hadoop QA commented on OOZIE-3229:
--

PreCommit-OOZIE-Build started


> Improved filtering options in V2SLAServlet
> --
>
> Key: OOZIE-3229
> URL: https://issues.apache.org/jira/browse/OOZIE-3229
> Project: Oozie
>  Issue Type: New Feature
>  Components: client
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Andras Piros
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3229-1.patch, OOZIE-3229-2.patch, 
> OOZIE-3229-3.patch, OOZIE-3229-4.patch, OOZIE-3229-5.patch
>
>
> Currently we can apply a range of filters on top of {{V2SLAServlet}} that can 
> be used in a rich but undocumented set of ways:
> * {{id}}
> * {{parent_id}}
> * {{event_status}}
> * {{app_name}}
> * {{nominal_start}}
> * {{nominal_end}}
> Need to refactor {{V2SLAServlet}} to feature:
> * a richer set of {{SLAEvent}}, {{SLARegistration}}, and {{SLASummary}} 
> filtering based on their attributes
> * filter options will always be {{AND}}-ed, never {{OR}}-ed to each other
> * maintain compatibility with the parameter names and behavior used thus far
> * remove {{SLASummaryFilter}} and refactor 
> {{SLASummaryGetForFilterJPAExecutor}} as just another possibility for 
> confusion
> * document new functionality with rich use case / example library so that 
> users can leverage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OOZIE-3229) Improved filtering options in V2SLAServlet

2018-08-14 Thread Andras Salamon (JIRA)


 [ 
https://issues.apache.org/jira/browse/OOZIE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon updated OOZIE-3229:
--
Attachment: OOZIE-3229-5.patch

> Improved filtering options in V2SLAServlet
> --
>
> Key: OOZIE-3229
> URL: https://issues.apache.org/jira/browse/OOZIE-3229
> Project: Oozie
>  Issue Type: New Feature
>  Components: client
>Affects Versions: 5.0.0, 4.3.1
>Reporter: Andras Piros
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-3229-1.patch, OOZIE-3229-2.patch, 
> OOZIE-3229-3.patch, OOZIE-3229-4.patch, OOZIE-3229-5.patch
>
>
> Currently we can apply a range of filters on top of {{V2SLAServlet}} that can 
> be used in a rich but undocumented set of ways:
> * {{id}}
> * {{parent_id}}
> * {{event_status}}
> * {{app_name}}
> * {{nominal_start}}
> * {{nominal_end}}
> Need to refactor {{V2SLAServlet}} to feature:
> * a richer set of {{SLAEvent}}, {{SLARegistration}}, and {{SLASummary}} 
> filtering based on their attributes
> * filter options will always be {{AND}}-ed, never {{OR}}-ed to each other
> * maintain compatibility with the parameter names and behavior used thus far
> * remove {{SLASummaryFilter}} and refactor 
> {{SLASummaryGetForFilterJPAExecutor}} as just another possibility for 
> confusion
> * document new functionality with rich use case / example library so that 
> users can leverage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OOZIE-3317) Fix false positive precommit reports

2018-08-14 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579335#comment-16579335
 ] 

Julia Kinga Marton edited comment on OOZIE-3317 at 8/14/18 7:02 AM:


The error was ignored, because we run Maven with 
-Dmaven.test.failure.ignore=true option. I have added an extra check in the 
script, what will check if there are errors in the output. If there are, it 
will report -1. Hopefully the next precommit report will show the output for 
this case. 


was (Author: kmarton):
The error was ignored, because we run Maven with 
-Dmaven.test.failure.ignore=true option. I have added an extra check in the 
script, what will check if there are errors in the output. If there are, it 
will report -1.

> Fix false positive precommit reports
> 
>
> Key: OOZIE-3317
> URL: https://issues.apache.org/jira/browse/OOZIE-3317
> Project: Oozie
>  Issue Type: Sub-task
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3317-DO_NOT_MERGE.patch, 
> OOZIE-3317-DO_NOT_MERGE2.patch, OOZIE-3317-TESTING.patch, consoleFull.txt
>
>
> Some steps of the current precommit are failing but we get a +1 anyways ( see 
> OOZIE-3304 for a recent example)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3317) Fix false positive precommit reports

2018-08-14 Thread Julia Kinga Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579335#comment-16579335
 ] 

Julia Kinga Marton commented on OOZIE-3317:
---

The error was ignored, because we run Maven with 
-Dmaven.test.failure.ignore=true option. I have added an extra check in the 
script, what will check if there are errors in the output. If there are, it 
will report -1.

> Fix false positive precommit reports
> 
>
> Key: OOZIE-3317
> URL: https://issues.apache.org/jira/browse/OOZIE-3317
> Project: Oozie
>  Issue Type: Sub-task
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3317-DO_NOT_MERGE.patch, 
> OOZIE-3317-DO_NOT_MERGE2.patch, OOZIE-3317-TESTING.patch, consoleFull.txt
>
>
> Some steps of the current precommit are failing but we get a +1 anyways ( see 
> OOZIE-3304 for a recent example)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3317) Fix false positive precommit reports

2018-08-14 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/OOZIE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579333#comment-16579333
 ] 

Hadoop QA commented on OOZIE-3317:
--

PreCommit-OOZIE-Build started


> Fix false positive precommit reports
> 
>
> Key: OOZIE-3317
> URL: https://issues.apache.org/jira/browse/OOZIE-3317
> Project: Oozie
>  Issue Type: Sub-task
>  Components: scripts
>Affects Versions: 5.0.0
>Reporter: Julia Kinga Marton
>Assignee: Julia Kinga Marton
>Priority: Critical
> Fix For: 5.1.0
>
> Attachments: OOZIE-3317-DO_NOT_MERGE.patch, 
> OOZIE-3317-DO_NOT_MERGE2.patch, OOZIE-3317-TESTING.patch, consoleFull.txt
>
>
> Some steps of the current precommit are failing but we get a +1 anyways ( see 
> OOZIE-3304 for a recent example)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)