[jira] [Comment Edited] (OOZIE-2778) Copy only jetty.version related server dependencies to distro
[ https://issues.apache.org/jira/browse/OOZIE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856304#comment-15856304 ] Abhishek Bafna edited comment on OOZIE-2778 at 2/7/17 4:59 PM: --- Hi [~asasvari], one of the exclusion is at wrong place. Can you please do {{mvn:dependency}} output for the server module, please have a look, with the recent patch. The exclusion needs to be in {{hadoop-common}} dependency. Thanks. was (Author: abhishekbafna): Hi [~asasvari], I think the exclusion is at wrong place. I am attaching a mvn:dependency output for the server module, please have a look. This is after the recent patch. The exclusion needs to be in {{hadoop-common}} dependency. Thanks. > Copy only jetty.version related server dependencies to distro > -- > > Key: OOZIE-2778 > URL: https://issues.apache.org/jira/browse/OOZIE-2778 > Project: Oozie > Issue Type: Bug >Reporter: Attila Sasvari >Assignee: Attila Sasvari > Attachments: OOZIE-2778-01.patch, OOZIE-2778-05.patch, > OOZIE-2778-06.patch, OOZIE-2778-2.patch, OOZIE-2778-3.patch, > OOZIE-2778-4.patch, OOZIE-2778-5.patch > > > To compile JSP, org.eclipse.jdt.core is used (see > http://www.eclipse.org/jetty/documentation/9.2.20.v20161216/configuring-jsp.html#compiling-jsps). > However, additional currently jasper libraries are copied to > embedded-oozie-server/dependency/ in the distro directory. It can cause > problems (e.g. NoSuchMethodException at runtime) if classes are loaded from > that jars. > Furthermore, transitive dependencies can pull in old jetty libraries (such as > jetty-util 6) that can cause runtime issues (at server startup). > We can make sure with the maven assembly plugin that only jetty.version > related dependencies are copied to distro. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OOZIE-2778) Copy only jetty.version related server dependencies to distro
[ https://issues.apache.org/jira/browse/OOZIE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856304#comment-15856304 ] Abhishek Bafna edited comment on OOZIE-2778 at 2/7/17 4:57 PM: --- Hi [~asasvari], I think the exclusion is at wrong place. I am attaching a mvn:dependency output for the server module, please have a look. This is after the recent patch. The exclusion needs to be in {{hadoop-common}} dependency. Thanks. was (Author: abhishekbafna): +1. > Copy only jetty.version related server dependencies to distro > -- > > Key: OOZIE-2778 > URL: https://issues.apache.org/jira/browse/OOZIE-2778 > Project: Oozie > Issue Type: Bug >Reporter: Attila Sasvari >Assignee: Attila Sasvari > Attachments: OOZIE-2778-01.patch, OOZIE-2778-05.patch, > OOZIE-2778-06.patch, OOZIE-2778-2.patch, OOZIE-2778-3.patch, > OOZIE-2778-4.patch, OOZIE-2778-5.patch > > > To compile JSP, org.eclipse.jdt.core is used (see > http://www.eclipse.org/jetty/documentation/9.2.20.v20161216/configuring-jsp.html#compiling-jsps). > However, additional currently jasper libraries are copied to > embedded-oozie-server/dependency/ in the distro directory. It can cause > problems (e.g. NoSuchMethodException at runtime) if classes are loaded from > that jars. > Furthermore, transitive dependencies can pull in old jetty libraries (such as > jetty-util 6) that can cause runtime issues (at server startup). > We can make sure with the maven assembly plugin that only jetty.version > related dependencies are copied to distro. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OOZIE-2778) Copy only jetty.version related server dependencies to distro
[ https://issues.apache.org/jira/browse/OOZIE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852653#comment-15852653 ] Abhishek Bafna edited comment on OOZIE-2778 at 2/4/17 7:08 AM: --- Thanks [~asasvari] for working on this. Though I still faced some issue and adding exclusion of the {{jsp-api}} helped me. Please verify at your end and update the patch as required. Pasting a {{git diff}} of the additional changes on top of the current patch (01). {noformat} iff --git a/server/pom.xml b/server/pom.xml index a336aa8..dae6594 100644 --- a/server/pom.xml +++ b/server/pom.xml @@ -89,6 +89,10 @@ org.mortbay.jetty jetty-util + +javax.servlet.jsp +jsp-api + @@ -125,6 +129,10 @@ org.eclipse.jetty.aggregate jetty-all + +javax.servlet.jsp +jsp-api + {noformat} was (Author: abhishekbafna): Thanks [~asasvari] for working on this. Though I still faced some issue and addeingexclusion of the {{jsp-api}} helped me. Please verify at your end and update the patch as required. Pasting a {{git diff}} of the additional changes on top of the current patch. {noformat} iff --git a/server/pom.xml b/server/pom.xml index a336aa8..dae6594 100644 --- a/server/pom.xml +++ b/server/pom.xml @@ -89,6 +89,10 @@ org.mortbay.jetty jetty-util + +javax.servlet.jsp +jsp-api + @@ -125,6 +129,10 @@ org.eclipse.jetty.aggregate jetty-all + +javax.servlet.jsp +jsp-api + {noformat} > Copy only jetty.version related server dependencies to distro > -- > > Key: OOZIE-2778 > URL: https://issues.apache.org/jira/browse/OOZIE-2778 > Project: Oozie > Issue Type: Bug >Reporter: Attila Sasvari >Assignee: Attila Sasvari > Attachments: OOZIE-2778-01.patch > > > To compile JSP, org.eclipse.jdt.core is used (see > http://www.eclipse.org/jetty/documentation/9.2.20.v20161216/configuring-jsp.html#compiling-jsps). > However, additional currently jasper libraries are copied to > embedded-oozie-server/dependency/ in the distro directory. It can cause > problems (e.g. NoSuchMethodException at runtime) if classes are loaded from > that jars. > Furthermore, transitive dependencies can pull in old jetty libraries (such as > jetty-util 6) that can cause runtime issues (at server startup). > We can make sure with the maven assembly plugin that only jetty.version > related dependencies are copied to distro. -- This message was sent by Atlassian JIRA (v6.3.15#6346)