[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-16 Thread Robert Kanter (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423904#comment-15423904
 ] 

Robert Kanter commented on OOZIE-2231:
--

LGTM, a few minor things:
# The change to {{JvmPauseMonitorService}} seems unrelated.  We should leave 
that code alone.
# The indentation for {{}} is off by one.
# Instead of putting the pig guava version number in the pig pom, let's do 
something similar to what we did with {{}}, and create a 
{{}}.
# This updates Guava to 16.  Hadoop currently requires Guava 11, which I 
believe is therefore required by Oozie because of the Hadoop dependencies in 
Oozie.  Have you actually tested that this isn't a problem?  (Hadoop 3 should 
address this problem with classpath isolation)

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Purshotam Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417793#comment-15417793
 ] 

Purshotam Shah commented on OOZIE-2231:
---

{quote}
Apparently ChildReaper is deprecated with Curator 2.9.0+. Can you look into 
this and update our code accordingly?
Deprecated. 
Since 2.9.0 - Reaper/ChildReaper are no longer needed. Use 
CreateMode.CONTAINER. Also, all Curator recipes create container parents.
ChildReaper JavaDoc
{quote}
CreateMode.CONTAINER is only supported in ZK-3.5.X. We are still running with 
ZK-3.4.X.  So we might need to do some testing to see if curator-2.11.0 works 
fine with ZK-3.4.X.


[~rkanter] which version of ZK do you guys use for Oozie? 


> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Abhishek Bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417705#comment-15417705
 ] 

Abhishek Bafna commented on OOZIE-2231:
---

failed testcase are not relevant, passes locally. Thanks.

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417578#comment-15417578
 ] 

Hadoop QA commented on OOZIE-2231:
--

Testing JIRA OOZIE-2231

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1792
.Tests failed: 3
.Tests errors: 0

.The patch failed the following testcases:

.  
testCoordStatusTransitServiceSuspendedWithError(org.apache.oozie.service.TestStatusTransitService)
.  
testCoordStatusTransitServiceSuspendAndResume(org.apache.oozie.service.TestStatusTransitService)
.  
testCoordStatus_Failed(org.apache.oozie.command.coord.TestCoordChangeXCommand)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3217/

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Abhishek Bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417360#comment-15417360
 ] 

Abhishek Bafna commented on OOZIE-2231:
---

[~rkanter] Sure. I will look into it and do it. Thanks.

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Robert Kanter (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417356#comment-15417356
 ] 

Robert Kanter commented on OOZIE-2231:
--

Apparently {{ChildReaper}} is deprecated with Curator 2.9.0+.  Can you look 
into this and update our code accordingly?
{quote}
Deprecated. 
Since 2.9.0 - Reaper/ChildReaper are no longer needed. Use 
CreateMode.CONTAINER. Also, all Curator recipes create container parents.
{quote}
??[ChildReaper JavaDoc|http://curator.apache.org/apidocs/index.html]??

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch, OOZIE-2231-01.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-08-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417201#comment-15417201
 ] 

Hadoop QA commented on OOZIE-2231:
--

Testing JIRA OOZIE-2231

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1792
.Tests failed: 4
.Tests errors: 4

.The patch failed the following testcases:

.  testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
.  testExecutionStats(org.apache.oozie.action.hadoop.TestPigActionExecutor)
.  
testExternalChildIds(org.apache.oozie.action.hadoop.TestPigActionExecutor)
.  
testExecutionStatsWithRetrieveStatsFalse(org.apache.oozie.action.hadoop.TestPigActionExecutor)

{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3215/

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2231-00.patch
>
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-07-13 Thread abhishek bafna (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376348#comment-15376348
 ] 

abhishek bafna commented on OOZIE-2231:
---

[~rkanter] [~puru], Currently we are using {{2.5.0}}, So we can move to the 
{{2.11.0}}.

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-07-13 Thread Purshotam Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375754#comment-15375754
 ] 

Purshotam Shah commented on OOZIE-2231:
---

bq. For now, I'm guessing we should stick with the 2.x line and maybe switch to 
the 3.x line for Oozie 5.
Yes, we should use 2.x.x. In our production we use ZK-3.4.x


> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OOZIE-2231) Upgrade curator to latest version 2.8.0

2016-07-12 Thread Robert Kanter (JIRA) 

[ 
https://issues.apache.org/jira/browse/OOZIE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373647#comment-15373647
 ] 

Robert Kanter commented on OOZIE-2231:
--

Looks like the latest version, as of this comment, is 2.11.0.  There also seems 
to be a 3.x line now, with 3.2.0 as the latest there.  According to the Curator 
website:
- Curator 2.x.x - compatible with both ZooKeeper 3.4.x and ZooKeeper 3.5.x
- Curator 3.x.x - compatible only with ZooKeeper 3.5.x and includes support for 
new features such as dynamic reconfiguration, etc.
For now, I'm guessing we should stick with the 2.x line and maybe switch to the 
3.x line for Oozie 5.

> Upgrade curator to latest version 2.8.0
> ---
>
> Key: OOZIE-2231
> URL: https://issues.apache.org/jira/browse/OOZIE-2231
> Project: Oozie
>  Issue Type: Bug
>  Components: HA
>Reporter: Purshotam Shah
>
> It have some fix related to InterProcessReadWriteLock, ChildReaper, 
> LeaderSelector which we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)