[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588454#comment-16588454
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Assignee: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588448#comment-16588448 ] Hadoop QA commented on OOZIE-2629: -- PreCommit-OOZIE-Build started > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Assignee: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, > OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588443#comment-16588443 ] Julia Kinga Marton commented on OOZIE-2629: --- [~yangyishan0901m], I think that OOZIE-2791 solved this problem. Can you please confirm this? > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Assignee: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, > OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465756#comment-16465756
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465749#comment-16465749 ] Hadoop QA commented on OOZIE-2629: -- PreCommit-OOZIE-Build started > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, > OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749642#comment-15749642
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:orange}0{color} There are [1] new bugs found in [tools] that would
be nice to have fixed.
.You can find the FindBugs diff here: tools/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1831
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3513/
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch, OOZIE-2629-4.patch, OOZIE-2629-5.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749047#comment-15749047 ] Yishan Yang commented on OOZIE-2629: Peter, thanks for your comment. And I do agree with you, if upload failed or exception thrown, I need add roll back. Will upload a new patch later. > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, > OOZIE-2629-3.patch, OOZIE-2629-4.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747989#comment-15747989
]
Peter Cseh commented on OOZIE-2629:
---
Thanks for the patch!
I don't know if this would solve the issue though.
If I see correctly, the [SharelibService only
checks|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ShareLibService.java#L679]
for the {{lib_}} prefix so it would pick up the the {{lib_TIMESTAMP_tmp}}
folder as well.
And the leftover folders won't be purged as they are not matching the sharelib
purge filter:
https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/service/ShareLibService.java#L471
I think it would be a better solution to add the {{tmp_]} prefix while
uploading and add a rollback mechanism to delete the temp folder if an
exception occurrs during upload.
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch, OOZIE-2629-4.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746702#comment-15746702
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:orange}0{color} There are [1] new bugs found in [tools] that would
be nice to have fixed.
.You can find the FindBugs diff here: tools/findbugs-new.html
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1831
.Tests failed: 2
.Tests errors: 0
.The patch failed the following testcases:
.
testBundleStatusCoordSubmitFails(org.apache.oozie.service.TestStatusTransitService)
.
testActionKillCommandDate(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3510/
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch, OOZIE-2629-4.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734568#comment-15734568 ] Abhishek Bafna commented on OOZIE-2629: --- Please add the 'oozie dev' group into your review request. \[When type 'oozie' it will auto complete.\] Thanks. > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch, > OOZIE-2629-3.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734030#comment-15734030
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1831
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3502/
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch,
> OOZIE-2629-3.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733784#comment-15733784 ] Yishan Yang commented on OOZIE-2629: Review request submitted, https://reviews.apache.org/r/54557/ > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[ https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732127#comment-15732127 ] Andras Piros commented on OOZIE-2629: - [~yangyishan0901m] Can you please upload the patch to reviewboard? And, in beforehand, address [*the failing test*|https://builds.apache.org/job/oozie-trunk-precommit-build/3497/testReport/org.apache.oozie.tools/TestOozieSharelibCLI/testOozieSharelibCLICreateConcurrent/]? Thanks! > Get OozieShareLibCLI to perform a final rename to destPath when creating a > Sharelib > --- > > Key: OOZIE-2629 > URL: https://issues.apache.org/jira/browse/OOZIE-2629 > Project: Oozie > Issue Type: Improvement >Affects Versions: 4.3.0 >Reporter: Yishan Yang >Priority: Minor > Fix For: trunk > > Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch > > > Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition > where 'half' of the sharelib could exist during sharelib installation, if > Oozie attempts to run a workflow at the same time as the sharelib > installation. Oozie will only start if the sharelib exists, but this by > itself is not enough since the sharelib could be in an unusable state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2629) Get OozieShareLibCLI to perform a final rename to destPath when creating a Sharelib
[
https://issues.apache.org/jira/browse/OOZIE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730271#comment-15730271
]
Hadoop QA commented on OOZIE-2629:
--
Testing JIRA OOZIE-2629
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1831
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
.Tests failing with errors:
.
testOozieSharelibCLICreateConcurrent(org.apache.oozie.tools.TestOozieSharelibCLI)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3497/
> Get OozieShareLibCLI to perform a final rename to destPath when creating a
> Sharelib
> ---
>
> Key: OOZIE-2629
> URL: https://issues.apache.org/jira/browse/OOZIE-2629
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 4.3.0
>Reporter: Yishan Yang
>Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2629-1.patch, OOZIE-2629-2.patch
>
>
> Change the OozieShareLibCLI to perform a final 'rename' to avoid a condition
> where 'half' of the sharelib could exist during sharelib installation, if
> Oozie attempts to run a workflow at the same time as the sharelib
> installation. Oozie will only start if the sharelib exists, but this by
> itself is not enough since the sharelib could be in an unusable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
