[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886894#comment-16886894
]
Julia Kinga Marton commented on OOZIE-2755:
---
committed to master
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886890#comment-16886890
]
Julia Kinga Marton commented on OOZIE-2755:
---
I agree with [~asalamon74] that simply returning true may cause other issues.
+1 for this specific warning approach.
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882883#comment-16882883
]
Hadoop QA commented on OOZIE-2755:
--
Testing JIRA OOZIE-2755
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [7] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [7] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3165
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1172/
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882802#comment-16882802
]
Hadoop QA commented on OOZIE-2755:
--
PreCommit-OOZIE-Build started
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882794#comment-16882794
]
Andras Salamon commented on OOZIE-2755:
---
Test errors are quite likely unrelated, but I retrigger the precommit check.
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882787#comment-16882787
]
Hadoop QA commented on OOZIE-2755:
--
Testing JIRA OOZIE-2755
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [7] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:red}-1{color} There are [7] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2966
.Tests failed : 1
.Tests in error : 0
.Tests timed out : 0
{color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing
only the first [5] ones
testPurgeableBundleUnpurgeableCoordinatorUnpurgebleWorkflowPurgeableSubWorkflow:org.apache.oozie.command.TestPurgeXCommand
Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1171/
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882725#comment-16882725
]
Hadoop QA commented on OOZIE-2755:
--
PreCommit-OOZIE-Build started
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch, OOZIE-2755-02.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882110#comment-16882110
]
Hadoop QA commented on OOZIE-2755:
--
Testing JIRA OOZIE-2755
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:red}-1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:red}-1{color} the patch seems to introduce 2 new Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [2] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:red}-1{color} There are [2] new bugs found below threshold in
[core] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a
file whose location might be specified by user input: At
BulkJPAExecutor.java:[line 206]
.At AuthorizationService.java:[line 189]: At
AuthorizationService.java:[line 192]
.{color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2966
.Tests failed : 1
.Tests in error : 0
.Tests timed out : 0
{color:red}-1{color} [ERROR] There are [1] test failures in [core]. Listing
only the first [5] ones
testBundlePauseExtendMaterializesCoordinator:org.apache.oozie.command.bundle.TestBundleChangeXCommand
Check console output for the full list of errors/failures
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1168/
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments:
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882032#comment-16882032
]
Hadoop QA commented on OOZIE-2755:
--
PreCommit-OOZIE-Build started
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Assignee: Andras Salamon
>Priority: Major
> Attachments: OOZIE-2755-01.patch
>
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2755) Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is zero
[
https://issues.apache.org/jira/browse/OOZIE-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881075#comment-16881075
]
Andras Salamon commented on OOZIE-2755:
---
We might just return true in this case as suggested
[here|https://mail-archives.apache.org/mod_mbox/oozie-user/201612.mbox/%3CCA+ygShDPz97uygHTSXeL-sUzk8h3=DFJbGdDoj+93XbSSt6=c...@mail.gmail.com%3E]
but without zookeper we will run into other problems. Maybe throwing a better
exception would be better.
Not only {{isJobIdForThisServer}} is affected, {{getJobIdsForThisServer}}
should be also checked.
> Oozie HA: ZKJobsConcurrencyService throws runtime exception when numOozies is
> zero
> --
>
> Key: OOZIE-2755
> URL: https://issues.apache.org/jira/browse/OOZIE-2755
> Project: Oozie
> Issue Type: Bug
> Components: HA
>Reporter: Dongying Jiao
>Priority: Major
>
> Setting up Oozie HA using virtual IP, {{server-1}} and {{server-2}}
> (active-active), when we take down {{server-1}} any Oozie job submitted fails
> with below stacktrace. If both are up , there is no issue.
> {code:java}
> ERROR RecoveryService$RecoveryRunnable:517 - SERVER[XXX] USER[-] GROUP[-]
> TOKEN[-] APP[-] JOB[-] ACTION[-] Exception, / by zero
> java.lang.ArithmeticException: / by zero
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.checkJobIdForServer(ZKJobsConcurrencyService.java:167)
> at
> org.apache.oozie.service.ZKJobsConcurrencyService.isJobIdForThisServer(ZKJobsConcurrencyService.java:129)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.runWFRecovery(RecoveryService.java:362)
> at
> org.apache.oozie.service.RecoveryService$RecoveryRunnable.run(RecoveryService.java:146)
> at
> org.apache.oozie.service.SchedulerService$2.run(SchedulerService.java:175)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
