[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561957#comment-16561957
]
Hadoop QA commented on OOZIE-2942:
--
Testing JIRA OOZIE-2942
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2911
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/700/
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
>
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561879#comment-16561879
]
Andras Piros commented on OOZIE-2942:
-
Thanks for the contribution [~kmarton]! +1 (pending re-triggered Jenkins run)
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561873#comment-16561873
]
Hadoop QA commented on OOZIE-2942:
--
PreCommit-OOZIE-Build started
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552011#comment-16552011
]
Julia Kinga Marton commented on OOZIE-2942:
---
As I cannot modify the original review, I have created a new Review Board
review: [https://reviews.apache.org/r/68008/]
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538390#comment-16538390
]
Julia Kinga Marton commented on OOZIE-2942:
---
Thank you [~andras.piros], I was afraid to make this replacement, because of
the conflicts it may cause.
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538205#comment-16538205
]
Hadoop QA commented on OOZIE-2942:
--
PreCommit-OOZIE-Build started
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch,
> OOZIE-2942.006.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537302#comment-16537302
]
Hadoop QA commented on OOZIE-2942:
--
Testing JIRA OOZIE-2942
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 4 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
.{color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2908
.{color:orange}Tests failed at first run:{color}
TestCoordActionsKillXCommand#testActionKillCommandDate
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/660/
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
>
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537093#comment-16537093
]
Andras Piros commented on OOZIE-2942:
-
[~kmarton] patch 005 replaces tabs w/ spaces within
{{examples/src/main/java/org/apache/oozie/example/DateList.java}}.
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch, OOZIE-2942.005.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531200#comment-16531200
]
Hadoop QA commented on OOZIE-2942:
--
Testing JIRA OOZIE-2942
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 10 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
.{color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2898
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/653/
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
>
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531096#comment-16531096
]
Hadoop QA commented on OOZIE-2942:
--
PreCommit-OOZIE-Build started
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531095#comment-16531095
]
Andras Piros commented on OOZIE-2942:
-
[~kmarton] I'm fine addressing only the relevant parts of those classes. You
can file a separate Jira to clean up all the tabs to whitespaces in different
modules, though.
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531079#comment-16531079
]
Julia Kinga Marton commented on OOZIE-2942:
---
The whole files (DateList.java and Repeatable.java) is indented using tabs
instead of whitespaces. I am not sure if I should change it, because of the
conflicts, it may cause.
Other opinions?
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-004.patch,
> OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530122#comment-16530122
]
Hadoop QA commented on OOZIE-2942:
--
Testing JIRA OOZIE-2942
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 9 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
. {color:red}-1{color} There are [1] new bugs found below threshold in
[examples] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones):
examples/findbugs-new.html
. The most important FindBugs errors are:
. Redundant null check at DateList.java:[line 53]: Redundant nullcheck of date
which is known to be null in org.apache.oozie.example.DateList.main(String[])
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2898
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/651/
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-1.patch,
> OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530018#comment-16530018
]
Hadoop QA commented on OOZIE-2942:
--
PreCommit-OOZIE-Build started
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Julia Kinga Marton
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-003.patch, OOZIE-2942-1.patch,
> OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529706#comment-16529706
]
Jan Hentschel commented on OOZIE-2942:
--
[~kmarton] Sure, go ahead.
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529517#comment-16529517
]
Julia Kinga Marton commented on OOZIE-2942:
---
Hi [~Jan Hentschel]! Do you have any plans to resume this issue? If you
consider so, I can take it over.
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463845#comment-16463845
]
Hadoop QA commented on OOZIE-2942:
--
Testing JIRA OOZIE-2942
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2129
.Tests failed: 17
.Tests errors: 12
.The patch failed the following testcases:
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testCoordinatorActionSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
testCoordinatorActionSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectors(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobSuspendEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsAnd(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener)
testWorkflowJobSelectorsOr(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorActionWaitingEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnCoordinatorActionStartEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testOnWorkflowJobStartedEvent(org.apache.oozie.jms.TestJMSJobEventListener)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
.Tests failing with errors:
testOnSLADurationMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAStartMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testSLAJobSelectorsNegative(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAEndMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAStartMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testSLAJobSelectors(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLAEndMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testOnSLADurationMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener)
testDropEventTypeMessage(org.apache.oozie.jms.TestHCatMessageHandler)
testCacheUpdateByMessage(org.apache.oozie.jms.TestHCatMessageHandler)
testThreadLocalSession(org.apache.oozie.jms.TestDefaultConnectionContext)
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
.
[jira] [Commented] (OOZIE-2942) [examples] Fix Findbugs warnings
[
https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463770#comment-16463770
]
Hadoop QA commented on OOZIE-2942:
--
PreCommit-OOZIE-Build started
> [examples] Fix Findbugs warnings
>
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the
> *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close
> stream on exception [org.apache.oozie.example.DateList] At
> DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in
> org.apache.oozie.example.DateList.main(String[])
> [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At
> DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method
> org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called
> [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample,
> org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource
> created at LocalOozieExample.java:[line 72] is not dischargedPath continues
> at LocalOozieExample.java:[line 76]Path continues at
> LocalOozieExample.java:[line 77]Path continues at
> LocalOozieExample.java:[line 78]Path continues at
> LocalOozieExample.java:[line 81]Path continues at
> LocalOozieExample.java:[line 88]Path continues at
> LocalOozieExample.java:[line 89]Path continues at
> LocalOozieExample.java:[line 91]Path continues at
> LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail
> to close stream [org.apache.oozie.example.LocalOozieExample] At
> LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal
> representation by returning Repeatable.baseline
> [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose
> internal representation by storing an externally mutable object into
> Repeatable.baseline [org.apache.oozie.example.Repeatable] At
> Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
