[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521469#comment-16521469 ] Julia Kinga Marton commented on OOZIE-3274: --- [~andras.piros], [~bpgergo], I agree with the idea of doing some cleaning related the used logging API-s. In my opinion it would be good to use the same approach everywhere. (Slf4j or Apache Commons Logging-used around XLog), or, now that we are switching to log4j2 ([OOZIE-3136|https://issues.apache.org/jira/browse/OOZIE-3136]), we should consider using it directly, since Log4j2 is separated into an API and an implementation module. > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521468#comment-16521468 ] Julia Kinga Marton commented on OOZIE-3274: --- [~andras.piros], [~bpgergo], I agree with the idea of doing some cleaning related the used logging API-s. In my opinion it would be good to use the same approach everywhere. (Slf4j or Apache Commons Logging-used around XLog), or, now that we are switching to log4j2 ([OOZIE-3136|https://issues.apache.org/jira/browse/OOZIE-3136]), we should consider using it directly, since Log4j2 is separated into an API and an implementation module. > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[
https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504447#comment-16504447
]
Andras Piros commented on OOZIE-3274:
-
[~bpgergo] can you please elaborate more on the motivation? I see that you try
to remove {{org.slf4j}} and replace it with {{org.apache.common.logging}}.
Why do we want to switch to Apache Commons Logging in the first place? Why do
we want to get rid of Slf4J? If you want to eliminate duplicate dependencies,
you can already do so.
Slf4J being rather a high-level logging API than an implementation itself, is
pluggable, and could be used [*across a variety of
implementations*|https://www.slf4j.org/legacy.html].
> Remove slf4j
>
>
> Key: OOZIE-3274
> URL: https://issues.apache.org/jira/browse/OOZIE-3274
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Péter Gergő Barna
>Assignee: Péter Gergő Barna
>Priority: Major
> Fix For: trunk
>
> Attachments: OOZIE-3274.rebased.patch
>
>
> Remove all slf4j jars from Oozie.
> I am not sure if Oozie works perfectly without slf4j jars, for me it seems
> that all kinds of hadoop2 jobs are working fine. Any comments are welcomed,
> I would appreciate a response from the community on this.
>
> I know about this issue, which introduced slf4j as a dependency, I am not
> sure if this is relevant any more.
> https://issues.apache.org/jira/browse/OOZIE-1004
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503911#comment-16503911 ] Peter Cseh commented on OOZIE-3274: --- So it looks like we can't even instantiate Xtestcase without slf4j. That covers every test where we use a MiniCluster of any sort. We could try to pull in slf4j only in test scope to avoid this, but it's worrying at least :) > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503909#comment-16503909 ] Hadoop QA commented on OOZIE-3274: -- PreCommit-OOZIE-Build started > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[
https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503512#comment-16503512
]
Hadoop QA commented on OOZIE-3274:
--
Testing JIRA OOZIE-3274
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:red}-1{color} the patch contains 3 line(s) with tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
error(s)
.{color:red}ERROR{color}: the current HEAD has 2 Javadoc error(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [12] new bugs found in total that would be
nice to have fixed.
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:orange}0{color} There are [12] new bugs found in [server] that would
be nice to have fixed.
. You can find the FindBugs diff here: server/findbugs-new.html
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 552
.Tests failed: 6
.Tests errors: 392
.The patch failed the following testcases:
scratchDir_Is_Created_When_Setup_Called_And_ScratchDir_Did_Not_Exist(org.apache.oozie.server.TestJspHandler)
scratchDir_Is_Reused_When_Setup_Called_And_ScratchDir_Existed(org.apache.oozie.server.TestJspHandler)
scratchDir_Cannot_Be_Created_When_Setup_Called_And_ScratchDir_Did_Not_Exist(org.apache.oozie.server.TestJspHandler)
testYarnUnregisterFails(org.apache.oozie.action.hadoop.TestLauncherAM)
testUpdateActionDataFailsWithActionError(org.apache.oozie.action.hadoop.TestLauncherAM)
testActionPrepareFails(org.apache.oozie.action.hadoop.TestLauncherAM)
.Tests failing with errors:
initializationError(org.apache.oozie.example.TestLocalOozieExample)
initializationError(org.apache.oozie.util.TestZKUtilsWithSecurity)
initializationError(org.apache.oozie.test.TestParallelJPAOperationRetries)
initializationError(org.apache.oozie.test.TestWorkflow)
initializationError(org.apache.oozie.test.TestWorkflowRetries)
initializationError(org.apache.oozie.util.TestTimestampedMessageParser)
initializationError(org.apache.oozie.command.bundle.TestBundleRerunXCommand)
initializationError(org.apache.oozie.jms.TestJMSJobEventListener)
initializationError(org.apache.oozie.executor.jpa.TestCoordActionsActiveCountJPAExecutor)
initializationError(org.apache.oozie.executor.jpa.TestCoordActionGetForStartJPAExecutor)
initializationError(org.apache.oozie.command.coord.TestPastActionsTimeOut)
initializationError(org.apache.oozie.command.coord.TestCoordKillXCommand)
initializationError(org.apache.oozie.executor.jpa.TestCoordJobGetActionsRunningJPAExecutor)
initializationError(org.apache.oozie.command.coord.TestCoordRerunXCommand)
initializationError(org.apache.oozie.TestCoordinatorEngineStreamLog)
initializationError(org.apache.oozie.coord.TestCoordUtils)
initializationError(org.apache.oozie.workflow.lite.TestLiteWorkflowAppParser)
initializationError(org.apache.oozie.util.db.TestSLAD
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503510#comment-16503510 ] Denes Bodo commented on OOZIE-3274: --- [~bpgergo] sorry for the late reaction. I think using slf4j in client is okay with slf4j-simple implementation. Otherwise hadoop's KerberosAuthenticator miss the log appender configuration. > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503500#comment-16503500 ] Péter Gergő Barna commented on OOZIE-3274: -- [~gezapeti], thanks for looking into this. First patch was something that would indicate what is this issue about. This new patch should work for master branch. > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503496#comment-16503496 ] Hadoop QA commented on OOZIE-3274: -- PreCommit-OOZIE-Build started > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.rebased.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503014#comment-16503014 ] Denes Bodo commented on OOZIE-3274: --- [~gezapeti] sure, we will do deeper tests. A quick check has done without slf4j jars and seems promising. > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503013#comment-16503013 ] Peter Cseh commented on OOZIE-3274: --- [~bpgergo], please rebase the patch > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[
https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503004#comment-16503004
]
Hadoop QA commented on OOZIE-3274:
--
Testing JIRA OOZIE-3274
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Remove slf4j
>
>
> Key: OOZIE-3274
> URL: https://issues.apache.org/jira/browse/OOZIE-3274
> Project: Oozie
> Issue Type: Bug
>Affects Versions: trunk
>Reporter: Péter Gergő Barna
>Assignee: Péter Gergő Barna
>Priority: Major
> Fix For: trunk
>
> Attachments: OOZIE-3274.patch
>
>
> Remove all slf4j jars from Oozie.
> I am not sure if Oozie works perfectly without slf4j jars, for me it seems
> that all kinds of hadoop2 jobs are working fine. Any comments are welcomed,
> I would appreciate a response from the community on this.
>
> I know about this issue, which introduced slf4j as a dependency, I am not
> sure if this is relevant any more.
> https://issues.apache.org/jira/browse/OOZIE-1004
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502996#comment-16502996 ] Hadoop QA commented on OOZIE-3274: -- PreCommit-OOZIE-Build started > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Assignee: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3274) Remove slf4j
[ https://issues.apache.org/jira/browse/OOZIE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502887#comment-16502887 ] Denes Bodo commented on OOZIE-3274: --- [~andras.piros], [~gezapeti], Do you think we can get rid of slf4j as [~bpgergo] mentions? Thanks > Remove slf4j > > > Key: OOZIE-3274 > URL: https://issues.apache.org/jira/browse/OOZIE-3274 > Project: Oozie > Issue Type: Bug >Affects Versions: trunk >Reporter: Péter Gergő Barna >Priority: Major > Fix For: trunk > > Attachments: OOZIE-3274.patch > > > Remove all slf4j jars from Oozie. > I am not sure if Oozie works perfectly without slf4j jars, for me it seems > that all kinds of hadoop2 jobs are working fine. Any comments are welcomed, > I would appreciate a response from the community on this. > > I know about this issue, which introduced slf4j as a dependency, I am not > sure if this is relevant any more. > https://issues.apache.org/jira/browse/OOZIE-1004 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
