[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739512#comment-16739512 ] Hadoop QA commented on OOZIE-3407: -- Testing JIRA OOZIE-3407 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any star imports .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} Javadoc generation succeeded with the patch .{color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) .{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} .Tests run: 3110 .{color:orange}Tests failed at first run:{color} TestCoordActionsKillXCommand#testActionKillCommandActionNumbers .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:green}*+1 Overall result, good!, no -1s*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/964/ > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch, > OOZIE-3407-03.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739387#comment-16739387 ] Hadoop QA commented on OOZIE-3407: -- PreCommit-OOZIE-Build started > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch, > OOZIE-3407-03.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739402#comment-16739402 ] Andras Piros commented on OOZIE-3407: - Thanks for the contribution [~asalamon74]! +1 (pending Jenkins pre-commit build for patch 03) > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch, > OOZIE-3407-03.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733477#comment-16733477 ] Andras Piros commented on OOZIE-3407: - Thanks [~asalamon74] for the contribution! Skimmed through the patch on RB. > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732744#comment-16732744 ] Andras Salamon commented on OOZIE-3407: --- Review Board has been fixed, created a review request there. > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732171#comment-16732171 ] Andras Salamon commented on OOZIE-3407: --- The tests were already flaky: https://issues.apache.org/jira/browse/OOZIE-3252 this problem was not introduced with this patch. > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732161#comment-16732161 ] Hadoop QA commented on OOZIE-3407: -- Testing JIRA OOZIE-3407 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any star imports .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} Javadoc generation succeeded with the patch .{color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) .{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s) {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [core]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} .Tests run: 3106 .{color:orange}Tests failed at first run:{color} TestPurgeXCommand#testPurgeBundleWithCoordChildWithWFChildWithSubWF1 TestPurgeXCommand#testPurgeBundleWithCoordChildWithWFChildWithSubWF2 TestPurgeXCommand#testPurgeCoordWithWFChild2 .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:green}*+1 Overall result, good!, no -1s*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/956/ > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732065#comment-16732065 ] Andras Salamon commented on OOZIE-3407: --- I cannot open a ReviewBoard request: https://issues.apache.org/jira/browse/INFRA-17525 > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3407) Cleanup TestPurgeXCommand
[ https://issues.apache.org/jira/browse/OOZIE-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732060#comment-16732060 ] Andras Salamon commented on OOZIE-3407: --- Reuploaded the patch using {{--full-index}} to make the ReviewBoard happy. > Cleanup TestPurgeXCommand > - > > Key: OOZIE-3407 > URL: https://issues.apache.org/jira/browse/OOZIE-3407 > Project: Oozie > Issue Type: Sub-task >Affects Versions: trunk >Reporter: Andras Salamon >Assignee: Andras Salamon >Priority: Major > Fix For: 5.2.0 > > Attachments: OOZIE-3407-01.patch, OOZIE-3407-02.patch > > > [TestPurgeXCommand|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java] > is the longest java source file of Oozie, more than 4000 rows. > As part of the Purge Service rewrite we need to use this file to make sure we > don't introduce new bugs and probably we also need to add a few more test > cases. Before that it would be useful to cleanup this file and extract > redundant code to new methods to make the code shorter and more manageable. > The patch uploaded to OOZIE-3400 introduced three new test cases to this file > and shows a simple way to make it shorter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)