[jira] [Commented] (OOZIE-3554) Add asf.yaml to git repo

2022-12-19 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/OOZIE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649403#comment-17649403
 ] 

Hadoop QA commented on OOZIE-3554:
--


Testing JIRA OOZIE-3554

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:red}-1{color} the patch contains 1 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that 
must be fixed.
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:red}-1{color} There are [1] new bugs found below threshold in 
[sharelib/oozie] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones): 
sharelib/oozie/findbugs-new.html
.The most important SpotBugs errors are:
.At ShellMain.java:[line 93]: This usage of 
java/lang/ProcessBuilder.(Ljava/util/List;)V can be vulnerable to 
Command Injection
.At ShellMain.java:[line 91]: At ShellMain.java:[line 90]
.At ShellMain.java:[line 92]
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:orange}0{color} There are [4] new bugs found in [server] that would 
be nice to have fixed.
.You can find the SpotBugs diff here: server/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3259
.{color:orange}Tests failed at first run:{color}
TestCLIParser#testCommandParserShowHelpWithOptions
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 
{color:green}+1 MODERNIZER{color}


{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/173/



> Add asf.yaml to git repo
> 
>
> Key: OOZIE-3554
> URL: https://issues.apache.org/jira/browse/OOZIE-3554
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3554-001.patch
>
>
> Add an {{asf.yaml}} file to the git repo similarly to LUCENE-8986. This will 
> be useful for the pull-request handling as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OOZIE-3554) Add asf.yaml to git repo

2022-12-19 Thread Andras Salamon (Jira)


[ 
https://issues.apache.org/jira/browse/OOZIE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649395#comment-17649395
 ] 

Andras Salamon commented on OOZIE-3554:
---

[~jmakai] I followed the link in the file to the documentation: 
[https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features] 
and it states the following:
{quote}Do not use the document separator – in your .asf.yaml file. It will 
cause parsing to fail.
{quote}
I'm not sure if this document separator is the same as the {{---}} used in the 
file, but probably it would be safer not to use it. (Lucene has no such 
separator).

BTW, is there a way to test this asf.yaml file? Maybe in a forked repo?

 

> Add asf.yaml to git repo
> 
>
> Key: OOZIE-3554
> URL: https://issues.apache.org/jira/browse/OOZIE-3554
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3554-001.patch
>
>
> Add an {{asf.yaml}} file to the git repo similarly to LUCENE-8986. This will 
> be useful for the pull-request handling as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OOZIE-3554) Add asf.yaml to git repo

2022-12-19 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/OOZIE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649361#comment-17649361
 ] 

Hadoop QA commented on OOZIE-3554:
--

PreCommit-OOZIE-Build started


> Add asf.yaml to git repo
> 
>
> Key: OOZIE-3554
> URL: https://issues.apache.org/jira/browse/OOZIE-3554
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3554-001.patch
>
>
> Add an {{asf.yaml}} file to the git repo similarly to LUCENE-8986. This will 
> be useful for the pull-request handling as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OOZIE-3554) Add asf.yaml to git repo

2022-12-19 Thread Janos Makai (Jira)


[ 
https://issues.apache.org/jira/browse/OOZIE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649360#comment-17649360
 ] 

Janos Makai commented on OOZIE-3554:


Similarly to LUCENE-8986, I've created a .asf.yaml file. [~asalamon74] / 
[~dionusos] could you please the created .asf.yaml file? Thank you.

> Add asf.yaml to git repo
> 
>
> Key: OOZIE-3554
> URL: https://issues.apache.org/jira/browse/OOZIE-3554
> Project: Oozie
>  Issue Type: Sub-task
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3554-001.patch
>
>
> Add an {{asf.yaml}} file to the git repo similarly to LUCENE-8986. This will 
> be useful for the pull-request handling as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)