[jira] [Updated] (OOZIE-2644) Skip queuing Notification Commands when there's nothing to notify
[
https://issues.apache.org/jira/browse/OOZIE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Azrael Seoeun updated OOZIE-2644:
-
Attachment: OOZIE-2644.2.patch
Fix test failures.
> Skip queuing Notification Commands when there's nothing to notify
> -
>
> Key: OOZIE-2644
> URL: https://issues.apache.org/jira/browse/OOZIE-2644
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 3.1.3
>Reporter: Robert Kanter
>Assignee: Azrael Seoeun
> Fix For: 5.0.0
>
> Attachments: OOZIE-2644.1.patch, OOZIE-2644.2.patch
>
>
> When you use the
> [Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
> or
> [Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
> Notification features, Oozie can end up queuing up a lot of
> {{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}.
> This happens even if there's no notification configured on the job (which I
> imagine is most of the time); in this case, the {{execute}} method simply
> does nothing. This is wasteful and clogs the queue up.
> We should change the code so that it doesn't queue up one of these Commands
> unless there's actually a URL to notify.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OOZIE-2644) Skip queuing Notification Commands when there's nothing to notify
[
https://issues.apache.org/jira/browse/OOZIE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Azrael Seoeun updated OOZIE-2644:
-
Attachment: OOZIE-2644.1.patch
The patch is addressed comments.
As of now, CallableQueueService increase one more count in queued group for
instrumentation if CompositeCallable queued. So, if CompositeCallable which
contain 2 callables is queued, it add 3 to queued count. I am not sure it is
intended or not. If it is not intended, I can create separate Jira issue.
And this patch fix the NullPointerException when CoordActionNotification
executed from CoordActionKillXCommand. This is caused the runConf of actionBean
is not set. I can create separate Jira issue if needed.
CoordActionNotificationXCommand.java
{noformat}
Configuration conf;
try {
conf = new XConfiguration(new
StringReader(actionBean.getRunConf()));
}
catch (IOException e1) {
LOG.warn("Configuration parse error. read from DB :" +
actionBean.getRunConf());
throw new CommandException(ErrorCode.E1005, e1.getMessage(), e1);
}
{noformat}
> Skip queuing Notification Commands when there's nothing to notify
> -
>
> Key: OOZIE-2644
> URL: https://issues.apache.org/jira/browse/OOZIE-2644
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 3.1.3
>Reporter: Robert Kanter
>Assignee: Azrael Seoeun
> Fix For: 5.0.0
>
> Attachments: OOZIE-2644.1.patch
>
>
> When you use the
> [Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
> or
> [Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
> Notification features, Oozie can end up queuing up a lot of
> {{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}.
> This happens even if there's no notification configured on the job (which I
> imagine is most of the time); in this case, the {{execute}} method simply
> does nothing. This is wasteful and clogs the queue up.
> We should change the code so that it doesn't queue up one of these Commands
> unless there's actually a URL to notify.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OOZIE-2644) Skip queuing Notification Commands when there's nothing to notify
[
https://issues.apache.org/jira/browse/OOZIE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Kanter updated OOZIE-2644:
-
Description:
When you use the
[Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
or
[Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
Notification features, Oozie can end up queuing up a lot of
{{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}. This
happens even if there's no notification configured on the job (which I imagine
is most of the time); in this case, the {{execute}} method simply does nothing.
This is wasteful and clogs the queue up.
We should change the code so that it doesn't queue up one of these Commands
unless there's actually a URL to notify.
was:
When you use the
[Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
or
[Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
Notification features, Oozie can end up queuing up a lot of
{{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}. This
happens even if there's no notification configured on the job (which I imagine
is most of the time); in this case, the {{execute}} method simply does nothing.
This is wasteful and clogs the queue up.
We should change the code so that it doesn't queue up one of these Commands
unless there's actually a URL to notify.
It would also be nice if we could combine the code more between the two, but
that might be tricky because of the parenting.
> Skip queuing Notification Commands when there's nothing to notify
> -
>
> Key: OOZIE-2644
> URL: https://issues.apache.org/jira/browse/OOZIE-2644
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 3.1.3
>Reporter: Robert Kanter
> Fix For: 4.4.0
>
>
> When you use the
> [Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
> or
> [Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
> Notification features, Oozie can end up queuing up a lot of
> {{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}.
> This happens even if there's no notification configured on the job (which I
> imagine is most of the time); in this case, the {{execute}} method simply
> does nothing. This is wasteful and clogs the queue up.
> We should change the code so that it doesn't queue up one of these Commands
> unless there's actually a URL to notify.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
