Re: Review Request 52824: OOZIE-2644 Skip queuing Notification Commands when there's nothing to notify
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52824/ --- (Updated Oct. 13, 2016, 3:56 p.m.) Review request for oozie and Robert Kanter. Changes --- Fix test failures. Bugs: OOZIE-2644 https://issues.apache.org/jira/browse/OOZIE-2644 Repository: oozie-git Description --- Skip queing Notification Command if the notification url is not configured. And this patch fix the NullPointerException when CoordActionNotification executed from CoordActionKillXCommand. This is caused the runConf of actionBean is not set. Diffs (updated) - core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9 core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 3a3120d core/src/main/java/org/apache/oozie/command/NotificationXCommand.java 68359aa core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java ef0fc2d core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 45abe5a core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 958194d core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d4c98c8 core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java f6c1782 core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java f1509e6 core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java d0551ff core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 740b8d3 core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java ac096cc core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java edfac48 core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 836e5d4 core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 40b93d3 core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java edbd767 core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java e95a60a core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java ef97990 core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java bc80dfe core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java c0e6c19 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 432f075 core/src/main/java/org/apache/oozie/local/LocalOozie.java bf1b0db core/src/main/resources/oozie-default.xml e71ebe3 core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 8ca404f core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java c9b2f28 core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4 core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java a0012fb core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd Diff: https://reviews.apache.org/r/52824/diff/ Testing --- Unit test. Thanks, Azrael Seoeun Park
Review Request 52824: OOZIE-2644 Skip queuing Notification Commands when there's nothing to notify
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52824/ --- Review request for oozie and Robert Kanter. Bugs: OOZIE-2644 https://issues.apache.org/jira/browse/OOZIE-2644 Repository: oozie-git Description --- Skip queing Notification Command if the notification url is not configured. And this patch fix the NullPointerException when CoordActionNotification executed from CoordActionKillXCommand. This is caused the runConf of actionBean is not set. Diffs - core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9 core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 3a3120d core/src/main/java/org/apache/oozie/command/NotificationXCommand.java 68359aa core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 6024138 core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java ef0fc2d core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 45abe5a core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 958194d core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d4c98c8 core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java f6c1782 core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java f1509e6 core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java d0551ff core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 740b8d3 core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java ac096cc core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java edfac48 core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 836e5d4 core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 40b93d3 core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java edbd767 core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java e95a60a core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java ef97990 core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java bc80dfe core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java c0e6c19 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 432f075 core/src/main/java/org/apache/oozie/local/LocalOozie.java bf1b0db core/src/main/resources/oozie-default.xml e71ebe3 core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 8ca404f core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java c9b2f28 core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4 core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java a0012fb core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd Diff: https://reviews.apache.org/r/52824/diff/ Testing --- Unit test. Thanks, Azrael Seoeun Park
