[GitHub] opennlp pull request #8: OPENNLP-891: Making the TokenClassFeatureGenerator ...

[jzonthemtn]

GitHub user jzonthemtn opened a pull request:

https://github.com/apache/opennlp/pull/8

OPENNLP-891: Making the TokenClassFeatureGenerator configurable.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jzonthemtn/opennlp OPENNLP-891

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit dd2baa0c6e9d49f19e98004fcaceb0cf558ebbdf
Author: jzonthemtn 
Date:   2016-12-13T00:55:57Z

OPENNLP-891: Making the TokenClassFeatureGenerator configurable.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Project of converting natural language to cypher language

[Xinran Yu]

Hi, OpenNLP team,
   How are you. I am interested in contributing of implementing conversion
of natural language to cypher query language. Please let me know if anyone
would like to collaborate. My linkedin:
https://www.linkedin.com/in/xinran-yu-28a1b314

Thanks!
Xinran Yu

Re: TODO in GeneratorFactory.java

[Joern Kottmann]

Yes, that is a nice change, can you open a jira issue for it and send me
the PR?

Would like to include that.

Jörn

On Tue, Dec 13, 2016 at 1:41 PM, Jeffrey Zemerick 
wrote:

> Hi everyone,
>
> I came across a TODO in GeneratorFactory.java to make
> the TokenClassFeatureGenerator construction configurable. My cursory search
> of the JIRA didn't show any related tasks. I presumed the configuration was
> referring to the boolean generateWordAndClassFeature argument in the
> constructor of TokenClassFeatureGenerator. I added the parameter to the XML
> and pass that value to the constructor. If there is no parameter in the XML
> it sets to `true` to maintain backward compatibility. A diff of my changes
> can be seen at
> https://github.com/apache/opennlp/compare/trunk...jzonthemtn:
> TokenClassFeatureGenerator
> .
>
> If this was still a valid "todo" item and the changes I made were what was
> desired I can submit a patch or a pull request.
>
> Jeff
>

TODO in GeneratorFactory.java

[Jeffrey Zemerick]

Hi everyone,

I came across a TODO in GeneratorFactory.java to make
the TokenClassFeatureGenerator construction configurable. My cursory search
of the JIRA didn't show any related tasks. I presumed the configuration was
referring to the boolean generateWordAndClassFeature argument in the
constructor of TokenClassFeatureGenerator. I added the parameter to the XML
and pass that value to the constructor. If there is no parameter in the XML
it sets to `true` to maintain backward compatibility. A diff of my changes
can be seen at
https://github.com/apache/opennlp/compare/trunk...jzonthemtn:TokenClassFeatureGenerator
.

If this was still a valid "todo" item and the changes I made were what was
desired I can submit a patch or a pull request.

Jeff