Re: AOO Design Patterns

[Damjan Jovanovic]

Hi Lalith

It looks like SbxErrObject is a singleton: if you read errobject.cxx,
you see that SbxErrObject::getErrObject() returns a single static
instance.

Why are you reading the main/basic code by the way? Would you like to
contribute a patch?

Damjan

On Sun, Mar 27, 2016 at 8:48 PM, Lalith Ramesh
 wrote:
> Dev List,
>
> I was browsing through the code on Fisheye, and I noticed some interesting
> design patterns that were in use.
> For example, errobject.hxx has a public factory method to make new
> ErrObjects, but the constructors are not marked as public.
> What was the motivation behind this design decision?

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Fwd: AOO Design Patterns

[Lalith Ramesh]

If no one knows the answer to this question, that's OK.
I just wanted to add a descriptive comment to the code.

-- Forwarded message --
From: Lalith Ramesh 
Date: Sun, Mar 27, 2016 at 2:48 PM
Subject: AOO Design Patterns
To: dev@openoffice.apache.org


Dev List,

I was browsing through the code on Fisheye, and I noticed some interesting
design patterns that were in use.
For example, errobject.hxx has a public factory method to make new
ErrObjects, but the constructors are not marked as public.
What was the motivation behind this design decision?

Re: failed to build aoo420 dev on win32

[Patricia Shanahan]

On 4/10/2016 5:28 AM, Oliver Brinzing wrote:

Hi Patricia,

thanks for your build settings.
Did you manage to build  aoo420 debug version?


I am building off the current Trunk. Is that a00420?



yesterday i started a new aoo412 debug build with my settings.
after 5 hours the build finished without any problems.

i tried again with rev 1738357 and failed again... added 4 issues:

windows build breaks in module crashrep - Assertion Failed
https://bz.apache.org/ooo/show_bug.cgi?id=126918

windows build breaks in module connectivity/source/parse/sqliterator.cxx
https://bz.apache.org/ooo/show_bug.cgi?id=126917

windows build breaks in module formula
https://bz.apache.org/ooo/show_bug.cgi?id=126916

windows build breaks in module sc/source/filter/excel - missing #include

https://bz.apache.org/ooo/show_bug.cgi?id=126919

maybe i should try again with " --disable-pch" do not use multiple
parallel processes feature (e.g. build --all -P2 -- -P2)


I put in --disable-pch because of build problems, so it may help. At a 
minimum it should make your builds more reproducible.




Regards
Oliver


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Re: failed to build aoo420 dev on win32

[Oliver Brinzing]

Hi Patricia,

thanks for your build settings.
Did you manage to build  aoo420 debug version?

yesterday i started a new aoo412 debug build with my settings.
after 5 hours the build finished without any problems.

i tried again with rev 1738357 and failed again... added 4 issues:

windows build breaks in module crashrep - Assertion Failed
https://bz.apache.org/ooo/show_bug.cgi?id=126918

windows build breaks in module connectivity/source/parse/sqliterator.cxx
https://bz.apache.org/ooo/show_bug.cgi?id=126917

windows build breaks in module formula
https://bz.apache.org/ooo/show_bug.cgi?id=126916

windows build breaks in module sc/source/filter/excel - missing #include 

https://bz.apache.org/ooo/show_bug.cgi?id=126919

maybe i should try again with " --disable-pch" do not use multiple
parallel processes feature (e.g. build --all -P2 -- -P2)

Regards
Oliver


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Re: [DISCUSS] Cleanup needed for RESOLVED-FIXED issues

[Marcus]

Am 04/09/2016 11:36 PM, schrieb Kay Schenk:

On Sat, Apr 9, 2016 at 3:01 AM, Marcus  wrote:


Am 04/07/2016 12:43 AM, schrieb Kay Schenk:


[...]

A warning -- unless you can see an SVN commit clearly
stating that the fix has been ported to one of our existing
releases, it may take a bit of investigation into the
release branch area to determine this.

release branch area--
http://svn.apache.org/viewvc/openoffice/branches/


Our new resolution of FIXED_WITHOUT_CODE should result in
CLOSING without any further investigation.

Thoughts on undertaking this cleanup?



many issues are commented with "fixed in CMS xyz" but there are no real
commits visible. Not every CWS was committed into Trunk before the project
and software was transferred to Apache.​




So, do we have a list of outstanding CWS from 2011 that were not
transferred to Apache?

Thanks



​As far as I know, NONE of the CWS (child workspaces) were ported when the
project was brought into Apache.​


hm, I remember that some were integrated. But I'm not really sure. It's 
too long ago. ;-)


@all:
Does anybody else remember a list of these CWS? Integrated or not? It 
would be very helpful.



​ For a while, these were "available" somewhere, but that archive
disappeared at some point, at least from its original location.


Too bad.


I
​ also believe looking at the activity when OpenOffice was brought in the
ASF, that some of this code may have been committed to /trunk by
individuals, but the spaces where not merged in their entirety. ​
Generally, these kinds of changes you find referenced in BZ may as well be
considered OBSOLETE I guess.


Knowing which CWS was integrated and which not is important to set the 
correct status. If the fix was never committed into Trunk then OBSOLETE 
seems not the right thing as the issue may still be occurring.



You're doing a considerable job on all this byt the way! :) Thanks.


:-)

Marcus


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org