Re: Is this a typo or is it intentional?
Hello Dick,
On Thu, Mar 04, 2021 at 06:25:10PM -, Dick Groskamp wrote:
> I'm definitely no developer but when I added the new Japanse era Reiwa to the
> file
> openoffice-trunk/main/i18npool/source/calendar/calendar_gregorian.cxx,
> I noticed this code:
>
> 132 Calendar_gregorian::Calendar_gregorian()
> 133 {
> 134 init(NULL);
> 135 }
> 136 Calendar_gregorian::Calendar_gregorian(Era *_earArray)
> 137 {
> 138 init(_earArray);
> 139 }
> _
> on line 140 it says however: Calendar_gregorian::init(Era *_eraArray)
>
> It seems to me that _eraArray is right because it is used further on in the
> code.
>
> QUESTION:
> Are the *_earArray on line 136 and _earArray on line 138 intentional or are
> they typo's ?
I think that "ear" instead of "era" is a typo.
If you look at the corresponding include file
main/i18npool/inc/calendar_gregorian.hxx at line 51:
45 class Calendar_gregorian : public CalendarImpl
46 {
47 public:
48
49// Constructors
50Calendar_gregorian();
51Calendar_gregorian(Era *_eraArray);
52void SAL_CALL init(Era *_eraArray);
The parameter is spelled correctly there.
However the code compiles and works fine, because the typo is ``used
consistently'' inside Calendar_gregorian::Calendar_gregorian(Era *)
If you don't like to have that typo in the code, I believe you can fix
it straight away as it is a ``trivial edit'' (i.e. no need to review
before committing), as I think you did for the new Japanese era.
I hope this helps.
Best regards,
--
Arrigo
http://rigo.altervista.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Is this a typo or is it intentional?
I'm definitely no developer but when I added the new Japanse era Reiwa to the
file
openoffice-trunk/main/i18npool/source/calendar/calendar_gregorian.cxx,
I noticed this code:
132 Calendar_gregorian::Calendar_gregorian()
133 {
134 init(NULL);
135 }
136 Calendar_gregorian::Calendar_gregorian(Era *_earArray)
137 {
138 init(_earArray);
139 }
_
on line 140 it says however: Calendar_gregorian::init(Era *_eraArray)
It seems to me that _eraArray is right because it is used further on in the
code.
QUESTION:
Are the *_earArray on line 136 and _earArray on line 138 intentional or are
they typo's ?
Could someone with more knowledge enlighten me or at least check if it is
correct as it is ?
Couldn't file an issue on GitHub so mentioned it here
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Testing Open Office for Big Sur 11.2.2
Hi Carolyn Hopefully the new version 4.1.9 released on February 7th solved the identified issues with Big Sur Please make sure to install this version and report back if you ever find any issues. https://www.openoffice.org/download/index.html Thank you for your encouraging message! All the best, Pedro > On 03/04/2021 2:29 PM Christian and Carolyn Alexander > wrote: > > > Greetings! > > I've been an Open Office user for over a decade. Thank you for all you do! > Your products have enabled my college, work, and personal endeavors over > the years. > > Your website says you're looking for users who will help test the version > of Open Office that's meant to work with Big Sur. I'd like to participate > if it would still be helpful. > > Typically, I use an OO spreadsheet every day, and a word processing > document perhaps every week or two. > > If I can be of assistance, please let me know. Thank you for working on > reestablishing compatibility for your Mac users. We appreciate you. > > Carolyn Alexander - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Testing Open Office for Big Sur 11.2.2
Greetings! I've been an Open Office user for over a decade. Thank you for all you do! Your products have enabled my college, work, and personal endeavors over the years. Your website says you're looking for users who will help test the version of Open Office that's meant to work with Big Sur. I'd like to participate if it would still be helpful. Typically, I use an OO spreadsheet every day, and a word processing document perhaps every week or two. If I can be of assistance, please let me know. Thank you for working on reestablishing compatibility for your Mac users. We appreciate you. Carolyn Alexander
