Re: JUnit update from 4.10 to 4.13.2 in test automation
Hi All, adding cc. dev@ On 5/31/21 3:05 PM, Carl Marcum wrote: Hi All, Just an FYI I've been working on updating the JUnit library used in the test suites for trunk. Our current 4.10 is ten years old. I'm doing this in two steps. First step was the library update to 4.12 in commit 069226d [1]. The only effect of this is users that have ran the automated tests and have a test/lib folder need to delete the junit.jar before compiling the tests again and you will get the 4.12 jar and also hamcrest 2.2 as well. A change in 4.11 was the need to separately include a hamcrest dependency. Now that is integrated I've submitted PR-131 [2] to go to JUnit 4.13.2 which is the latest in the JUnit 4 series. This required class changes due to changes in JUnit 4.13 which is why I chose to split it up. BTW, JUnit 5 is the new rewrite of this library but it has a Java 8 dependency and a lot of changes to the API to it's not something I'm looking at currently. However just these updates open up many improvements that can be made in the tests especially the parameterized ones. *** Anyone who compiles the test suite needs to delete or empty the /test/lib directory before compiling to get the correct junit.jar and the new hamcrest.jar required. *** This will need done again after PR-131 is merged. I'll post a note here after it's integrated. [1] https://github.com/apache/openoffice/commit/069226d344055623fb554fac841132ecefce563a [2] https://github.com/apache/openoffice/pull/131 The test automation has been updated in trunk and AOO42X to use JUnit 4.13.2 (latest JUnit 4) and now includes Hamcrest 2.2 (latest). Anyone who runs the automated test suites will need to remove the junit.jar from /test/lib and you should get the new jars downloaded next time you compile the tests. Please let me know if you have any questions. Thanks, Carl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] cbmarcum merged pull request #131: Refs #i128455# - updated junit to 4.13.2.
cbmarcum merged pull request #131: URL: https://github.com/apache/openoffice/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
Hello All, On Wed, Jun 02, 2021 at 01:00:08PM -0700, Dave Fisher wrote: > > On Jun 2, 2021, at 11:58 AM, Marcus wrote: > > > > Am 02.06.21 um 00:07 schrieb Peter Kovacs: > >> On 01.06.21 21:57, Arrigo Marchiori wrote: > > I would not go for file://. Can we go for a pattern derivated from > > file://path/document.ods#anchor ? > >>> I am not sure I understand your question, Peter. > >>> > >> I am suggesting not to trust file:// in general, but the anchored URL, > > > > yes, the securty report is talking about nin-http(s) links, And "ile" is > > not http. There we have to treat this as insecure. > > > >> maybe file://*#anchor if you like. > >> But maybe I got this URL wrong. > > > > Hm, I don't see how an anchor makes the document more secure. ;-) > > We need to know if the file:// is already open. We might be able to know whether the file is already open, if it is an AOO document. But what if the file is a JPG image? Or a MP3 audio? Should it not be considered safe as well? And for what I know, AOO cannot open images or MP3's as documents. Judging on the file extension seems to me the best way to follow, at least for the file:/// protocol and any other protocols that rely on XSystemShellExecute::execute(). I hope this makes sense. -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
Hi Arrigo, Am 01.06.21 um 21:57 schrieb Arrigo Marchiori: >> We are grabbing an INetURLObject here: >> http://opengrok.openoffice.org/xref/aoo4110/main/sfx2/source/appl/appopen.cxx?r=b1cdbd2c#929 >> >> The code after here >> http://opengrok.openoffice.org/xref/aoo4110/main/sfx2/source/appl/appopen.cxx?r=b1cdbd2c#1040 >> may be helpful. > I do not seem to be able to open your links, sorry... I have no problem opening these links... > Please see branch bug128453, just pushed. I just started a Windows Test Build on that branch. Regards, Matthias > > I will look for older CVE's in the next days. > > I hope this helps. > > Best regards, smime.p7s Description: S/MIME Cryptographic Signature
