Re: Openssl, serf and curl
Hello Carl, On Wed, Nov 17, 2021 at 07:36:37PM -0500, Carl Marcum wrote: > Hi Arrigo, > > On 11/17/21 2:16 AM, Arrigo Marchiori wrote: > > Dear All, > > > > I pushed a new branch "serf", that contains the OpenSSL upgrade > > commits (I reverted the reverts ;-) plus a tentative upgrade of the > > serf library to 1.3.9. > > > > A small patch is included to allow building with Python3-based SCons. > > > > The oox module also needed minor patching because it uses some OpenSSL > > functions that were refactored since OpenSSL 1.1.0. > > > > I tested it under Linux with Peter's Docker image (adding SCons). It > > builds and runs, but I am not sure how to verify if the SSL related > > problems are solved. > > > > I could not yet test if it builds under Windows and Mac. Any help > > would be appreciated. Please note that the "serf" branch derives from > > trunk. > > > > Best regards, > I tried to build the serf branch but it broke on serf module. I think I > need Scons. > Are there instructions to add it? Not yet. I think we should only document it if we ``officially'' choose this path. If you are using Peter's Docker image, you can install SCons in a temporary container with the command: # yum install scons In order to make the installation permanent, we should edit the Dockerfile. If you are using your own computer, then you will need to install the scons package using your distribution's package manager (apt, yum, zypper...) I hope this helps. Best regards, -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Openssl, serf and curl
Hi Arrigo, On 11/17/21 2:16 AM, Arrigo Marchiori wrote: Dear All, I pushed a new branch "serf", that contains the OpenSSL upgrade commits (I reverted the reverts ;-) plus a tentative upgrade of the serf library to 1.3.9. A small patch is included to allow building with Python3-based SCons. The oox module also needed minor patching because it uses some OpenSSL functions that were refactored since OpenSSL 1.1.0. I tested it under Linux with Peter's Docker image (adding SCons). It builds and runs, but I am not sure how to verify if the SSL related problems are solved. I could not yet test if it builds under Windows and Mac. Any help would be appreciated. Please note that the "serf" branch derives from trunk. Best regards, I tried to build the serf branch but it broke on serf module. I think I need Scons. Are there instructions to add it? Thanks, Carl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: problem reading old XML formats with trunk
On 11/17/21 3:00 PM, Carl Marcum wrote: Hi Arrigo, On 11/17/21 2:43 PM, Arrigo Marchiori wrote: Hello All, sorry for chiming in here so late. On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote: Hi All, On 11/14/21 5:05 PM, Matthias Seidel wrote: Hi Carl, Am 14.11.21 um 22:45 schrieb Carl Marcum: Hi Matthias, On 11/14/21 11:44 AM, Matthias Seidel wrote: Hi Carl, Am 14.11.21 um 17:36 schrieb Matthias Seidel: Hi Carl, Am 14.11.21 um 17:31 schrieb Carl Marcum: Hi Matthias and All, On 11/14/21 9:10 AM, Matthias Seidel wrote: Hi Carl, I only have a VM available with Xubuntu 18.04.6 and AOO42X, but have no problems opening and saving *.STW. Okay I'll build AOO42X and see if I have same issues as trunk. I recompiled trunk with --enable-crashdump=yes \ --enable-dbgutil \ and now I get a better error dialog for opening these file types: testSaveNewSTC.stc testSaveNewSXC.sxc -- Error: uno exception caught while importing: attempt to insert duplicate XML tag attribute: xmlns:svg From File /openoffice/main/sc/source/filter/xml/xmlwrap.cxx at Line 365 Abort ? (Yes=abort / No=ignore / Cancel=core dump) I remember that we have a commit in trunk but not in AOO42X: https://github.com/apache/openoffice/pull/122 Until now it has not been tested... Maybe that is the problem? I can confirm Read-Errors with AOO450 (trunk) on Windows with STW and SXW. No problems with AOO420 (AOO42X). This merge may need to be reverted... Thanks for checking. It might be better at this point to fix the code. That's why I asked for testing... ;-) I'll do some bisecting and try to narrow it down. I am not sure if the code was ready, Arrigo might know better. I bisected it down to this one where it starts giving me the error which makes sense according the the commit message: ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit commit ebd28ad3a7fedadb378ee1596803008e8c6b383b Raise an exception when attempting to add duplicate attributes Yes, that's my commit. It is supposed to avoid duplicated attributes when _saving_ files. I am surprised you see this error while _opening_ them. I could not really understand how to reproduce this problem. Could you please send me a RTFM or a more precise link to the file/script/whatever? Reverting that commit is of course possible. But it would be like sweeping dust under the carpet. Duplicated XML attributes are just illegal, and we should rather fix the code requesting them. IMHO, of course. Thank you in advance and best regards, The test is here [1] which all these methods do you can try manually. 1. open a new writer documant. 2. type @AOO (this really doesn't matter but that's what the test does) 3. Save As "helloworld_saveas.sxw" (only extension type matters here). 4. Close and reopen it. Repeat for the other old XML filetypes. [1] https://github.com/apache/openoffice/blob/trunk/test/testgui/source/bvt/gui/FileTypeTest.java In the meantime I'll build trunk again and make sure I'm getting the save results. Yes, I just built trunk again (c2aa676) looks like I'm two typo commits behind. And I still get the errors. These errors are upon opening a newly created file with trunk. To test an existing file I just created a SXW file with 4.1.11 and moved it to my test VM. My build of AOO42X will open it and my trunk build has a read error so it's not in the writing of the file from what I can tell from that test. Thanks, Carl Thanks, Carl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Buildbot config - svn or git?
Hi Gavin Am 17.11.21 um 11:30 schrieb Gavin McDonald: > Hi All, > > With the new Buildbot 3.x we are using, we also added the ability to host > project config files from either an SVN [1] location or GIT [2] . So now > you have a choice. Currently your modified openoffice.py config lives in > SVN, but I can easily move it to GIT - the choice is yours! Personally, I would prefer git. Do we have write access? Regards, Matthias > > HTH > > [1] - https://svn.apache.org/repos/infra/infrastructure/buildbot2/projects > [2] - https://github.com/apache/infrastructure-bb2 > smime.p7s Description: S/MIME Cryptographic Signature
Re: problem reading old XML formats with trunk
Hi Arrigo, On 11/17/21 2:43 PM, Arrigo Marchiori wrote: Hello All, sorry for chiming in here so late. On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote: Hi All, On 11/14/21 5:05 PM, Matthias Seidel wrote: Hi Carl, Am 14.11.21 um 22:45 schrieb Carl Marcum: Hi Matthias, On 11/14/21 11:44 AM, Matthias Seidel wrote: Hi Carl, Am 14.11.21 um 17:36 schrieb Matthias Seidel: Hi Carl, Am 14.11.21 um 17:31 schrieb Carl Marcum: Hi Matthias and All, On 11/14/21 9:10 AM, Matthias Seidel wrote: Hi Carl, I only have a VM available with Xubuntu 18.04.6 and AOO42X, but have no problems opening and saving *.STW. Okay I'll build AOO42X and see if I have same issues as trunk. I recompiled trunk with --enable-crashdump=yes \ --enable-dbgutil \ and now I get a better error dialog for opening these file types: testSaveNewSTC.stc testSaveNewSXC.sxc -- Error: uno exception caught while importing: attempt to insert duplicate XML tag attribute: xmlns:svg From File /openoffice/main/sc/source/filter/xml/xmlwrap.cxx at Line 365 Abort ? (Yes=abort / No=ignore / Cancel=core dump) I remember that we have a commit in trunk but not in AOO42X: https://github.com/apache/openoffice/pull/122 Until now it has not been tested... Maybe that is the problem? I can confirm Read-Errors with AOO450 (trunk) on Windows with STW and SXW. No problems with AOO420 (AOO42X). This merge may need to be reverted... Thanks for checking. It might be better at this point to fix the code. That's why I asked for testing... ;-) I'll do some bisecting and try to narrow it down. I am not sure if the code was ready, Arrigo might know better. I bisected it down to this one where it starts giving me the error which makes sense according the the commit message: ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit commit ebd28ad3a7fedadb378ee1596803008e8c6b383b Raise an exception when attempting to add duplicate attributes Yes, that's my commit. It is supposed to avoid duplicated attributes when _saving_ files. I am surprised you see this error while _opening_ them. I could not really understand how to reproduce this problem. Could you please send me a RTFM or a more precise link to the file/script/whatever? Reverting that commit is of course possible. But it would be like sweeping dust under the carpet. Duplicated XML attributes are just illegal, and we should rather fix the code requesting them. IMHO, of course. Thank you in advance and best regards, The test is here [1] which all these methods do you can try manually. 1. open a new writer documant. 2. type @AOO (this really doesn't matter but that's what the test does) 3. Save As "helloworld_saveas.sxw" (only extension type matters here). 4. Close and reopen it. Repeat for the other old XML filetypes. [1] https://github.com/apache/openoffice/blob/trunk/test/testgui/source/bvt/gui/FileTypeTest.java In the meantime I'll build trunk again and make sure I'm getting the save results. Thanks, Carl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: problem reading old XML formats with trunk
Hello All, sorry for chiming in here so late. On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote: > Hi All, > > On 11/14/21 5:05 PM, Matthias Seidel wrote: > > Hi Carl, > > > > Am 14.11.21 um 22:45 schrieb Carl Marcum: > > > Hi Matthias, > > > > > > > > > On 11/14/21 11:44 AM, Matthias Seidel wrote: > > > > Hi Carl, > > > > > > > > Am 14.11.21 um 17:36 schrieb Matthias Seidel: > > > > > Hi Carl, > > > > > > > > > > Am 14.11.21 um 17:31 schrieb Carl Marcum: > > > > > > Hi Matthias and All, > > > > > > > > > > > > On 11/14/21 9:10 AM, Matthias Seidel wrote: > > > > > > > Hi Carl, > > > > > > > > > > > > > > I only have a VM available with Xubuntu 18.04.6 and AOO42X, but > > > > > > > have no > > > > > > > problems opening and saving *.STW. > > > > > > Okay I'll build AOO42X and see if I have same issues as trunk. > > > > > > > > > > > > I recompiled trunk with > > > > > > --enable-crashdump=yes \ > > > > > > --enable-dbgutil \ > > > > > > > > > > > > and now I get a better error dialog for opening these file types: > > > > > > testSaveNewSTC.stc > > > > > > testSaveNewSXC.sxc > > > > > > -- > > > > > > Error: uno exception caught while importing: > > > > > > attempt to insert duplicate XML tag attribute: xmlns:svg > > > > > > From File > > > > > > /openoffice/main/sc/source/filter/xml/xmlwrap.cxx at > > > > > > Line 365 > > > > > > Abort ? (Yes=abort / No=ignore / Cancel=core dump) > > > > > I remember that we have a commit in trunk but not in AOO42X: > > > > > > > > > > https://github.com/apache/openoffice/pull/122 > > > > > > > > > > Until now it has not been tested... Maybe that is the problem? > > > > I can confirm Read-Errors with AOO450 (trunk) on Windows with STW and > > > > SXW. > > > > No problems with AOO420 (AOO42X). > > > > > > > > This merge may need to be reverted... > > > > > > Thanks for checking. > > > > > > It might be better at this point to fix the code. > > That's why I asked for testing... ;-) > > > I'll do some bisecting and try to narrow it down. > > I am not sure if the code was ready, Arrigo might know better. > > I bisected it down to this one where it starts giving me the error which > makes sense according the the commit message: > > ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit > commit ebd28ad3a7fedadb378ee1596803008e8c6b383b > > Raise an exception when attempting to add duplicate attributes Yes, that's my commit. It is supposed to avoid duplicated attributes when _saving_ files. I am surprised you see this error while _opening_ them. I could not really understand how to reproduce this problem. Could you please send me a RTFM or a more precise link to the file/script/whatever? Reverting that commit is of course possible. But it would be like sweeping dust under the carpet. Duplicated XML attributes are just illegal, and we should rather fix the code requesting them. IMHO, of course. Thank you in advance and best regards, -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Win Builds progress
Scratch that, let me try looking at the right machine. On Wed, Nov 17, 2021 at 6:36 PM Gavin McDonald wrote: > Hi, > > On Wed, Nov 17, 2021 at 4:49 PM Matthias Seidel < > matthias.sei...@hamburg.de> wrote: > >> Hi Gavin, >> Am 17.11.21 um 11:10 schrieb Gavin McDonald: >> >> Hi All. >> >> With the addition of the openoffice-externals repository and tweaking the >> config, we have now got a little further. >> >> Great! >> >> See: https://ci2.apache.org/#/builders/67/builds/5 >> >> tl'dr: >> >> The 'configure' step fails with the following errors >> >> 1. head: cannot open '/etc/*-release' for reading: No such file or directory >> .. >> >> I think this is a minor issue we had for years. It should not break the >> build. >> > > Ok, would be nice to make it disappear anyway at some point, > > 2. configure: error: /usr/bin/gawk, awk, tar or gunzip is a cygwin symlink! >> Native Windows programs cannot use cygwin symlinks. Remove the symbolic >> link, and copy the program to the name of the link. >> >> You need to do the following commands once inside the Cygwin64 shell: >> >> rm /usr/bin/awk >> mv /usr/bin/gawk.exe /usr/bin/awk.exe >> >> >> This is documented in our Wiki: >> >> >> https://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO/Step_by_step_Windows#Windows_7.2C_Windows_8.1.2C_Windows_10 >> >> For AOO41X this has to be done in the Cygwin32 shell. >> > > I see, ok. To be clear awk is not a symlink as it currently stands, and > gawk has a non standard name: > > $ ls -al /usr/bin | grep awk > -rwxr-xr-x1 Admin None 605203 Feb 27 2018 awk.exe > -rwxr-xr-x1 Admin None 605203 Apr 23 2018 gawk-4.2.1.exe > > So, should I go ahead and delete awk.exe and rename gawk-4.2.1.exe to > awk.exe ? > > > Regards, >> >>Matthias >> >> The next step also fails 'bootstrap' but it likely related to the previous >> step above. >> >> I am unsure if we Infra need to tweak the node somehow or if it can fixed >> on the project side of things, ideas welcome. >> >> >> >> > > -- > > *Gavin McDonald* > Systems Administrator > ASF Infrastructure Team > -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Re: Win Builds progress
Hi, On Wed, Nov 17, 2021 at 4:49 PM Matthias Seidel wrote: > Hi Gavin, > Am 17.11.21 um 11:10 schrieb Gavin McDonald: > > Hi All. > > With the addition of the openoffice-externals repository and tweaking the > config, we have now got a little further. > > Great! > > See: https://ci2.apache.org/#/builders/67/builds/5 > > tl'dr: > > The 'configure' step fails with the following errors > > 1. head: cannot open '/etc/*-release' for reading: No such file or directory > .. > > I think this is a minor issue we had for years. It should not break the > build. > Ok, would be nice to make it disappear anyway at some point, 2. configure: error: /usr/bin/gawk, awk, tar or gunzip is a cygwin symlink! > Native Windows programs cannot use cygwin symlinks. Remove the symbolic > link, and copy the program to the name of the link. > > You need to do the following commands once inside the Cygwin64 shell: > > rm /usr/bin/awk > mv /usr/bin/gawk.exe /usr/bin/awk.exe > > > This is documented in our Wiki: > > > https://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO/Step_by_step_Windows#Windows_7.2C_Windows_8.1.2C_Windows_10 > > For AOO41X this has to be done in the Cygwin32 shell. > I see, ok. To be clear awk is not a symlink as it currently stands, and gawk has a non standard name: $ ls -al /usr/bin | grep awk -rwxr-xr-x1 Admin None 605203 Feb 27 2018 awk.exe -rwxr-xr-x1 Admin None 605203 Apr 23 2018 gawk-4.2.1.exe So, should I go ahead and delete awk.exe and rename gawk-4.2.1.exe to awk.exe ? Regards, > >Matthias > > The next step also fails 'bootstrap' but it likely related to the previous > step above. > > I am unsure if we Infra need to tweak the node somehow or if it can fixed > on the project side of things, ideas welcome. > > > > -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Re: Openssl, serf and curl
HI Arrigo, Am 17.11.21 um 08:16 schrieb Arrigo Marchiori: > Dear All, > > I pushed a new branch "serf", that contains the OpenSSL upgrade > commits (I reverted the reverts ;-) plus a tentative upgrade of the > serf library to 1.3.9. > > A small patch is included to allow building with Python3-based SCons. > > The oox module also needed minor patching because it uses some OpenSSL > functions that were refactored since OpenSSL 1.1.0. > > I tested it under Linux with Peter's Docker image (adding SCons). It > builds and runs, but I am not sure how to verify if the SSL related > problems are solved. On Linux simply look for AOO updates or new extensions. Regards, Matthias > > I could not yet test if it builds under Windows and Mac. Any help > would be appreciated. Please note that the "serf" branch derives from > trunk. > > Best regards, smime.p7s Description: S/MIME Cryptographic Signature
Re: Win Builds progress
Hi Gavin, Am 17.11.21 um 11:10 schrieb Gavin McDonald: > Hi All. > > With the addition of the openoffice-externals repository and tweaking the > config, we have now got a little further. Great! > > See: https://ci2.apache.org/#/builders/67/builds/5 > > tl'dr: > > The 'configure' step fails with the following errors > > 1. head: cannot open '/etc/*-release' for reading: No such file or directory > .. I think this is a minor issue we had for years. It should not break the build. > > 2. configure: error: /usr/bin/gawk, awk, tar or gunzip is a cygwin symlink! > Native Windows programs cannot use cygwin symlinks. Remove the symbolic > link, and copy the program to the name of the link. You need to do the following commands once inside the Cygwin64 shell: rm /usr/bin/awk mv /usr/bin/gawk.exe /usr/bin/awk.exe This is documented in our Wiki: https://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO/Step_by_step_Windows#Windows_7.2C_Windows_8.1.2C_Windows_10 For AOO41X this has to be done in the Cygwin32 shell. Regards, Matthias > > The next step also fails 'bootstrap' but it likely related to the previous > step above. > > I am unsure if we Infra need to tweak the node somehow or if it can fixed > on the project side of things, ideas welcome. > > smime.p7s Description: S/MIME Cryptographic Signature
Buildbot config - svn or git?
Hi All, With the new Buildbot 3.x we are using, we also added the ability to host project config files from either an SVN [1] location or GIT [2] . So now you have a choice. Currently your modified openoffice.py config lives in SVN, but I can easily move it to GIT - the choice is yours! HTH [1] - https://svn.apache.org/repos/infra/infrastructure/buildbot2/projects [2] - https://github.com/apache/infrastructure-bb2 -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Win Builds progress
Hi All. With the addition of the openoffice-externals repository and tweaking the config, we have now got a little further. See: https://ci2.apache.org/#/builders/67/builds/5 tl'dr: The 'configure' step fails with the following errors 1. head: cannot open '/etc/*-release' for reading: No such file or directory .. 2. configure: error: /usr/bin/gawk, awk, tar or gunzip is a cygwin symlink! Native Windows programs cannot use cygwin symlinks. Remove the symbolic link, and copy the program to the name of the link. The next step also fails 'bootstrap' but it likely related to the previous step above. I am unsure if we Infra need to tweak the node somehow or if it can fixed on the project side of things, ideas welcome. -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
