[GitHub] [openoffice] leginee closed pull request #153: Fix for Issue 128375
leginee closed pull request #153: Fix for Issue 128375 URL: https://github.com/apache/openoffice/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on pull request #153: Fix for Issue 128375
leginee commented on PR #153: URL: https://github.com/apache/openoffice/pull/153#issuecomment-1154150850 > Are you sure the tilde doesn't have some significance like in hotkeys? Interesting point. Needs to be reviewe?. Then why is Tilde visible in the string as reported. > Also, which file has this change. I see removing stax and some some build files? oO. There went something wrong. I need to check. I withdraw my PR then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: PR 141 - Only addes empty lines
Am 13.06.22 um 12:06 schrieb Arrigo Marchiori: On Mon, Jun 13, 2022 at 08:46:06AM +0200, Peter Kovacs wrote: see https://github.com/apache/openoffice/pull/141 I do not see any value in this Request. It does not make the code more readable, since there are already empty lines. I would like to close it with the same reason. Any insights? +1 +1 also from me. Marcus - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: PR 141 - Only addes empty lines
Hi Peter, Am 13.06.22 um 08:46 schrieb Peter Kovacs: > Hi all, > > see https://github.com/apache/openoffice/pull/141 > > > I do not see any value in this Request. It does not make the code more > readable, since there are already empty lines. > > I would like to close it with the same reason. Any insights? +1 Matthias > > > all the best > > Peter > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
Re: PR 141 - Only addes empty lines
Hello All, On Mon, Jun 13, 2022 at 08:46:06AM +0200, Peter Kovacs wrote: > Hi all, > > see https://github.com/apache/openoffice/pull/141 > > > I do not see any value in this Request. It does not make the code more > readable, since there are already empty lines. > > I would like to close it with the same reason. Any insights? +1 We have a lot of whitespace-fixing commits (thanks, Matthias!) but this is not the same. I do not think that it makes the code better adhere to our coding standards, or solves any compiler warnings. All the above is IMHO, of course. Best regards, -- Arrigo - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] cbmarcum commented on pull request #153: Fix for Issue 128375
cbmarcum commented on PR #153: URL: https://github.com/apache/openoffice/pull/153#issuecomment-1153718179 Are you sure the tilde doesn't have some significance like in hotkeys? Also, which file has this change. I see removing stax and some some build files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
PR 141 - Only addes empty lines
Hi all, see https://github.com/apache/openoffice/pull/141 I do not see any value in this Request. It does not make the code more readable, since there are already empty lines. I would like to close it with the same reason. Any insights? all the best Peter - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
