Re: [PR] misc: fix spelling [openoffice]
ardovm commented on code in PR #184: URL: https://github.com/apache/openoffice/pull/184#discussion_r1395766868 ## main/offapi/com/sun/star/awt/XListBox.idl: ## Review Comment: Being it a long standing API, IMHO we should be very very motivated in order to change it. I agree that duplicating it is a feasible way to go, for the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] misc: fix spelling [openoffice]
Pilot-Pirx commented on code in PR #184: URL: https://github.com/apache/openoffice/pull/184#discussion_r1395752148 ## main/offapi/com/sun/star/awt/XListBox.idl: ## Review Comment: https://www.openoffice.org/api/docs/common/ref/com/sun/star/awt/XListBox.html#isMutipleMode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] misc: fix spelling [openoffice]
Pilot-Pirx commented on code in PR #184: URL: https://github.com/apache/openoffice/pull/184#discussion_r1395640262 ## main/offapi/com/sun/star/awt/XListBox.idl: ## Review Comment: This is a historical typo in our API. I think we would need to address both versions and set the wrong one to "deprecated". @ardovm What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] misc: fix spelling [openoffice]
Pilot-Pirx commented on code in PR #184: URL: https://github.com/apache/openoffice/pull/184#discussion_r1395640262 ## main/offapi/com/sun/star/awt/XListBox.idl: ## Review Comment: This is a historical typo in our API. I think we would need to address both versions and set the wrong one to "deprecated". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org