Re: AOO 4.2.0-Dev5 ?
Am 24.01.24 um 13:05 schrieb Jim Jagielski: Are we ready for a Dev5 in any case? I am ready as soon as we decide on a Git hash to build. On Jan 15, 2024, at 10:02 AM, Matthias Seidel wrote: Am 10.01.24 um 19:14 schrieb Matthias Seidel: Am 10.01.24 um 15:01 schrieb Jim Jagielski: Lets fold this in and build -Dev5 after it's committed Committed it, didn't build on Linux Buildbot, reverted it. I am out! If someone else is interested, please take over. Matthias +1 On Jan 9, 2024, at 6:18 AM, Matthias Seidel wrote: Hi Pedro, Am 09.01.24 um 12:08 schrieb Pedro Lino: Hi Matthias, all On 01/09/2024 10:37 AM WET Matthias Seidel wrote: Unless someone else volunteers, I can do the Windows builds. Please do ;) Something we want to integrate? How about this PR: https://github.com/apache/openoffice/pull/194 Is this a Linux fix only? What does boost do? Improve calculation speed? I already did a build for Windows, boost is part of our build system. We need to check for macOS/Linux now. In any case, +1 to updating libraries That is the intention. Regards, Matthias Best, Pedro Am 08.01.24 um 14:06 schrieb Jim Jagielski: I'm up for doing the dev tarballs for Linux and macOS On Jan 7, 2024, at 5:55 PM, Keith N. McKenna wrote: Matthias Seidel wrote: Hi All, and a happy new year! After successfully releasing AOO 4.1.15 in December we should now work towards a renewed Developer Edition 5 for AOO 4.2.0. I am still in the massive process to clean up our Help files, so the whole translation process may be postponed to Dev 6. Opinions? Regards, Matthias I think concentrating on a dev 5 would be a very good thing. We need to see movement on 4.2.0. Regards Keith - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org smime.p7s Description: Kryptografische S/MIME-Signatur
Re: AOO 4.2.0-Dev5 ?
Are we ready for a Dev5 in any case? > On Jan 15, 2024, at 10:02 AM, Matthias Seidel > wrote: > > Am 10.01.24 um 19:14 schrieb Matthias Seidel: >> Am 10.01.24 um 15:01 schrieb Jim Jagielski: >>> Lets fold this in and build -Dev5 after it's committed > > Committed it, didn't build on Linux Buildbot, reverted it. > > I am out! If someone else is interested, please take over. > > Matthias > >> +1 >>> On Jan 9, 2024, at 6:18 AM, Matthias Seidel wrote: Hi Pedro, Am 09.01.24 um 12:08 schrieb Pedro Lino: > Hi Matthias, all > >> On 01/09/2024 10:37 AM WET Matthias Seidel >> wrote: >> Unless someone else volunteers, I can do the Windows builds. > Please do ;) > >> Something we want to integrate? >> >> How about this PR: >> >> https://github.com/apache/openoffice/pull/194 > Is this a Linux fix only? What does boost do? Improve calculation speed? I already did a build for Windows, boost is part of our build system. We need to check for macOS/Linux now. > In any case, +1 to updating libraries That is the intention. Regards, Matthias > Best, > Pedro > >> Am 08.01.24 um 14:06 schrieb Jim Jagielski: >>> I'm up for doing the dev tarballs for Linux and macOS >>> On Jan 7, 2024, at 5:55 PM, Keith N. McKenna wrote: Matthias Seidel wrote: > Hi All, > and a happy new year! > After successfully releasing AOO 4.1.15 in December we should now > work towards a renewed Developer Edition 5 for AOO 4.2.0. > I am still in the massive process to clean up our Help files, so the > whole translation process may be postponed to Dev 6. > Opinions? > Regards, > Matthias I think concentrating on a dev 5 would be a very good thing. We need to see movement on 4.2.0. Regards Keith - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org >>> - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
oooforum commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1464537713
##
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController(
Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) )
nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
I don't know because I have no idea what maSlideVisible.size is supposed to
return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
