Re: WaE: STR_EXAMPLE redefined
On Nov 26, 2013, at 11:16 AM, Pavel Janík wrote: STR_EXAMPLE is redefined in cui: source/tabpages/connect.hrc:#define STR_EXAMPLE 1 source/tabpages/paragrph.hrc:#define STR_EXAMPLE 5010 It comes from accessibility improvements. Can I delete the define to 1? Who cares? ;-) -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: define ACCESSIBLE_LAYOUT?
On Nov 27, 2013, at 12:19 PM, Pavel Janík wrote: where is this defined? Occurences: sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/ui/docvw/edtwin.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/ui/uiview/pview.cxx:#ifdef ACCESSIBLE_LAYOUT It is not defined in the source and thus is a source of compiler warnings about unused function arguments at the places mentined above. I plan to delete this... -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: define ACCESSIBLE_LAYOUT?
Hi Andre,
On Nov 29, 2013, at 12:03 PM, Andre Fischer wrote:
On 29.11.2013 10:34, Pavel Janík wrote:
On Nov 27, 2013, at 12:19 PM, Pavel Janík wrote:
where is this defined?
Occurences:
sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT
sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT
sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT
sw/source/ui/docvw/edtwin.cxx:#ifdef ACCESSIBLE_LAYOUT
sw/source/ui/uiview/pview.cxx:#ifdef ACCESSIBLE_LAYOUT
It is not defined in the source and thus is a source of compiler warnings
about unused function arguments at the places mentined above.
I am confused. The lines above test whether ACCESSIBLE_LAYOUT has been
defined. Why would that lead to a warning if the definition does not exist.
This pattern is used in many places in our source code. One usage, that
might apply in this case, is to temporarily activate a debug feature by
passing additional arguments to the compiler via environment variables. In
my opinion that is a valid use of otherwise never defined variables.
the code looks like this:
void SwCrsrShell::FirePageChangeEvent(sal_uInt16 nOldPage, sal_uInt16 nNewPage)
{
#ifdef ACCESSIBLE_LAYOUT
if( Imp()-IsAccessible() )
Imp()-FirePageChangeEvent( nOldPage, nNewPage );
#endif
}
ACCESSIBLE_LAYOUT is not defined. Thus compiler has:
void SwCrsrShell::FirePageChangeEvent(sal_uInt16 nOldPage, sal_uInt16 nNewPage)
{
}
and thus warns about not used arguments nOldPage, nNewPage.
This warning is minor warning, the real question is why we have #ifdef'ed code
on something that is never ever mentioned/defined elsewhere...
--
Pavel Janík
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: STR_EXAMPLE redefined
source/tabpages/connect.hrc:#define STR_EXAMPLE 1
source/tabpages/paragrph.hrc:#define STR_EXAMPLE 5010
It comes from accessibility improvements. Can I delete the define to 1?
The defines look like made for strings used in dialogs. The values would be
local to the dialog. Redefinition to 1 might lead to collision with another
string that is already defined to 1.
That said, STR_EXAMPLE may have been used for debugging and not be used
anymore.
Therefore, without knowing more, I would not change the value and live with
the warning. But it would be better if STR_EXAMPLE is still used and delete
it otherwise.
The normal use is in cui/source/tabpages/* except connect* files.
Accessibility changes brought this:
source/tabpages/connect.cxx:
aCtlPreview.SetAccessibleName(String(CUI_RES(STR_EXAMPLE)));
source/tabpages/connect.hrc:#define STR_EXAMPLE 1
The string is defined in paragraph*:
Pavel-Janiks-MacBook-Pro:tabpages pavel$ grep -r STR_EXAMPLE paragrph.*rc -A2
paragrph.hrc:#define STR_EXAMPLE
5010
paragrph.hrc-#define STR_PAGE_STYLE 5011
paragrph.hrc-#endif
--
paragrph.src:String STR_EXAMPLE
paragrph.src-{
paragrph.src- Text [ en-US ] = Example ;
Pavel-Janiks-MacBook-Pro:tabpages pavel$
I think that aCtlPreview.SetAccessibleName with redefined STR_EXAMPLE can't
work properly...
--
Pavel Janík
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
define ACCESSIBLE_LAYOUT?
Hi, where is this defined? Occurences: sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/core/crsr/crsrsh.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/ui/docvw/edtwin.cxx:#ifdef ACCESSIBLE_LAYOUT sw/source/ui/uiview/pview.cxx:#ifdef ACCESSIBLE_LAYOUT -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
WaE on trunk: svx/source/accessibility/charmapacc.cxx
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/accessibility/charmapacc.cxx:746: warning: comparison is always false due to limited range of data type sal_Unicode c_Shifted = c; ... if(c_Shifted0x) tmp_len = 8; -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
WaE: STR_EXAMPLE redefined
Hi, STR_EXAMPLE is redefined in cui: source/tabpages/connect.hrc:#define STR_EXAMPLE 1 source/tabpages/paragrph.hrc:#define STR_EXAMPLE 5010 -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: trunk: error: STR_STYLE_ELEMTLIST redefined
To clarify main/sfx2/source/dialog/dialog.hrc seems to be the right one because it was intentionally moved there (from [2] to [3]) in the resource error fix by Matthias. [2] http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sfx2/source/dialog/templdlg.hrc?r1=1172343r2=1172342pathrev=1172343 [3] http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sfx2/source/dialog/dialog.hrc?r1=1172343r2=1172342pathrev=1172343 OK, I fixed it again along this line. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
trunk build failure: ld: library not found for -lc++ in comphelper
Hi,
current trunk on unxmacxi:
Pavel-Janiks-MacBook-Pro:comphelper pavel$ make
[ build LNK ] Library/libcomphelpgcc3.dylib
R=/Users/pavel/BUILD/BuildDir S=$R/ooo_trunk_src
O=$S/solver/410/unxmacxi.pro W=$O/workdir mkdir -p
$W/LinkTarget/Library/ DYLIB_FILE=`/usr/bin/mktemp -t gbuild.`
/usr/bin/perl $S/solenv/bin/macosx-dylib-link-list.pl -dynamiclib
-single_module -install_name
'@__OOO/libcomphelpgcc3.dylib'
-Wl,-syslibroot,/Developer/SDKs/MacOSX10.5.sdk -L$O/lib -L/usr/lib -luno_sal
-luno_cppuhelpergcc3 -luno_cppu -lucbhelper4gcc3 -lvos3gcc3 -lc++
${DYLIB_FILE} ccache /usr/bin/g++-4.0 -dynamiclib -single_module
-install_name
'@__OOO/libcomphelpgcc3.dylib'
-Wl,-syslibroot,/Developer/SDKs/MacOSX10.5.sdk -L$O/lib -L/usr/lib -luno_sal
-luno_cppuhelpergcc3 -luno_cppu -lucbhelper4gcc3 -lvos3gcc3 -lc++
$W/CxxObject/comphelper/source/compare/AnyCompareFactory.o
$W/CxxObject/comphelper/source/container/IndexedPropertyValuesContainer.o
$W/CxxObject/comphelper/source/container/NamedPropertyValuesContainer.o ...
$W/CxxObject/comphelper/source/xml/attributelist.o
$W/CxxObject/comphelper/source/xml/ofopxmlhelper.o-o
$W/LinkTarget/Library/libcomphelpgcc3.dylib `cat ${DYLIB_FILE}`
/usr/bin/perl $S/solenv/bin/macosx-change-install-names.pl Library OOO
$W/LinkTarget/Library/libcomphelpgcc3.dylib ln -sf
$W/LinkTarget/Library/libcomphelpgcc3.dylib
$W/LinkTarget/Library/libcomphelpgcc3.jnilib rm -f ${DYLIB_FILE}
ld: library not found for -lc++
collect2: ld returned 1 exit status
make: ***
[/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/410/unxmacxi.pro/workdir/LinkTarget/Library/libcomphelpgcc3.dylib]
Error 1
Pavel-Janiks-MacBook-Pro:comphelper pavel$
--
Pavel Janík
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Mails from iss...@openoffice.apache.org
Hi, On Sep 12, 2013, at 6:30 PM, Mechtilde wrote: What happens? I get nearly 6500 mails today with date 07.08.2013. My mail provider ask me, if all things are right ;-) looks like Rob Weir (or someone who hacked his account) is removing target milestones from *old* issues... -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Coverage of 4.0 Release
Rob, On Jul 25, 2013, at 3:21 PM, Rob Weir wrote: This is the advantage of writing innovative code, not just copying it. can you please stop writing such stupid sentences? Notice that I do not talk at all about the particular license issue. A few people in other project do the same stuff as you do and maybe you can fight with them in some mud, but why mud-spraying all the people in this mailing list? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
basic/source/runtime/runtime.cxx: error: operation on 'pCollection' may be undefined
Hi, anyone seeing this problem when compiling basic/source/runtime/runtime.cxx (https://issues.apache.org/ooo/show_bug.cgi?id=117703)? I still have this patch in my local tree, but no longer need it. But the bug is still not fixed in the current trunk. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: error in svx/source/svdraw/svdmrkv
The method calculateCropScaling was introduced for fixing bug 74211, 2013-05-17, with r1483903. Therefore it is likely, that your local source does not reflect current trunk or that you have remainders from previous builds which do not know this new method. Please try rebase, clean output-tree and build again. Bad SVN Root. Incubator, ie. old one. Shouldn't we somehow delete incubator SVN tree? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: trunk: TOOLBOX_ITEM_HEIGHT redefined
Hi Andre, This should make a difference because in sfx2/sidebar/ResourceDefinitions.hrcTOOLBOX_ITEM_HEIGHT is defined to be 15, not 12. But I tried both versions and can not see a difference. But still #undefTOOLBOX_ITEM_HEIGHT #define TOOLBOX_ITEM_HEIGHT 12 might be safer. This only hides the problem and makes the code looking strange. What about using different name/prefix or something other? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: trunk: TOOLBOX_ITEM_HEIGHT redefined
On May 17, 2013, at 9:49 AM, Andre Fischer wrote: On 17.05.2013 09:44, Pavel Janík wrote: Hi Andre, This should make a difference because in sfx2/sidebar/ResourceDefinitions.hrcTOOLBOX_ITEM_HEIGHT is defined to be 15, not 12. But I tried both versions and can not see a difference. But still #undef TOOLBOX_ITEM_HEIGHT #define TOOLBOX_ITEM_HEIGHT 12 might be safer. This only hides the problem and makes the code looking strange. What about using different name/prefix or something other? I would prefer the 'something other' option: refactor the definition of positions of the number format panel. But I don't have the time for it right now. Well, yes. But... This constant is used in three files in sidebar directory: source/ui/sidebar/AlignmentPropertyPanel.hrc:#define FT_LEFTINDENT_Y (ALIGNMENT_Y + TOOLBOX_ITEM_HEIGHT + TBX_OUT_BORDER_OFFSET_Y + CONTROL_SPACING_VERTICAL) source/ui/sidebar/AlignmentPropertyPanel.src: Size = MAP_APPFONT ( TOOLBOX_ITEM_WIDTH * 3 , TOOLBOX_ITEM_HEIGHT) ; source/ui/sidebar/NumberFormatPropertyPanel.hrc:#define TOOLBOX_ITEM_HEIGHT 12 source/ui/sidebar/NumberFormatPropertyPanel.hrc:#define FT_DECIMALS_Y TBX_CATEGORY_Y + TOOLBOX_ITEM_HEIGHT + 4 + CONTROL_SPACING_VERTICAL In the first case, it's value is 15, in the second case it is 12. This will lead to some error in the near future... So is this the right solution? sed -i 's#TOOLBOX_ITEM_HEIGHT#LOCAL_TOOLBOX_ITEM_HEIGHT#' source/ui/sidebar/NumberFormatPropertyPanel.hrc -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: svn commit: r1482736 - /openoffice/trunk/main/sal/inc/rtl/string.hxx
-n += 4*n + *(p++); +n += 4*n + *static_castunsigned char*(p++); This breaks on Linux: Compiling: sal/osl/unx/file.cxx In file included from ../../inc/rtl/ustring.hxx:33:0, from ../../inc/osl/file.hxx:33, from sal/osl/unx/file.cxx:27: ../../inc/rtl/string.hxx: In member function 'size_t rtl::CStringHash::operator()(const char*) const': ../../inc/rtl/string.hxx:950:47: error: invalid static_cast from type 'const char*' to type 'unsigned char*' dmake: Error code 1, while making '../../unxlngx6/obj/file.obj' ERROR: error 65280 occurred while making sal/osl/unx The same with gcc version 4.0.1 (Apple Inc. build 5494). -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: trunk: TOOLBOX_ITEM_HEIGHT redefined
On Apr 11, 2013, at 7:58 AM, Pavel Janík wrote: current trunk: Compiling: sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx:28: ./NumberFormatPropertyPanel.hrc:45:1: error: TOOLBOX_ITEM_HEIGHT redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx:24: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/sidebar/propertypanel.hrc:94:1: error: this is the location of the previous definition dmake: Error code 1, while making '../../../unxmacxi.pro/slo/NumberFormatPropertyPanel.obj' ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar This is still the case in the current tree. As a workaround, I have this in my tree. Is this constant the same as in sfx2? Should it be the same value? Index: source/ui/sidebar/NumberFormatPropertyPanel.hrc === --- source/ui/sidebar/NumberFormatPropertyPanel.hrc (revision 1483653) +++ source/ui/sidebar/NumberFormatPropertyPanel.hrc (working copy) @@ -37,7 +37,7 @@ //===position= #define MBOX_WIDTH 28 -#defineTOOLBOX_ITEM_HEIGHT 12 +// #define TOOLBOX_ITEM_HEIGHT 12 #define CHECKBOX_HEIGHT10 #define FT_CATEGORY_X SECTIONPAGE_MARGIN_HORIZONTAL -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
On Apr 19, 2013, at 11:02 AM, Pavel Janík wrote: On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. I do not know, the compiler should know better ;-) solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE = SAL_MAX_ENUM I added missing cases to the code today. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [BUILD] Build breaks in sfx2 with IContextChangeReceiver.cxx
Hi Regina, On May 10, 2013, at 4:17 PM, Regina Henschel wrote: I'm try to build r1480942 and get the following error: C:/AOO_2013_05_10/trunk/main/solenv/gbuild/LinkTarget.mk:163: *** Unable to find generated C++ file /cygdrive/c/AOO_2013_05_10/trunk/main/solver/400/wntmsci12/workdir/sfx2/source/sidebar/IContextChangeReceiver.cxx in WORKDIR.. Stop. try this: diff -ur sfx2.orig/Library_sfx.mk sfx2/Library_sfx.mk --- sfx2.orig/Library_sfx.mk2013-05-10 20:24:44.0 +0200 +++ sfx2/Library_sfx.mk 2013-05-10 20:27:03.0 +0200 @@ -234,8 +234,6 @@ sfx2/source/sidebar/EnumContext \ sfx2/source/sidebar/FocusManager \ sfx2/source/sidebar/MenuButton \ - sfx2/source/sidebar/IContextChangeReceiver \ - sfx2/source/sidebar/ILayoutableWindow \ sfx2/source/sidebar/Paint \ sfx2/source/sidebar/Panel \ sfx2/source/sidebar/PanelDescriptor \ -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [BUILD] Build breaks in sfx2 with IContextChangeReceiver.cxx
On May 10, 2013, at 4:17 PM, Regina Henschel wrote: I'm try to build r1480942 and get the following error: C:/AOO_2013_05_10/trunk/main/solenv/gbuild/LinkTarget.mk:163: *** Unable to find generated C++ file /cygdrive/c/AOO_2013_05_10/trunk/main/solver/400/wntmsci12/workdir/sfx2/source/sidebar/IContextChangeReceiver.cxx in WORKDIR.. Stop. No, the diff doesn't help. the files are missing. Trunk is unbuildable now. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: A2S redefined
On May 3, 2013, at 8:42 PM, Pavel Janík wrote: Hi, curent trunk: [ build CXX ] svx/source/sidebar/insert/InsertPropertyPanel /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/sidebar/insert/InsertPropertyPanel.cxx:49:1: error: A2S redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/sidebar/insert/InsertPropertyPanel.cxx:30: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/sidebar/Tools.hxx:37:1: error: this is the location of the previous definition make: *** [/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/workdir/CxxObject/svx/source/sidebar/insert/InsertPropertyPanel.o] Error 1 dmake: Error code 2, while making 'all' This looks very ugly... Pavel-Janiks-MacBook-Pro:svx pavel$ grep -r A2S * | grep define | grep -v svn/te source/sidebar/PanelFactory.cxx:#define A2S(s) ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(s)) source/sidebar/area/AreaPropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/graphic/GraphicPropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/insert/InsertPropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/line/LinePropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/paragraph/ParaPropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/possize/PosSizePropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) source/sidebar/text/TextPropertyPanel.cxx:#define A2S(pString) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(pString))) Pavel-Janiks-MacBook-Pro:svx pavel$ -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
A2S redefined
Hi, curent trunk: [ build CXX ] svx/source/sidebar/insert/InsertPropertyPanel /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/sidebar/insert/InsertPropertyPanel.cxx:49:1: error: A2S redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/sidebar/insert/InsertPropertyPanel.cxx:30: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/sidebar/Tools.hxx:37:1: error: this is the location of the previous definition make: *** [/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/workdir/CxxObject/svx/source/sidebar/insert/InsertPropertyPanel.o] Error 1 dmake: Error code 2, while making 'all' -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Macro security?
Hi, does the button Zabezpeceni maker... in the lower right part of this dialog work for you in the current trunk build? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: sd/source/ui/unoidl/DrawController.cxx:575:'ST_SIDEBAR’ not handled in switch
On Apr 25, 2013, at 10:11 AM, Andre Fischer wrote: On 24.04.2013 22:05, Pavel Janík wrote: Hi, WaE issue. Please add default branch or handle ST_SIDEBAR. Compiling: sd/source/ui/unoidl/DrawController.cxx cc1plus: warnings being treated as errors /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sd/source/ui/unoidl/DrawController.cxx: In member function ‘void sd::DrawController::BroadcastContextChange() const’: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sd/source/ui/unoidl/DrawController.cxx:575: warning: enumeration value ‘ST_SIDEBAR’ not handled in switch dmake: Error code 1, while making '../../../unxmacxi.pro/slo/DrawController.obj' Done in revision 1475665. Verified, thanks :-) -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
sd/source/ui/unoidl/DrawController.cxx:575:'ST_SIDEBAR’ not handled in switch
Hi, WaE issue. Please add default branch or handle ST_SIDEBAR. Compiling: sd/source/ui/unoidl/DrawController.cxx cc1plus: warnings being treated as errors /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sd/source/ui/unoidl/DrawController.cxx: In member function ‘void sd::DrawController::BroadcastContextChange() const’: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sd/source/ui/unoidl/DrawController.cxx:575: warning: enumeration value ‘ST_SIDEBAR’ not handled in switch dmake: Error code 1, while making '../../../unxmacxi.pro/slo/DrawController.obj' -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [CODE]: obsolete binfilter module deleted
Hi, On Apr 20, 2013, at 11:50 PM, Juergen Schmidt wrote: yes open an issue for this. I have just removed the module. This wizard wouldn't have worked before my removal anyway ;-) but of course this should be fixed... yup. Strange it was there even with --without-binfilter before. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
Who is the author of this code? Is it right to not handle the value in these switches? On Apr 10, 2013, at 10:19 PM, Pavel Janík wrote: Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: WaE: LineJoint_MAKE_FIXED_SIZE
On Apr 19, 2013, at 10:51 AM, Armin Le Grand wrote: I am confused; where does com::sun::star::drawing::LineJoint_MAKE_FIXED_SIZE come from? When you look at he UNO API file (trunk\main\offapi\com\sun\star\drawing\LineJoint.idl) there is no such definition. Since the headers are generated from the UNO API files I would wonder if we have such a token at all. I do not know, the compiler should know better ;-) solver/400/unxmacxi.pro/inc/offuh/com/sun/star/drawing/LineJoint.hdl: LineJoint_MAKE_FIXED_SIZE = SAL_MAX_ENUM -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [Error] Compile AOO on Debian amd64
On Apr 18, 2013, at 9:41 PM, Albino B Neto wrote: 2013/4/18 Pavel Janík pa...@janik.cz: Paste more so we see the actual error and not the message that there is an error in instsetoo_native ;-) Sorry :-P Look: http://pastebin.com/2NNAcKwt https://issues.apache.org/ooo/show_bug.cgi?id=121469 -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [Error] Compile AOO on Debian amd64
On Apr 17, 2013, at 9:19 PM, Albino B Neto wrote: == ERROR: error 65280 occurred while making /home/albino/projetos/aoo/source/main/sw/prj When you have fixed the errors in that module you can resume the build by running: build --all:sw == I can't find solution. We can't help you, you have to show us the actual error. Show us cd sw build and copy the error... -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [Error] Compile AOO on Debian amd64
On Apr 17, 2013, at 9:26 PM, Albino B Neto wrote: 2013/4/17 Pavel Janík pa...@janik.cz: cd sw build Look [1]. /home/albino/projetos/aoo/source/main/solver/400/unxlngx6.pro/workdir/SdiTarget/sw/sdi/swslots.hxx:9874:5: error: 'FN_PROPERTY_WRAP_DLG' was not declared in this scope This is not your fault. Start again from scratch... It was deleted today. Start with the clean checkout and do clean build. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: svn commit: r1468340 - in /openoffice/trunk/main: cui/source/inc/ cui/source/tabpages/ sd/source/ui/app/ sd/source/ui/slideshow/ sd/source/ui/view/ svx/ svx/inc/svx/ svx/inc/svx/sidebar/ svx/sourc
Hi, On Apr 16, 2013, at 11:41 AM, a...@apache.org wrote: Author: alg Date: Tue Apr 16 09:41:07 2013 New Revision: 1468340 URL: http://svn.apache.org/r1468340 Log: i122041 Unified and centralized control for Color ValueSets -#include svtools/valueset.hxx +#include svx/SvxColorValueSet.hxx there is no such file on trunk. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: trunk: TOOLBOX_ITEM_HEIGHT redefined
did you made a clean build? Ok you compile with warning as errors but this is no warning. I am surprised because I have built over night trunk on my Mac and everything was fine. I always do clean builds and WaE. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [CODE]: 3layer drop, looking for volunteers who are interested to play with my test builds
Jürgen, On Apr 11, 2013, at 6:15 PM, Jürgen Schmidt wrote: MacOS users can try it out now with the merged sidebar. 3layer fee sidebar office ;-) I have tried to put the patch over my finished trunk build (modulo binfilter directory, I do not have it in my local tree), dmake clean and build again. DMG, copy to Desktop, works. Even with sidebar. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Sidebar merged into trunk
Another questionable: [ build CXX ] svx/source/tbxctrls/tbcontrl In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/tbxctrls/tbcontrl.cxx:89: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/editeng/editrids.hrc:322:1: error: RID_SVXITEMS_COLOR_WHITE redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/source/tbxctrls/tbcontrl.cxx:69: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/svx/inc/svx/svxitems.hrc:74:1: error: this is the location of the previous definition make: *** [/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o] Error 1 What should be renamed? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
WaE: LineJoint_MAKE_FIXED_SIZE
Hi, please have a look at this change: http://tmp.janik.cz/AO/WaE-cui+svx-LineJoint_MAKE_FIXED_SIZE.diff LineJoint_MAKE_FIXED_SIZE is not handled in two switch commands. It is OK? Please add proper handling or default case or whatever suits you. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
trunk: TOOLBOX_ITEM_HEIGHT redefined
Hi, current trunk: Compiling: sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx:28: ./NumberFormatPropertyPanel.hrc:45:1: error: TOOLBOX_ITEM_HEIGHT redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx:24: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/sidebar/propertypanel.hrc:94:1: error: this is the location of the previous definition dmake: Error code 1, while making '../../../unxmacxi.pro/slo/NumberFormatPropertyPanel.obj' ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/ui/sidebar -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Binfilter removal - PATCH
Excellent! What should we put in the Release Notes for this? We are started to collect the info here: Changes that Impact Backwards Compatibility Module binfilter removed - we do no longer support old fileformats from StarOffice. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Working with nightly builds parallel to standard releases
On Apr 3, 2013, at 4:59 PM, Alexandro Colorado wrote: BTW trying to untar it, it spew some error: tar -xzvf Apache_OpenOffice_4.0.0_Linux_x86_install-rpm_en-US.tar.gz_2013-03-12_04\:29\:29_1455404.tar.gz tar (child): Cannot connect to Looks like it thinks it is a hostname. Use tar ...Apache...gz instead. -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Binfilter removal - PATCH
On Apr 3, 2013, at 4:04 PM, Jürgen Schmidt wrote: On 4/3/13 10:45 AM, janI wrote: On 3 April 2013 10:22, Pavel Janík pa...@janik.cz wrote: Hi, http://tmp.janik.cz/AO/binfilter-removal.diff This is the first attempt to remove module binfilter. To add more to this, we should remove directories binfilter and scp2/source/binfilter. +1 to remove directories, +1 for removal of binfilter Anyone against the lazy approach - ie. doing this on trunk directly? This could make testing much easier... -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: svn commit: r1451887 - /openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml
Hi, this breaks the build: Warning: Time100SecSeparator is different from DecimalSeparator, this may be correct or not. Intended? Warning: Don't forget to adapt corresponding FormatCode elements when changing separators. Error: Ordering of ThousandSeparator and DecimalSeparator not correct in formatindex=4. Warning: formatindex=4,44,45 are the only FormatCode elements checked for separator usage, there may be others that have errors. Error: in data for es_PE: 1 parsing document es_PE finished dmake: Error code 1, while making '../../../unxmacxi.pro/misc/localedata_es_PE.cxx' ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/i18npool/source/localedata/data On Mar 2, 2013, at 2:40 PM, j...@apache.org wrote: Author: jza Date: Sat Mar 2 13:40:33 2013 New Revision: 1451887 URL: http://svn.apache.org/r1451887 Log: new xml Modified: openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml Modified: openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml URL: http://svn.apache.org/viewvc/openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml?rev=1451887r1=1451886r2=1451887view=diff == --- openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml (original) +++ openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml Sat Mar 2 13:40:33 2013 @@ -37,8 +37,8 @@ LC_CTYPE unoid=generic Separators DateSeparator//DateSeparator -ThousandSeparator./ThousandSeparator -DecimalSeparator,/DecimalSeparator +ThousandSeparator,/ThousandSeparator +DecimalSeparator./DecimalSeparator TimeSeparator:/TimeSeparator Time100SecSeparator,/Time100SecSeparator ListSeparator;/ListSeparator -- Pavel Janík
Re: svn commit: r1451887 - /openoffice/trunk/main/i18npool/source/localedata/data/es_PE.xml
+ThousandSeparator,/ThousandSeparator +DecimalSeparator./DecimalSeparator Is there a bug number for this commit? Found bug 121825 Should be fixed with revision 1452033 and verified it builds now. Thanks! -- Pavel Janík
Re: error: BOOST_MATH_OVERFLOW_ERROR_POLICY redefined
Hi, On Feb 20, 2013, at 3:50 AM, Pedro Giffuni wrote: It is a bit strange that you seem to be the only one that reports this error after all this time: I wonder if you are using something different than the internal boost (which is already outdated), or if this is just a WaE. I use internal boost. I was not building for a few weeks... Yes, it is WaE. In any case, try this: http://people.apache.org/~pfg/patches/patch-boost-math-error-policy I'd prefer #ifndef there instead of FreeBSD case... How is this connected to freebsd? -- Pavel Janík
error: BOOST_MATH_OVERFLOW_ERROR_POLICY redefined
Mac OS X/trunk: Compiling: sc/source/core/data/cell.cxx In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/core/data/cell.cxx:33: ../inc/interpre.hxx:47:1: error: BOOST_MATH_OVERFLOW_ERROR_POLICY redefined In file included from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/boost/math/tools/precision.hpp:19, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/boost/math/special_functions/sinc.hpp:19, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/vcl/bitmap.hxx:37, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/vcl/bitmapex.hxx:28, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/vcl/image.hxx:31, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/vcl/button.hxx:29, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/tabdlg.hxx:30, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/sfx2/module.hxx:54, from ../../../inc/scdll.hxx:35, from ../inc/interpre.hxx:29, from /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/core/data/cell.cxx:33: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/400/unxmacxi.pro/inc/boost/math/policies/policy.hpp:54:1: error: this is the location of the previous definition dmake: Error code 1, while making '../../../unxmacxi.pro/slo/cell.obj' ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/core/data -- Pavel Janík
Re: New member's introduction - Tomas Zahradnik
Hi Tomáš, On Feb 14, 2013, at 11:06 PM, Tomáš Zahradník wrote: I am a high school (gymnasial) student in 12th grade from Czech Republic, Prague. should you need any help in the project/with AOO, just ask. and Java. I have just finished an engine for a card game called Raining (variety of mau-mau) and going to post it as open source with hope of finding someone who would help with UI (plus I created four different strategies how to play the game, run simulation and did statistics). Good. I prefer mariáš though ;-) -- Pavel Janík
Re: Proposal: How we should handle committer vetos and reverts in the future
On Feb 15, 2013, at 8:43 PM, Dave Fisher wrote: Please review the following: http://openoffice.apache.org/list-conduct.html +1 Please let's stop the thread. -- Pavel Janík
Re: Apache OpenOffice in Fedora 19?
In my opinion the problem is not only the problem with the trade mark (or the simple program-name) but also a public relations problem. I do not know the team of Feodora, but I know many people of LO / TDF and, let me be clear, _some_ (_not_ all) consider it well to cultivate a public representation that users subliminally says that LO's successor OOo is . (not as an official statement, but subliminally) Is it LO who is infringing on our trademark or is it Fedora who is misusing our trademark for other project? Shouldn't we notify Fedora people politely about this situation and let them (and help them!) solve the issue first? -- Pavel Janík
trunk/AOO341: how is --disable-category-b --enable-hunspell supposed to work?
Hi, configure --help says: --enable-category-b Activate components under a category B license (see http://www.apache.org/legal/3party.html#category-b): MPL (seamonkey, hunspell, hyphen, nss, saxon, rhino), CPL (silgraphite), CPL/EPL (CoinMP), SPL (beanshell), OFL (fonts). Flags for individual libraries override this one. How is this overriding supposed to work? First configure check --enable-category-b and RESETS the enable_hunspell on both yes and no in enable-category-b. This way, the code later on doesn't know what user entered on the command line: if test $enable_category_b = yes; then ENABLE_CATEGORY_B=YES enable_hunspell=yes enable_hyphen=yes enable_saxon=yes enable_javascript=yes enable_beanshell=yes enable_graphite=yes enable_coinmp=yes enable_category_b_fonts=yes AC_MSG_RESULT([yes: allow modules moz, nss, hunspell, hyphen, saxon, rhino, beanshell, graphite, coinmp to be built]) else # Disable libaries. enable_mozilla=no enable_nss_module=no enable_hunspell=no enable_hyphen=no enable_saxon=no enable_javascript=no enable_beanshell=no enable_graphite=no enable_coinmp=no enable_category_b_fonts=no AC_MSG_RESULT([no: disabled modules moz, nss, hunspell, hyphen, saxon, rhino, beanshell, graphite, coinmp]) fi -- Pavel Janík
Re: trunk/AOO341: how is --disable-category-b --enable-hunspell supposed to work?
On Jan 26, 2013, at 11:20 AM, Pavel Janík wrote: --enable-category-b Activate components under a category B license (see http://www.apache.org/legal/3party.html#category-b): MPL (seamonkey, hunspell, hyphen, nss, saxon, rhino), CPL (silgraphite), CPL/EPL (CoinMP), SPL (beanshell), OFL (fonts). Flags for individual libraries override this one. How is this overriding supposed to work? And to add even more, external_deps.lst contains: if (ENABLE_CATEGORY_B==YES ENABLE_HUNSPELL==YES) name = hunspell-1.3.2.tar.gz MD5 = 3121aaf3e13e5d88dfff13fb4a5f1ab8 URL1 = http://sourceforge.net/projects/hunspell/files/Hunspell/1.3.2/hunspell-1.3.2.tar.gz/download URL2 = $(OOO_EXTRAS)$(MD5)-$(name) URL3 = $(SVN_TRUNK)$(MD5)-$(name) Ie. it EXPECTS category B enabled anyway. So it is not possible at all to use --disable-category-b --enable-hunspell to get only hunspell. -- Pavel Janík
tag AOO341 and serf - 1.1.0 or 1.0.0
Hi, I'm trying to build current tag AOO341 (https://svn.apache.org/repos/asf/openoffice/tags/AOO341/ext_sources/). serf 1.1.0 is in external_deps.lst: p-00:/posta/build/BuildDir/ooo_AOO341_src # grep serf external_deps.lst name = serf-1.1.0.tar.bz2 URL1 = http://serf.googlecode.com/files/serf-1.1.0.tar.bz2 and it is really downloaded. BUT serf-1.0.0 is expected: p-00:/posta/build/BuildDir/ooo_AOO341_src # cat ../ext_libraries/serf/serf_version.mk ... SERF_MAJOR=1 SERF_MINOR=0 SERF_MICRO=0 p-00:/posta/build/BuildDir/ooo_AOO341_src # -- Pavel Janík
Re: tag AOO341 and serf - 1.1.0 or 1.0.0
Hi, p-00:/posta/build/BuildDir/ooo_AOO341_src # grep serf external_deps.lst name = serf-1.1.0.tar.bz2 URL1 = http://serf.googlecode.com/files/serf-1.1.0.tar.bz2 I unpacked trunk main here instead of AOO341 tag's one. Sorry for confusion. -- Pavel Janík
Re: Presenter Screen/Console?
It should be Presenter Screen. Presenter Console was an early working title. So we need something like this: Index: configure.in === --- configure.in(revision 1435113) +++ configure.in(working copy) @@ -516,8 +516,8 @@ AC_ARG_ENABLE(minimizer, [ --enable-minimizer enables the build of the Presentation Minimizer extension ],,) -AC_ARG_ENABLE(presenter-console, -[ --enable-presenter-console enables the build of the Presenter Console extension +AC_ARG_ENABLE(presenter-screen, +[ --enable-presenter-screen enables the build of the Presenter Screen extension ],,) AC_ARG_ENABLE(pdfimport, [ --enable-pdfimport enables the build of the PDF Import extension @@ -6392,7 +6392,7 @@ AC_SUBST(ENABLE_MINIMIZER) AC_MSG_CHECKING([whether to build the Presenter Screen extension]) -if test -n $enable_presenter_console -a $enable_presenter_screen != no; then +if test -n $enable_presenter_screen -a $enable_presenter_screen != no; then AC_MSG_RESULT([yes]) ENABLE_PRESENTER_SCREEN=YES else -- Pavel Janík
not using system apr, serf...
Hi, how are internal apr and apr-util and serf designed to work together? Can they work together at all? apr is producing apr-1-config in solver. serf is using apr-config... -- Pavel Janík
Re: WaE: sw/source/filter/ww8 compiler warnings
Hi!
On Dec 3, 2012, at 4:18 PM, chengjh wrote:
I committed some changes to solve the found warnings...Please help to
verify again..And I will have a check to the whole sw module to see whether
any missed warning is still existing.thanks.
thanks. The module is almost clean now.
I only see:
sw/source/filter/ww8/ww8par3.cxx:1125: warning: comparison is always true due
to limited range of data type
SwNumRule* WW8ListManager::GetNumRule(sal_uInt16 i)
{
if ( i = 0 i maLSTInfos.size() )
surely i=0 when it is unsigned.
--
Pavel Janík
WaE: sw/source/filter/ww8 compiler warnings
Hi,
current trunk issues few warnings in sw/source/filter/ww8:
cc1plus: warnings being treated as errors
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cxx: In
member function ‘SwNumRule* WW8ListManager::GetNumRule(int)’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cxx:1125:
warning: comparison between signed and unsigned integer expressions
make: ***
[/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/350/unxmacxi.pro/workdir/CxxObject/sw/source/filter/ww8/ww8par3.o]
Error 1
cc1plus: warnings being treated as errors
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx: In
member function ‘void WW8_WrtBookmarks::MoveFieldMarks(sal_uLong, sal_uLong)’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx:317:
warning: comparison between signed and unsigned integer expressions
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx: In
member function ‘int WW8Export::CollectGrfsOfBullets() const’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx:1452:
warning: comparison between signed and unsigned integer expressions
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx: In
member function ‘int WW8Export::GetGrfIndex(const SvxBrushItem)’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx:1535:
warning: comparison between signed and unsigned integer expressions
make: ***
[/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/350/unxmacxi.pro/workdir/CxxObject/sw/source/filter/ww8/wrtww8.o]
Error 1
The following patch fixes these issues, but I'd like to see author committing
the change:
===
--- wrtww8.cxx (revision 1415339)
+++ wrtww8.cxx (working copy)
@@ -314,7 +314,7 @@
{
if (aItr-second)
{
-if (aItr-second-first == nFrom)
+if (aItr-second-first == static_castlong(nFrom))
{
aItr-second-second.first = true;
aItr-second-first = nTo;
@@ -1449,7 +1449,7 @@
if ( pGrf )
{
bool bHas = false;
- for (int i = 0; i
m_vecBulletPic.size(); ++i)
+ for (unsigned int i = 0; i
m_vecBulletPic.size(); ++i)
{
if
(m_vecBulletPic[i]-GetChecksum() == pGrf-GetChecksum())
{
@@ -1532,7 +1532,7 @@
int nIndex = -1;
if ( rBrush.GetGraphic() )
{
- for (int i = 0; i m_vecBulletPic.size(); ++i)
+ for (unsigned int i = 0; i m_vecBulletPic.size(); ++i)
{
if (m_vecBulletPic[i]-GetChecksum() ==
rBrush.GetGraphic()-GetChecksum())
{
Index: ww8par3.cxx
===
--- ww8par3.cxx (revision 1415339)
+++ ww8par3.cxx (working copy)
@@ -1122,7 +1122,7 @@
SwNumRule* WW8ListManager::GetNumRule(int i)
{
- if ( i = 0 i maLSTInfos.size() )
+ if ( i = 0 static_castsal_Size(i) maLSTInfos.size() )
return maLSTInfos[i]-pNumRule;
else
return 0;
--
Pavel Janík
DOCX: merged comments
Hi, today I was shown the problem which is described in the issue https://issues.apache.org/ooo/show_bug.cgi?id=113059 This issue is fixed in LibreOffice and thus I (after spending some hours xmllint'ing OOXML's comments.xml and debugging writerfilter) isolated and improved the fix for AOO and attached sample patch to the issue. Any volunteers to review/intergation/QA? DOCX comments need more love: no author is shown (DOCS contains initials and author's name) and the date of the change is ignored and current date is used... Any takers? -- Pavel Janík
Re: L10n tools is no longer needed.
On Nov 28, 2012, at 10:07 AM, janI wrote: It is soon Christmas so it allowed to wishmy wish this year will be that some of our funding is spent on, getting key people for LO and AOO together. Lock them up in a room with a big pizza, tell them the door will be unlocked when they have agreed on how to slice the pizza, instead of make two mini pizzas. +1 ... and beer. For some of them ;-) -- Pavel Janík
