[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)
ardovm commented on pull request #122: URL: https://github.com/apache/openoffice/pull/122#issuecomment-925836356 > Is this PR ready? Or, have the changes already been merged in a different PR? Thank you for checking this! I am still waiting for a review. I would like to have the proposed _changes_ reviewed first. Then I'd reshuffle a bit the commits before merging, so they will make more sense -- mainly squashing the WIP and typo correction commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)
ardovm commented on pull request #122: URL: https://github.com/apache/openoffice/pull/122#issuecomment-774489872 Ok, I am done. Reviews welcome! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)
ardovm commented on pull request #122: URL: https://github.com/apache/openoffice/pull/122#issuecomment-774448450 Ok, the exception details are shown in non-product builds. Product builds just show an error message "Error saving the document: write error. Error in writing sub-document content.xml". I think it is enough to warn the user that the attempt to save the document has failed. Moreover, if I try to close the document, I am warned that it has not been saved. Please note that the above was checked with a "hand-inserted" exception, as the documents attached to the reports do not seem to trigger the bug any more. The PR is IMHO production-ready, but I would like to spend some more time on documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #122: Address bug 128356 and similar ones (duplicated XML attributes)
ardovm commented on pull request #122: URL: https://github.com/apache/openoffice/pull/122#issuecomment-774024441 > Is > `if (!!bAutoStyles)` > really the best way to format that logical if for [7af97f4](https://github.com/apache/openoffice/commit/7af97f4fe332f523912f0174635fb94d88995f46) ? Not at all! It's a typo! Thank you for spotting it! I was going to test this code later, after changing the assertion into an exception. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
