Re: [OS/2 and macOS] saving ODS with chart

2021-08-05 Thread Arrigo Marchiori
Hello Jim,

On Thu, Aug 05, 2021 at 01:41:23PM -0400, Jim Jagielski wrote:

> Never mind that one: This one is the one: THX!
[...]

Compiling now.

Best regards,
-- 
Arrigo

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: LAZY CONSENSUS: change IRC links from Freenode to Libera.Chat

2021-08-05 Thread Carl Marcum

Hi Arrigo,

On 8/5/21 4:44 PM, Dave Fisher wrote:



On Aug 5, 2021, at 1:11 PM, Arrigo Marchiori  wrote:

Hello All,

following Carl's very good advice, here is my proposal:

  I will merge https://github.com/apache/openoffice-org/pull/57
  consisting of changing IRC links from Freenode into Libera Chat, if
  no one objects within August 10th.

Nicely done!


I don’t see any reason to wait. We aren’t going back to Freenode …

Make it so!


I also agree.

Best regards,
Carl


Regards,
Dave


Thank you and best regards,
--
Arrigo

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: [OS/2 and macOS] saving ODS with chart

2021-08-05 Thread Jim Jagielski
Never mind that one: This one is the one: THX!

diff --git a/main/comphelper/inc/comphelper/extract.hxx 
b/main/comphelper/inc/comphelper/extract.hxx
index dc67c5dc58..fc75fa9cb9 100644
--- a/main/comphelper/inc/comphelper/extract.hxx
+++ b/main/comphelper/inc/comphelper/extract.hxx
@@ -131,9 +131,10 @@ inline sal_Bool SAL_CALL extractInterface(
 inline sal_Bool SAL_CALL any2bool( const ::com::sun::star::uno::Any & rAny )
throw( ::com::sun::star::lang::IllegalArgumentException )
 {
-   if (rAny.getValueTypeClass() == 
::com::sun::star::uno::TypeClass_BOOLEAN)
+   sal_Bool sValue;
+   if ( rAny >>= sValue)
{
-   return *(sal_Bool *)rAny.getValue();
+   return sValue;
}
else
{
diff --git a/main/cppu/inc/com/sun/star/uno/Any.hxx 
b/main/cppu/inc/com/sun/star/uno/Any.hxx
index e1d125be82..2a38598efa 100644
--- a/main/cppu/inc/com/sun/star/uno/Any.hxx
+++ b/main/cppu/inc/com/sun/star/uno/Any.hxx
@@ -251,9 +251,9 @@ inline sal_Bool SAL_CALL operator >>= ( Any const & rAny, 
bool & value )
{
value = *reinterpret_cast< sal_Bool const * >(
  ) != sal_False;
-   return true;
+   return sal_True;
}
-   return false;
+   return sal_False;
 }
 
 
//__
diff --git a/main/starmath/source/mathmlexport.cxx 
b/main/starmath/source/mathmlexport.cxx
index 3f36ff152d..00b301d0eb 100644
--- a/main/starmath/source/mathmlexport.cxx
+++ b/main/starmath/source/mathmlexport.cxx
@@ -169,9 +169,7 @@ sal_Bool SmXMLExportWrapper::Export(SfxMedium )
 SvtSaveOptions aSaveOpt;
 OUString 
sUsePrettyPrinting(RTL_CONSTASCII_USTRINGPARAM("UsePrettyPrinting"));
 sal_Bool bUsePrettyPrinting( bFlat || aSaveOpt.IsPrettyPrinting() );
-Any aAny;
-aAny.setValue( , ::getBooleanCppuType() );
-xInfoSet->setPropertyValue( sUsePrettyPrinting, aAny );
+xInfoSet->setPropertyValue( sUsePrettyPrinting, 
uno::makeAny(bUsePrettyPrinting));
 
 // Set base URI
 OUString sPropName( RTL_CONSTASCII_USTRINGPARAM("BaseURI") );
diff --git a/main/sw/source/filter/xml/wrtxml.cxx 
b/main/sw/source/filter/xml/wrtxml.cxx
index e288bfc006..7677f86ff1 100644
--- a/main/sw/source/filter/xml/wrtxml.cxx
+++ b/main/sw/source/filter/xml/wrtxml.cxx
@@ -207,8 +207,7 @@ pGraphicHelper = SvXMLGraphicHelper::Create( xStg,
SvtSaveOptions aSaveOpt;
OUString 
sUsePrettyPrinting(RTL_CONSTASCII_USTRINGPARAM("UsePrettyPrinting"));
sal_Bool bUsePrettyPrinting( aSaveOpt.IsPrettyPrinting() );
-   aAny.setValue( , ::getBooleanCppuType() );
-   xInfoSet->setPropertyValue( sUsePrettyPrinting, aAny );
+   xInfoSet->setPropertyValue( sUsePrettyPrinting, 
uno::makeAny(bUsePrettyPrinting));
 
 // save show redline mode ...
OUString sShowChanges(RTL_CONSTASCII_USTRINGPARAM("ShowChanges"));



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: LAZY CONSENSUS: change IRC links from Freenode to Libera.Chat

2021-08-05 Thread Dave Fisher



> On Aug 5, 2021, at 1:11 PM, Arrigo Marchiori  wrote:
> 
> Hello All,
> 
> following Carl's very good advice, here is my proposal:
> 
>  I will merge https://github.com/apache/openoffice-org/pull/57
>  consisting of changing IRC links from Freenode into Libera Chat, if
>  no one objects within August 10th.

I don’t see any reason to wait. We aren’t going back to Freenode …

Make it so!

Regards,
Dave

> 
> Thank you and best regards,
> -- 
> Arrigo
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: [OS/2 and macOS] saving ODS with chart

2021-08-05 Thread Jim Jagielski
Can you try this:

diff --git a/main/comphelper/inc/comphelper/extract.hxx 
b/main/comphelper/inc/comphelper/extract.hxx
index dc67c5dc58..fc75fa9cb9 100644
--- a/main/comphelper/inc/comphelper/extract.hxx
+++ b/main/comphelper/inc/comphelper/extract.hxx
@@ -131,9 +131,10 @@ inline sal_Bool SAL_CALL extractInterface(
 inline sal_Bool SAL_CALL any2bool( const ::com::sun::star::uno::Any & rAny )
throw( ::com::sun::star::lang::IllegalArgumentException )
 {
-   if (rAny.getValueTypeClass() == 
::com::sun::star::uno::TypeClass_BOOLEAN)
+   sal_Bool sValue;
+   if ( rAny >>= sValue)
{
-   return *(sal_Bool *)rAny.getValue();
+   return sValue;
}
else
{
diff --git a/main/cppu/inc/com/sun/star/uno/Any.hxx 
b/main/cppu/inc/com/sun/star/uno/Any.hxx
index e1d125be82..2a38598efa 100644
--- a/main/cppu/inc/com/sun/star/uno/Any.hxx
+++ b/main/cppu/inc/com/sun/star/uno/Any.hxx
@@ -251,9 +251,9 @@ inline sal_Bool SAL_CALL operator >>= ( Any const & rAny, 
bool & value )
{
value = *reinterpret_cast< sal_Bool const * >(
  ) != sal_False;
-   return true;
+   return sal_True;
}
-   return false;
+   return sal_False;
 }
 
 
//__
diff --git a/main/xmloff/source/core/xmlexp.cxx 
b/main/xmloff/source/core/xmlexp.cxx
index 4a867ca64c..2b63c0f991 100644
--- a/main/xmloff/source/core/xmlexp.cxx
+++ b/main/xmloff/source/core/xmlexp.cxx
@@ -699,7 +699,7 @@ void SAL_CALL SvXMLExport::setSourceDocument( const 
uno::Reference< lang::XCompo
OUString 
sUsePrettyPrinting(RTL_CONSTASCII_USTRINGPARAM(XML_USEPRETTYPRINTING));
if 
(xPropertySetInfo->hasPropertyByName(sUsePrettyPrinting))
{
-   uno::Any aAny = 
mxExportInfo->getPropertyValue(sUsePrettyPrinting);
+   uno::Any aAny = 
mxExportInfo->getPropertyValue(bUsePrettyPrinting);
if (::cppu::any2bool(aAny))
mnExportFlags |= EXPORT_PRETTY;
else


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: IRC links on our web site

2021-08-05 Thread Arrigo Marchiori
Hello Mechtilde, All,

On Wed, Aug 04, 2021 at 02:56:19PM +0200, Mechtilde wrote:

> helllo
> 
> I added it to
> 
> https://wiki.openoffice.org/wiki/IRC_Communication

Yes, thank you! I just fixed the instructions at the bottom of the
page, that were still referring to Freenode.

And I appreciate DiGro's recent big red banner on the deprecation
warning ;-)

Best regards,
-- 
Arrigo

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: Time for a 4.2.0-dev3?

2021-08-05 Thread Jim Jagielski
I think I will tag tomorrow morning and start some builds :-)

> On Aug 3, 2021, at 12:48 PM, Matthias Seidel  
> wrote:
> 
> Ready, when you are! ;-)
> 
> Am 03.08.21 um 18:44 schrieb Jim Jagielski:
>> I'd like to spend some time on the ODS bug on macOS:
>> 
>> Executive Summary (TL;DR ;-)
>> 
>> A boolean setting is not recognized as a boolean. An exception is
>> thrown when accessing it. The exception is swallowed and the XML
>> files' contents are not written.
>> 
>> 
>>> On Aug 3, 2021, at 5:13 AM, Matthias Seidel  
>>> wrote:
>>> 
>>> I would be able to upload the Windows binaries now...
>>> 
>>> @Jim: Can you create a tag on GitHub and provide macOS and Linux builds?
>>> 
>>> Regards,
>>> 
>>>   Matthias
>>> 
>>> Am 01.08.21 um 23:30 schrieb Matthias Seidel:
 Hi,
 
 Just FYI: I just build a AOO420-Dev3 for Windows (as a test) based on
 Git hash 494e99f846.
 
 Regards,
 
   Matthias
 
 Am 31.07.21 um 17:26 schrieb Matthias Seidel:
> Hi all,
> 
> Next weekend? Any idea?
> 
> Matthias
> 
> Am 29.07.21 um 15:21 schrieb Matthias Seidel:
>> Hi all,
>> 
>> Am 27.07.21 um 19:11 schrieb Arrigo Marchiori:
>>> Hello All,
>>> 
>>> On Tue, Jul 27, 2021 at 06:56:25PM +0200, Matthias Seidel wrote:
>>> 
 Hi Jim,
 
 Am 27.07.21 um 17:44 schrieb Jim Jagielski:
> Snapshot works for me
 Great! What do others think?
 
 Commits are low at the moment, so we could start any time...
>>> +1
>> I would have time this weekend...
>> 
>> Regards,
>> 
>>   Matthias
>> 
>> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



LAZY CONSENSUS: change IRC links from Freenode to Libera.Chat

2021-08-05 Thread Arrigo Marchiori
Hello All,

following Carl's very good advice, here is my proposal:

  I will merge https://github.com/apache/openoffice-org/pull/57
  consisting of changing IRC links from Freenode into Libera Chat, if
  no one objects within August 10th.

Thank you and best regards,
-- 
Arrigo

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



[GitHub] [openoffice-org] Mechtilde commented on pull request #57: Change IRC links into Libera.Chat

2021-08-05 Thread GitBox


Mechtilde commented on pull request #57:
URL: https://github.com/apache/openoffice-org/pull/57#issuecomment-892634726


   helllo
   
   I added it to
   
   https://wiki.openoffice.org/wiki/IRC_Communication
   
   Kind regards
   
   Mechtilde
   
   
   Am 04.08.21 um 10:34 schrieb Matthias Seidel:
   > Mechtilde, where did you change something? I only see the commit from 
Arrigo here.
   > 
   > @ardovm Yes, many pages are outdated, but that is another task.
   > 
   
   -- 
   Mechtilde Stehmann
   ## Apache OpenOffice
   ## Freie Office Suite für Linux, MacOSX, Windows und OS/2
   ## Debian Developer
   ## PGP encryption welcome
   ## F0E3 7F3D C87A 4998 2899  39E7 F287 7BBA 141A AD7F
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org