[dev] Re: [dba-dev] Build problem in dbaccess on simplified Chinese WinXP

2008-03-02 Thread Zhang Xiaofei 

Hi Ocke,

Ocke Janssen - Sun Microsystems Inc. 

Hi Felix,

Zhang Xiaofei schrieb:

[...]
Thanks for reporting this. Do you have a fix for it? May be it is 
possible to insert /// slashes instead of two or we have to remove the 
comment and replace it with words. Could you please test which may 
work on your side?

Thanks.

Best regards,

Ocke

[...]
Thank you for your reply, I tried triple slashes however it seems not 
working for me. If the characters have to be reserved to make the 
comment clear, might it be better to put some buffer characters, space 
for example, between the non-ASCII characters and the line ending? In 
this case even when the characters displays incorrect, the compilation 
won't be interrupted.


I have filed a issue on this in response to Mr. Stephan Bergmann's 
advice, please find it here:

http://www.openoffice.org/issues/show_bug.cgi?id=86621

Best Regards,
Felix.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[dev] Build problem in dbaccess on simplified Chinese WinXP

2008-02-28 Thread Zhang Xiaofei 

Hi all,

Building the dbaccess module on simplified Chinese WinXP results in the 
following error:


g:/ooo_SRC680_latest\dbaccess\source\sdbtools\connection\objectnames.cxx(223) 
:
error C2958: the left parenthesis '(' found at 
'g:\ooo_src680_latest\dbaccess\so

urce\sdbtools\connection\objectnames.cxx(213)' was not matched correctly
dmake:  Error code 2, while making 
'../../../wntmsci10.pro/slo/objectnames.obj'



As the correct form of the code can be seen at
http://lxr.go-oo.org/source/dba/dbaccess/source/sdbtools/connection/objectnames.cxx#213
like:

   if  (   ( _rName.indexOf( (sal_Unicode)34  ) = 0 )  // 
   ||  ( _rName.indexOf( (sal_Unicode)39  ) = 0 )  // '
   ||  ( _rName.indexOf( (sal_Unicode)96  ) = 0 )  // `
   ||  ( _rName.indexOf( (sal_Unicode)145 ) = 0 )  // ‘
   ||  ( _rName.indexOf( (sal_Unicode)146 ) = 0 )  // ’
   ||  ( _rName.indexOf( (sal_Unicode)180 ) = 0 )  // ´
   )

In my MS VS2003 It is displayed as the following form:

   if  (   ( _rName.indexOf( (sal_Unicode)34  ) = 0 )  // 
   ||  ( _rName.indexOf( (sal_Unicode)39  ) = 0 )  // '
   ||  ( _rName.indexOf( (sal_Unicode)96  ) = 0 )  // `
   ||  ( _rName.indexOf( (sal_Unicode)145 ) = 0 )  // 
?||  ( _rName.indexOf( (sal_Unicode)146 ) = 0 )  // 
?||  ( _rName.indexOf( (sal_Unicode)180 ) = 0 )  // 
?)

   return ErrorCondition::DB_QUERY_NAME_WITH_QUOTES;


It seems the last two conditions and the parenthesis is mistakenly 
interpreted as a part of the comment, due to some encoding problem. Here 
in Beijing it is a very old problem in dozens of milestones AFAIR, and 
we always add linebreaks manually to fix it. But I think it's better to 
have it reported and fixed in the official source.


Thanks and Best Regards, :-)
Felix.










-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [dev] Build problem in dbaccess on simplified Chinese WinXP

2008-02-28 Thread Stephan Bergmann 

Zhang Xiaofei wrote:

Hi all,

Building the dbaccess module on simplified Chinese WinXP results in the 
following error:


g:/ooo_SRC680_latest\dbaccess\source\sdbtools\connection\objectnames.cxx(223) 
:
error C2958: the left parenthesis '(' found at 
'g:\ooo_src680_latest\dbaccess\so

urce\sdbtools\connection\objectnames.cxx(213)' was not matched correctly
dmake:  Error code 2, while making 
'../../../wntmsci10.pro/slo/objectnames.obj'



As the correct form of the code can be seen at
http://lxr.go-oo.org/source/dba/dbaccess/source/sdbtools/connection/objectnames.cxx#213 


like:

   if  (   ( _rName.indexOf( (sal_Unicode)34  ) = 0 )  // 
   ||  ( _rName.indexOf( (sal_Unicode)39  ) = 0 )  // '
   ||  ( _rName.indexOf( (sal_Unicode)96  ) = 0 )  // `
   ||  ( _rName.indexOf( (sal_Unicode)145 ) = 0 )  // ‘
   ||  ( _rName.indexOf( (sal_Unicode)146 ) = 0 )  // ’


The above two lines contain non-ASCII bytes (in the comments), which are 
notorious troublemakers.  I would suggest you file an issue to get that 
straight.


-Stephan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]